]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_cgiirc.cpp
Make VF_OPTCOMMON module mismatches a fatal link error by default
[user/henk/code/inspircd.git] / src / modules / m_cgiirc.cpp
index 85acae8ab86bc5e3ab243158341b85bf2b5c0841..3e00f498d9ed2dd621a853647dd3974706636580 100644 (file)
@@ -53,9 +53,9 @@ typedef std::vector<CGIhost> CGIHostlist;
  */
 class CommandWebirc : public Command
 {
-       CGIHostlist Hosts;
-       bool notify;
+               bool notify;
        public:
+               CGIHostlist Hosts;
                CommandWebirc(InspIRCd* Instance, bool bnotify) : Command(Instance, "WEBIRC", 0, 4, true), notify(bnotify)
                {
                        this->source = "m_cgiirc.so";
@@ -86,11 +86,6 @@ class CommandWebirc : public Command
                        ServerInstance->SNO->WriteGlobalSno('a', "Connecting user %s tried to use WEBIRC, but didn't match any configured webirc blocks.", user->GetFullRealHost().c_str());
                        return CMD_FAILURE;
                }
-
-               void SetHosts(CGIHostlist &phosts)
-               {
-                       this->Hosts = phosts;
-               }
 };
 
 
@@ -117,7 +112,7 @@ class CGIResolver : public Resolver
                        them->host.assign(result,0, 64);
                        them->dhost.assign(result, 0, 64);
                        if (querytype)
-                               them->SetSockAddr(result.c_str(), them->GetServerPort());
+                               them->SetClientIP(result.c_str());
                        them->ident.assign("~cgiirc", 0, 8);
                        them->InvalidateCache();
                        them->CheckLines(true);
@@ -140,17 +135,15 @@ class CGIResolver : public Resolver
 
 class ModuleCgiIRC : public Module
 {
-       CommandWebirc* mycommand;
+       CommandWebirc cmd;
        bool NotifyOpers;
-       CGIHostlist Hosts;
 public:
-       ModuleCgiIRC(InspIRCd* Me) : Module(Me)
+       ModuleCgiIRC(InspIRCd* Me) : Module(Me), cmd(Me, NotifyOpers)
        {
-               mycommand = new CommandWebirc(Me, NotifyOpers);
                OnRehash(NULL);
-               ServerInstance->AddCommand(mycommand);
+               ServerInstance->AddCommand(&cmd);
 
-               Implementation eventlist[] = { I_OnRehash, I_OnUserRegister, I_OnCleanup, I_OnSyncUserMetaData, I_OnDecodeMetaData, I_OnUserDisconnect, I_OnUserConnect };
+               Implementation eventlist[] = { I_OnRehash, I_OnUserRegister, I_OnCleanup, I_OnSyncUser, I_OnDecodeMetaData, I_OnUserDisconnect, I_OnUserConnect };
                ServerInstance->Modules->Attach(eventlist, this, 7);
        }
 
@@ -163,7 +156,7 @@ public:
        virtual void OnRehash(User* user)
        {
                ConfigReader Conf(ServerInstance);
-               Hosts.clear();
+               cmd.Hosts.clear();
 
                NotifyOpers = Conf.ReadFlag("cgiirc", "opernotice", 0); // If we send an oper notice when a CGI:IRC has their host changed.
 
@@ -198,7 +191,7 @@ public:
                                        if (cgitype == INVALID)
                                                cgitype = PASS;
 
-                                       Hosts.push_back(CGIhost(hostmask,cgitype, password.length() ? password : "" ));
+                                       cmd.Hosts.push_back(CGIhost(hostmask,cgitype, password.length() ? password : "" ));
                                }
                        }
                        else
@@ -207,8 +200,6 @@ public:
                                continue;
                        }
                }
-
-               mycommand->SetHosts(Hosts);
        }
 
        virtual void OnCleanup(int target_type, void* item)
@@ -233,29 +224,22 @@ public:
                }
        }
 
-       virtual void OnSyncUserMetaData(User* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
+       virtual void OnSyncUser(User* user, Module* proto, void* opaque)
        {
-               if((extname == "cgiirc_realhost") || (extname == "cgiirc_realip"))
-               {
-                       std::string* data;
-
-                       if(user->GetExt(extname, data))
-                       {
-                               proto->ProtoSendMetaData(opaque, TYPE_USER, user, extname, *data);
-                       }
-               }
+               std::string* data;
+               if (user->GetExt("cgiirc_realhost", data))
+                       proto->ProtoSendMetaData(opaque, user, "cgiirc_realhost", *data);
+               if (user->GetExt("cgiirc_realip", data))
+                       proto->ProtoSendMetaData(opaque, user, "cgiirc_realip", *data);
        }
 
-       virtual void OnDecodeMetaData(int target_type, void* target, const std::string &extname, const std::string &extdata)
+       virtual void OnDecodeMetaData(Extensible* target, const std::string &extname, const std::string &extdata)
        {
-               if(target_type == TYPE_USER)
+               User* dest = dynamic_cast<User*>(target);
+               std::string* bleh;
+               if(dest && ((extname == "cgiirc_realhost") || (extname == "cgiirc_realip")) && (!dest->GetExt(extname, bleh)))
                {
-                       User* dest = (User*)target;
-                       std::string* bleh;
-                       if(((extname == "cgiirc_realhost") || (extname == "cgiirc_realip")) && (!dest->GetExt(extname, bleh)))
-                       {
-                               dest->Extend(extname, new std::string(extdata));
-                       }
+                       dest->Extend(extname, new std::string(extdata));
                }
        }
 
@@ -267,7 +251,7 @@ public:
 
        virtual int OnUserRegister(User* user)
        {
-               for(CGIHostlist::iterator iter = Hosts.begin(); iter != Hosts.end(); iter++)
+               for(CGIHostlist::iterator iter = cmd.Hosts.begin(); iter != cmd.Hosts.end(); iter++)
                {
                        if(InspIRCd::Match(user->host, iter->hostmask, ascii_case_insensitive_map) || InspIRCd::MatchCIDR(user->GetIPString(), iter->hostmask, ascii_case_insensitive_map))
                        {
@@ -318,7 +302,7 @@ public:
                if(user->GetExt("cgiirc_webirc_ip", webirc_ip))
                {
                        ServerInstance->Users->RemoveCloneCounts(user);
-                       user->SetSockAddr(webirc_ip->c_str(), user->GetServerPort());
+                       user->SetClientIP(webirc_ip->c_str());
                        delete webirc_ip;
                        user->InvalidateCache();
                        user->Shrink("cgiirc_webirc_ip");
@@ -341,15 +325,7 @@ public:
 
                        bool valid = false;
                        ServerInstance->Users->RemoveCloneCounts(user);
-#ifdef IPV6
-                       if (user->ip.sa.sa_family == AF_INET6)
-                               valid = (inet_pton(AF_INET6, user->password.c_str(), &user->ip.in6.sin6_addr) > 0);
-                       else
-                               valid = (inet_aton(user->password.c_str(), &user->ip.in4.sin_addr));
-#else
-                       if (inet_aton(user->password.c_str(), &((sockaddr_in*)user->ip)->sin_addr))
-                               valid = true;
-#endif
+                       valid = user->SetClientIP(user->password.c_str());
                        ServerInstance->Users->AddLocalClone(user);
                        ServerInstance->Users->AddGlobalClone(user);
                        user->CheckClass();
@@ -386,10 +362,9 @@ public:
 
        bool CheckIdent(User* user)
        {
-               int ip[4];
                const char* ident;
-               char newip[16];
                int len = user->ident.length();
+               in_addr newip;
 
                if(len == 8)
                        ident = user->ident.c_str();
@@ -398,34 +373,32 @@ public:
                else
                        return false;
 
-               for(int i = 0; i < 4; i++)
-                       if(!HexToInt(ip[i], ident + i*2))
-                               return false;
-
-               snprintf(newip, 16, "%d.%d.%d.%d", ip[0], ip[1], ip[2], ip[3]);
+               errno = 0;
+               unsigned long ipaddr = strtoul(ident, NULL, 16);
+               if (errno)
+                       return false;
+               newip.s_addr = htonl(ipaddr);
+               char* newipstr = inet_ntoa(newip);
 
                user->Extend("cgiirc_realhost", new std::string(user->host));
                user->Extend("cgiirc_realip", new std::string(user->GetIPString()));
                ServerInstance->Users->RemoveCloneCounts(user);
-               user->SetSockAddr(newip, user->GetServerPort());
+               user->SetClientIP(newipstr);
                ServerInstance->Users->AddLocalClone(user);
                ServerInstance->Users->AddGlobalClone(user);
                user->CheckClass();
+               user->host = newipstr;
+               user->dhost = newipstr;
+               user->ident.assign("~cgiirc", 0, 8);
                try
                {
-                       user->host.assign(newip, 0, 16);
-                       user->dhost.assign(newip, 0, 16);
-                       user->ident.assign("~cgiirc", 0, 8);
 
                        bool cached;
-                       CGIResolver* r = new CGIResolver(this, ServerInstance, NotifyOpers, newip, false, user, user->GetFd(), "IDENT", cached);
+                       CGIResolver* r = new CGIResolver(this, ServerInstance, NotifyOpers, newipstr, false, user, user->GetFd(), "IDENT", cached);
                        ServerInstance->AddResolver(r, cached);
                }
                catch (...)
                {
-                       user->host.assign(newip, 0, 16);
-                       user->dhost.assign(newip, 0, 16);
-                       user->ident.assign("~cgiirc", 0, 8);
                        user->InvalidateCache();
 
                        if(NotifyOpers)
@@ -491,20 +464,6 @@ public:
                return true;
        }
 
-       bool HexToInt(int &out, const char* in)
-       {
-               char ip[3];
-               ip[0] = in[0];
-               ip[1] = in[1];
-               ip[2] = 0;
-               out = strtol(ip, NULL, 16);
-
-               if(out > 255 || out < 0)
-                       return false;
-
-               return true;
-       }
-
        virtual ~ModuleCgiIRC()
        {
        }