]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_cgiirc.cpp
Use !empty instead of size when checking if containers are empty.
[user/henk/code/inspircd.git] / src / modules / m_cgiirc.cpp
index 8d911a5b4c122e40435c40f1549925f14e603048..52c24e50ad89eb815173d9abbc46b72efbbf09d2 100644 (file)
@@ -1,13 +1,18 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
+ *   Copyright (C) 2019 linuxdaemon <linuxdaemon.irc@gmail.com>
+ *   Copyright (C) 2014 md_5 <git@md-5.net>
+ *   Copyright (C) 2014 Googolplexed <googol@googolplexed.net>
+ *   Copyright (C) 2013, 2017-2018, 2020 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2013 Adam <Adam@anope.org>
+ *   Copyright (C) 2012-2013, 2015 Attila Molnar <attilamolnar@hush.com>
+ *   Copyright (C) 2012, 2019 Robby <robby@chatbelgie.be>
  *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
- *   Copyright (C) 2007-2008 John Brooks <john.brooks@dereferenced.net>
- *   Copyright (C) 2008 Pippijn van Steenhoven <pip88nl@gmail.com>
- *   Copyright (C) 2006-2008 Craig Edwards <craigedwards@brainbox.cc>
- *   Copyright (C) 2007 Robin Burchell <robin+git@viroteck.net>
+ *   Copyright (C) 2009 Uli Schlachter <psychon@inspircd.org>
+ *   Copyright (C) 2007-2009 Robin Burchell <robin+git@viroteck.net>
  *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
- *   Copyright (C) 2006 Oliver Lupton <oliverlupton@gmail.com>
+ *   Copyright (C) 2006-2007, 2010 Craig Edwards <brain@inspircd.org>
  *
  * This file is part of InspIRCd.  InspIRCd is free software: you can
  * redistribute it and/or modify it under the terms of the GNU General Public
@@ -25,6 +30,7 @@
 
 #include "inspircd.h"
 #include "modules/ssl.h"
+#include "modules/webirc.h"
 #include "modules/whois.h"
 
 enum
@@ -33,29 +39,6 @@ enum
        RPL_WHOISGATEWAY = 350
 };
 
-// We need this method up here so that it can be accessed from anywhere
-static void ChangeIP(LocalUser* user, const irc::sockets::sockaddrs& sa)
-{
-       // Set the users IP address and make sure they are in the right clone pool.
-       ServerInstance->Users->RemoveCloneCounts(user);
-       user->SetClientIP(sa);
-       ServerInstance->Users->AddClone(user);
-       if (user->quitting)
-               return;
-
-       // Recheck the connect class.
-       user->MyClass = NULL;
-       user->SetClass();
-       user->CheckClass();
-       if (user->quitting)
-               return;
-
-       // Check if this user matches any XLines.
-       user->CheckLines(true);
-       if (user->quitting)
-               return;
-}
-
 // Encapsulates information about an ident host.
 class IdentHost
 {
@@ -102,15 +85,15 @@ class WebIRCHost
        {
        }
 
-       bool Matches(LocalUser* user, const std::string& pass) const
+       bool Matches(LocalUser* user, const std::string& pass, UserCertificateAPI& sslapi) const
        {
                // Did the user send a valid password?
                if (!password.empty() && !ServerInstance->PassCompare(user, password, pass, passhash))
                        return false;
 
                // Does the user have a valid fingerprint?
-               const std::string fp = SSLClientCert::GetFingerprint(&user->eh);
-               if (!fingerprint.empty() && fp != fingerprint)
+               const std::string fp = sslapi ? sslapi->GetFingerprint(user) : "";
+               if (!fingerprint.empty() && !InspIRCd::TimingSafeCompare(fp, fingerprint))
                        return false;
 
                // Does the user's hostname match our hostmask?
@@ -141,16 +124,20 @@ class CommandWebIRC : public SplitCommand
        StringExtItem gateway;
        StringExtItem realhost;
        StringExtItem realip;
+       UserCertificateAPI sslapi;
+       Events::ModuleEventProvider webircevprov;
 
        CommandWebIRC(Module* Creator)
                : SplitCommand(Creator, "WEBIRC", 4)
                , gateway("cgiirc_gateway", ExtensionItem::EXT_USER, Creator)
                , realhost("cgiirc_realhost", ExtensionItem::EXT_USER, Creator)
                , realip("cgiirc_realip", ExtensionItem::EXT_USER, Creator)
+               , sslapi(Creator)
+               , webircevprov(Creator, "event/webirc")
        {
                allow_empty_last_param = false;
                works_before_reg = true;
-               this->syntax = "password gateway hostname ip";
+               this->syntax = "<password> <gateway> <hostname> <ip> [<flags>]";
        }
 
        CmdResult HandleLocal(LocalUser* user, const Params& parameters) CXX11_OVERRIDE
@@ -158,21 +145,21 @@ class CommandWebIRC : public SplitCommand
                if (user->registered == REG_ALL || realhost.get(user))
                        return CMD_FAILURE;
 
-               irc::sockets::sockaddrs ipaddr;
-               if (!irc::sockets::aptosa(parameters[3], user->client_sa.port(), ipaddr))
-               {
-                       user->CommandFloodPenalty += 5000;
-                       WriteLog("Connecting user %s (%s) tried to use WEBIRC but gave an invalid IP address.",
-                               user->uuid.c_str(), user->GetIPString().c_str());
-                       return CMD_FAILURE;
-               }
-
                for (std::vector<WebIRCHost>::const_iterator iter = hosts.begin(); iter != hosts.end(); ++iter)
                {
                        // If we don't match the host then skip to the next host.
-                       if (!iter->Matches(user, parameters[0]))
+                       if (!iter->Matches(user, parameters[0], sslapi))
                                continue;
 
+                       irc::sockets::sockaddrs ipaddr;
+                       if (!irc::sockets::aptosa(parameters[3], user->client_sa.port(), ipaddr))
+                       {
+                               WriteLog("Connecting user %s (%s) tried to use WEBIRC but gave an invalid IP address.",
+                                       user->uuid.c_str(), user->GetIPString().c_str());
+                               ServerInstance->Users->QuitUser(user, "WEBIRC: IP address is invalid: " + parameters[3]);
+                               return CMD_FAILURE;
+                       }
+
                        // The user matched a WebIRC block!
                        gateway.set(user, parameters[1]);
                        realhost.set(user, user->GetRealHost());
@@ -181,15 +168,42 @@ class CommandWebIRC : public SplitCommand
                        WriteLog("Connecting user %s is using a WebIRC gateway; changing their IP from %s to %s.",
                                user->uuid.c_str(), user->GetIPString().c_str(), parameters[3].c_str());
 
+                       // If we have custom flags then deal with them.
+                       WebIRC::FlagMap flags;
+                       const bool hasflags = (parameters.size() > 4);
+                       if (hasflags)
+                       {
+                               // Parse the flags.
+                               irc::spacesepstream flagstream(parameters[4]);
+                               for (std::string flag; flagstream.GetToken(flag); )
+                               {
+                                       // Does this flag have a value?
+                                       const size_t separator = flag.find('=');
+                                       if (separator == std::string::npos)
+                                       {
+                                               flags[flag];
+                                               continue;
+                                       }
+
+                                       // The flag has a value!
+                                       const std::string key = flag.substr(0, separator);
+                                       const std::string value = flag.substr(separator + 1);
+                                       flags[key] = value;
+                               }
+                       }
+
+                       // Inform modules about the WebIRC attempt.
+                       FOREACH_MOD_CUSTOM(webircevprov, WebIRC::EventListener, OnWebIRCAuth, (user, (hasflags ? &flags : NULL)));
+
                        // Set the IP address sent via WEBIRC. We ignore the hostname and lookup
                        // instead do our own DNS lookups because of unreliable gateways.
-                       ChangeIP(user, ipaddr);
+                       user->SetClientIP(ipaddr);
                        return CMD_SUCCESS;
                }
 
-               user->CommandFloodPenalty += 5000;
                WriteLog("Connecting user %s (%s) tried to use WEBIRC but didn't match any configured WebIRC hosts.",
                        user->uuid.c_str(), user->GetIPString().c_str());
+               ServerInstance->Users->QuitUser(user, "WEBIRC: you don't match any configured WebIRC hosts.");
                return CMD_FAILURE;
        }
 
@@ -207,7 +221,10 @@ class CommandWebIRC : public SplitCommand
        }
 };
 
-class ModuleCgiIRC : public Module, public Whois::EventListener
+class ModuleCgiIRC
+       : public Module
+       , public WebIRC::EventListener
+       , public Whois::EventListener
 {
  private:
        CommandWebIRC cmd;
@@ -251,7 +268,8 @@ class ModuleCgiIRC : public Module, public Whois::EventListener
 
  public:
        ModuleCgiIRC()
-               : Whois::EventListener(this)
+               : WebIRC::EventListener(this)
+               , Whois::EventListener(this)
                , cmd(this)
        {
        }
@@ -289,16 +307,23 @@ class ModuleCgiIRC : public Module, public Whois::EventListener
                                // The IP address will be received via the WEBIRC command.
                                const std::string fingerprint = tag->getString("fingerprint");
                                const std::string password = tag->getString("password");
+                               const std::string passwordhash = tag->getString("hash", "plaintext", 1);
 
                                // WebIRC blocks require a password.
                                if (fingerprint.empty() && password.empty())
                                        throw ModuleException("When using <cgihost type=\"webirc\"> either the fingerprint or password field is required, at " + tag->getTagLocation());
 
-                               webirchosts.push_back(WebIRCHost(mask, fingerprint, password, tag->getString("hash")));
+                               if (!password.empty() && stdalgo::string::equalsci(passwordhash, "plaintext"))
+                               {
+                                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "<cgihost> tag at %s contains an plain text password, this is insecure!",
+                                               tag->getTagLocation().c_str());
+                               }
+
+                               webirchosts.push_back(WebIRCHost(mask, fingerprint, password, passwordhash));
                        }
                        else
                        {
-                               throw ModuleException(type + " is an invalid <cgihost:mask> type, at " + tag->getTagLocation()); 
+                               throw ModuleException(type + " is an invalid <cgihost:mask> type, at " + tag->getTagLocation());
                        }
                }
 
@@ -321,11 +346,22 @@ class ModuleCgiIRC : public Module, public Whois::EventListener
                // cannot match this connect class.
                const std::string* gateway = cmd.gateway.get(user);
                if (!gateway)
+               {
+                       ServerInstance->Logs->Log("CONNECTCLASS", LOG_DEBUG, "The %s connect class is not suitable as it requires a connection via a WebIRC gateway",
+                                       myclass->GetName().c_str());
                        return MOD_RES_DENY;
+               }
 
                // If the gateway matches the <connect:webirc> constraint then
                // allow the check to continue. Otherwise, reject it.
-               return InspIRCd::Match(*gateway, webirc) ? MOD_RES_PASSTHRU : MOD_RES_DENY;
+               if (!InspIRCd::Match(*gateway, webirc))
+               {
+                       ServerInstance->Logs->Log("CONNECTCLASS", LOG_DEBUG, "The %s connect class is not suitable as the WebIRC gateway name (%s) does not match %s",
+                                       myclass->GetName().c_str(), gateway->c_str(), webirc.c_str());
+                       return MOD_RES_DENY;
+               }
+
+               return MOD_RES_PASSTHRU;
        }
 
        ModResult OnUserRegister(LocalUser* user) CXX11_OVERRIDE
@@ -355,12 +391,72 @@ class ModuleCgiIRC : public Module, public Whois::EventListener
                                user->uuid.c_str(), user->GetIPString().c_str(), address.addr().c_str(), user->ident.c_str(), newident.c_str());
 
                        user->ChangeIdent(newident);
-                       ChangeIP(user, address);
-                       break; 
+                       user->SetClientIP(address);
+                       break;
                }
                return MOD_RES_PASSTHRU;
        }
 
+       void OnWebIRCAuth(LocalUser* user, const WebIRC::FlagMap* flags) CXX11_OVERRIDE
+       {
+               // We are only interested in connection flags. If none have been
+               // given then we have nothing to do.
+               if (!flags)
+                       return;
+
+               WebIRC::FlagMap::const_iterator cport = flags->find("remote-port");
+               if (cport != flags->end())
+               {
+                       // If we can't parse the port then just give up.
+                       uint16_t port = ConvToNum<uint16_t>(cport->second);
+                       if (port)
+                       {
+                               switch (user->client_sa.family())
+                               {
+                                       case AF_INET:
+                                               user->client_sa.in4.sin_port = htons(port);
+                                               break;
+
+                                       case AF_INET6:
+                                               user->client_sa.in6.sin6_port = htons(port);
+                                               break;
+
+                                       default:
+                                               // If we have reached this point then we have encountered a bug.
+                                               ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "BUG: OnWebIRCAuth(%s): socket type %d is unknown!",
+                                                       user->uuid.c_str(), user->client_sa.family());
+                                               return;
+                               }
+                       }
+               }
+
+               WebIRC::FlagMap::const_iterator sport = flags->find("local-port");
+               if (sport != flags->end())
+               {
+                       // If we can't parse the port then just give up.
+                       uint16_t port = ConvToNum<uint16_t>(sport->second);
+                       if (port)
+                       {
+                               switch (user->server_sa.family())
+                               {
+                                       case AF_INET:
+                                               user->server_sa.in4.sin_port = htons(port);
+                                               break;
+
+                                       case AF_INET6:
+                                               user->server_sa.in6.sin6_port = htons(port);
+                                               break;
+
+                                       default:
+                                               // If we have reached this point then we have encountered a bug.
+                                               ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "BUG: OnWebIRCAuth(%s): socket type %d is unknown!",
+                                                       user->uuid.c_str(), user->server_sa.family());
+                                               return;
+                               }
+                       }
+               }
+       }
+
        void OnWhois(Whois::Context& whois) CXX11_OVERRIDE
        {
                if (!whois.IsSelfWhois() && !whois.GetSource()->HasPrivPermission("users/auspex"))
@@ -381,7 +477,7 @@ class ModuleCgiIRC : public Module, public Whois::EventListener
 
        Version GetVersion() CXX11_OVERRIDE
        {
-               return Version("Enables forwarding the real IP address of a user from a gateway to the IRC server", VF_VENDOR);
+               return Version("Adds the ability for IRC gateways to forward the real IP address of users connecting through them.", VF_VENDOR);
        }
 };