]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_cgiirc.cpp
fixed some indentation and spacing in modules
[user/henk/code/inspircd.git] / src / modules / m_cgiirc.cpp
index 09edefb824a171689ec6b95e783a4e97cf8b3c9d..a9abb4b15d69a7a0885a48c7cab2806dbfa4875c 100644 (file)
@@ -2,33 +2,27 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd is copyright (C) 2002-2004 ChatSpike-Dev.
- *                       E-mail:
- *               <brain@chatspike.net>
- *               <Craig@chatspike.net>
- *               <omster@gmail.com>
- *     
- * Written by Craig Edwards, Craig McLure, and others.
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
+ * See: http://www.inspircd.org/wiki/index.php/Credits
+ *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
  *
  * ---------------------------------------------------
  */
 
-#include <vector>
-#include <string>
-#include <stdlib.h>
+#include "inspircd.h"
+
+#ifndef WINDOWS
 #include <sys/socket.h>
 #include <netinet/in.h>
 #include <arpa/inet.h>
-#include "users.h"
-#include "modules.h"
-#include "dns.h"
-#include "inspircd.h"
+#endif
 
 /* $ModDesc: Change user's hosts connecting from known CGI:IRC hosts */
 
-enum CGItype { PASS, IDENT, PASSFIRST, IDENTFIRST };
+enum CGItype { INVALID, PASS, IDENT, PASSFIRST, IDENTFIRST, WEBIRC };
+
 
 /** Holds a CGI site's details
  */
@@ -37,38 +31,90 @@ class CGIhost : public classbase
 public:
        std::string hostmask;
        CGItype type;
+       std::string password;
 
-       CGIhost(const std::string &mask = "", CGItype t = IDENTFIRST)
-       : hostmask(mask), type(t)
+       CGIhost(const std::string &mask = "", CGItype t = IDENTFIRST, const std::string &spassword ="")
+       : hostmask(mask), type(t), password(spassword)
        {
        }
 };
-
 typedef std::vector<CGIhost> CGIHostlist;
 
+/*
+ * WEBIRC
+ *  This is used for the webirc method of CGIIRC auth, and is (really) the best way to do these things.
+ *  Syntax: WEBIRC password client hostname ip
+ *  Where password is a shared key, client is the name of the "client" and version (e.g. cgiirc), hostname
+ *  is the resolved host of the client issuing the command and IP is the real IP of the client.
+ *
+ * How it works:
+ *  To tie in with the rest of cgiirc module, and to avoid race conditions, /webirc is only processed locally
+ *  and simply sets metadata on the user, which is later decoded on full connect to give something meaningful.
+ */
+class CommandWebirc : public Command
+{
+       CGIHostlist Hosts;
+       bool notify;
+       public:
+               CommandWebirc(InspIRCd* Instance, CGIHostlist &cHosts, bool bnotify) : Command(Instance, "WEBIRC", 0, 4, true), Hosts(cHosts), notify(bnotify)
+               {
+                       this->source = "m_cgiirc.so";
+                       this->syntax = "password client hostname ip";
+               }
+               CmdResult Handle(const std::vector<std::string> &parameters, User *user)
+               {
+                       if(user->registered == REG_ALL)
+                               return CMD_FAILURE;
+
+                       for(CGIHostlist::iterator iter = Hosts.begin(); iter != Hosts.end(); iter++)
+                       {
+                               if(ServerInstance->MatchText(user->host, iter->hostmask) || ServerInstance->MatchText(user->GetIPString(), iter->hostmask))
+                               {
+                                       if(iter->type == WEBIRC && parameters[0] == iter->password)
+                                       {
+                                               user->Extend("cgiirc_realhost", new std::string(user->host));
+                                               user->Extend("cgiirc_realip", new std::string(user->GetIPString()));
+                                               if (notify)
+                                                       ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from %s", user->nick.c_str(), user->host.c_str(), parameters[2].c_str(), user->host.c_str());
+                                               user->Extend("cgiirc_webirc_hostname", new std::string(parameters[2]));
+                                               user->Extend("cgiirc_webirc_ip", new std::string(parameters[3]));
+                                               return CMD_LOCALONLY;
+                                       }
+                               }
+                       }
+                       return CMD_FAILURE;
+               }
+};
+
+
 /** Resolver for CGI:IRC hostnames encoded in ident/GECOS
  */
 class CGIResolver : public Resolver
 {
        std::string typ;
        int theirfd;
-       userrec* them;
+       User* them;
        bool notify;
  public:
-       CGIResolver(InspIRCd* ServerInstance, bool NotifyOpers, const std::string &source, bool forward, userrec* u, int userfd, const std::string &type)
-               : Resolver(ServerInstance, source, forward ? DNS_QUERY_FORWARD : DNS_QUERY_REVERSE), typ(type), theirfd(userfd), them(u), notify(NotifyOpers) { }
+       CGIResolver(Module* me, InspIRCd* Instance, bool NotifyOpers, const std::string &source, bool forward, User* u, int userfd, const std::string &type, bool &cached)
+               : Resolver(Instance, source, forward ? DNS_QUERY_A : DNS_QUERY_PTR4, cached, me), typ(type), theirfd(userfd), them(u), notify(NotifyOpers) { }
 
-       virtual void OnLookupComplete(const std::string &result)
+       virtual void OnLookupComplete(const std::string &result, unsigned int ttl, bool cached, int resultnum = 0)
        {
+               if (resultnum)
+                       return;
+
                /* Check the user still exists */
                if ((them) && (them == ServerInstance->SE->GetRef(theirfd)))
                {
                        if (notify)
-                               ServerInstance->WriteOpers("*** Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from %s", them->nick, them->host, result.c_str(), typ.c_str());
+                               ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from %s", them->nick.c_str(), them->host.c_str(), result.c_str(), typ.c_str());
 
-                       strlcpy(them->host, result.c_str(), 63);
-                       strlcpy(them->dhost, result.c_str(), 63);
-                       strlcpy(them->ident, "~cgiirc", 8);
+                       them->host.assign(result,0, 64);
+                       them->dhost.assign(result, 0, 64);
+                       them->ident.assign("~cgiirc", 0, 8);
+                       them->InvalidateCache();
+                       them->CheckLines();
                }
        }
 
@@ -77,7 +123,7 @@ class CGIResolver : public Resolver
                if ((them) && (them == ServerInstance->SE->GetRef(theirfd)))
                {
                        if (notify)
-                               ServerInstance->WriteOpers("*** Connecting user %s detected as using CGI:IRC (%s), but their host can't be resolved from their %s!", them->nick, them->host,typ.c_str());
+                               ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), but their host can't be resolved from their %s!", them->nick.c_str(), them->host.c_str(), typ.c_str());
                }
        }
 
@@ -88,55 +134,71 @@ class CGIResolver : public Resolver
 
 class ModuleCgiIRC : public Module
 {
-       
+       CommandWebirc* mycommand;
        bool NotifyOpers;
        CGIHostlist Hosts;
 public:
-       ModuleCgiIRC(InspIRCd* Me) : Module::Module(Me)
+       ModuleCgiIRC(InspIRCd* Me) : Module(Me)
        {
-               
-               OnRehash("");
-       }
 
-       void Implements(char* List)
-       {
-               List[I_OnRehash] = List[I_OnUserRegister] = List[I_OnCleanup] = List[I_OnSyncUserMetaData] = List[I_OnDecodeMetaData] = List[I_OnUserQuit] = 1;
+               OnRehash(NULL,"");
+               mycommand = new CommandWebirc(Me, Hosts, NotifyOpers);
+               ServerInstance->AddCommand(mycommand);
+
+               Implementation eventlist[] = { I_OnRehash, I_OnUserRegister, I_OnCleanup, I_OnSyncUserMetaData, I_OnDecodeMetaData, I_OnUserDisconnect, I_OnUserConnect };
+               ServerInstance->Modules->Attach(eventlist, this, 7);
        }
-       
-       virtual Priority Prioritize()
+
+
+       virtual void Prioritize()
        {
-               // We want to get here before m_cloaking and m_hostchange etc
-               return PRIORITY_FIRST;
+               ServerInstance->Modules->SetPriority(this, I_OnUserConnect, PRIO_FIRST);
        }
 
-       virtual void OnRehash(const std::string &parameter)
+       virtual void OnRehash(User* user, const std::string &parameter)
        {
                ConfigReader Conf(ServerInstance);
-               
+               Hosts.clear();
+
                NotifyOpers = Conf.ReadFlag("cgiirc", "opernotice", 0); // If we send an oper notice when a CGI:IRC has their host changed.
-               
+
                if(Conf.GetError() == CONF_VALUE_NOT_FOUND)
                        NotifyOpers = true;
-               
+
                for(int i = 0; i < Conf.Enumerate("cgihost"); i++)
                {
                        std::string hostmask = Conf.ReadValue("cgihost", "mask", i); // An allowed CGI:IRC host
                        std::string type = Conf.ReadValue("cgihost", "type", i); // What type of user-munging we do on this host.
-                       
+                       std::string password = Conf.ReadValue("cgihost", "password", i);
+
                        if(hostmask.length())
                        {
-                               Hosts.push_back(CGIhost(hostmask));
-                               
-                               if(type == "pass")
-                                       Hosts.back().type = PASS;
-                               else if(type == "ident")
-                                       Hosts.back().type = IDENT;
-                               else if(type == "passfirst")
-                                       Hosts.back().type = PASSFIRST;
+                               if (type == "webirc" && !password.length()) {
+                                               ServerInstance->Logs->Log("CONFIG",DEFAULT, "m_cgiirc: Missing password in config: %s", hostmask.c_str());
+                               }
+                               else
+                               {
+                                       CGItype cgitype = INVALID;
+                                       if (type == "pass")
+                                               cgitype = PASS;
+                                       else if (type == "ident")
+                                               cgitype = IDENT;
+                                       else if (type == "passfirst")
+                                               cgitype = PASSFIRST;
+                                       else if (type == "webirc")
+                                       {
+                                               cgitype = WEBIRC;
+                                       }
+
+                                       if (cgitype == INVALID)
+                                               cgitype = PASS;
+
+                                       Hosts.push_back(CGIhost(hostmask,cgitype, password.length() ? password : "" ));
+                               }
                        }
                        else
                        {
-                               ServerInstance->Log(DEBUG, "m_cgiirc.so: Invalid <cgihost:mask> value in config: %s", hostmask.c_str());
+                               ServerInstance->Logs->Log("CONFIG",DEFAULT, "m_cgiirc.so: Invalid <cgihost:mask> value in config: %s", hostmask.c_str());
                                continue;
                        }
                }
@@ -146,16 +208,16 @@ public:
        {
                if(target_type == TYPE_USER)
                {
-                       userrec* user = (userrec*)item;
+                       User* user = (User*)item;
                        std::string* realhost;
                        std::string* realip;
-                       
+
                        if(user->GetExt("cgiirc_realhost", realhost))
                        {
                                delete realhost;
                                user->Shrink("cgiirc_realhost");
                        }
-                       
+
                        if(user->GetExt("cgiirc_realip", realip))
                        {
                                delete realip;
@@ -163,13 +225,13 @@ public:
                        }
                }
        }
-       
-       virtual void OnSyncUserMetaData(userrec* user, Module* proto, void* opaque, const std::string &extname)
+
+       virtual void OnSyncUserMetaData(User* user, Module* proto, void* opaque, const std::string &extname, bool displayable)
        {
                if((extname == "cgiirc_realhost") || (extname == "cgiirc_realip"))
                {
                        std::string* data;
-                       
+
                        if(user->GetExt(extname, data))
                        {
                                proto->ProtoSendMetaData(opaque, TYPE_USER, user, extname, *data);
@@ -181,7 +243,7 @@ public:
        {
                if(target_type == TYPE_USER)
                {
-                       userrec* dest = (userrec*)target;
+                       User* dest = (User*)target;
                        std::string* bleh;
                        if(((extname == "cgiirc_realhost") || (extname == "cgiirc_realip")) && (!dest->GetExt(extname, bleh)))
                        {
@@ -190,159 +252,202 @@ public:
                }
        }
 
-       virtual void OnUserQuit(userrec* user, const std::string &message)
+       virtual void OnUserDisconnect(User* user)
        {
                OnCleanup(TYPE_USER, user);
        }
-       
 
-       virtual void OnUserRegister(userrec* user)
+
+       virtual int OnUserRegister(User* user)
        {
-               ServerInstance->Log(DEBUG, "m_cgiirc.so: User %s registering, %s %s", user->nick,user->host,user->GetIPString());
-               
                for(CGIHostlist::iterator iter = Hosts.begin(); iter != Hosts.end(); iter++)
                {
-                       ServerInstance->Log(DEBUG, "m_cgiirc.so: Matching %s against (%s or %s)", iter->hostmask.c_str(), user->host, user->GetIPString());
-                       
                        if(ServerInstance->MatchText(user->host, iter->hostmask) || ServerInstance->MatchText(user->GetIPString(), iter->hostmask))
                        {
                                // Deal with it...
-                               ServerInstance->Log(DEBUG, "m_cgiirc.so: Handling CGI:IRC user: %s (%s) matched %s", user->GetFullRealHost(), user->GetIPString(), iter->hostmask.c_str());
-                               
                                if(iter->type == PASS)
                                {
                                        CheckPass(user); // We do nothing if it fails so...
+                                       user->CheckLines();
                                }
                                else if(iter->type == PASSFIRST && !CheckPass(user))
                                {
                                        // If the password lookup failed, try the ident
                                        CheckIdent(user);       // If this fails too, do nothing
+                                       user->CheckLines();
                                }
                                else if(iter->type == IDENT)
                                {
                                        CheckIdent(user); // Nothing on failure.
+                                       user->CheckLines();
                                }
                                else if(iter->type == IDENTFIRST && !CheckIdent(user))
                                {
                                        // If the ident lookup fails, try the password.
                                        CheckPass(user);
+                                       user->CheckLines();
                                }
-                               
-                               return;
+                               else if(iter->type == WEBIRC)
+                               {
+                                       // We don't need to do anything here
+                               }
+                               return 0;
                        }
                }
+               return 0;
+       }
+
+       virtual void OnUserConnect(User* user)
+       {
+               std::string *webirc_hostname, *webirc_ip;
+               if(user->GetExt("cgiirc_webirc_hostname", webirc_hostname))
+               {
+                       user->host.assign(*webirc_hostname, 0, 64);
+                       user->dhost.assign(*webirc_hostname, 0, 64);
+                       delete webirc_hostname;
+                       user->InvalidateCache();
+                       user->Shrink("cgiirc_webirc_hostname");
+               }
+               if(user->GetExt("cgiirc_webirc_ip", webirc_ip))
+               {
+                       bool valid=false;
+                       ServerInstance->Users->RemoveCloneCounts(user);
+#ifdef IPV6
+                       valid = (inet_pton(AF_INET6, webirc_ip->c_str(), &((sockaddr_in6*)user->ip)->sin6_addr) > 0);
+
+                       if(!valid)
+                               valid = (inet_aton(webirc_ip->c_str(), &((sockaddr_in*)user->ip)->sin_addr));
+#else
+                       if (inet_aton(webirc_ip->c_str(), &((sockaddr_in*)user->ip)->sin_addr))
+                               valid = true;
+#endif
+
+                       delete webirc_ip;
+                       user->InvalidateCache();
+                       user->Shrink("cgiirc_webirc_ip");
+                       ServerInstance->Users->AddLocalClone(user);
+                       ServerInstance->Users->AddGlobalClone(user);
+                       user->CheckClass();
+                       user->CheckLines();
+               }
        }
 
-       bool CheckPass(userrec* user)
+       bool CheckPass(User* user)
        {
-               ServerInstance->Log(DEBUG, "m_cgiirc.so: CheckPass(%s) - %s", user->nick, user->password);
-               
                if(IsValidHost(user->password))
                {
                        user->Extend("cgiirc_realhost", new std::string(user->host));
                        user->Extend("cgiirc_realip", new std::string(user->GetIPString()));
-                       strlcpy(user->host, user->password, 64);
-                       strlcpy(user->dhost, user->password, 64);
-                       
+                       user->host.assign(user->password, 0, 64);
+                       user->dhost.assign(user->password, 0, 64);
+                       user->InvalidateCache();
+
+                       bool valid = false;
+                       ServerInstance->Users->RemoveCloneCounts(user);
 #ifdef IPV6
-                       if (insp_aton(user->password, (insp_inaddr*)&((sockaddr_in6*)&user->ip)->sin6_addr))
+                       if (user->GetProtocolFamily() == AF_INET6)
+                               valid = (inet_pton(AF_INET6, user->password.c_str(), &((sockaddr_in6*)user->ip)->sin6_addr) > 0);
+                       else
+                               valid = (inet_aton(user->password.c_str(), &((sockaddr_in*)user->ip)->sin_addr));
 #else
-                       if (insp_aton(user->password, (insp_inaddr*)&((sockaddr_in*)&user->ip)->sin_addr))
+                       if (inet_aton(user->password.c_str(), &((sockaddr_in*)user->ip)->sin_addr))
+                               valid = true;
 #endif
+                       ServerInstance->Users->AddLocalClone(user);
+                       ServerInstance->Users->AddGlobalClone(user);
+                       user->CheckClass();
+
+                       if (valid)
                        {
                                /* We were given a IP in the password, we don't do DNS so they get this is as their host as well. */
-                               ServerInstance->Log(DEBUG, "m_cgiirc.so: Got an IP in the user's password");
-
                                if(NotifyOpers)
-                                       ServerInstance->WriteOpers("*** Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from PASS", user->nick, user->host, user->password);
+                                       ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from PASS", user->nick.c_str(), user->host.c_str(), user->password.c_str());
                        }
                        else
                        {
                                /* We got as resolved hostname in the password. */
-                               ServerInstance->Log(DEBUG, "m_cgiirc.so: Got a hostname in the user's password");
-
                                try
                                {
-                                       CGIResolver* r = new CGIResolver(ServerInstance, NotifyOpers, user->password, false, user, user->GetFd(), "PASS");
-                                       ServerInstance->AddResolver(r);
+
+                                       bool cached;
+                                       CGIResolver* r = new CGIResolver(this, ServerInstance, NotifyOpers, user->password, false, user, user->GetFd(), "PASS", cached);
+                                       ServerInstance->AddResolver(r, cached);
                                }
-                               catch (ModuleException& e)
+                               catch (...)
                                {
                                        if (NotifyOpers)
-                                               ServerInstance->WriteOpers("*** Connecting user %s detected as using CGI:IRC (%s), but i could not resolve their hostname!", user->nick, user->host);
+                                               ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), but I could not resolve their hostname!", user->nick.c_str(), user->host.c_str());
                                }
                        }
-                       
-                       *user->password = 0;
-
-                       /*if(NotifyOpers)
-                               ServerInstance->WriteOpers("*** Connecting user %s detected as using CGI:IRC (%s), changing real host to %s from PASS", user->nick, user->host, user->password);*/
 
+                       user->password.clear();
                        return true;
                }
-               else
-               {
-                       ServerInstance->Log(DEBUG, "m_cgiirc.so: User's password was not a valid host");
-               }
-               
+
                return false;
        }
-       
-       bool CheckIdent(userrec* user)
+
+       bool CheckIdent(User* user)
        {
                int ip[4];
-               char* ident;
+               const char* ident;
                char newip[16];
-               int len = strlen(user->ident);
-               
+               int len = user->ident.length();
+
                if(len == 8)
-                       ident = user->ident;
-               else if(len == 9 && *user->ident == '~')
-                       ident = user->ident+1;
+                       ident = user->ident.c_str();
+               else if(len == 9 && user->ident[0] == '~')
+                       ident = user->ident.c_str() + 1;
                else
                        return false;
-       
+
                for(int i = 0; i < 4; i++)
                        if(!HexToInt(ip[i], ident + i*2))
                                return false;
 
                snprintf(newip, 16, "%d.%d.%d.%d", ip[0], ip[1], ip[2], ip[3]);
-                       
+
                user->Extend("cgiirc_realhost", new std::string(user->host));
                user->Extend("cgiirc_realip", new std::string(user->GetIPString()));
+               ServerInstance->Users->RemoveCloneCounts(user);
 #ifdef IPV6
-               insp_aton(newip, (insp_inaddr*)&((sockaddr_in6*)&user->ip)->sin6_addr);
-#else
-               insp_aton(newip, (insp_inaddr*)&((sockaddr_in*)&user->ip)->sin_addr);
+               if (user->GetProtocolFamily() == AF_INET6)
+                       inet_pton(AF_INET6, newip, &((sockaddr_in6*)user->ip)->sin6_addr);
+               else
 #endif
-                                                               
+               inet_aton(newip, &((sockaddr_in*)user->ip)->sin_addr);
+               ServerInstance->Users->AddLocalClone(user);
+               ServerInstance->Users->AddGlobalClone(user);
+               user->CheckClass();
                try
                {
-                       ServerInstance->Log(DEBUG,"MAKE RESOLVER: %s %d %s",newip, user->GetFd(), "IDENT");
-                       CGIResolver* r = new CGIResolver(ServerInstance, NotifyOpers, newip, false, user, user->GetFd(), "IDENT");
-                       ServerInstance->AddResolver(r);
+                       user->host.assign(newip, 0, 16);
+                       user->dhost.assign(newip, 0, 16);
+                       user->ident.assign("~cgiirc", 0, 8);
+
+                       bool cached;
+                       CGIResolver* r = new CGIResolver(this, ServerInstance, NotifyOpers, newip, false, user, user->GetFd(), "IDENT", cached);
+                       ServerInstance->AddResolver(r, cached);
                }
-               catch (ModuleException& e)
+               catch (...)
                {
-                       strlcpy(user->host, newip, 16);
-                       strlcpy(user->dhost, newip, 16);
-                       strlcpy(user->ident, "~cgiirc", 8);
+                       user->host.assign(newip, 0, 16);
+                       user->dhost.assign(newip, 0, 16);
+                       user->ident.assign("~cgiirc", 0, 8);
+                       user->InvalidateCache();
 
                        if(NotifyOpers)
-                                ServerInstance->WriteOpers("*** Connecting user %s detected as using CGI:IRC (%s), but i could not resolve their hostname!", user->nick, user->host);
+                                ServerInstance->SNO->WriteToSnoMask('A', "Connecting user %s detected as using CGI:IRC (%s), but I could not resolve their hostname!", user->nick.c_str(), user->host.c_str());
                }
-               /*strlcpy(user->host, newip, 16);
-               strlcpy(user->dhost, newip, 16);
-               strlcpy(user->ident, "~cgiirc", 8);*/
 
                return true;
        }
-       
+
        bool IsValidHost(const std::string &host)
        {
                if(!host.size())
                        return false;
-       
+
                for(unsigned int i = 0; i < host.size(); i++)
                {
                        if(     ((host[i] >= '0') && (host[i] <= '9')) ||
@@ -350,12 +455,12 @@ public:
                                        ((host[i] >= 'a') && (host[i] <= 'z')) ||
                                        ((host[i] == '-') && (i > 0) && (i+1 < host.size()) && (host[i-1] != '.') && (host[i+1] != '.')) ||
                                        ((host[i] == '.') && (i > 0) && (i+1 < host.size())) )
-                                       
+
                                continue;
                        else
                                return false;
                }
-               
+
                return true;
        }
 
@@ -363,10 +468,10 @@ public:
        {
                if(ip.size() < 7 || ip.size() > 15)
                        return false;
-       
+
                short sincedot = 0;
                short dots = 0;
-       
+
                for(unsigned int i = 0; i < ip.size(); i++)
                {
                        if((dots <= 3) && (sincedot <= 3))
@@ -384,16 +489,16 @@ public:
                        else
                        {
                                return false;
-                       
+
                        }
                }
-               
+
                if(dots != 3)
                        return false;
-               
+
                return true;
        }
-       
+
        bool HexToInt(int &out, const char* in)
        {
                char ip[3];
@@ -401,44 +506,22 @@ public:
                ip[1] = in[1];
                ip[2] = 0;
                out = strtol(ip, NULL, 16);
-               
+
                if(out > 255 || out < 0)
                        return false;
 
                return true;
        }
-       
+
        virtual ~ModuleCgiIRC()
        {
        }
-        
+
        virtual Version GetVersion()
        {
-               return Version(1,0,0,0,VF_VENDOR,API_VERSION);
+               return Version(1,2,0,0,VF_VENDOR,API_VERSION);
        }
-       
-};
 
-class ModuleCgiIRCFactory : public ModuleFactory
-{
- public:
-       ModuleCgiIRCFactory()
-       {
-       }
-       
-       ~ModuleCgiIRCFactory()
-       {
-       }
-       
-       virtual Module * CreateModule(InspIRCd* Me)
-       {
-               return new ModuleCgiIRC(Me);
-       }
-       
 };
 
-
-extern "C" void * init_module( void )
-{
-       return new ModuleCgiIRCFactory;
-}
+MODULE_INIT(ModuleCgiIRC)