]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_chanprotect.cpp
Implement feature in bug #395 reported by stealth, and tidy up a bit
[user/henk/code/inspircd.git] / src / modules / m_chanprotect.cpp
index 766898c5a8dc9589262c5706e66fc223624361b7..6d99ed10bcba7c755ad46fab9b6ac6a57bfd6386 100644 (file)
  * ---------------------------------------------------
  */
 
+#include "inspircd.h"
 #include "users.h"
 #include "channels.h"
 #include "modules.h"
-#include "inspircd.h"
 
 /* $ModDesc: Provides channel modes +a and +q */
 /* $ModDep: ../../include/u_listmode.h */
@@ -80,7 +80,7 @@ class FounderProtectBase
                unload_kludge = true;
                CUList* cl = channel->GetUsers();
                std::string item = extend + std::string(channel->name);
-               const char* mode_junk[MAXMODES+1];
+               const char* mode_junk[MAXMODES+2];
                userrec* n = new userrec(MyInstance);
                n->SetFd(FD_MAGIC_NUMBER);
                mode_junk[0] = channel->name;
@@ -88,9 +88,9 @@ class FounderProtectBase
                std::deque<std::string> stackresult;                            
                for (CUList::iterator i = cl->begin(); i != cl->end(); i++)
                {
-                       if (i->second->GetExt(item, dummyptr))
+                       if (i->first->GetExt(item, dummyptr))
                        {
-                               modestack.Push(mc, i->second->nick);
+                               modestack.Push(mc, i->first->nick);
                        }
                }
 
@@ -107,15 +107,15 @@ class FounderProtectBase
                unload_kludge = false;
        }
 
-        void DisplayList(userrec* user, chanrec* channel)
+       void DisplayList(userrec* user, chanrec* channel)
        {
                CUList* cl = channel->GetUsers();
                std::string item = extend+std::string(channel->name);
-               for (CUList::iterator i = cl->begin(); i != cl->end(); i++)
+               for (CUList::reverse_iterator i = cl->rbegin(); i != cl->rend(); ++i)
                {
-                       if (i->second->GetExt(item, dummyptr))
+                       if (i->first->GetExt(item, dummyptr))
                        {
-                               user->WriteServ("%d %s %s %s", list, user->nick, channel->name,i->second->nick);
+                               user->WriteServ("%d %s %s %s", list, user->nick, channel->name,i->first->nick);
                        }
                }
                user->WriteServ("%d %s %s :End of channel %s list", end, user->nick, channel->name, type.c_str());
@@ -126,7 +126,7 @@ class FounderProtectBase
                userrec* theuser = MyInstance->FindNick(parameter);
                if ((!theuser) || (!channel->HasUser(theuser)))
                {
-                       parameter = "";
+                       parameter.clear();
                        return NULL;
                }
                return theuser;
@@ -215,7 +215,7 @@ class ChanFounder : public ModeHandler, public FounderProtectBase
                {
                        // whoops, someones being naughty!
                        source->WriteServ("468 %s %s :Only servers may set channel mode +q",source->nick, channel->name);
-                       parameter = "";
+                       parameter.clear();
                        return MODEACTION_DENY;
                }
        }
@@ -303,7 +303,7 @@ class ModuleChanProtect : public Module
  public:
  
        ModuleChanProtect(InspIRCd* Me)
-               : Module::Module(Me), FirstInGetsFounder(false), QAPrefixes(false), DeprivSelf(false), DeprivOthers(false), booting(true)
+               : Module(Me), FirstInGetsFounder(false), QAPrefixes(false), DeprivSelf(false), DeprivOthers(false), booting(true)
        {       
                /* Load config stuff */
                OnRehash(NULL,"");
@@ -320,17 +320,17 @@ class ModuleChanProtect : public Module
 
        void Implements(char* List)
        {
-               List[I_OnUserKick] = List[I_OnUserPart] = List[I_OnRehash] = List[I_OnUserJoin] = List[I_OnAccessCheck] = List[I_OnSyncChannel] = 1;
+               List[I_OnUserKick] = List[I_OnUserPart] = List[I_OnRehash] = List[I_OnUserPreJoin] = List[I_OnPostJoin] = List[I_OnAccessCheck] = List[I_OnSyncChannel] = 1;
        }
 
-       virtual void OnUserKick(userrec* source, userrec* user, chanrec* chan, const std::string &reason)
+       virtual void OnUserKick(userrec* source, userrec* user, chanrec* chan, const std::string &reason, bool &silent)
        {
                // FIX: when someone gets kicked from a channel we must remove their Extensibles!
                user->Shrink("cm_founder_"+std::string(chan->name));
                user->Shrink("cm_protect_"+std::string(chan->name));
        }
 
-       virtual void OnUserPart(userrec* user, chanrec* channel, const std::string &partreason)
+       virtual void OnUserPart(userrec* user, chanrec* channel, const std::string &partreason, bool &silent)
        {
                // FIX: when someone parts a channel we must remove their Extensibles!
                user->Shrink("cm_founder_"+std::string(channel->name));
@@ -372,26 +372,29 @@ class ModuleChanProtect : public Module
                }
        }
        
-       virtual void OnUserJoin(userrec* user, chanrec* channel)
+       virtual int OnUserPreJoin(userrec *user, chanrec *chan, const char *cname, std::string &privs)
        {
                // if the user is the first user into the channel, mark them as the founder, but only if
                // the config option for it is set
-               if (FirstInGetsFounder)
-               {
-                       if (channel->GetUserCounter() == 1)
-                       {
-                               // we're using Extensible::Extend to add data into user objects.
-                               // this way is best as it adds data thats accessible to other modules
-                               // (so long as you document your code properly) without breaking anything
-                               // because its encapsulated neatly in a map.
-
-                               // Change requested by katsklaw... when the first in is set to get founder,
-                               // to make it clearer that +q has been given, send that one user the +q notice
-                               // so that their client's syncronization and their sanity are left intact.
-                               user->WriteServ("MODE %s +q %s",channel->name,user->nick);
-                               user->Extend("cm_founder_"+std::string(channel->name),fakevalue);
-                       }
-               }
+
+               if (FirstInGetsFounder && !chan)
+                       privs = "~@";
+               
+               return 0;
+       }
+       
+       virtual void OnPostJoin(userrec *user, chanrec *channel)
+       {
+               // This *must* be in PostJoin, not UserJoin - the former will make it appear to happen
+               // before the client is in the channel
+               
+               // This notice was here originally because it was all done prior to the creation of
+               // privs in OnUserPreJoin. I've left it because it might still be wanted, but i'm
+               // not sure it really should be here - ops don't get shown, obviously, and the prefix
+               // will appear in the names list for the user.. remove if desired -Special
+
+               if (FirstInGetsFounder && channel->GetUserCounter() == 1)
+                       user->WriteServ("MODE %s +q %s", channel->name, user->nick);
        }
        
        virtual int OnAccessCheck(userrec* source,userrec* dest,chanrec* channel,int access_type)
@@ -508,13 +511,13 @@ class ModuleChanProtect : public Module
                        std::deque<std::string> stackresult;
                        for (CUList::iterator i = cl->begin(); i != cl->end(); i++)
                        {
-                               if (i->second->GetExt(founder,dummyptr))
+                               if (i->first->GetExt(founder,dummyptr))
                                {
-                                       modestack.Push('q',i->second->nick);
+                                       modestack.Push('q',i->first->nick);
                                }
-                               if (i->second->GetExt(protect,dummyptr))
+                               if (i->first->GetExt(protect,dummyptr))
                                {
-                                       modestack.Push('a',i->second->nick);
+                                       modestack.Push('a',i->first->nick);
                                }
                        }
                        while (modestack.GetStackedLine(stackresult))
@@ -528,27 +531,4 @@ class ModuleChanProtect : public Module
 
 };
 
-
-class ModuleChanProtectFactory : public ModuleFactory
-{
- public:
-       ModuleChanProtectFactory()
-       {
-       }
-       
-       ~ModuleChanProtectFactory()
-       {
-       }
-       
-       virtual Module * CreateModule(InspIRCd* Me)
-       {
-               return new ModuleChanProtect(Me);
-       }
-       
-};
-
-
-extern "C" void * init_module( void )
-{
-       return new ModuleChanProtectFactory;
-}
+MODULE_INIT(ModuleChanProtect)