m_check: remove unnecessary usage of CheckContext::List.

[user/henk/code/inspircd.git] / src / modules / m_check.cpp

diff --git a/src/modules/m_check.cpp b/src/modules/m_check.cpp
index f2da47f1bb63cb4d317b6c880112ab458550d423..5e1c01acb4ec085af2a0e013b0009a8818308ff8 100644 (file)
--- a/src/modules/m_check.cpp
+++ b/src/modules/m_check.cpp
@@ -30,9 +30,18 @@ enum
 
 class CheckContext
 {
+ private:
        User* const user;
        const std::string& target;
 
+       std::string FormatTime(time_t ts)
+       {
+               std::string timestr(InspIRCd::TimeString(ts, "%Y-%m-%d %H:%M:%S UTC (", true));
+               timestr.append(ConvToStr(ts));
+               timestr.push_back(')');
+               return timestr;
+       }
+
  public:
        CheckContext(User* u, const std::string& targetstr)
                : user(u)
@@ -51,6 +60,11 @@ class CheckContext
                user->WriteRemoteNumeric(RPL_CHECK, type, text);
        }
 
+       void Write(const std::string& type, time_t ts)
+       {
+               user->WriteRemoteNumeric(RPL_CHECK, type, FormatTime(ts));
+       }
+
        User* GetUser() const { return user; }
 
        void DumpListMode(const ListModeBase::ModeList* list)
@@ -130,19 +144,9 @@ class CommandCheck : public Command
                flags_needed = 'o'; syntax = "<nickname>|<ip>|<hostmask>|<channel> <server>";
        }
 
-       std::string timestring(time_t time)
+       CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE
        {
-               char timebuf[60];
-               struct tm *mytime = gmtime(&time);
-               strftime(timebuf, 59, "%Y-%m-%d %H:%M:%S UTC (", mytime);
-               std::string ret(timebuf);
-               ret.append(ConvToStr(time)).push_back(')');
-               return ret;
-       }
-
-       CmdResult Handle(const std::vector<std::string>& parameters, User* user) CXX11_OVERRIDE
-       {
-               if (parameters.size() > 1 && parameters[1] != ServerInstance->Config->ServerName)
+               if (parameters.size() > 1 && !irc::equals(parameters[1], ServerInstance->Config->ServerName))
                        return CMD_SUCCESS;
 
                User *targuser;
@@ -168,20 +172,20 @@ class CommandCheck : public Command
                        /* /check on a user */
                        context.Write("nuh", targuser->GetFullHost());
                        context.Write("realnuh", targuser->GetFullRealHost());
-                       context.Write("realname", targuser->fullname);
+                       context.Write("realname", targuser->GetRealName());
                        context.Write("modes", targuser->GetModeLetters());
                        context.Write("snomasks", GetSnomasks(targuser));
                        context.Write("server", targuser->server->GetName());
                        context.Write("uid", targuser->uuid);
-                       context.Write("signon", timestring(targuser->signon));
-                       context.Write("nickts", timestring(targuser->age));
+                       context.Write("signon", targuser->signon);
+                       context.Write("nickts", targuser->age);
                        if (loctarg)
-                               context.Write("lastmsg", timestring(loctarg->idle_lastmsg));
+                               context.Write("lastmsg", loctarg->idle_lastmsg);
 
                        if (targuser->IsAway())
                        {
                                /* user is away */
-                               context.Write("awaytime", timestring(targuser->awaytime));
+                               context.Write("awaytime", targuser->awaytime);
                                context.Write("awaymsg", targuser->awaymsg);
                        }
 
@@ -195,13 +199,8 @@ class CommandCheck : public Command
                                        std::string umodes = GetAllowedOperOnlyModes(loctarg, MODETYPE_USER);
                                        std::string cmodes = GetAllowedOperOnlyModes(loctarg, MODETYPE_CHANNEL);
                                        context.Write("modeperms", "user=" + umodes + " channel=" + cmodes);
-
-                                       CheckContext::List opcmdlist(context, "commandperms");
-                                       opcmdlist.Add(oper->AllowedOperCommands.ToString());
-                                       opcmdlist.Flush();
-                                       CheckContext::List privlist(context, "permissions");
-                                       opcmdlist.Add(oper->AllowedPrivs.ToString());
-                                       privlist.Flush();
+                                       context.Write("commandperms", oper->AllowedOperCommands.ToString());
+                                       context.Write("permissions", oper->AllowedPrivs.ToString());
                                }
                        }
 
@@ -237,14 +236,14 @@ class CommandCheck : public Command
                else if (targchan)
                {
                        /* /check on a channel */
-                       context.Write("timestamp", timestring(targchan->age));
+                       context.Write("timestamp", targchan->age);
 
                        if (!targchan->topic.empty())
                        {
                                /* there is a topic, assume topic related information exists */
                                context.Write("topic", targchan->topic);
                                context.Write("topic_setby", targchan->setby);
-                               context.Write("topic_setat", timestring(targchan->topicset));
+                               context.Write("topic_setat", targchan->topicset);
                        }
 
                        context.Write("modes", targchan->ChanModes(true));
@@ -263,7 +262,7 @@ class CommandCheck : public Command
                                const UserManager::CloneCounts& clonecount = ServerInstance->Users->GetCloneCounts(i->first);
                                context.Write("member", InspIRCd::Format("%-3u %s%s (%s@%s) %s ", clonecount.global,
                                        i->second->GetAllPrefixChars().c_str(), i->first->nick.c_str(),
-                                       i->first->ident.c_str(), i->first->GetDisplayedHost().c_str(), i->first->fullname.c_str()));
+                                       i->first->ident.c_str(), i->first->GetDisplayedHost().c_str(), i->first->GetRealName().c_str()));
                        }
 
                        const ModeParser::ListModeList& listmodes = ServerInstance->Modes->GetListModes();
@@ -284,13 +283,13 @@ class CommandCheck : public Command
                                if (InspIRCd::Match(a->second->GetRealHost(), parameters[0], ascii_case_insensitive_map) || InspIRCd::Match(a->second->GetDisplayedHost(), parameters[0], ascii_case_insensitive_map))
                                {
                                        /* host or vhost matches mask */
-                                       context.Write("match", ConvToStr(++x) + " " + a->second->GetFullRealHost() + " " + a->second->GetIPString() + " " + a->second->fullname);
+                                       context.Write("match", ConvToStr(++x) + " " + a->second->GetFullRealHost() + " " + a->second->GetIPString() + " " + a->second->GetRealName());
                                }
                                /* IP address */
                                else if (InspIRCd::MatchCIDR(a->second->GetIPString(), parameters[0]))
                                {
                                        /* same IP. */
-                                       context.Write("match", ConvToStr(++x) + " " + a->second->GetFullRealHost() + " " + a->second->GetIPString() + " " + a->second->fullname);
+                                       context.Write("match", ConvToStr(++x) + " " + a->second->GetFullRealHost() + " " + a->second->GetIPString() + " " + a->second->GetRealName());
                                }
                        }
 
@@ -301,7 +300,7 @@ class CommandCheck : public Command
                return CMD_SUCCESS;
        }
 
-       RouteDescriptor GetRouting(User* user, const std::vector<std::string>& parameters) CXX11_OVERRIDE
+       RouteDescriptor GetRouting(User* user, const Params& parameters) CXX11_OVERRIDE
        {
                if ((parameters.size() > 1) && (parameters[1].find('.') != std::string::npos))
                        return ROUTE_OPT_UCAST(parameters[1]);