Fix infinite loop on alias expansion, found by Adam

[user/henk/code/inspircd.git] / src / modules / m_cloaking.cpp

diff --git a/src/modules/m_cloaking.cpp b/src/modules/m_cloaking.cpp
index 0aee306a341f798f66900c180839ce940d038f34..3be6e2163f2ce80b51fc4fe6c539f2fd13e3c814 100644 (file)
--- a/src/modules/m_cloaking.cpp
+++ b/src/modules/m_cloaking.cpp
@@ -344,7 +344,7 @@ class ModuleCloaking : public Module
        {
                // returns the version number of the module to be
                // listed in /MODULES
-               return Version("Provides masking of user hostnames", VF_COMMON|VF_VENDOR,API_VERSION);
+               return Version("Provides masking of user hostnames", VF_COMMON|VF_VENDOR);
        }
 
        void OnRehash(User* user)
@@ -377,10 +377,10 @@ class ModuleCloaking : public Module
                         * We must limit the keys or else we get different results on
                         * amd64/x86 boxes. - psychon */
                        const unsigned int limit = 0x80000000;
-                       compatkey[1] = (unsigned int) Conf.ReadInteger("cloak","key1",0,false);
-                       compatkey[2] = (unsigned int) Conf.ReadInteger("cloak","key2",0,false);
-                       compatkey[3] = (unsigned int) Conf.ReadInteger("cloak","key3",0,false);
-                       compatkey[4] = (unsigned int) Conf.ReadInteger("cloak","key4",0,false);
+                       compatkey[0] = (unsigned int) Conf.ReadInteger("cloak","key1",0,false);
+                       compatkey[1] = (unsigned int) Conf.ReadInteger("cloak","key2",0,false);
+                       compatkey[2] = (unsigned int) Conf.ReadInteger("cloak","key3",0,false);
+                       compatkey[3] = (unsigned int) Conf.ReadInteger("cloak","key4",0,false);
 
                        if (!lowercase)
                        {
@@ -400,17 +400,17 @@ class ModuleCloaking : public Module
                        if (prefix.empty())
                                prefix = ServerInstance->Config->Network;
 
-                       if (!compatkey[1] || !compatkey[2] || !compatkey[3] || !compatkey[4] ||
-                               compatkey[1] >= limit || compatkey[2] >= limit || compatkey[3] >= limit || compatkey[4] >= limit)
+                       if (!compatkey[0] || !compatkey[1] || !compatkey[2] || !compatkey[3] ||
+                               compatkey[0] >= limit || compatkey[1] >= limit || compatkey[2] >= limit || compatkey[3] >= limit)
                        {
                                std::string detail;
-                               if (!compatkey[1] || compatkey[1] >= limit)
+                               if (!compatkey[0] || compatkey[0] >= limit)
                                        detail = "<cloak:key1> is not valid, it may be set to a too high/low value, or it may not exist.";
-                               else if (!compatkey[2] || compatkey[2] >= limit)
+                               else if (!compatkey[1] || compatkey[1] >= limit)
                                        detail = "<cloak:key2> is not valid, it may be set to a too high/low value, or it may not exist.";
-                               else if (!compatkey[3] || compatkey[3] >= limit)
+                               else if (!compatkey[2] || compatkey[2] >= limit)
                                        detail = "<cloak:key3> is not valid, it may be set to a too high/low value, or it may not exist.";
-                               else if (!compatkey[4] || compatkey[4] >= limit)
+                               else if (!compatkey[3] || compatkey[3] >= limit)
                                        detail = "<cloak:key4> is not valid, it may be set to a too high/low value, or it may not exist.";
 
                                throw ModuleException("You have not defined cloak keys for m_cloaking!!! THIS IS INSECURE AND SHOULD BE CHECKED! - " + detail);