]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_cloaking.cpp
Replace snprintf usage with InspIRCd::Format.
[user/henk/code/inspircd.git] / src / modules / m_cloaking.cpp
index 0aee306a341f798f66900c180839ce940d038f34..890c799f2b2b55d2e96b4c099db9bdc1163a9f75 100644 (file)
@@ -1,27 +1,33 @@
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
  *
- *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
- * See: http://wiki.inspircd.org/Credits
+ *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2006-2008 Robin Burchell <robin+git@viroteck.net>
+ *   Copyright (C) 2008 Pippijn van Steenhoven <pip88nl@gmail.com>
+ *   Copyright (C) 2003-2008 Craig Edwards <craigedwards@brainbox.cc>
+ *   Copyright (C) 2007 John Brooks <john.brooks@dereferenced.net>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
+ *   Copyright (C) 2006 Oliver Lupton <oliverlupton@gmail.com>
  *
- * This program is free but copyrighted software; see
- *         the file COPYING for details.
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "inspircd.h"
-#include "m_hash.h"
 
-/* $ModDesc: Provides masking of user hostnames */
+#include "inspircd.h"
+#include "modules/hash.h"
 
 enum CloakMode
 {
-       /** 1.2-compatible host-based cloak */
-       MODE_COMPAT_HOST,
-       /** 1.2-compatible IP-only cloak */
-       MODE_COMPAT_IPONLY,
        /** 2.0 cloak of "half" of the hostname plus the full IP hash */
        MODE_HALF_CLOAK,
        /** 2.0 cloak of IP hash, split at 2 common CIDR range points */
@@ -37,108 +43,107 @@ class CloakUser : public ModeHandler
 {
  public:
        LocalStringExt ext;
+       std::string debounce_uid;
+       time_t debounce_ts;
+       int debounce_count;
 
        CloakUser(Module* source)
                : ModeHandler(source, "cloak", 'x', PARAM_NONE, MODETYPE_USER),
-               ext("cloaked_host", source)
+               ext("cloaked_host", ExtensionItem::EXT_USER, source), debounce_ts(0), debounce_count(0)
        {
        }
 
        ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string &parameter, bool adding)
        {
+               LocalUser* user = IS_LOCAL(dest);
+
                /* For remote clients, we don't take any action, we just allow it.
                 * The local server where they are will set their cloak instead.
                 * This is fine, as we will receive it later.
                 */
-               if (!IS_LOCAL(dest))
+               if (!user)
                {
-                       dest->SetMode('x',adding);
+                       dest->SetMode(this, adding);
                        return MODEACTION_ALLOW;
                }
 
+               if (user->uuid == debounce_uid && debounce_ts == ServerInstance->Time())
+               {
+                       // prevent spamming using /mode user +x-x+x-x+x-x
+                       if (++debounce_count > 2)
+                               return MODEACTION_DENY;
+               }
+               else
+               {
+                       debounce_uid = user->uuid;
+                       debounce_count = 1;
+                       debounce_ts = ServerInstance->Time();
+               }
+
+               if (adding == user->IsModeSet(this))
+                       return MODEACTION_DENY;
+
                /* don't allow this user to spam modechanges */
-               dest->IncreasePenalty(5);
+               if (source == dest)
+                       user->CommandFloodPenalty += 5000;
 
                if (adding)
                {
-                       if(!dest->IsModeSet('x'))
+                       std::string* cloak = ext.get(user);
+
+                       if (!cloak)
                        {
-                               /* The mode is being turned on - so attempt to
-                                * allocate the user a cloaked host using a non-reversible
-                                * algorithm (its simple, but its non-reversible so the
-                                * simplicity doesnt really matter). This algorithm
-                                * will not work if the user has only one level of domain
-                                * naming in their hostname (e.g. if they are on a lan or
-                                * are connecting via localhost) -- this doesnt matter much.
-                                */
-
-                               std::string* cloak = ext.get(dest);
-
-                               if (!cloak)
-                               {
-                                       /* Force creation of missing cloak */
-                                       creator->OnUserConnect(dest);
-                                       cloak = ext.get(dest);
-                               }
-                               if (cloak)
-                               {
-                                       dest->ChangeDisplayedHost(cloak->c_str());
-                                       dest->SetMode('x',true);
-                                       return MODEACTION_ALLOW;
-                               }
+                               /* Force creation of missing cloak */
+                               creator->OnUserConnect(user);
+                               cloak = ext.get(user);
                        }
-               }
-               else
-               {
-                       if (dest->IsModeSet('x'))
+                       if (cloak)
                        {
-                               /* User is removing the mode, so just restore their real host
-                                * and make it match the displayed one.
-                                */
-                               dest->ChangeDisplayedHost(dest->host.c_str());
-                               dest->SetMode('x',false);
+                               user->ChangeDisplayedHost(*cloak);
+                               user->SetMode(this, true);
                                return MODEACTION_ALLOW;
                        }
+                       else
+                               return MODEACTION_DENY;
+               }
+               else
+               {
+                       /* User is removing the mode, so restore their real host
+                        * and make it match the displayed one.
+                        */
+                       user->SetMode(this, false);
+                       user->ChangeDisplayedHost(user->host.c_str());
+                       return MODEACTION_ALLOW;
                }
+       }
+};
 
-               return MODEACTION_DENY;
+class CommandCloak : public Command
+{
+ public:
+       CommandCloak(Module* Creator) : Command(Creator, "CLOAK", 1)
+       {
+               flags_needed = 'o';
+               syntax = "<host>";
        }
 
+       CmdResult Handle(const std::vector<std::string> &parameters, User *user);
 };
 
-
 class ModuleCloaking : public Module
 {
- private:
+ public:
        CloakUser cu;
        CloakMode mode;
+       CommandCloak ck;
        std::string prefix;
+       std::string suffix;
        std::string key;
-       unsigned int compatkey[4];
        const char* xtab[4];
-       Module* HashProvider;
+       dynamic_reference<HashProvider> Hash;
 
- public:
-       ModuleCloaking() : cu(this)
+       ModuleCloaking() : cu(this), mode(MODE_OPAQUE), ck(this), Hash(this, "hash/md5")
        {
-               /* Attempt to locate the md5 service provider, bail if we can't find it */
-               HashProvider = ServerInstance->Modules->Find("m_md5.so");
-               if (!HashProvider)
-                       throw ModuleException("Can't find m_md5.so. Please load m_md5.so before m_cloaking.so.");
-
-               OnRehash(NULL);
-
-               /* Register it with the core */
-               if (!ServerInstance->Modes->AddMode(&cu))
-                       throw ModuleException("Could not add new modes!");
-
-               ServerInstance->Modules->UseInterface("HashRequest");
-               ServerInstance->Extensions.Register(&cu.ext);
-
-               Implementation eventlist[] = { I_OnRehash, I_OnCheckBan, I_OnUserConnect };
-               ServerInstance->Modules->Attach(eventlist, this, 3);
-
-               CloakExistingUsers();
        }
 
        /** This function takes a domain name string and returns just the last two domain parts,
@@ -167,163 +172,115 @@ class ModuleCloaking : public Module
                }
 
                if (splitdot == host.length())
-                       return host;
+                       return "";
                else
                        return host.substr(splitdot);
        }
 
-       std::string CompatCloak4(const char* ip)
-       {
-               irc::sepstream seps(ip, '.');
-               std::string octet[4];
-               int i[4];
-
-               for (int j = 0; j < 4; j++)
-               {
-                       seps.GetToken(octet[j]);
-                       i[j] = atoi(octet[j].c_str());
-               }
-
-               octet[3] = octet[0] + "." + octet[1] + "." + octet[2] + "." + octet[3];
-               octet[2] = octet[0] + "." + octet[1] + "." + octet[2];
-               octet[1] = octet[0] + "." + octet[1];
-
-               /* Reset the Hash module and send it our IV */
-
-               std::string rv;
-
-               /* Send the Hash module a different hex table for each octet group's Hash sum */
-               for (int k = 0; k < 4; k++)
-               {
-                       HashRequestIV hash(this, HashProvider, compatkey, xtab[(compatkey[k]+i[k]) % 4], octet[k]);
-                       rv.append(hash.result.substr(0,6));
-                       if (k < 3)
-                               rv.append(".");
-               }
-               /* Stick them all together */
-               return rv;
-       }
-
-       std::string CompatCloak6(const char* ip)
+       /**
+        * 2.0-style cloaking function
+        * @param item The item to cloak (part of an IP or hostname)
+        * @param id A unique ID for this type of item (to make it unique if the item matches)
+        * @param len The length of the output. Maximum for MD5 is 16 characters.
+        */
+       std::string SegmentCloak(const std::string& item, char id, int len)
        {
-               std::vector<std::string> hashies;
-               std::string item;
-               int rounds = 0;
-
-               /* Reset the Hash module and send it our IV */
-
-               for (const char* input = ip; *input; input++)
-               {
-                       item += *input;
-                       if (item.length() > 7)
-                       {
-                               HashRequestIV hash(this, HashProvider, compatkey, xtab[(compatkey[1]+rounds) % 4], item);
-                               hashies.push_back(hash.result.substr(0,8));
-                               item.clear();
-                       }
-                       rounds++;
-               }
-               if (!item.empty())
-               {
-                       HashRequestIV hash(this, HashProvider, compatkey, xtab[(compatkey[1]+rounds) % 4], item);
-                       hashies.push_back(hash.result.substr(0,8));
-               }
-               /* Stick them all together */
-               return irc::stringjoiner(":", hashies, 0, hashies.size() - 1).GetJoined();
-       }
+               std::string input;
+               input.reserve(key.length() + 3 + item.length());
+               input.append(1, id);
+               input.append(key);
+               input.append(1, '\0'); // null does not terminate a C++ string
+               input.append(item);
 
-       std::string ReversePartialIP(const irc::sockets::sockaddrs& ip)
-       {
-               char rv[50];
-               if (ip.sa.sa_family == AF_INET6)
-               {
-                       snprintf(rv, 50, ".%02x%02x.%02x%02x.%02x%02x.IP",
-                               ip.in6.sin6_addr.s6_addr[4], ip.in6.sin6_addr.s6_addr[5],
-                               ip.in6.sin6_addr.s6_addr[2], ip.in6.sin6_addr.s6_addr[3],
-                               ip.in6.sin6_addr.s6_addr[0], ip.in6.sin6_addr.s6_addr[1]);
-               }
-               else
+               std::string rv = Hash->GenerateRaw(input).substr(0,len);
+               for(int i=0; i < len; i++)
                {
-                       const unsigned char* ip4 = (const unsigned char*)&ip.in4.sin_addr;
-                       snprintf(rv, 50, ".%d.%d.IP", ip4[1], ip4[0]);
+                       // this discards 3 bits per byte. We have an
+                       // overabundance of bits in the hash output, doesn't
+                       // matter which ones we are discarding.
+                       rv[i] = base32[rv[i] & 0x1F];
                }
                return rv;
        }
 
-       std::string SegmentIP(const irc::sockets::sockaddrs& ip)
+       std::string SegmentIP(const irc::sockets::sockaddrs& ip, bool full)
        {
                std::string bindata;
-               int hop1, hop2;
+               int hop1, hop2, hop3;
+               int len1, len2;
+               std::string rv;
                if (ip.sa.sa_family == AF_INET6)
                {
                        bindata = std::string((const char*)ip.in6.sin6_addr.s6_addr, 16);
                        hop1 = 8;
                        hop2 = 6;
+                       hop3 = 4;
+                       len1 = 6;
+                       len2 = 4;
+                       // pfx s1.s2.s3. (xxxx.xxxx or s4) sfx
+                       //     6  4  4    9/6
+                       rv.reserve(prefix.length() + 26 + suffix.length());
                }
                else
                {
                        bindata = std::string((const char*)&ip.in4.sin_addr, 4);
                        hop1 = 3;
-                       hop2 = 2;
+                       hop2 = 0;
+                       hop3 = 2;
+                       len1 = len2 = 3;
+                       // pfx s1.s2. (xxx.xxx or s3) sfx
+                       rv.reserve(prefix.length() + 15 + suffix.length());
                }
 
-               std::string rv;
-               rv.reserve(prefix.length() + 30);
                rv.append(prefix);
-               rv.append(SegmentCloak(bindata, 2));
+               rv.append(SegmentCloak(bindata, 10, len1));
                rv.append(1, '.');
                bindata.erase(hop1);
-               rv.append(SegmentCloak(bindata, 3));
-               rv.append(1, '.');
-               bindata.erase(hop2);
-               rv.append(SegmentCloak(bindata, 4));
-               rv.append(".IP");
-               return rv;
-       }
-
-       std::string SegmentCloak(const std::string& item, char id)
-       {
-               std::string input;
-               input.reserve(key.length() + 3 + item.length());
-               input.append(1, id);
-               input.append(key);
-               input.append(1, 0); // null does not terminate a C++ string
-               input.append(item);
-
-               HashRequest hash(this, HashProvider, input);
-               std::string rv = hash.binresult.substr(0,6);
-               for(int i=0; i < 6; i++)
+               rv.append(SegmentCloak(bindata, 11, len2));
+               if (hop2)
                {
-                       // this discards 3 bits per byte. We have an
-                       // overabundance of bits in the hash output, doesn't
-                       // matter which ones we are discarding.
-                       rv[i] = base32[rv[i] & 0x1F];
+                       rv.append(1, '.');
+                       bindata.erase(hop2);
+                       rv.append(SegmentCloak(bindata, 12, len2));
                }
-               return rv;
-       }
 
-       void CloakExistingUsers()
-       {
-               std::string* cloak;
-               for (std::vector<User*>::iterator u = ServerInstance->Users->local_users.begin(); u != ServerInstance->Users->local_users.end(); u++)
+               if (full)
                {
-                       cloak = cu.ext.get(*u);
-                       if (!cloak)
+                       rv.append(1, '.');
+                       bindata.erase(hop3);
+                       rv.append(SegmentCloak(bindata, 13, 6));
+                       rv.append(suffix);
+               }
+               else
+               {
+                       if (ip.sa.sa_family == AF_INET6)
+                       {
+                               rv.append(InspIRCd::Format(".%02x%02x.%02x%02x%s",
+                                       ip.in6.sin6_addr.s6_addr[2], ip.in6.sin6_addr.s6_addr[3],
+                                       ip.in6.sin6_addr.s6_addr[0], ip.in6.sin6_addr.s6_addr[1], suffix.c_str()));
+                       }
+                       else
                        {
-                               OnUserConnect(*u);
+                               const unsigned char* ip4 = (const unsigned char*)&ip.in4.sin_addr;
+                               rv.append(InspIRCd::Format(".%d.%d%s", ip4[1], ip4[0], suffix.c_str()));
                        }
                }
+               return rv;
        }
 
-       ModResult OnCheckBan(User* user, Channel* chan, const std::string& mask)
+       ModResult OnCheckBan(User* user, Channel* chan, const std::string& mask) CXX11_OVERRIDE
        {
-               char cmask[MAXBUF];
+               LocalUser* lu = IS_LOCAL(user);
+               if (!lu)
+                       return MOD_RES_PASSTHRU;
+
+               OnUserConnect(lu);
                std::string* cloak = cu.ext.get(user);
                /* Check if they have a cloaked host, but are not using it */
                if (cloak && *cloak != user->dhost)
                {
-                       snprintf(cmask, MAXBUF, "%s!%s@%s", user->nick.c_str(), user->ident.c_str(), cloak->c_str());
-                       if (InspIRCd::Match(cmask,mask))
+                       const std::string cloakMask = user->nick + "!" + user->ident + "@" + *cloak;
+                       if (InspIRCd::Match(cloakMask, mask))
                                return MOD_RES_DENY;
                }
                return MOD_RES_PASSTHRU;
@@ -335,152 +292,98 @@ class ModuleCloaking : public Module
                ServerInstance->Modules->SetPriority(this, I_OnCheckBan, PRIORITY_LAST);
        }
 
-       ~ModuleCloaking()
+       // this unsets umode +x on every host change. If we are actually doing a +x
+       // mode change, we will call SetMode back to true AFTER the host change is done.
+       void OnChangeHost(User* u, const std::string& host) CXX11_OVERRIDE
        {
-               ServerInstance->Modules->DoneWithInterface("HashRequest");
+               if (u->IsModeSet(cu))
+               {
+                       u->SetMode(cu, false);
+                       u->WriteCommand("MODE", "-" + ConvToStr(cu.GetModeChar()));
+               }
        }
 
-       Version GetVersion()
+       Version GetVersion() CXX11_OVERRIDE
        {
-               // returns the version number of the module to be
-               // listed in /MODULES
-               return Version("Provides masking of user hostnames", VF_COMMON|VF_VENDOR,API_VERSION);
+               std::string testcloak = "broken";
+               if (Hash)
+               {
+                       switch (mode)
+                       {
+                               case MODE_HALF_CLOAK:
+                                       testcloak = prefix + SegmentCloak("*", 3, 8) + suffix;
+                                       break;
+                               case MODE_OPAQUE:
+                                       testcloak = prefix + SegmentCloak("*", 4, 8) + suffix;
+                       }
+               }
+               return Version("Provides masking of user hostnames", VF_COMMON|VF_VENDOR, testcloak);
        }
 
-       void OnRehash(User* user)
+       void ReadConfig(ConfigStatus& status) CXX11_OVERRIDE
        {
-               ConfigReader Conf;
-               prefix = Conf.ReadValue("cloak","prefix",0);
-
-               std::string modestr = Conf.ReadValue("cloak", "mode", 0);
-               if (modestr == "compat-host")
-                       mode = MODE_COMPAT_HOST;
-               else if (modestr == "compat-ip")
-                       mode = MODE_COMPAT_IPONLY;
-               else if (modestr == "half")
+               ConfigTag* tag = ServerInstance->Config->ConfValue("cloak");
+               prefix = tag->getString("prefix");
+               suffix = tag->getString("suffix", ".IP");
+
+               std::string modestr = tag->getString("mode");
+               if (modestr == "half")
                        mode = MODE_HALF_CLOAK;
                else if (modestr == "full")
                        mode = MODE_OPAQUE;
                else
-                       throw ModuleException("Bad value for <cloak:mode>; must be one of compat-host, compat-ip, half, full");
-
-               if (mode == MODE_COMPAT_HOST || mode == MODE_COMPAT_IPONLY)
-               {
-                       bool lowercase = Conf.ReadFlag("cloak", "lowercase", 0);
-
-                       /* These are *not* using the need_positive parameter of ReadInteger -
-                        * that will limit the valid values to only the positive values in a
-                        * signed int. Instead, accept any value that fits into an int and
-                        * cast it to an unsigned int. That will, a bit oddly, give us the full
-                        * spectrum of an unsigned integer. - Special
-                        *
-                        * We must limit the keys or else we get different results on
-                        * amd64/x86 boxes. - psychon */
-                       const unsigned int limit = 0x80000000;
-                       compatkey[1] = (unsigned int) Conf.ReadInteger("cloak","key1",0,false);
-                       compatkey[2] = (unsigned int) Conf.ReadInteger("cloak","key2",0,false);
-                       compatkey[3] = (unsigned int) Conf.ReadInteger("cloak","key3",0,false);
-                       compatkey[4] = (unsigned int) Conf.ReadInteger("cloak","key4",0,false);
-
-                       if (!lowercase)
-                       {
-                               xtab[0] = "F92E45D871BCA630";
-                               xtab[1] = "A1B9D80C72E653F4";
-                               xtab[2] = "1ABC078934DEF562";
-                               xtab[3] = "ABCDEF5678901234";
-                       }
-                       else
-                       {
-                               xtab[0] = "f92e45d871bca630";
-                               xtab[1] = "a1b9d80c72e653f4";
-                               xtab[2] = "1abc078934def562";
-                               xtab[3] = "abcdef5678901234";
-                       }
-
-                       if (prefix.empty())
-                               prefix = ServerInstance->Config->Network;
+                       throw ModuleException("Bad value for <cloak:mode>; must be half or full");
 
-                       if (!compatkey[1] || !compatkey[2] || !compatkey[3] || !compatkey[4] ||
-                               compatkey[1] >= limit || compatkey[2] >= limit || compatkey[3] >= limit || compatkey[4] >= limit)
-                       {
-                               std::string detail;
-                               if (!compatkey[1] || compatkey[1] >= limit)
-                                       detail = "<cloak:key1> is not valid, it may be set to a too high/low value, or it may not exist.";
-                               else if (!compatkey[2] || compatkey[2] >= limit)
-                                       detail = "<cloak:key2> is not valid, it may be set to a too high/low value, or it may not exist.";
-                               else if (!compatkey[3] || compatkey[3] >= limit)
-                                       detail = "<cloak:key3> is not valid, it may be set to a too high/low value, or it may not exist.";
-                               else if (!compatkey[4] || compatkey[4] >= limit)
-                                       detail = "<cloak:key4> is not valid, it may be set to a too high/low value, or it may not exist.";
-
-                               throw ModuleException("You have not defined cloak keys for m_cloaking!!! THIS IS INSECURE AND SHOULD BE CHECKED! - " + detail);
-                       }
-               }
-               else
-               {
-                       key = Conf.ReadFlag("cloak", "key", 0);
-                       if (key.empty() || key == "secret")
-                               throw ModuleException("You have not defined cloak keys for m_cloaking. Define <cloak:key> as a network-wide secret.");
-               }
+               key = tag->getString("key");
+               if (key.empty() || key == "secret")
+                       throw ModuleException("You have not defined cloak keys for m_cloaking. Define <cloak:key> as a network-wide secret.");
        }
 
-       void OnUserConnect(User* dest)
+       std::string GenCloak(const irc::sockets::sockaddrs& ip, const std::string& ipstr, const std::string& host)
        {
-               std::string* cloak = cu.ext.get(dest);
-               if (cloak)
-                       return;
-
-               if (dest->host.find('.') == std::string::npos && dest->host.find(':') == std::string::npos)
-                       return;
-
-               std::string ipstr = dest->GetIPString();
                std::string chost;
 
                switch (mode)
                {
-                       case MODE_COMPAT_HOST:
-                       {
-                               if (ipstr != dest->host)
-                               {
-                                       std::string tail = LastTwoDomainParts(dest->host);
-
-                                       /** Reset the Hash module, and send it our IV and hex table */
-                                       HashRequestIV hash(this, HashProvider, compatkey, xtab[(dest->host[0]) % 4], dest->host);
-
-                                       /* Generate a cloak using specialized Hash */
-                                       chost = prefix + "-" + hash.result.substr(0,8) + tail;
-
-                                       /* Fix by brain - if the cloaked host is > the max length of a host (64 bytes
-                                        * according to the DNS RFC) then they get cloaked as an IP.
-                                        */
-                                       if (chost.length() <= 64)
-                                               break;
-                               }
-                               // fall through to IP cloak
-                       }
-                       case MODE_COMPAT_IPONLY:
-                               if (dest->client_sa.sa.sa_family == AF_INET6)
-                                       chost = CompatCloak6(ipstr.c_str());
-                               else
-                                       chost = CompatCloak4(ipstr.c_str());
-                               break;
                        case MODE_HALF_CLOAK:
                        {
-                               std::string tail;
-                               if (ipstr != dest->host)
-                                       tail = LastTwoDomainParts(dest->host);
-                               if (tail.empty() || tail.length() > 50)
-                                       tail = ReversePartialIP(dest->client_sa);
-                               chost = prefix + SegmentCloak(dest->host, 1) + tail;
+                               if (ipstr != host)
+                                       chost = prefix + SegmentCloak(host, 1, 6) + LastTwoDomainParts(host);
+                               if (chost.empty() || chost.length() > 50)
+                                       chost = SegmentIP(ip, false);
                                break;
                        }
                        case MODE_OPAQUE:
                        default:
-                               chost = prefix + SegmentIP(dest->client_sa);
+                               chost = SegmentIP(ip, true);
                }
-               cu.ext.set(dest,chost);
+               return chost;
        }
 
+       void OnUserConnect(LocalUser* dest) CXX11_OVERRIDE
+       {
+               std::string* cloak = cu.ext.get(dest);
+               if (cloak)
+                       return;
+
+               cu.ext.set(dest, GenCloak(dest->client_sa, dest->GetIPString(), dest->host));
+       }
 };
 
+CmdResult CommandCloak::Handle(const std::vector<std::string> &parameters, User *user)
+{
+       ModuleCloaking* mod = (ModuleCloaking*)(Module*)creator;
+       irc::sockets::sockaddrs sa;
+       std::string cloak;
+
+       if (irc::sockets::aptosa(parameters[0], 0, sa))
+               cloak = mod->GenCloak(sa, parameters[0], parameters[0]);
+       else
+               cloak = mod->GenCloak(sa, "", parameters[0]);
+
+       user->WriteNotice("*** Cloak for " + parameters[0] + " is " + cloak);
+
+       return CMD_SUCCESS;
+}
+
 MODULE_INIT(ModuleCloaking)