Get rid of a bunch of memory-wasting C-style strings

[user/henk/code/inspircd.git] / src / modules / m_close.cpp

diff --git a/src/modules/m_close.cpp b/src/modules/m_close.cpp
index 1da88c3d5f3dca75ad81a4f43b131c07161e5d00..a2e9692cdbf2c38b7c814d2fd01f33e26bd139b5 100644 (file)
--- a/src/modules/m_close.cpp
+++ b/src/modules/m_close.cpp
@@ -29,20 +29,22 @@ class CommandClose : public Command
 {
  public:
        /* Command 'close', needs operator */
-       CommandClose (InspIRCd* Instance, Module* Creator) : Command(Instance, Creator,"CLOSE", "o", 0)
+       CommandClose(Module* Creator) : Command(Creator,"CLOSE", 0)
        {
-       }
+       flags_needed = 'o'; }
 
-       CmdResult Handle (const std::vector<std::string> &parameters, User *user)
+       CmdResult Handle (const std::vector<std::string> &parameters, User *src)
        {
                std::map<std::string,int> closed;
 
-               for (std::vector<User*>::iterator u = ServerInstance->Users->local_users.begin(); u != ServerInstance->Users->local_users.end(); u++)
+               std::vector<User*>::reverse_iterator u = ServerInstance->Users->local_users.rbegin();
+               while (u != ServerInstance->Users->local_users.rend())
                {
-                       if ((*u)->registered != REG_ALL)
+                       User* user = *u++;
+                       if (user->registered != REG_ALL)
                        {
-                               ServerInstance->Users->QuitUser(*u, "Closing all unknown connections per request");
-                               std::string key = ConvToStr((*u)->GetIPString())+"."+ConvToStr((*u)->GetServerPort());
+                               ServerInstance->Users->QuitUser(user, "Closing all unknown connections per request");
+                               std::string key = ConvToStr(user->GetIPString())+"."+ConvToStr(user->GetServerPort());
                                closed[key]++;
                        }
                }
@@ -50,13 +52,13 @@ class CommandClose : public Command
                int total = 0;
                for (std::map<std::string,int>::iterator ci = closed.begin(); ci != closed.end(); ci++)
                {
-                       user->WriteServ("NOTICE %s :*** Closed %d unknown connection%s from [%s]",user->nick.c_str(),(*ci).second,((*ci).second>1)?"s":"",(*ci).first.c_str());
+                       src->WriteServ("NOTICE %s :*** Closed %d unknown connection%s from [%s]",src->nick.c_str(),(*ci).second,((*ci).second>1)?"s":"",(*ci).first.c_str());
                        total += (*ci).second;
                }
                if (total)
-                       user->WriteServ("NOTICE %s :*** %i unknown connection%s closed",user->nick.c_str(),total,(total>1)?"s":"");
+                       src->WriteServ("NOTICE %s :*** %i unknown connection%s closed",src->nick.c_str(),total,(total>1)?"s":"");
                else
-                       user->WriteServ("NOTICE %s :*** No unknown connections found",user->nick.c_str());
+                       src->WriteServ("NOTICE %s :*** No unknown connections found",src->nick.c_str());
 
                return CMD_SUCCESS;
        }
@@ -66,8 +68,8 @@ class ModuleClose : public Module
 {
        CommandClose cmd;
  public:
-       ModuleClose(InspIRCd* Me)
-               : Module(Me), cmd(Me, this)
+       ModuleClose()
+               : cmd(this)
        {
                ServerInstance->AddCommand(&cmd);
        }
@@ -78,7 +80,7 @@ class ModuleClose : public Module
 
        virtual Version GetVersion()
        {
-               return Version("$Id$", VF_VENDOR, API_VERSION);
+               return Version("Provides /CLOSE functionality", VF_VENDOR, API_VERSION);
        }
 };