Clean up the parsing logic for <shun:enabledcmds>.

[user/henk/code/inspircd.git] / src / modules / m_customtitle.cpp

diff --git a/src/modules/m_customtitle.cpp b/src/modules/m_customtitle.cpp
index da88d1759e0f3f3feeaa13ea78165bcc4bf87bb8..7cdd0bc4fd3f42543755fd3f5852aee6d10645f9 100644 (file)
--- a/src/modules/m_customtitle.cpp
+++ b/src/modules/m_customtitle.cpp
@@ -1,8 +1,13 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
+ *   Copyright (C) 2018 linuxdaemon <linuxdaemon.irc@gmail.com>
+ *   Copyright (C) 2013, 2017-2018 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2012, 2019 Robby <robby@chatbelgie.be>
+ *   Copyright (C) 2012, 2015-2016 Attila Molnar <attilamolnar@hush.com>
+ *   Copyright (C) 2010 Craig Edwards <brain@inspircd.org>
  *   Copyright (C) 2009 Daniel De Graaf <danieldg@inspircd.org>
- *   Copyright (C) 2008 Pippijn van Steenhoven <pip88nl@gmail.com>
+ *   Copyright (C) 2007 Robin Burchell <robin+git@viroteck.net>
  *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
  *
  * This file is part of InspIRCd.  InspIRCd is free software: you can
@@ -131,7 +136,13 @@ class ModuleCustomTitle : public Module, public Whois::LineEventListener
                        if (pass.empty())
                                throw ModuleException("<title:password> is empty at " + tag->getTagLocation());
 
-                       std::string hash = tag->getString("hash");
+                       const std::string hash = tag->getString("hash", "plaintext", 1);
+                       if (stdalgo::string::equalsci(hash, "plaintext"))
+                       {
+                               ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "<title> tag for %s at %s contains an plain text password, this is insecure!",
+                                       name.c_str(), tag->getTagLocation().c_str());
+                       }
+
                        std::string host = tag->getString("host", "*@*");
                        std::string title = tag->getString("title");
                        std::string vhost = tag->getString("vhost");
@@ -160,7 +171,7 @@ class ModuleCustomTitle : public Module, public Whois::LineEventListener
 
        Version GetVersion() CXX11_OVERRIDE
        {
-               return Version("Custom Title for users", VF_OPTCOMMON | VF_VENDOR);
+               return Version("Provides the TITLE command, custom titles for users", VF_OPTCOMMON | VF_VENDOR);
        }
 };