]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_dnsbl.cpp
Avoid doing "IP changed" event stuff on quitting users.
[user/henk/code/inspircd.git] / src / modules / m_dnsbl.cpp
index 752a0d7a5997a14ba39845295f7cf6bf3886612b..37819c05ce0b0b5239e6e0a34d24a3fd5cf72b73 100644 (file)
@@ -1,11 +1,16 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
+ *   Copyright (C) 2018-2020 Matt Schatz <genius3000@g3k.solutions>
+ *   Copyright (C) 2018-2019 linuxdaemon <linuxdaemon.irc@gmail.com>
+ *   Copyright (C) 2013, 2016-2020 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2013, 2015-2016 Adam <Adam@anope.org>
+ *   Copyright (C) 2012-2016 Attila Molnar <attilamolnar@hush.com>
+ *   Copyright (C) 2012, 2018 Robby <robby@chatbelgie.be>
  *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
- *   Copyright (C) 2006-2008 Robin Burchell <robin+git@viroteck.net>
- *   Copyright (C) 2007 Craig Edwards <craigedwards@brainbox.cc>
- *   Copyright (C) 2006-2007 Dennis Friis <peavey@inspircd.org>
- *   Copyright (C) 2007 John Brooks <john.brooks@dereferenced.net>
+ *   Copyright (C) 2007, 2010 Craig Edwards <brain@inspircd.org>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
+ *   Copyright (C) 2006-2009 Robin Burchell <robin+git@viroteck.net>
  *
  * This file is part of InspIRCd.  InspIRCd is free software: you can
  * redistribute it and/or modify it under the terms of the GNU General Public
@@ -24,6 +29,7 @@
 #include "inspircd.h"
 #include "xline.h"
 #include "modules/dns.h"
+#include "modules/stats.h"
 
 /* Class holding data for a single entry */
 class DNSBLConfEntry : public refcountbase
@@ -34,27 +40,33 @@ class DNSBLConfEntry : public refcountbase
                std::string name, ident, host, domain, reason;
                EnumBanaction banaction;
                EnumType type;
-               long duration;
-               int bitmask;
+               unsigned long duration;
+               unsigned int bitmask;
                unsigned char records[256];
                unsigned long stats_hits, stats_misses;
                DNSBLConfEntry(): type(A_BITMASK),duration(86400),bitmask(0),stats_hits(0), stats_misses(0) {}
 };
 
 
-/** Resolver for CGI:IRC hostnames encoded in ident/GECOS
+/** Resolver for CGI:IRC hostnames encoded in ident/real name
  */
 class DNSBLResolver : public DNS::Request
 {
+ private:
+       irc::sockets::sockaddrs theirsa;
        std::string theiruid;
        LocalStringExt& nameExt;
        LocalIntExt& countExt;
        reference<DNSBLConfEntry> ConfEntry;
 
  public:
-
        DNSBLResolver(DNS::Manager *mgr, Module *me, LocalStringExt& match, LocalIntExt& ctr, const std::string &hostname, LocalUser* u, reference<DNSBLConfEntry> conf)
-               : DNS::Request(mgr, me, hostname, DNS::QUERY_A, true), theiruid(u->uuid), nameExt(match), countExt(ctr), ConfEntry(conf)
+               : DNS::Request(mgr, me, hostname, DNS::QUERY_A, true)
+               , theirsa(u->client_sa)
+               , theiruid(u->uuid)
+               , nameExt(match)
+               , countExt(ctr)
+               , ConfEntry(conf)
        {
        }
 
@@ -62,8 +74,8 @@ class DNSBLResolver : public DNS::Request
        void OnLookupComplete(const DNS::Query *r) CXX11_OVERRIDE
        {
                /* Check the user still exists */
-               LocalUser* them = (LocalUser*)ServerInstance->FindUUID(theiruid);
-               if (!them)
+               LocalUser* them = IS_LOCAL(ServerInstance->FindUUID(theiruid));
+               if (!them || them->client_sa != theirsa)
                        return;
 
                const DNS::ResourceRecord* const ans_record = r->FindAnswerOfType(DNS::QUERY_A);
@@ -73,7 +85,7 @@ class DNSBLResolver : public DNS::Request
                // All replies should be in 127.0.0.0/8
                if (ans_record->rdata.compare(0, 4, "127.") != 0)
                {
-                       ServerInstance->SNO->WriteGlobalSno('a', "DNSBL: %s returned address outside of acceptable subnet 127.0.0.0/8: %s", ConfEntry->domain.c_str(), ans_record->rdata.c_str());
+                       ServerInstance->SNO->WriteGlobalSno('d', "DNSBL: %s returned address outside of acceptable subnet 127.0.0.0/8: %s", ConfEntry->domain.c_str(), ans_record->rdata.c_str());
                        ConfEntry->stats_misses++;
                        return;
                }
@@ -88,7 +100,7 @@ class DNSBLResolver : public DNS::Request
                bool match = false;
                in_addr resultip;
 
-               inet_aton(ans_record->rdata.c_str(), &resultip);
+               inet_pton(AF_INET, ans_record->rdata.c_str(), &resultip);
 
                switch (ConfEntry->type)
                {
@@ -127,13 +139,13 @@ class DNSBLResolver : public DNS::Request
                                {
                                        if (!ConfEntry->ident.empty())
                                        {
-                                               them->WriteNumeric(304, "Your ident has been set to " + ConfEntry->ident + " because you matched " + reason);
+                                               them->WriteNotice("Your ident has been set to " + ConfEntry->ident + " because you matched " + reason);
                                                them->ChangeIdent(ConfEntry->ident);
                                        }
 
                                        if (!ConfEntry->host.empty())
                                        {
-                                               them->WriteNumeric(304, "Your host has been set to " + ConfEntry->host + " because you matched " + reason);
+                                               them->WriteNotice("Your host has been set to " + ConfEntry->host + " because you matched " + reason);
                                                them->ChangeDisplayedHost(ConfEntry->host);
                                        }
 
@@ -146,9 +158,9 @@ class DNSBLResolver : public DNS::Request
                                                        "*", them->GetIPString());
                                        if (ServerInstance->XLines->AddLine(kl,NULL))
                                        {
-                                               std::string timestr = InspIRCd::TimeString(kl->expiry);
-                                               ServerInstance->SNO->WriteGlobalSno('x',"K:line added due to DNSBL match on *@%s to expire on %s: %s",
-                                                       them->GetIPString().c_str(), timestr.c_str(), reason.c_str());
+                                               ServerInstance->SNO->WriteToSnoMask('x', "K-line added due to DNSBL match on *@%s to expire in %s (on %s): %s",
+                                                       them->GetIPString().c_str(), InspIRCd::DurationString(kl->duration).c_str(),
+                                                       InspIRCd::TimeString(kl->expiry).c_str(), reason.c_str());
                                                ServerInstance->XLines->ApplyLines();
                                        }
                                        else
@@ -164,9 +176,9 @@ class DNSBLResolver : public DNS::Request
                                                        "*", them->GetIPString());
                                        if (ServerInstance->XLines->AddLine(gl,NULL))
                                        {
-                                               std::string timestr = InspIRCd::TimeString(gl->expiry);
-                                               ServerInstance->SNO->WriteGlobalSno('x',"G:line added due to DNSBL match on *@%s to expire on %s: %s",
-                                                       them->GetIPString().c_str(), timestr.c_str(), reason.c_str());
+                                               ServerInstance->SNO->WriteToSnoMask('x', "G-line added due to DNSBL match on *@%s to expire in %s (on %s): %s",
+                                                       them->GetIPString().c_str(), InspIRCd::DurationString(gl->duration).c_str(),
+                                                       InspIRCd::TimeString(gl->expiry).c_str(), reason.c_str());
                                                ServerInstance->XLines->ApplyLines();
                                        }
                                        else
@@ -182,9 +194,9 @@ class DNSBLResolver : public DNS::Request
                                                        them->GetIPString());
                                        if (ServerInstance->XLines->AddLine(zl,NULL))
                                        {
-                                               std::string timestr = InspIRCd::TimeString(zl->expiry);
-                                               ServerInstance->SNO->WriteGlobalSno('x',"Z:line added due to DNSBL match on %s to expire on %s: %s",
-                                                       them->GetIPString().c_str(), timestr.c_str(), reason.c_str());
+                                               ServerInstance->SNO->WriteToSnoMask('x', "Z-line added due to DNSBL match on %s to expire in %s (on %s): %s",
+                                                       them->GetIPString().c_str(), InspIRCd::DurationString(zl->duration).c_str(),
+                                                       InspIRCd::TimeString(zl->expiry).c_str(), reason.c_str());
                                                ServerInstance->XLines->ApplyLines();
                                        }
                                        else
@@ -199,7 +211,8 @@ class DNSBLResolver : public DNS::Request
                                        break;
                        }
 
-                       ServerInstance->SNO->WriteGlobalSno('a', "Connecting user %s%s detected as being on a DNS blacklist (%s) with result %d", them->nick.empty() ? "<unknown>" : "", them->GetFullRealHost().c_str(), ConfEntry->domain.c_str(), (ConfEntry->type==DNSBLConfEntry::A_BITMASK) ? bitmask : record);
+                       ServerInstance->SNO->WriteGlobalSno('d', "Connecting user %s (%s) detected as being on the '%s' DNS blacklist with result %d",
+                               them->GetFullRealHost().c_str(), them->GetIPString().c_str(), ConfEntry->name.c_str(), (ConfEntry->type==DNSBLConfEntry::A_BITMASK) ? bitmask : record);
                }
                else
                        ConfEntry->stats_misses++;
@@ -207,8 +220,8 @@ class DNSBLResolver : public DNS::Request
 
        void OnError(const DNS::Query *q) CXX11_OVERRIDE
        {
-               LocalUser* them = (LocalUser*)ServerInstance->FindUUID(theiruid);
-               if (!them)
+               LocalUser* them = IS_LOCAL(ServerInstance->FindUUID(theiruid));
+               if (!them || them->client_sa != theirsa)
                        return;
 
                int i = countExt.get(them);
@@ -216,13 +229,21 @@ class DNSBLResolver : public DNS::Request
                        countExt.set(them, i - 1);
 
                if (q->error == DNS::ERROR_NO_RECORDS || q->error == DNS::ERROR_DOMAIN_NOT_FOUND)
+               {
                        ConfEntry->stats_misses++;
+                       return;
+               }
+
+               ServerInstance->SNO->WriteGlobalSno('d', "An error occurred whilst checking whether %s (%s) is on the '%s' DNS blacklist: %s",
+                       them->GetFullRealHost().c_str(), them->GetIPString().c_str(), ConfEntry->name.c_str(), this->manager->GetErrorStr(q->error).c_str());
        }
 };
 
-class ModuleDNSBL : public Module
+typedef std::vector<reference<DNSBLConfEntry> > DNSBLConfList;
+
+class ModuleDNSBL : public Module, public Stats::EventListener
 {
-       std::vector<reference<DNSBLConfEntry> > DNSBLConfEntries;
+       DNSBLConfList DNSBLConfEntries;
        dynamic_reference<DNS::Manager> DNS;
        LocalStringExt nameExt;
        LocalIntExt countExt;
@@ -232,37 +253,48 @@ class ModuleDNSBL : public Module
         */
        DNSBLConfEntry::EnumBanaction str2banaction(const std::string &action)
        {
-               if(action.compare("KILL")==0)
+               if (stdalgo::string::equalsci(action, "kill"))
                        return DNSBLConfEntry::I_KILL;
-               if(action.compare("KLINE")==0)
+               if (stdalgo::string::equalsci(action, "kline"))
                        return DNSBLConfEntry::I_KLINE;
-               if(action.compare("ZLINE")==0)
+               if (stdalgo::string::equalsci(action, "zline"))
                        return DNSBLConfEntry::I_ZLINE;
-               if(action.compare("GLINE")==0)
+               if (stdalgo::string::equalsci(action, "gline"))
                        return DNSBLConfEntry::I_GLINE;
-               if(action.compare("MARK")==0)
+               if (stdalgo::string::equalsci(action, "mark"))
                        return DNSBLConfEntry::I_MARK;
-
                return DNSBLConfEntry::I_UNKNOWN;
        }
  public:
        ModuleDNSBL()
-               : DNS(this, "DNS")
+               : Stats::EventListener(this)
+               , DNS(this, "DNS")
                , nameExt("dnsbl_match", ExtensionItem::EXT_USER, this)
                , countExt("dnsbl_pending", ExtensionItem::EXT_USER, this)
        {
        }
 
+       void init() CXX11_OVERRIDE
+       {
+               ServerInstance->SNO->EnableSnomask('d', "DNSBL");
+       }
+
+       void Prioritize() CXX11_OVERRIDE
+       {
+               Module* corexline = ServerInstance->Modules->Find("core_xline");
+               ServerInstance->Modules->SetPriority(this, I_OnSetUserIP, PRIORITY_AFTER, corexline);
+       }
+
        Version GetVersion() CXX11_OVERRIDE
        {
-               return Version("Provides handling of DNS blacklists", VF_VENDOR);
+               return Version("Allows the server administrator to check the IP address of connecting users against a DNSBL.", VF_VENDOR);
        }
 
        /** Fill our conf vector with data
         */
        void ReadConfig(ConfigStatus& status) CXX11_OVERRIDE
        {
-               DNSBLConfEntries.clear();
+               DNSBLConfList newentries;
 
                ConfigTagList dnsbls = ServerInstance->Config->ConfTags("dnsbl");
                for(ConfigIter i = dnsbls.first; i != dnsbls.second; ++i)
@@ -273,13 +305,13 @@ class ModuleDNSBL : public Module
                        e->name = tag->getString("name");
                        e->ident = tag->getString("ident");
                        e->host = tag->getString("host");
-                       e->reason = tag->getString("reason");
+                       e->reason = tag->getString("reason", "Your IP has been blacklisted.", 1);
                        e->domain = tag->getString("domain");
 
-                       if (tag->getString("type") == "bitmask")
+                       if (stdalgo::string::equalsci(tag->getString("type"), "bitmask"))
                        {
                                e->type = DNSBLConfEntry::A_BITMASK;
-                               e->bitmask = tag->getInt("bitmask");
+                               e->bitmask = tag->getUInt("bitmask", 0, 0, UINT_MAX);
                        }
                        else
                        {
@@ -299,42 +331,37 @@ class ModuleDNSBL : public Module
                        /* yeah, logic here is a little messy */
                        if ((e->bitmask <= 0) && (DNSBLConfEntry::A_BITMASK == e->type))
                        {
-                               std::string location = tag->getTagLocation();
-                               ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): invalid bitmask", location.c_str());
+                               throw ModuleException("Invalid <dnsbl:bitmask> at " + tag->getTagLocation());
                        }
                        else if (e->name.empty())
                        {
-                               std::string location = tag->getTagLocation();
-                               ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): Invalid name", location.c_str());
+                               throw ModuleException("Empty <dnsbl:name> at " + tag->getTagLocation());
                        }
                        else if (e->domain.empty())
                        {
-                               std::string location = tag->getTagLocation();
-                               ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): Invalid domain", location.c_str());
+                               throw ModuleException("Empty <dnsbl:domain> at " + tag->getTagLocation());
                        }
                        else if (e->banaction == DNSBLConfEntry::I_UNKNOWN)
                        {
-                               std::string location = tag->getTagLocation();
-                               ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): Invalid banaction", location.c_str());
+                               throw ModuleException("Unknown <dnsbl:action> at " + tag->getTagLocation());
                        }
                        else
                        {
-                               if (e->reason.empty())
-                               {
-                                       std::string location = tag->getTagLocation();
-                                       ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): empty reason, using defaults", location.c_str());
-                                       e->reason = "Your IP has been blacklisted.";
-                               }
-
                                /* add it, all is ok */
-                               DNSBLConfEntries.push_back(e);
+                               newentries.push_back(e);
                        }
                }
+
+               DNSBLConfEntries.swap(newentries);
        }
 
        void OnSetUserIP(LocalUser* user) CXX11_OVERRIDE
        {
-               if ((user->exempt) || !DNS)
+               if (user->exempt || user->quitting || !DNS)
+                       return;
+
+               // Clients can't be in a DNSBL if they aren't connected via IPv4 or IPv6.
+               if (user->client_sa.family() != AF_INET && user->client_sa.family() != AF_INET6)
                        return;
 
                if (user->MyClass)
@@ -343,10 +370,13 @@ class ModuleDNSBL : public Module
                                return;
                }
                else
+               {
                        ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "User has no connect class in OnSetUserIP");
+                       return;
+               }
 
                std::string reversedip;
-               if (user->client_sa.sa.sa_family == AF_INET)
+               if (user->client_sa.family() == AF_INET)
                {
                        unsigned int a, b, c, d;
                        d = (unsigned int) (user->client_sa.in4.sin_addr.s_addr >> 24) & 0xFF;
@@ -356,7 +386,7 @@ class ModuleDNSBL : public Module
 
                        reversedip = ConvToStr(d) + "." + ConvToStr(c) + "." + ConvToStr(b) + "." + ConvToStr(a);
                }
-               else if (user->client_sa.sa.sa_family == AF_INET6)
+               else if (user->client_sa.family() == AF_INET6)
                {
                        const unsigned char* ip = user->client_sa.in6.sin6_addr.s6_addr;
 
@@ -366,6 +396,7 @@ class ModuleDNSBL : public Module
                                reversedip.push_back(*it);
                                reversedip.push_back('.');
                        }
+                       reversedip.erase(reversedip.length() - 1, 1);
                }
                else
                        return;
@@ -402,11 +433,23 @@ class ModuleDNSBL : public Module
                std::string dnsbl;
                if (!myclass->config->readString("dnsbl", dnsbl))
                        return MOD_RES_PASSTHRU;
+
                std::string* match = nameExt.get(user);
-               std::string myname = match ? *match : "";
-               if (dnsbl == myname)
-                       return MOD_RES_PASSTHRU;
-               return MOD_RES_DENY;
+               if (!match)
+               {
+                       ServerInstance->Logs->Log("CONNECTCLASS", LOG_DEBUG, "The %s connect class is not suitable as it requires a DNSBL mark",
+                                       myclass->GetName().c_str());
+                       return MOD_RES_DENY;
+               }
+
+               if (!InspIRCd::Match(*match, dnsbl))
+               {
+                       ServerInstance->Logs->Log("CONNECTCLASS", LOG_DEBUG, "The %s connect class is not suitable as the DNSBL mark (%s) does not match %s",
+                                       myclass->GetName().c_str(), match->c_str(), dnsbl.c_str());
+                       return MOD_RES_DENY;
+               }
+
+               return MOD_RES_PASSTHRU;
        }
 
        ModResult OnCheckReady(LocalUser *user) CXX11_OVERRIDE