]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_dnsbl.cpp
Sync helpop chmodes s and p with docs
[user/henk/code/inspircd.git] / src / modules / m_dnsbl.cpp
index 3dea080cee59dd99474510ae5fe5567f4eda3b44..dc43dda3f0c6f2045580a47ce77a51855693aa13 100644 (file)
@@ -1,11 +1,16 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
+ *   Copyright (C) 2018-2020 Matt Schatz <genius3000@g3k.solutions>
+ *   Copyright (C) 2018-2019 linuxdaemon <linuxdaemon.irc@gmail.com>
+ *   Copyright (C) 2013, 2017-2021 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2013, 2015-2016 Adam <Adam@anope.org>
+ *   Copyright (C) 2012-2016 Attila Molnar <attilamolnar@hush.com>
+ *   Copyright (C) 2012, 2018 Robby <robby@chatbelgie.be>
  *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
- *   Copyright (C) 2006-2008 Robin Burchell <robin+git@viroteck.net>
- *   Copyright (C) 2007 Craig Edwards <craigedwards@brainbox.cc>
- *   Copyright (C) 2006-2007 Dennis Friis <peavey@inspircd.org>
- *   Copyright (C) 2007 John Brooks <john.brooks@dereferenced.net>
+ *   Copyright (C) 2007, 2010 Craig Edwards <brain@inspircd.org>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
+ *   Copyright (C) 2006-2009 Robin Burchell <robin+git@viroteck.net>
  *
  * This file is part of InspIRCd.  InspIRCd is free software: you can
  * redistribute it and/or modify it under the terms of the GNU General Public
@@ -23,8 +28,8 @@
 
 #include "inspircd.h"
 #include "xline.h"
-
-/* $ModDesc: Provides handling of DNS blacklists */
+#include "modules/dns.h"
+#include "modules/stats.h"
 
 /* Class holding data for a single entry */
 class DNSBLConfEntry : public refcountbase
@@ -35,195 +40,249 @@ class DNSBLConfEntry : public refcountbase
                std::string name, ident, host, domain, reason;
                EnumBanaction banaction;
                EnumType type;
-               long duration;
-               int bitmask;
+               unsigned long duration;
+               unsigned int bitmask;
+               unsigned int timeout;
                unsigned char records[256];
-               unsigned long stats_hits, stats_misses;
-               DNSBLConfEntry(): type(A_BITMASK),duration(86400),bitmask(0),stats_hits(0), stats_misses(0) {}
-               ~DNSBLConfEntry() { }
+               unsigned long stats_hits, stats_misses, stats_errors;
+               DNSBLConfEntry()
+                       : type(A_BITMASK)
+                       , duration(86400)
+                       , bitmask(0)
+                       , timeout(0)
+                       , stats_hits(0)
+                       , stats_misses(0)
+                       , stats_errors(0)
+               {
+               }
 };
 
 
-/** Resolver for CGI:IRC hostnames encoded in ident/GECOS
+/** Resolver for CGI:IRC hostnames encoded in ident/real name
  */
-class DNSBLResolver : public Resolver
+class DNSBLResolver : public DNS::Request
 {
+ private:
+       irc::sockets::sockaddrs theirsa;
        std::string theiruid;
        LocalStringExt& nameExt;
        LocalIntExt& countExt;
        reference<DNSBLConfEntry> ConfEntry;
 
  public:
-
-       DNSBLResolver(Module *me, LocalStringExt& match, LocalIntExt& ctr, const std::string &hostname, LocalUser* u, reference<DNSBLConfEntry> conf, bool &cached)
-               : Resolver(hostname, DNS_QUERY_A, cached, me), theiruid(u->uuid), nameExt(match), countExt(ctr), ConfEntry(conf)
+       DNSBLResolver(DNS::Manager *mgr, Module *me, LocalStringExt& match, LocalIntExt& ctr, const std::string &hostname, LocalUser* u, reference<DNSBLConfEntry> conf)
+               : DNS::Request(mgr, me, hostname, DNS::QUERY_A, true, conf->timeout)
+               , theirsa(u->client_sa)
+               , theiruid(u->uuid)
+               , nameExt(match)
+               , countExt(ctr)
+               , ConfEntry(conf)
        {
        }
 
        /* Note: This may be called multiple times for multiple A record results */
-       virtual void OnLookupComplete(const std::string &result, unsigned int ttl, bool cached)
+       void OnLookupComplete(const DNS::Query *r) CXX11_OVERRIDE
        {
                /* Check the user still exists */
-               LocalUser* them = (LocalUser*)ServerInstance->FindUUID(theiruid);
-               if (them)
+               LocalUser* them = IS_LOCAL(ServerInstance->FindUUID(theiruid));
+               if (!them || them->client_sa != theirsa)
+               {
+                       ConfEntry->stats_misses++;
+                       return;
+               }
+
+               int i = countExt.get(them);
+               if (i)
+                       countExt.set(them, i - 1);
+
+               // The DNSBL reply must contain an A result.
+               const DNS::ResourceRecord* const ans_record = r->FindAnswerOfType(DNS::QUERY_A);
+               if (!ans_record)
+               {
+                       ConfEntry->stats_errors++;
+                       ServerInstance->SNO->WriteGlobalSno('d', "%s returned an result with no IPv4 address.",
+                               ConfEntry->name.c_str());
+                       return;
+               }
+
+               // The DNSBL reply must be a valid IPv4 address.
+               in_addr resultip;
+               if (inet_pton(AF_INET, ans_record->rdata.c_str(), &resultip) != 1)
                {
-                       int i = countExt.get(them);
-                       if (i)
-                               countExt.set(them, i - 1);
-                       // All replies should be in 127.0.0.0/8
-                       if (result.compare(0, 4, "127.") == 0)
+                       ConfEntry->stats_errors++;
+                       ServerInstance->SNO->WriteGlobalSno('d', "%s returned an invalid IPv4 address: %s",
+                               ConfEntry->name.c_str(), ans_record->rdata.c_str());
+                       return;
+               }
+
+               // The DNSBL reply should be in the 127.0.0.0/8 range.
+               if ((resultip.s_addr & 0xFF) != 127)
+               {
+                       ConfEntry->stats_errors++;
+                       ServerInstance->SNO->WriteGlobalSno('d', "%s returned an IPv4 address which is outside of the 127.0.0.0/8 subnet: %s",
+                               ConfEntry->name.c_str(), ans_record->rdata.c_str());
+                       return;
+               }
+
+               bool match = false;
+               unsigned int result = 0;
+               switch (ConfEntry->type)
+               {
+                       case DNSBLConfEntry::A_BITMASK:
+                       {
+                               result = (resultip.s_addr >> 24) & ConfEntry->bitmask;
+                               match = (result != 0);
+                               break;
+                       }
+                       case DNSBLConfEntry::A_RECORD:
                        {
-                               unsigned int bitmask = 0, record = 0;
-                               bool match = false;
-                               in_addr resultip;
+                               result = resultip.s_addr >> 24;
+                               match = (ConfEntry->records[result] == 1);
+                               break;
+                       }
+               }
+
+               if (match)
+               {
+                       std::string reason = ConfEntry->reason;
+                       std::string::size_type x = reason.find("%ip%");
+                       while (x != std::string::npos)
+                       {
+                               reason.erase(x, 4);
+                               reason.insert(x, them->GetIPString());
+                               x = reason.find("%ip%");
+                       }
 
-                               inet_aton(result.c_str(), &resultip);
+                       ConfEntry->stats_hits++;
 
-                               switch (ConfEntry->type)
+                       switch (ConfEntry->banaction)
+                       {
+                               case DNSBLConfEntry::I_KILL:
                                {
-                                       case DNSBLConfEntry::A_BITMASK:
-                                               // Now we calculate the bitmask: 256*(256*(256*a+b)+c)+d
-                                               bitmask = resultip.s_addr >> 24; /* Last octet (network byte order) */
-                                               bitmask &= ConfEntry->bitmask;
-                                               match = (bitmask != 0);
-                                       break;
-                                       case DNSBLConfEntry::A_RECORD:
-                                               record = resultip.s_addr >> 24; /* Last octet */
-                                               match = (ConfEntry->records[record] == 1);
+                                       ServerInstance->Users->QuitUser(them, "Killed (" + reason + ")");
                                        break;
                                }
-
-                               if (match)
+                               case DNSBLConfEntry::I_MARK:
                                {
-                                       std::string reason = ConfEntry->reason;
-                                       std::string::size_type x = reason.find("%ip%");
-                                       while (x != std::string::npos)
+                                       if (!ConfEntry->ident.empty())
                                        {
-                                               reason.erase(x, 4);
-                                               reason.insert(x, them->GetIPString());
-                                               x = reason.find("%ip%");
+                                               them->WriteNotice("Your ident has been set to " + ConfEntry->ident + " because you matched " + reason);
+                                               them->ChangeIdent(ConfEntry->ident);
                                        }
 
-                                       ConfEntry->stats_hits++;
-
-                                       switch (ConfEntry->banaction)
+                                       if (!ConfEntry->host.empty())
                                        {
-                                               case DNSBLConfEntry::I_KILL:
-                                               {
-                                                       ServerInstance->Users->QuitUser(them, "Killed (" + reason + ")");
-                                                       break;
-                                               }
-                                               case DNSBLConfEntry::I_MARK:
-                                               {
-                                                       if (!ConfEntry->ident.empty())
-                                                       {
-                                                               them->WriteServ("304 " + them->nick + " :Your ident has been set to " + ConfEntry->ident + " because you matched " + reason);
-                                                               them->ChangeIdent(ConfEntry->ident.c_str());
-                                                       }
-
-                                                       if (!ConfEntry->host.empty())
-                                                       {
-                                                               them->WriteServ("304 " + them->nick + " :Your host has been set to " + ConfEntry->host + " because you matched " + reason);
-                                                               them->ChangeDisplayedHost(ConfEntry->host.c_str());
-                                                       }
-
-                                                       nameExt.set(them, ConfEntry->name);
-                                                       break;
-                                               }
-                                               case DNSBLConfEntry::I_KLINE:
-                                               {
-                                                       KLine* kl = new KLine(ServerInstance->Time(), ConfEntry->duration, ServerInstance->Config->ServerName.c_str(), reason.c_str(),
-                                                                       "*", them->GetIPString());
-                                                       if (ServerInstance->XLines->AddLine(kl,NULL))
-                                                       {
-                                                               std::string timestr = ServerInstance->TimeString(kl->expiry);
-                                                               ServerInstance->SNO->WriteGlobalSno('x',"K:line added due to DNSBL match on *@%s to expire on %s: %s",
-                                                                       them->GetIPString(), timestr.c_str(), reason.c_str());
-                                                               ServerInstance->XLines->ApplyLines();
-                                                       }
-                                                       else
-                                                       {
-                                                               delete kl;
-                                                               return;
-                                                       }
-                                                       break;
-                                               }
-                                               case DNSBLConfEntry::I_GLINE:
-                                               {
-                                                       GLine* gl = new GLine(ServerInstance->Time(), ConfEntry->duration, ServerInstance->Config->ServerName.c_str(), reason.c_str(),
-                                                                       "*", them->GetIPString());
-                                                       if (ServerInstance->XLines->AddLine(gl,NULL))
-                                                       {
-                                                               std::string timestr = ServerInstance->TimeString(gl->expiry);
-                                                               ServerInstance->SNO->WriteGlobalSno('x',"G:line added due to DNSBL match on *@%s to expire on %s: %s",
-                                                                       them->GetIPString(), timestr.c_str(), reason.c_str());
-                                                               ServerInstance->XLines->ApplyLines();
-                                                       }
-                                                       else
-                                                       {
-                                                               delete gl;
-                                                               return;
-                                                       }
-                                                       break;
-                                               }
-                                               case DNSBLConfEntry::I_ZLINE:
-                                               {
-                                                       ZLine* zl = new ZLine(ServerInstance->Time(), ConfEntry->duration, ServerInstance->Config->ServerName.c_str(), reason.c_str(),
-                                                                       them->GetIPString());
-                                                       if (ServerInstance->XLines->AddLine(zl,NULL))
-                                                       {
-                                                               std::string timestr = ServerInstance->TimeString(zl->expiry);
-                                                               ServerInstance->SNO->WriteGlobalSno('x',"Z:line added due to DNSBL match on *@%s to expire on %s: %s",
-                                                                       them->GetIPString(), timestr.c_str(), reason.c_str());
-                                                               ServerInstance->XLines->ApplyLines();
-                                                       }
-                                                       else
-                                                       {
-                                                               delete zl;
-                                                               return;
-                                                       }
-                                                       break;
-                                               }
-                                               case DNSBLConfEntry::I_UNKNOWN:
-                                               {
-                                                       break;
-                                               }
-                                               break;
+                                               them->WriteNotice("Your host has been set to " + ConfEntry->host + " because you matched " + reason);
+                                               them->ChangeDisplayedHost(ConfEntry->host);
                                        }
 
-                                       ServerInstance->SNO->WriteGlobalSno('a', "Connecting user %s%s detected as being on a DNS blacklist (%s) with result %d", them->nick.empty() ? "<unknown>" : "", them->GetFullRealHost().c_str(), ConfEntry->domain.c_str(), (ConfEntry->type==DNSBLConfEntry::A_BITMASK) ? bitmask : record);
+                                       nameExt.set(them, ConfEntry->name);
+                                       break;
                                }
-                               else
-                                       ConfEntry->stats_misses++;
-                       }
-                       else
-                       {
-                               if (!result.empty())
-                                       ServerInstance->SNO->WriteGlobalSno('a', "DNSBL: %s returned address outside of acceptable subnet 127.0.0.0/8: %s", ConfEntry->domain.c_str(), result.c_str());
-                               ConfEntry->stats_misses++;
+                               case DNSBLConfEntry::I_KLINE:
+                               {
+                                       KLine* kl = new KLine(ServerInstance->Time(), ConfEntry->duration, ServerInstance->Config->ServerName.c_str(), reason.c_str(),
+                                                       "*", them->GetIPString());
+                                       if (ServerInstance->XLines->AddLine(kl,NULL))
+                                       {
+                                               ServerInstance->SNO->WriteToSnoMask('x', "K-line added due to DNSBL match on *@%s to expire in %s (on %s): %s",
+                                                       them->GetIPString().c_str(), InspIRCd::DurationString(kl->duration).c_str(),
+                                                       InspIRCd::TimeString(kl->expiry).c_str(), reason.c_str());
+                                               ServerInstance->XLines->ApplyLines();
+                                       }
+                                       else
+                                       {
+                                               delete kl;
+                                               return;
+                                       }
+                                       break;
+                               }
+                               case DNSBLConfEntry::I_GLINE:
+                               {
+                                       GLine* gl = new GLine(ServerInstance->Time(), ConfEntry->duration, ServerInstance->Config->ServerName.c_str(), reason.c_str(),
+                                                       "*", them->GetIPString());
+                                       if (ServerInstance->XLines->AddLine(gl,NULL))
+                                       {
+                                               ServerInstance->SNO->WriteToSnoMask('x', "G-line added due to DNSBL match on *@%s to expire in %s (on %s): %s",
+                                                       them->GetIPString().c_str(), InspIRCd::DurationString(gl->duration).c_str(),
+                                                       InspIRCd::TimeString(gl->expiry).c_str(), reason.c_str());
+                                               ServerInstance->XLines->ApplyLines();
+                                       }
+                                       else
+                                       {
+                                               delete gl;
+                                               return;
+                                       }
+                                       break;
+                               }
+                               case DNSBLConfEntry::I_ZLINE:
+                               {
+                                       ZLine* zl = new ZLine(ServerInstance->Time(), ConfEntry->duration, ServerInstance->Config->ServerName.c_str(), reason.c_str(),
+                                                       them->GetIPString());
+                                       if (ServerInstance->XLines->AddLine(zl,NULL))
+                                       {
+                                               ServerInstance->SNO->WriteToSnoMask('x', "Z-line added due to DNSBL match on %s to expire in %s (on %s): %s",
+                                                       them->GetIPString().c_str(), InspIRCd::DurationString(zl->duration).c_str(),
+                                                       InspIRCd::TimeString(zl->expiry).c_str(), reason.c_str());
+                                               ServerInstance->XLines->ApplyLines();
+                                       }
+                                       else
+                                       {
+                                               delete zl;
+                                               return;
+                                       }
+                                       break;
+                               }
+                               case DNSBLConfEntry::I_UNKNOWN:
+                               default:
+                                       break;
                        }
+
+                       ServerInstance->SNO->WriteGlobalSno('d', "Connecting user %s (%s) detected as being on the '%s' DNS blacklist with result %d",
+                               them->GetFullRealHost().c_str(), them->GetIPString().c_str(), ConfEntry->name.c_str(), result);
                }
+               else
+                       ConfEntry->stats_misses++;
        }
 
-       virtual void OnError(ResolverError e, const std::string &errormessage)
+       void OnError(const DNS::Query *q) CXX11_OVERRIDE
        {
-               LocalUser* them = (LocalUser*)ServerInstance->FindUUID(theiruid);
-               if (them)
+               bool is_miss = true;
+               switch (q->error)
                {
-                       int i = countExt.get(them);
-                       if (i)
-                               countExt.set(them, i - 1);
+                       case DNS::ERROR_NO_RECORDS:
+                       case DNS::ERROR_DOMAIN_NOT_FOUND:
+                               ConfEntry->stats_misses++;
+                               break;
+
+                       default:
+                               ConfEntry->stats_errors++;
+                               is_miss = false;
+                               break;
                }
-       }
 
-       virtual ~DNSBLResolver()
-       {
+               LocalUser* them = IS_LOCAL(ServerInstance->FindUUID(theiruid));
+               if (!them || them->client_sa != theirsa)
+                       return;
+
+               int i = countExt.get(them);
+               if (i)
+                       countExt.set(them, i - 1);
+
+               if (is_miss)
+                       return;
+
+               ServerInstance->SNO->WriteGlobalSno('d', "An error occurred whilst checking whether %s (%s) is on the '%s' DNS blacklist: %s",
+                       them->GetFullRealHost().c_str(), them->GetIPString().c_str(), ConfEntry->name.c_str(), this->manager->GetErrorStr(q->error).c_str());
        }
 };
 
-class ModuleDNSBL : public Module
+typedef std::vector<reference<DNSBLConfEntry> > DNSBLConfList;
+
+class ModuleDNSBL : public Module, public Stats::EventListener
 {
-       std::vector<reference<DNSBLConfEntry> > DNSBLConfEntries;
+       DNSBLConfList DNSBLConfEntries;
+       dynamic_reference<DNS::Manager> DNS;
        LocalStringExt nameExt;
        LocalIntExt countExt;
 
@@ -232,41 +291,48 @@ class ModuleDNSBL : public Module
         */
        DNSBLConfEntry::EnumBanaction str2banaction(const std::string &action)
        {
-               if(action.compare("KILL")==0)
+               if (stdalgo::string::equalsci(action, "kill"))
                        return DNSBLConfEntry::I_KILL;
-               if(action.compare("KLINE")==0)
+               if (stdalgo::string::equalsci(action, "kline"))
                        return DNSBLConfEntry::I_KLINE;
-               if(action.compare("ZLINE")==0)
+               if (stdalgo::string::equalsci(action, "zline"))
                        return DNSBLConfEntry::I_ZLINE;
-               if(action.compare("GLINE")==0)
+               if (stdalgo::string::equalsci(action, "gline"))
                        return DNSBLConfEntry::I_GLINE;
-               if(action.compare("MARK")==0)
+               if (stdalgo::string::equalsci(action, "mark"))
                        return DNSBLConfEntry::I_MARK;
-
                return DNSBLConfEntry::I_UNKNOWN;
        }
  public:
-       ModuleDNSBL() : nameExt("dnsbl_match", this), countExt("dnsbl_pending", this) { }
+       ModuleDNSBL()
+               : Stats::EventListener(this)
+               , DNS(this, "DNS")
+               , nameExt("dnsbl_match", ExtensionItem::EXT_USER, this)
+               , countExt("dnsbl_pending", ExtensionItem::EXT_USER, this)
+       {
+       }
+
+       void init() CXX11_OVERRIDE
+       {
+               ServerInstance->SNO->EnableSnomask('d', "DNSBL");
+       }
 
-       void init()
+       void Prioritize() CXX11_OVERRIDE
        {
-               ReadConf();
-               ServerInstance->Modules->AddService(nameExt);
-               ServerInstance->Modules->AddService(countExt);
-               Implementation eventlist[] = { I_OnRehash, I_OnSetUserIP, I_OnStats, I_OnSetConnectClass, I_OnCheckReady };
-               ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
+               Module* corexline = ServerInstance->Modules->Find("core_xline");
+               ServerInstance->Modules->SetPriority(this, I_OnSetUserIP, PRIORITY_AFTER, corexline);
        }
 
-       Version GetVersion()
+       Version GetVersion() CXX11_OVERRIDE
        {
-               return Version("Provides handling of DNS blacklists", VF_VENDOR);
+               return Version("Allows the server administrator to check the IP address of connecting users against a DNSBL.", VF_VENDOR);
        }
 
        /** Fill our conf vector with data
         */
-       void ReadConf()
+       void ReadConfig(ConfigStatus& status) CXX11_OVERRIDE
        {
-               DNSBLConfEntries.clear();
+               DNSBLConfList newentries;
 
                ConfigTagList dnsbls = ServerInstance->Config->ConfTags("dnsbl");
                for(ConfigIter i = dnsbls.first; i != dnsbls.second; ++i)
@@ -277,13 +343,14 @@ class ModuleDNSBL : public Module
                        e->name = tag->getString("name");
                        e->ident = tag->getString("ident");
                        e->host = tag->getString("host");
-                       e->reason = tag->getString("reason");
+                       e->reason = tag->getString("reason", "Your IP has been blacklisted.", 1);
                        e->domain = tag->getString("domain");
+                       e->timeout = tag->getDuration("timeout", 0);
 
-                       if (tag->getString("type") == "bitmask")
+                       if (stdalgo::string::equalsci(tag->getString("type"), "bitmask"))
                        {
                                e->type = DNSBLConfEntry::A_BITMASK;
-                               e->bitmask = tag->getInt("bitmask");
+                               e->bitmask = tag->getUInt("bitmask", 0, 0, UINT_MAX);
                        }
                        else
                        {
@@ -296,59 +363,44 @@ class ModuleDNSBL : public Module
                        }
 
                        e->banaction = str2banaction(tag->getString("action"));
-                       e->duration = ServerInstance->Duration(tag->getString("duration", "60"));
+                       e->duration = tag->getDuration("duration", 60, 1);
 
                        /* Use portparser for record replies */
 
                        /* yeah, logic here is a little messy */
                        if ((e->bitmask <= 0) && (DNSBLConfEntry::A_BITMASK == e->type))
                        {
-                               std::string location = tag->getTagLocation();
-                               ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): invalid bitmask", location.c_str());
+                               throw ModuleException("Invalid <dnsbl:bitmask> at " + tag->getTagLocation());
                        }
                        else if (e->name.empty())
                        {
-                               std::string location = tag->getTagLocation();
-                               ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): Invalid name", location.c_str());
+                               throw ModuleException("Empty <dnsbl:name> at " + tag->getTagLocation());
                        }
                        else if (e->domain.empty())
                        {
-                               std::string location = tag->getTagLocation();
-                               ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): Invalid domain", location.c_str());
+                               throw ModuleException("Empty <dnsbl:domain> at " + tag->getTagLocation());
                        }
                        else if (e->banaction == DNSBLConfEntry::I_UNKNOWN)
                        {
-                               std::string location = tag->getTagLocation();
-                               ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): Invalid banaction", location.c_str());
-                       }
-                       else if (e->duration <= 0)
-                       {
-                               std::string location = tag->getTagLocation();
-                               ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): Invalid duration", location.c_str());
+                               throw ModuleException("Unknown <dnsbl:action> at " + tag->getTagLocation());
                        }
                        else
                        {
-                               if (e->reason.empty())
-                               {
-                                       std::string location = tag->getTagLocation();
-                                       ServerInstance->SNO->WriteGlobalSno('a', "DNSBL(%s): empty reason, using defaults", location.c_str());
-                                       e->reason = "Your IP has been blacklisted.";
-                               }
-
                                /* add it, all is ok */
-                               DNSBLConfEntries.push_back(e);
+                               newentries.push_back(e);
                        }
                }
-       }
 
-       void OnRehash(User* user)
-       {
-               ReadConf();
+               DNSBLConfEntries.swap(newentries);
        }
 
-       void OnSetUserIP(LocalUser* user)
+       void OnSetUserIP(LocalUser* user) CXX11_OVERRIDE
        {
-               if ((user->exempt) || (user->client_sa.sa.sa_family != AF_INET))
+               if (user->exempt || user->quitting || !DNS)
+                       return;
+
+               // Clients can't be in a DNSBL if they aren't connected via IPv4 or IPv6.
+               if (user->client_sa.family() != AF_INET && user->client_sa.family() != AF_INET6)
                        return;
 
                if (user->MyClass)
@@ -357,77 +409,116 @@ class ModuleDNSBL : public Module
                                return;
                }
                else
-                       ServerInstance->Logs->Log("m_dnsbl", DEBUG, "User has no connect class in OnSetUserIP");
+               {
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "User has no connect class in OnSetUserIP");
+                       return;
+               }
 
-               unsigned char a, b, c, d;
-               char reversedipbuf[128];
                std::string reversedip;
+               if (user->client_sa.family() == AF_INET)
+               {
+                       unsigned int a, b, c, d;
+                       d = (unsigned int) (user->client_sa.in4.sin_addr.s_addr >> 24) & 0xFF;
+                       c = (unsigned int) (user->client_sa.in4.sin_addr.s_addr >> 16) & 0xFF;
+                       b = (unsigned int) (user->client_sa.in4.sin_addr.s_addr >> 8) & 0xFF;
+                       a = (unsigned int) user->client_sa.in4.sin_addr.s_addr & 0xFF;
 
-               d = (unsigned char) (user->client_sa.in4.sin_addr.s_addr >> 24) & 0xFF;
-               c = (unsigned char) (user->client_sa.in4.sin_addr.s_addr >> 16) & 0xFF;
-               b = (unsigned char) (user->client_sa.in4.sin_addr.s_addr >> 8) & 0xFF;
-               a = (unsigned char) user->client_sa.in4.sin_addr.s_addr & 0xFF;
+                       reversedip = ConvToStr(d) + "." + ConvToStr(c) + "." + ConvToStr(b) + "." + ConvToStr(a);
+               }
+               else if (user->client_sa.family() == AF_INET6)
+               {
+                       const unsigned char* ip = user->client_sa.in6.sin6_addr.s6_addr;
 
-               snprintf(reversedipbuf, 128, "%d.%d.%d.%d", d, c, b, a);
-               reversedip = std::string(reversedipbuf);
+                       std::string buf = BinToHex(ip, 16);
+                       for (std::string::const_reverse_iterator it = buf.rbegin(); it != buf.rend(); ++it)
+                       {
+                               reversedip.push_back(*it);
+                               reversedip.push_back('.');
+                       }
+                       reversedip.erase(reversedip.length() - 1, 1);
+               }
+               else
+                       return;
+
+               ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "Reversed IP %s -> %s", user->GetIPString().c_str(), reversedip.c_str());
 
                countExt.set(user, DNSBLConfEntries.size());
 
                // For each DNSBL, we will run through this lookup
-               unsigned int i = 0;
-               while (i < DNSBLConfEntries.size())
+               for (unsigned i = 0; i < DNSBLConfEntries.size(); ++i)
                {
                        // Fill hostname with a dnsbl style host (d.c.b.a.domain.tld)
                        std::string hostname = reversedip + "." + DNSBLConfEntries[i]->domain;
 
                        /* now we'd need to fire off lookups for `hostname'. */
-                       bool cached;
-                       DNSBLResolver *r = new DNSBLResolver(this, nameExt, countExt, hostname, user, DNSBLConfEntries[i], cached);
-                       ServerInstance->AddResolver(r, cached);
+                       DNSBLResolver *r = new DNSBLResolver(*this->DNS, this, nameExt, countExt, hostname, user, DNSBLConfEntries[i]);
+                       try
+                       {
+                               this->DNS->Process(r);
+                       }
+                       catch (DNS::Exception &ex)
+                       {
+                               delete r;
+                               ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, ex.GetReason());
+                       }
+
                        if (user->quitting)
                                break;
-                       i++;
                }
        }
 
-       ModResult OnSetConnectClass(LocalUser* user, ConnectClass* myclass)
+       ModResult OnSetConnectClass(LocalUser* user, ConnectClass* myclass) CXX11_OVERRIDE
        {
                std::string dnsbl;
                if (!myclass->config->readString("dnsbl", dnsbl))
                        return MOD_RES_PASSTHRU;
+
                std::string* match = nameExt.get(user);
-               std::string myname = match ? *match : "";
-               if (dnsbl == myname)
-                       return MOD_RES_PASSTHRU;
-               return MOD_RES_DENY;
+               if (!match)
+               {
+                       ServerInstance->Logs->Log("CONNECTCLASS", LOG_DEBUG, "The %s connect class is not suitable as it requires a DNSBL mark",
+                                       myclass->GetName().c_str());
+                       return MOD_RES_DENY;
+               }
+
+               if (!InspIRCd::Match(*match, dnsbl))
+               {
+                       ServerInstance->Logs->Log("CONNECTCLASS", LOG_DEBUG, "The %s connect class is not suitable as the DNSBL mark (%s) does not match %s",
+                                       myclass->GetName().c_str(), match->c_str(), dnsbl.c_str());
+                       return MOD_RES_DENY;
+               }
+
+               return MOD_RES_PASSTHRU;
        }
-       
-       ModResult OnCheckReady(LocalUser *user)
+
+       ModResult OnCheckReady(LocalUser *user) CXX11_OVERRIDE
        {
                if (countExt.get(user))
                        return MOD_RES_DENY;
                return MOD_RES_PASSTHRU;
        }
 
-       ModResult OnStats(char symbol, User* user, string_list &results)
+       ModResult OnStats(Stats::Context& stats) CXX11_OVERRIDE
        {
-               if (symbol != 'd')
+               if (stats.GetSymbol() != 'd')
                        return MOD_RES_PASSTHRU;
 
-               unsigned long total_hits = 0, total_misses = 0;
-
+               unsigned long total_hits = 0;
+               unsigned long total_misses = 0;
+               unsigned long total_errors = 0;
                for (std::vector<reference<DNSBLConfEntry> >::const_iterator i = DNSBLConfEntries.begin(); i != DNSBLConfEntries.end(); ++i)
                {
                        total_hits += (*i)->stats_hits;
                        total_misses += (*i)->stats_misses;
+                       total_errors += (*i)->stats_errors;
 
-                       results.push_back(ServerInstance->Config->ServerName + " 304 " + user->nick + " :DNSBLSTATS DNSbl \"" + (*i)->name + "\" had " +
-                                       ConvToStr((*i)->stats_hits) + " hits and " + ConvToStr((*i)->stats_misses) + " misses");
+                       stats.AddRow(304, InspIRCd::Format("DNSBLSTATS \"%s\" had %lu hits, %lu misses, and %lu errors",
+                               (*i)->name.c_str(), (*i)->stats_hits, (*i)->stats_misses, (*i)->stats_errors));
                }
 
-               results.push_back(ServerInstance->Config->ServerName + " 304 " + user->nick + " :DNSBLSTATS Total hits: " + ConvToStr(total_hits));
-               results.push_back(ServerInstance->Config->ServerName + " 304 " + user->nick + " :DNSBLSTATS Total misses: " + ConvToStr(total_misses));
-
+               stats.AddRow(304, "DNSBLSTATS Total hits: " + ConvToStr(total_hits));
+               stats.AddRow(304, "DNSBLSTATS Total misses: " + ConvToStr(total_misses));
+               stats.AddRow(304, "DNSBLSTATS Total errors: " + ConvToStr(total_errors));
                return MOD_RES_PASSTHRU;
        }
 };