Fix /STATS output to show the regex module in use

[user/henk/code/inspircd.git] / src / modules / m_filter.cpp

diff --git a/src/modules/m_filter.cpp b/src/modules/m_filter.cpp
index ab7005c6baa9374c806fe9265331f2a6753f2cac..a44785b140b8a572ecc12841550903f775f2ba7e 100644 (file)
--- a/src/modules/m_filter.cpp
+++ b/src/modules/m_filter.cpp
@@ -126,6 +126,7 @@ protected:
        virtual int OnPreCommand(std::string &command, std::vector<std::string> &parameters, User *user, bool validated, const std::string &original_line);
        bool AppliesToMe(User* user, FilterResult* filter, int flags);
        void OnLoadModule(Module* mod, const std::string& name);
+       virtual void ReadFilters(ConfigReader &MyConf) = 0;
 };
 
 class CommandFilter : public Command
@@ -448,8 +449,13 @@ void FilterBase::OnLoadModule(Module* mod, const std::string& name)
                std::string rxname = RegexNameRequest(this, mod).Send();
                if (rxname == RegexEngine)
                {
-                       ServerInstance->SNO->WriteToSnoMask('A', "Filter now using engine '%s'", RegexEngine.c_str());
                        rxengine = mod;
+                       /* Force a rehash to make sure that any filters that couldnt be applied from the conf
+                        * on startup or on load are applied right now.
+                        */
+                       ConfigReader Config(ServerInstance);
+                       ServerInstance->SNO->WriteToSnoMask('A', "Found and activated regex module '%s' for m_filter.so.", RegexEngine.c_str());
+                       ReadFilters(Config);
                }
        }
 }
@@ -531,7 +537,6 @@ class ImplFilter : public FilterResult
 
        ImplFilter()
        {
-               delete regex;
        }
 };
 
@@ -547,7 +552,6 @@ class ModuleFilter : public FilterBase
        : FilterBase(Me, "m_filter.so")
        {
                OnRehash(NULL,"");
-
        }
 
        virtual ~ModuleFilter()
@@ -584,6 +588,7 @@ class ModuleFilter : public FilterBase
                {
                        if (i->freeform == freeform)
                        {
+                               delete i->regex;
                                filters.erase(i);
                                return true;
                        }
@@ -624,9 +629,12 @@ class ModuleFilter : public FilterBase
        virtual void OnRehash(User* user, const std::string &parameter)
        {
                ConfigReader MyConf(ServerInstance);
-
                FilterBase::OnRehash(user, parameter);
+               ReadFilters(MyConf);
+       }
 
+       void ReadFilters(ConfigReader &MyConf)
+       {
                for (int index = 0; index < MyConf.Enumerate("keyword"); index++)
                {
                        this->DeleteFilter(MyConf.ReadValue("keyword", "pattern", index));
@@ -644,11 +652,11 @@ class ModuleFilter : public FilterBase
                        try
                        {
                                filters.push_back(ImplFilter(this, reason, action, gline_time, pattern, flgs));
-                               ServerInstance->Logs->Log("m_filter",DEFAULT,"Regular expression %s loaded.", pattern.c_str());
+                               ServerInstance->Logs->Log("m_filter", DEFAULT, "Regular expression %s loaded.", pattern.c_str());
                        }
                        catch (ModuleException &e)
                        {
-                               ServerInstance->Logs->Log("m_filter",DEFAULT,"Error in regular expression '%s': %s", pattern.c_str(), e.GetReason());
+                               ServerInstance->Logs->Log("m_filter", DEFAULT, "Error in regular expression '%s': %s", pattern.c_str(), e.GetReason());
                        }
                }
        }
@@ -660,7 +668,7 @@ class ModuleFilter : public FilterBase
                        std::string sn = ServerInstance->Config->ServerName;
                        for (std::vector<ImplFilter>::iterator i = filters.begin(); i != filters.end(); i++)
                        {
-                               results.push_back(sn+" 223 "+user->nick+" :REGEXP:"+i->freeform+" "+i->flags+" "+i->action+" "+ConvToStr(i->gline_time)+" :"+i->reason);
+                               results.push_back(sn+" 223 "+user->nick+" :"+RegexEngine+":"+i->freeform+" "+i->flags+" "+i->action+" "+ConvToStr(i->gline_time)+" :"+i->reason);
                        }
                        for (std::vector<std::string>::iterator i = exemptfromfilter.begin(); i != exemptfromfilter.end(); ++i)
                        {