]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_filter.cpp
Pass an interface to the OnSync hooks
[user/henk/code/inspircd.git] / src / modules / m_filter.cpp
index b91c0c0c31b061fd382d11ec9ba7aa929d783ac7..c0ed4d9cbff2289f0227685dea2d4e2b9aca52ae 100644 (file)
@@ -22,9 +22,7 @@
 
 #include "inspircd.h"
 #include "xline.h"
-#include "m_regex.h"
-
-/* $ModDesc: Text (spam) filtering */
+#include "modules/regex.h"
 
 class ModuleFilter;
 
@@ -36,14 +34,22 @@ enum FilterFlags
        FLAG_NOTICE = 16
 };
 
+enum FilterAction
+{
+       FA_GLINE,
+       FA_BLOCK,
+       FA_SILENT,
+       FA_KILL,
+       FA_NONE
+};
+
 class FilterResult
 {
  public:
        std::string freeform;
        std::string reason;
-       std::string action;
+       FilterAction action;
        long gline_time;
-       std::string flags;
 
        bool flag_no_opers;
        bool flag_part_message;
@@ -52,20 +58,18 @@ class FilterResult
        bool flag_notice;
        bool flag_strip_color;
 
-       FilterResult(const std::string free, const std::string &rea, const std::string &act, long gt, const std::string &fla) :
-                       freeform(free), reason(rea), action(act), gline_time(gt), flags(fla)
+       FilterResult(const std::string& free, const std::string& rea, FilterAction act, long gt, const std::string& fla) :
+                       freeform(free), reason(rea), action(act), gline_time(gt)
        {
                this->FillFlags(fla);
        }
 
-       int FillFlags(const std::string &fl)
+       char FillFlags(const std::string &fl)
        {
-               flags = fl;
                flag_no_opers = flag_part_message = flag_quit_message = flag_privmsg =
                        flag_notice = flag_strip_color = false;
-               size_t x = 0;
 
-               for (std::string::const_iterator n = flags.begin(); n != flags.end(); ++n, ++x)
+               for (std::string::const_iterator n = fl.begin(); n != fl.end(); ++n)
                {
                        switch (*n)
                        {
@@ -92,13 +96,40 @@ class FilterResult
                                                flag_privmsg = flag_notice = flag_strip_color = true;
                                break;
                                default:
-                                       return x;
+                                       return *n;
                                break;
                        }
                }
                return 0;
        }
 
+       std::string GetFlags()
+       {
+               std::string flags;
+               if (flag_no_opers)
+                       flags.push_back('o');
+               if (flag_part_message)
+                       flags.push_back('P');
+               if (flag_quit_message)
+                       flags.push_back('q');
+               if (flag_privmsg)
+                       flags.push_back('p');
+               if (flag_notice)
+                       flags.push_back('n');
+
+               /* Order is important here, 'c' must be the last char in the string as it is unsupported
+                * on < 2.0.10, and the logic in FillFlags() stops parsing when it ecounters an unknown
+                * character.
+                */
+               if (flag_strip_color)
+                       flags.push_back('c');
+
+               if (flags.empty())
+                       flags.push_back('-');
+
+               return flags;
+       }
+
        FilterResult()
        {
        }
@@ -126,40 +157,44 @@ class ImplFilter : public FilterResult
  public:
        Regex* regex;
 
-       ImplFilter(ModuleFilter* mymodule, const std::string &rea, const std::string &act, long glinetime, const std::string &pat, const std::string &flgs);
+       ImplFilter(ModuleFilter* mymodule, const std::string &rea, FilterAction act, long glinetime, const std::string &pat, const std::string &flgs);
 };
 
 
 class ModuleFilter : public Module
 {
+       bool initing;
+       RegexFactory* factory;
+       void FreeFilters();
+
  public:
        CommandFilter filtcommand;
        dynamic_reference<RegexFactory> RegexEngine;
 
        std::vector<ImplFilter> filters;
-       const char *error;
-       int erroffset;
        int flags;
 
-       std::vector<std::string> exemptfromfilter; // List of channel names excluded from filtering.
+       std::set<std::string> exemptfromfilter; // List of channel names excluded from filtering.
 
        ModuleFilter();
-       void init();
-       ModResult OnUserPreMessage(User* user,void* dest,int target_type, std::string &text, char status, CUList &exempt_list);
+       CullResult cull();
+       ModResult OnUserPreMessage(User* user, void* dest, int target_type, std::string& text, char status, CUList& exempt_list, MessageType msgtype) CXX11_OVERRIDE;
        FilterResult* FilterMatch(User* user, const std::string &text, int flags);
        bool DeleteFilter(const std::string &freeform);
-       std::pair<bool, std::string> AddFilter(const std::string &freeform, const std::string &type, const std::string &reason, long duration, const std::string &flags);
-       ModResult OnUserPreNotice(User* user,void* dest,int target_type, std::string &text, char status, CUList &exempt_list);
-       void OnRehash(User* user);
-       Version GetVersion();
+       std::pair<bool, std::string> AddFilter(const std::string &freeform, FilterAction type, const std::string &reason, long duration, const std::string &flags);
+       void ReadConfig(ConfigStatus& status) CXX11_OVERRIDE;
+       Version GetVersion() CXX11_OVERRIDE;
        std::string EncodeFilter(FilterResult* filter);
        FilterResult DecodeFilter(const std::string &data);
-       void OnSyncNetwork(Module* proto, void* opaque);
-       void OnDecodeMetaData(Extensible* target, const std::string &extname, const std::string &extdata);
-       ModResult OnStats(char symbol, User* user, string_list &results);
-       ModResult OnPreCommand(std::string &command, std::vector<std::string> &parameters, LocalUser *user, bool validated, const std::string &original_line);
+       void OnSyncNetwork(ProtocolInterface::Server& server) CXX11_OVERRIDE;
+       void OnDecodeMetaData(Extensible* target, const std::string &extname, const std::string &extdata) CXX11_OVERRIDE;
+       ModResult OnStats(char symbol, User* user, string_list &results) CXX11_OVERRIDE;
+       ModResult OnPreCommand(std::string &command, std::vector<std::string> &parameters, LocalUser *user, bool validated, const std::string &original_line) CXX11_OVERRIDE;
+       void OnUnloadModule(Module* mod) CXX11_OVERRIDE;
        bool AppliesToMe(User* user, FilterResult* filter, int flags);
-       void ReadFilters(ConfigReader &MyConf);
+       void ReadFilters();
+       static bool StringToFilterAction(const std::string& str, FilterAction& fa);
+       static std::string FilterActionToString(FilterAction fa);
 };
 
 CmdResult CommandFilter::Handle(const std::vector<std::string> &parameters, User *user)
@@ -170,13 +205,13 @@ CmdResult CommandFilter::Handle(const std::vector<std::string> &parameters, User
                Module *me = creator;
                if (static_cast<ModuleFilter *>(me)->DeleteFilter(parameters[0]))
                {
-                       user->WriteServ("NOTICE %s :*** Removed filter '%s'", user->nick.c_str(), parameters[0].c_str());
+                       user->WriteNotice("*** Removed filter '" + parameters[0] + "'");
                        ServerInstance->SNO->WriteToSnoMask(IS_LOCAL(user) ? 'a' : 'A', "FILTER: "+user->nick+" removed filter '"+parameters[0]+"'");
                        return CMD_SUCCESS;
                }
                else
                {
-                       user->WriteServ("NOTICE %s :*** Filter '%s' not found in list, try /stats s.", user->nick.c_str(), parameters[0].c_str());
+                       user->WriteNotice("*** Filter '" + parameters[0] + "' not found in list, try /stats s.");
                        return CMD_FAILURE;
                }
        }
@@ -185,58 +220,57 @@ CmdResult CommandFilter::Handle(const std::vector<std::string> &parameters, User
                /* Adding a filter */
                if (parameters.size() >= 4)
                {
-                       std::string freeform = parameters[0];
-                       std::string type = parameters[1];
-                       std::string flags = parameters[2];
-                       std::string reason;
+                       const std::string& freeform = parameters[0];
+                       FilterAction type;
+                       const std::string& flags = parameters[2];
+                       unsigned int reasonindex;
                        long duration = 0;
 
-
-                       if ((type != "gline") && (type != "none") && (type != "block") && (type != "kill") && (type != "silent"))
+                       if (!ModuleFilter::StringToFilterAction(parameters[1], type))
                        {
-                               user->WriteServ("NOTICE %s :*** Invalid filter type '%s'. Supported types are 'gline', 'none', 'block', 'silent' and 'kill'.", user->nick.c_str(), type.c_str());
+                               user->WriteNotice("*** Invalid filter type '" + parameters[1] + "'. Supported types are 'gline', 'none', 'block', 'silent' and 'kill'.");
                                return CMD_FAILURE;
                        }
 
-                       if (type == "gline")
+                       if (type == FA_GLINE)
                        {
                                if (parameters.size() >= 5)
                                {
-                                       duration = ServerInstance->Duration(parameters[3]);
-                                       reason = parameters[4];
+                                       duration = InspIRCd::Duration(parameters[3]);
+                                       reasonindex = 4;
                                }
                                else
                                {
-                                       user->WriteServ("NOTICE %s :*** Not enough parameters: When setting a gline type filter, a gline duration must be specified as the third parameter.", user->nick.c_str());
+                                       user->WriteNotice("*** Not enough parameters: When setting a gline type filter, a gline duration must be specified as the third parameter.");
                                        return CMD_FAILURE;
                                }
                        }
                        else
                        {
-                               reason = parameters[3];
+                               reasonindex = 3;
                        }
 
                        Module *me = creator;
-                       std::pair<bool, std::string> result = static_cast<ModuleFilter *>(me)->AddFilter(freeform, type, reason, duration, flags);
+                       std::pair<bool, std::string> result = static_cast<ModuleFilter *>(me)->AddFilter(freeform, type, parameters[reasonindex], duration, flags);
                        if (result.first)
                        {
-                               user->WriteServ("NOTICE %s :*** Added filter '%s', type '%s'%s%s, flags '%s', reason: '%s'", user->nick.c_str(), freeform.c_str(),
-                                               type.c_str(), (duration ? ", duration " : ""), (duration ? parameters[3].c_str() : ""),
-                                               flags.c_str(), reason.c_str());
+                               user->WriteNotice("*** Added filter '" + freeform + "', type '" + parameters[1] + "'" +
+                                       (duration ? ", duration " +  parameters[3] : "") + ", flags '" + flags + "', reason: '" +
+                                       parameters[reasonindex] + "'");
 
-                               ServerInstance->SNO->WriteToSnoMask(IS_LOCAL(user) ? 'a' : 'A', "FILTER: "+user->nick+" added filter '"+freeform+"', type '"+type+"', "+(duration ? "duration "+parameters[3]+", " : "")+"flags '"+flags+"', reason: "+reason);
+                               ServerInstance->SNO->WriteToSnoMask(IS_LOCAL(user) ? 'a' : 'A', "FILTER: "+user->nick+" added filter '"+freeform+"', type '"+parameters[1]+"', "+(duration ? "duration "+parameters[3]+", " : "")+"flags '"+flags+"', reason: "+parameters[reasonindex]);
 
                                return CMD_SUCCESS;
                        }
                        else
                        {
-                               user->WriteServ("NOTICE %s :*** Filter '%s' could not be added: %s", user->nick.c_str(), freeform.c_str(), result.second.c_str());
+                               user->WriteNotice("*** Filter '" + freeform + "' could not be added: " + result.second);
                                return CMD_FAILURE;
                        }
                }
                else
                {
-                       user->WriteServ("NOTICE %s :*** Not enough parameters.", user->nick.c_str());
+                       user->WriteNotice("*** Not enough parameters.");
                        return CMD_FAILURE;
                }
 
@@ -245,7 +279,7 @@ CmdResult CommandFilter::Handle(const std::vector<std::string> &parameters, User
 
 bool ModuleFilter::AppliesToMe(User* user, FilterResult* filter, int iflags)
 {
-       if ((filter->flag_no_opers) && IS_OPER(user))
+       if ((filter->flag_no_opers) && user->IsOper())
                return false;
        if ((iflags & FLAG_PRIVMSG) && (!filter->flag_privmsg))
                return false;
@@ -258,40 +292,37 @@ bool ModuleFilter::AppliesToMe(User* user, FilterResult* filter, int iflags)
        return true;
 }
 
-ModuleFilter::ModuleFilter() : filtcommand(this), RegexEngine(this, "regex")
+ModuleFilter::ModuleFilter()
+       : initing(true), filtcommand(this), RegexEngine(this, "regex")
 {
 }
 
-void ModuleFilter::init()
+CullResult ModuleFilter::cull()
 {
-       ServerInstance->AddCommand(&filtcommand);
-       Implementation eventlist[] = { I_OnPreCommand, I_OnStats, I_OnSyncNetwork, I_OnDecodeMetaData, I_OnUserPreMessage, I_OnUserPreNotice, I_OnRehash };
-       ServerInstance->Modules->Attach(eventlist, this, 7);
-       OnRehash(NULL);
+       FreeFilters();
+       return Module::cull();
 }
 
-ModResult ModuleFilter::OnUserPreMessage(User* user,void* dest,int target_type, std::string &text, char status, CUList &exempt_list)
+void ModuleFilter::FreeFilters()
 {
-       if (!IS_LOCAL(user))
-               return MOD_RES_PASSTHRU;
+       for (std::vector<ImplFilter>::const_iterator i = filters.begin(); i != filters.end(); ++i)
+               delete i->regex;
 
-       flags = FLAG_PRIVMSG;
-       return OnUserPreNotice(user,dest,target_type,text,status,exempt_list);
+       filters.clear();
 }
 
-ModResult ModuleFilter::OnUserPreNotice(User* user,void* dest,int target_type, std::string &text, char status, CUList &exempt_list)
+ModResult ModuleFilter::OnUserPreMessage(User* user, void* dest, int target_type, std::string& text, char status, CUList& exempt_list, MessageType msgtype)
 {
        /* Leave ulines alone */
        if ((ServerInstance->ULine(user->server)) || (!IS_LOCAL(user)))
                return MOD_RES_PASSTHRU;
 
-       if (!flags)
-               flags = FLAG_NOTICE;
+       flags = (msgtype == MSG_PRIVMSG) ? FLAG_PRIVMSG : FLAG_NOTICE;
 
        FilterResult* f = this->FilterMatch(user, text, flags);
        if (f)
        {
-               std::string target = "";
+               std::string target;
                if (target_type == TYPE_USER)
                {
                        User* t = (User*)dest;
@@ -300,30 +331,31 @@ ModResult ModuleFilter::OnUserPreNotice(User* user,void* dest,int target_type, s
                else if (target_type == TYPE_CHANNEL)
                {
                        Channel* t = (Channel*)dest;
-                       target = std::string(t->name);
-                       std::vector<std::string>::iterator i = find(exemptfromfilter.begin(), exemptfromfilter.end(), target);
-                       if (i != exemptfromfilter.end()) return MOD_RES_PASSTHRU;
+                       if (exemptfromfilter.find(t->name) != exemptfromfilter.end())
+                               return MOD_RES_PASSTHRU;
+
+                       target = t->name;
                }
-               if (f->action == "block")
+               if (f->action == FA_BLOCK)
                {
                        ServerInstance->SNO->WriteGlobalSno('a', "FILTER: "+user->nick+" had their message filtered, target was "+target+": "+f->reason);
                        if (target_type == TYPE_CHANNEL)
                                user->WriteNumeric(404, "%s %s :Message to channel blocked and opers notified (%s)",user->nick.c_str(), target.c_str(), f->reason.c_str());
                        else
-                               user->WriteServ("NOTICE "+user->nick+" :Your message to "+target+" was blocked and opers notified: "+f->reason);
+                               user->WriteNotice("Your message to "+target+" was blocked and opers notified: "+f->reason);
                }
-               if (f->action == "silent")
+               else if (f->action == FA_SILENT)
                {
                        if (target_type == TYPE_CHANNEL)
                                user->WriteNumeric(404, "%s %s :Message to channel blocked (%s)",user->nick.c_str(), target.c_str(), f->reason.c_str());
                        else
-                               user->WriteServ("NOTICE "+user->nick+" :Your message to "+target+" was blocked: "+f->reason);
+                               user->WriteNotice("Your message to "+target+" was blocked: "+f->reason);
                }
-               if (f->action == "kill")
+               else if (f->action == FA_KILL)
                {
                        ServerInstance->Users->QuitUser(user, "Filtered: " + f->reason);
                }
-               if (f->action == "gline")
+               else if (f->action == FA_GLINE)
                {
                        GLine* gl = new GLine(ServerInstance->Time(), f->gline_time, ServerInstance->Config->ServerName.c_str(), f->reason.c_str(), "*", user->GetIPString());
                        if (ServerInstance->XLines->AddLine(gl,NULL))
@@ -334,7 +366,7 @@ ModResult ModuleFilter::OnUserPreNotice(User* user,void* dest,int target_type, s
                                delete gl;
                }
 
-               ServerInstance->Logs->Log("FILTER",DEFAULT,"FILTER: "+ user->nick + " had their message filtered, target was " + target + ": " + f->reason + " Action: " + f->action);
+               ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, user->nick + " had their message filtered, target was " + target + ": " + f->reason + " Action: " + ModuleFilter::FilterActionToString(f->action));
                return MOD_RES_DENY;
        }
        return MOD_RES_PASSTHRU;
@@ -342,12 +374,10 @@ ModResult ModuleFilter::OnUserPreNotice(User* user,void* dest,int target_type, s
 
 ModResult ModuleFilter::OnPreCommand(std::string &command, std::vector<std::string> &parameters, LocalUser *user, bool validated, const std::string &original_line)
 {
-       flags = 0;
        if (validated && IS_LOCAL(user))
        {
-               std::string checkline;
-               int replacepoint = 0;
-               bool parting = false;
+               flags = 0;
+               bool parting;
 
                if (command == "QUIT")
                {
@@ -355,8 +385,6 @@ ModResult ModuleFilter::OnPreCommand(std::string &command, std::vector<std::stri
                        if (parameters.size() < 1)
                                return MOD_RES_PASSTHRU;
 
-                       checkline = parameters[0];
-                       replacepoint = 0;
                        parting = false;
                        flags = FLAG_QUIT;
                }
@@ -366,10 +394,9 @@ ModResult ModuleFilter::OnPreCommand(std::string &command, std::vector<std::stri
                        if (parameters.size() < 2)
                                return MOD_RES_PASSTHRU;
 
-                       std::vector<std::string>::iterator i = find(exemptfromfilter.begin(), exemptfromfilter.end(), parameters[0]);
-                       if (i != exemptfromfilter.end()) return MOD_RES_PASSTHRU;
-                       checkline = parameters[1];
-                       replacepoint = 1;
+                       if (exemptfromfilter.find(parameters[0]) != exemptfromfilter.end())
+                               return MOD_RES_PASSTHRU;
+
                        parting = true;
                        flags = FLAG_PART;
                }
@@ -377,85 +404,86 @@ ModResult ModuleFilter::OnPreCommand(std::string &command, std::vector<std::stri
                        /* We're only messing with PART and QUIT */
                        return MOD_RES_PASSTHRU;
 
-               FilterResult* f = NULL;
-
-               if (flags)
-                       f = this->FilterMatch(user, checkline, flags);
-
+               FilterResult* f = this->FilterMatch(user, parameters[parting ? 1 : 0], flags);
                if (!f)
                        /* PART or QUIT reason doesnt match a filter */
                        return MOD_RES_PASSTHRU;
 
                /* We cant block a part or quit, so instead we change the reason to 'Reason filtered' */
-               Command* c = ServerInstance->Parser->GetHandler(command);
-               if (c)
+               parameters[parting ? 1 : 0] = "Reason filtered";
+
+               /* We're blocking, OR theyre quitting and its a KILL action
+                * (we cant kill someone whos already quitting, so filter them anyway)
+                */
+               if ((f->action == FA_BLOCK) || (((!parting) && (f->action == FA_KILL))) || (f->action == FA_SILENT))
+               {
+                       return MOD_RES_PASSTHRU;
+               }
+               else
                {
-                       std::vector<std::string> params;
-                       for (int item = 0; item < (int)parameters.size(); item++)
-                               params.push_back(parameters[item]);
-                       params[replacepoint] = "Reason filtered";
-
-                       /* We're blocking, OR theyre quitting and its a KILL action
-                        * (we cant kill someone whos already quitting, so filter them anyway)
-                        */
-                       if ((f->action == "block") || (((!parting) && (f->action == "kill"))) || (f->action == "silent"))
+                       /* Are they parting, if so, kill is applicable */
+                       if ((parting) && (f->action == FA_KILL))
                        {
-                               c->Handle(params, user);
-                               return MOD_RES_DENY;
+                               user->WriteNotice("*** Your PART message was filtered: " + f->reason);
+                               ServerInstance->Users->QuitUser(user, "Filtered: " + f->reason);
                        }
-                       else
+                       if (f->action == FA_GLINE)
                        {
-                               /* Are they parting, if so, kill is applicable */
-                               if ((parting) && (f->action == "kill"))
+                               /* Note: We gline *@IP so that if their host doesnt resolve the gline still applies. */
+                               GLine* gl = new GLine(ServerInstance->Time(), f->gline_time, ServerInstance->Config->ServerName.c_str(), f->reason.c_str(), "*", user->GetIPString());
+                               if (ServerInstance->XLines->AddLine(gl,NULL))
                                {
-                                       user->WriteServ("NOTICE %s :*** Your PART message was filtered: %s", user->nick.c_str(), f->reason.c_str());
-                                       ServerInstance->Users->QuitUser(user, "Filtered: " + f->reason);
+                                       ServerInstance->XLines->ApplyLines();
                                }
-                               if (f->action == "gline")
-                               {
-                                       /* Note: We gline *@IP so that if their host doesnt resolve the gline still applies. */
-                                       GLine* gl = new GLine(ServerInstance->Time(), f->gline_time, ServerInstance->Config->ServerName.c_str(), f->reason.c_str(), "*", user->GetIPString());
-                                       if (ServerInstance->XLines->AddLine(gl,NULL))
-                                       {
-                                               ServerInstance->XLines->ApplyLines();
-                                       }
-                                       else
-                                               delete gl;
-                               }
-                               return MOD_RES_DENY;
+                               else
+                                       delete gl;
                        }
+                       return MOD_RES_DENY;
                }
-               return MOD_RES_PASSTHRU;
        }
        return MOD_RES_PASSTHRU;
 }
 
-void ModuleFilter::OnRehash(User* user)
+void ModuleFilter::ReadConfig(ConfigStatus& status)
 {
-       ConfigReader MyConf;
-       std::vector<std::string>().swap(exemptfromfilter);
-       for (int index = 0; index < MyConf.Enumerate("exemptfromfilter"); ++index)
+       ConfigTagList tags = ServerInstance->Config->ConfTags("exemptfromfilter");
+       exemptfromfilter.clear();
+       for (ConfigIter i = tags.first; i != tags.second; ++i)
        {
-               std::string chan = MyConf.ReadValue("exemptfromfilter", "channel", index);
-               if (!chan.empty()) {
-                       exemptfromfilter.push_back(chan);
-               }
+               std::string chan = i->second->getString("channel");
+               if (!chan.empty())
+                       exemptfromfilter.insert(chan);
        }
-       std::string newrxengine = "regex/" + MyConf.ReadValue("filteropts", "engine", 0);
-       if (newrxengine == "regex/")
-               newrxengine = "regex";
-       if (RegexEngine.GetProvider() == newrxengine)
-               return;
 
-       //ServerInstance->SNO->WriteGlobalSno('a', "Dumping all filters due to regex engine change (was '%s', now '%s')", RegexEngine.GetProvider().c_str(), newrxengine.c_str());
-       //ServerInstance->XLines->DelAll("R");
+       std::string newrxengine = ServerInstance->Config->ConfValue("filteropts")->getString("engine");
+
+       factory = RegexEngine ? (RegexEngine.operator->()) : NULL;
+
+       if (newrxengine.empty())
+               RegexEngine.SetProvider("regex");
+       else
+               RegexEngine.SetProvider("regex/" + newrxengine);
 
-       RegexEngine.SetProvider(newrxengine);
        if (!RegexEngine)
        {
-               ServerInstance->SNO->WriteGlobalSno('a', "WARNING: Regex engine '%s' is not loaded - Filter functionality disabled until this is corrected.", newrxengine.c_str());
+               if (newrxengine.empty())
+                       ServerInstance->SNO->WriteGlobalSno('a', "WARNING: No regex engine loaded - Filter functionality disabled until this is corrected.");
+               else
+                       ServerInstance->SNO->WriteGlobalSno('a', "WARNING: Regex engine '%s' is not loaded - Filter functionality disabled until this is corrected.", newrxengine.c_str());
+
+               initing = false;
+               FreeFilters();
+               return;
        }
-       ReadFilters(MyConf);
+
+       if ((!initing) && (RegexEngine.operator->() != factory))
+       {
+               ServerInstance->SNO->WriteGlobalSno('a', "Dumping all filters due to regex engine change");
+               FreeFilters();
+       }
+
+       initing = false;
+       ReadFilters();
 }
 
 Version ModuleFilter::GetVersion()
@@ -473,20 +501,26 @@ std::string ModuleFilter::EncodeFilter(FilterResult* filter)
                if (*n == ' ')
                        *n = '\7';
 
-       stream << x << " " << filter->action << " " << (filter->flags.empty() ? "-" : filter->flags) << " " << filter->gline_time << " :" << filter->reason;
+       stream << x << " " << FilterActionToString(filter->action) << " " << filter->GetFlags() << " " << filter->gline_time << " :" << filter->reason;
        return stream.str();
 }
 
 FilterResult ModuleFilter::DecodeFilter(const std::string &data)
 {
+       std::string filteraction;
        FilterResult res;
        irc::tokenstream tokens(data);
        tokens.GetToken(res.freeform);
-       tokens.GetToken(res.action);
-       tokens.GetToken(res.flags);
-       if (res.flags == "-")
-               res.flags = "";
-       res.FillFlags(res.flags);
+       tokens.GetToken(filteraction);
+       if (!StringToFilterAction(filteraction, res.action))
+               throw ModuleException("Invalid action: " + filteraction);
+
+       std::string filterflags;
+       tokens.GetToken(filterflags);
+       char c = res.FillFlags(filterflags);
+       if (c != 0)
+               throw ModuleException("Invalid flag: '" + std::string(1, c) + "'");
+
        tokens.GetToken(res.gline_time);
        tokens.GetToken(res.reason);
 
@@ -498,11 +532,11 @@ FilterResult ModuleFilter::DecodeFilter(const std::string &data)
        return res;
 }
 
-void ModuleFilter::OnSyncNetwork(Module* proto, void* opaque)
+void ModuleFilter::OnSyncNetwork(ProtocolInterface::Server& server)
 {
        for (std::vector<ImplFilter>::iterator i = filters.begin(); i != filters.end(); ++i)
        {
-               proto->ProtoSendMetaData(opaque, NULL, "filter", EncodeFilter(&(*i)));
+               server.SendMetaData("filter", EncodeFilter(&(*i)));
        }
 }
 
@@ -510,12 +544,19 @@ void ModuleFilter::OnDecodeMetaData(Extensible* target, const std::string &extna
 {
        if ((target == NULL) && (extname == "filter"))
        {
-               FilterResult data = DecodeFilter(extdata);
-               this->AddFilter(data.freeform, data.action, data.reason, data.gline_time, data.flags);
+               try
+               {
+                       FilterResult data = DecodeFilter(extdata);
+                       this->AddFilter(data.freeform, data.action, data.reason, data.gline_time, data.GetFlags());
+               }
+               catch (ModuleException& e)
+               {
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "Error when unserializing filter: " + std::string(e.GetReason()));
+               }
        }
 }
 
-ImplFilter::ImplFilter(ModuleFilter* mymodule, const std::string &rea, const std::string &act, long glinetime, const std::string &pat, const std::string &flgs)
+ImplFilter::ImplFilter(ModuleFilter* mymodule, const std::string &rea, FilterAction act, long glinetime, const std::string &pat, const std::string &flgs)
                : FilterResult(pat, rea, act, glinetime, flgs)
 {
        if (!mymodule->RegexEngine)
@@ -542,20 +583,8 @@ FilterResult* ModuleFilter::FilterMatch(User* user, const std::string &text, int
                        InspIRCd::StripColor(stripped_text);
                }
 
-               //ServerInstance->Logs->Log("m_filter", DEBUG, "Match '%s' against '%s'", text.c_str(), index->freeform.c_str());
                if (index->regex->Matches(filter->flag_strip_color ? stripped_text : text))
-               {
-                       //ServerInstance->Logs->Log("m_filter", DEBUG, "MATCH");
-                       ImplFilter fr = *index;
-                       if (index != filters.begin())
-                       {
-                               /* Move to head of list for efficiency */
-                               filters.erase(index);
-                               filters.insert(filters.begin(), fr);
-                       }
-                       return &*filters.begin();
-               }
-               //ServerInstance->Logs->Log("m_filter", DEBUG, "NO MATCH");
+                       return &*index;
        }
        return NULL;
 }
@@ -574,7 +603,7 @@ bool ModuleFilter::DeleteFilter(const std::string &freeform)
        return false;
 }
 
-std::pair<bool, std::string> ModuleFilter::AddFilter(const std::string &freeform, const std::string &type, const std::string &reason, long duration, const std::string &flgs)
+std::pair<bool, std::string> ModuleFilter::AddFilter(const std::string &freeform, FilterAction type, const std::string &reason, long duration, const std::string &flgs)
 {
        for (std::vector<ImplFilter>::iterator i = filters.begin(); i != filters.end(); i++)
        {
@@ -590,36 +619,71 @@ std::pair<bool, std::string> ModuleFilter::AddFilter(const std::string &freeform
        }
        catch (ModuleException &e)
        {
-               ServerInstance->Logs->Log("m_filter", DEFAULT, "Error in regular expression '%s': %s", freeform.c_str(), e.GetReason());
+               ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Error in regular expression '%s': %s", freeform.c_str(), e.GetReason());
                return std::make_pair(false, e.GetReason());
        }
        return std::make_pair(true, "");
 }
 
-void ModuleFilter::ReadFilters(ConfigReader &MyConf)
+bool ModuleFilter::StringToFilterAction(const std::string& str, FilterAction& fa)
 {
-       for (int index = 0; index < MyConf.Enumerate("keyword"); index++)
+       irc::string s(str.c_str());
+
+       if (s == "gline")
+               fa = FA_GLINE;
+       else if (s == "block")
+               fa = FA_BLOCK;
+       else if (s == "silent")
+               fa = FA_SILENT;
+       else if (s == "kill")
+               fa = FA_KILL;
+       else if (s == "none")
+               fa = FA_NONE;
+       else
+               return false;
+
+       return true;
+}
+
+std::string ModuleFilter::FilterActionToString(FilterAction fa)
+{
+       switch (fa)
        {
-               this->DeleteFilter(MyConf.ReadValue("keyword", "pattern", index));
-
-               std::string pattern = MyConf.ReadValue("keyword", "pattern", index);
-               std::string reason = MyConf.ReadValue("keyword", "reason", index);
-               std::string action = MyConf.ReadValue("keyword", "action", index);
-               std::string flgs = MyConf.ReadValue("keyword", "flags", index);
-               long gline_time = ServerInstance->Duration(MyConf.ReadValue("keyword", "duration", index));
-               if (action.empty())
-                       action = "none";
+               case FA_GLINE:  return "gline";
+               case FA_BLOCK:  return "block";
+               case FA_SILENT: return "silent";
+               case FA_KILL:   return "kill";
+               default:                return "none";
+       }
+}
+
+void ModuleFilter::ReadFilters()
+{
+       ConfigTagList tags = ServerInstance->Config->ConfTags("keyword");
+       for (ConfigIter i = tags.first; i != tags.second; ++i)
+       {
+               std::string pattern = i->second->getString("pattern");
+               this->DeleteFilter(pattern);
+
+               std::string reason = i->second->getString("reason");
+               std::string action = i->second->getString("action");
+               std::string flgs = i->second->getString("flags");
+               unsigned long gline_time = i->second->getDuration("duration", 10*60, 1);
                if (flgs.empty())
                        flgs = "*";
 
+               FilterAction fa;
+               if (!StringToFilterAction(action, fa))
+                       fa = FA_NONE;
+
                try
                {
-                       filters.push_back(ImplFilter(this, reason, action, gline_time, pattern, flgs));
-                       ServerInstance->Logs->Log("m_filter", DEFAULT, "Regular expression %s loaded.", pattern.c_str());
+                       filters.push_back(ImplFilter(this, reason, fa, gline_time, pattern, flgs));
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Regular expression %s loaded.", pattern.c_str());
                }
                catch (ModuleException &e)
                {
-                       ServerInstance->Logs->Log("m_filter", DEFAULT, "Error in regular expression '%s': %s", pattern.c_str(), e.GetReason());
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "Error in regular expression '%s': %s", pattern.c_str(), e.GetReason());
                }
        }
 }
@@ -630,9 +694,9 @@ ModResult ModuleFilter::OnStats(char symbol, User* user, string_list &results)
        {
                for (std::vector<ImplFilter>::iterator i = filters.begin(); i != filters.end(); i++)
                {
-                       results.push_back(ServerInstance->Config->ServerName+" 223 "+user->nick+" :"+RegexEngine.GetProvider()+":"+i->freeform+" "+i->flags+" "+i->action+" "+ConvToStr(i->gline_time)+" :"+i->reason);
+                       results.push_back(ServerInstance->Config->ServerName+" 223 "+user->nick+" :"+RegexEngine.GetProvider()+":"+i->freeform+" "+i->GetFlags()+" "+FilterActionToString(i->action)+" "+ConvToStr(i->gline_time)+" :"+i->reason);
                }
-               for (std::vector<std::string>::iterator i = exemptfromfilter.begin(); i != exemptfromfilter.end(); ++i)
+               for (std::set<std::string>::iterator i = exemptfromfilter.begin(); i != exemptfromfilter.end(); ++i)
                {
                        results.push_back(ServerInstance->Config->ServerName+" 223 "+user->nick+" :EXEMPT "+(*i));
                }
@@ -640,4 +704,18 @@ ModResult ModuleFilter::OnStats(char symbol, User* user, string_list &results)
        return MOD_RES_PASSTHRU;
 }
 
+void ModuleFilter::OnUnloadModule(Module* mod)
+{
+       // If the regex engine became unavailable or has changed, remove all filters
+       if (!RegexEngine)
+       {
+               FreeFilters();
+       }
+       else if (RegexEngine.operator->() != factory)
+       {
+               factory = RegexEngine.operator->();
+               FreeFilters();
+       }
+}
+
 MODULE_INIT(ModuleFilter)