]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_helpop.cpp
Various improvements for the helpop module.
[user/henk/code/inspircd.git] / src / modules / m_helpop.cpp
index 6533aa5953529730e4c5765b6bc561335afea374..a34e3ff9407889b523eee56950ff28fe0ac5d772 100644 (file)
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
  *
- *  InspIRCd: (C) 2002-2010 InspIRCd Development Team
- * See: http://wiki.inspircd.org/Credits
+ *   Copyright (C) 2013-2015 Attila Molnar <attilamolnar@hush.com>
+ *   Copyright (C) 2013, 2017-2018, 2020 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2012, 2019 Robby <robby@chatbelgie.be>
+ *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2009 Uli Schlachter <psychon@inspircd.org>
+ *   Copyright (C) 2007-2008 Robin Burchell <robin+git@viroteck.net>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
+ *   Copyright (C) 2006-2007 Craig Edwards <brain@inspircd.org>
  *
- * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "inspircd.h"
-
-/* $ModDesc: /helpop Command, Works like Unreal helpop */
-static std::map<irc::string, std::string> helpop_map;
 
+#include "inspircd.h"
+#include "modules/whois.h"
 
-/** Handles user mode +h
- */
-class Helpop : public ModeHandler
+enum
 {
- public:
-       Helpop(Module* Creator) : ModeHandler(Creator, "helpop", 'h', PARAM_NONE, MODETYPE_USER)
-       {
-               oper = true;
-       }
+       // From UnrealIRCd.
+       RPL_WHOISHELPOP = 310,
+
+       // From ircd-ratbox.
+       ERR_HELPNOTFOUND = 524,
+       RPL_HELPSTART = 704,
+       RPL_HELPTXT = 705,
+       RPL_ENDOFHELP = 706
+};
 
-       ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string &parameter, bool adding)
-       {
-               if (adding)
-               {
-                       if (!dest->IsModeSet('h'))
-                       {
-                               dest->SetMode('h',true);
-                               return MODEACTION_ALLOW;
-                       }
-               }
-               else
-               {
-                       if (dest->IsModeSet('h'))
-                       {
-                               dest->SetMode('h',false);
-                               return MODEACTION_ALLOW;
-                       }
-               }
+typedef std::vector<std::string> HelpMessage;
 
-               return MODEACTION_DENY;
-       }
-};
+typedef std::map<std::string, HelpMessage, irc::insensitive_swo> HelpMap;
 
-/** Handles /HELPOP
- */
 class CommandHelpop : public Command
 {
+ private:
+       const std::string startkey;
+
  public:
-       CommandHelpop(Module* Creator) : Command(Creator, "HELP", 0)
+       HelpMap help;
+       std::string nohelp;
+
+       CommandHelpop(Module* Creator)
+               : Command(Creator, "HELPOP", 0)
+               , startkey("start")
        {
                syntax = "<any-text>";
        }
 
-       CmdResult Handle (const std::vector<std::string> &parameters, User *user)
+       CmdResult Handle(User* user, const Params& parameters) CXX11_OVERRIDE
        {
-               irc::string parameter("start");
-               if (parameters.size() > 0)
-                       parameter = parameters[0].c_str();
-
-               if (parameter == "index")
+               const std::string& topic = parameters.empty() ? startkey : parameters[0];
+               HelpMap::const_iterator titer = help.find(topic);
+               if (titer == help.end())
                {
-                       /* iterate over all helpop items */
-                       user->WriteServ("290 %s :HELPOP topic index", user->nick.c_str());
-                       for (std::map<irc::string, std::string>::iterator iter = helpop_map.begin(); iter != helpop_map.end(); iter++)
-                       {
-                               user->WriteServ("292 %s :  %s", user->nick.c_str(), iter->first.c_str());
-                       }
-                       user->WriteServ("292 %s :*** End of HELPOP topic index", user->nick.c_str());
+                       user->WriteNumeric(ERR_HELPNOTFOUND, topic, nohelp);
+                       return CMD_FAILURE;
                }
-               else
-               {
-                       user->WriteServ("290 %s :*** HELPOP for %s", user->nick.c_str(), parameter.c_str());
-                       user->WriteServ("292 %s : -", user->nick.c_str());
-
-                       std::map<irc::string, std::string>::iterator iter = helpop_map.find(parameter);
 
-                       if (iter == helpop_map.end())
-                       {
-                               iter = helpop_map.find("nohelp");
-                       }
-
-                       std::string value = iter->second;
-                       irc::sepstream stream(value, '\n');
-                       std::string token = "*";
-
-                       while (stream.GetToken(token))
-                       {
-                               // Writing a blank line will not work with some clients
-                               if (token.empty())
-                                       user->WriteServ("292 %s : ", user->nick.c_str());
-                               else
-                                       user->WriteServ("292 %s :%s", user->nick.c_str(), token.c_str());
-                       }
-
-                       user->WriteServ("292 %s : -", user->nick.c_str());
-                       user->WriteServ("292 %s :*** End of HELPOP", user->nick.c_str());
-               }
+               user->WriteNumeric(RPL_HELPSTART, topic, InspIRCd::Format("*** Help for %s", topic.c_str()));
+               for (HelpMessage::const_iterator liter = titer->second.begin(); liter != titer->second.end(); ++liter)
+                       user->WriteNumeric(RPL_HELPTXT, topic, *liter);
+               user->WriteNumeric(RPL_ENDOFHELP, topic, "*** End of help");
                return CMD_SUCCESS;
        }
 };
 
-class ModuleHelpop : public Module
+class ModuleHelpop
+       : public Module
+       , public Whois::EventListener
 {
-       private:
-               std::string  h_file;
+ private:
                CommandHelpop cmd;
-               Helpop ho;
+               SimpleUserModeHandler ho;
 
        public:
                ModuleHelpop()
-                       : cmd(this), ho(this)
+                       : Whois::EventListener(this)
+                       , cmd(this)
+                       , ho(this, "helpop", 'h', true)
                {
-                       ReadConfig();
-                       if (!ServerInstance->Modes->AddMode(&ho))
-                               throw ModuleException("Could not add new modes!");
-                       ServerInstance->AddCommand(&cmd);
-                       Implementation eventlist[] = { I_OnRehash, I_OnWhois };
-                       ServerInstance->Modules->Attach(eventlist, this, 2);
                }
 
-               virtual void ReadConfig()
+               void ReadConfig(ConfigStatus& status) CXX11_OVERRIDE
                {
-                       ConfigReader MyConf;
-
-                       helpop_map.clear();
+                       size_t longestkey = 0;
 
+                       HelpMap newhelp;
                        ConfigTagList tags = ServerInstance->Config->ConfTags("helpop");
-                       for(ConfigIter i = tags.first; i != tags.second; ++i)
+                       if (tags.first == tags.second)
+                               throw ModuleException("You have loaded the helpop module but not configured any help topics!");
+
+                       for (ConfigIter i = tags.first; i != tags.second; ++i)
                        {
                                ConfigTag* tag = i->second;
-                               irc::string key = assign(tag->getString("key"));
-                               std::string value;
-                               tag->readString("value", value, true); /* Linefeeds allowed */
 
-                               if (key == "index")
-                               {
-                                       throw ModuleException("m_helpop: The key 'index' is reserved for internal purposes. Please remove it.");
-                               }
+                               // Attempt to read the help key.
+                               const std::string key = tag->getString("key");
+                               if (key.empty())
+                                       throw ModuleException(InspIRCd::Format("<helpop:key> is empty at %s", tag->getTagLocation().c_str()));
+                               else if (irc::equals(key, "index"))
+                                       throw ModuleException(InspIRCd::Format("<helpop:key> is set to \"index\" which is reserved at %s", tag->getTagLocation().c_str()));
+                               else if (key.length() > longestkey)
+                                       longestkey = key.length();
 
-                               helpop_map[key] = value;
+                               // Attempt to read the help value.
+                               std::string value;
+                               if (!tag->readString("value", value, true) || value.empty())
+                                       throw ModuleException(InspIRCd::Format("<helpop:value> is empty at %s", tag->getTagLocation().c_str()));
+
+                               // Parse the help body. Empty lines are replaced with a single
+                               // space because some clients are unable to show blank lines.
+                               HelpMessage helpmsg;
+                               irc::sepstream linestream(value, '\n', true);
+                               for (std::string line; linestream.GetToken(line); )
+                                       helpmsg.push_back(line.empty() ? " " : line);
+                               newhelp[key] = helpmsg;
                        }
 
-                       if (helpop_map.find("start") == helpop_map.end())
+                       // The number of items we can fit on a page.
+                       HelpMessage& indexmsg = newhelp["index"];
+                       size_t maxcolumns = 80 / (longestkey + 2);
+                       for (HelpMap::iterator iter = newhelp.begin(); iter != newhelp.end(); )
                        {
-                               // error!
-                               throw ModuleException("m_helpop: Helpop file is missing important entry 'start'. Please check the example conf.");
-                       }
-                       else if (helpop_map.find("nohelp") == helpop_map.end())
-                       {
-                               // error!
-                               throw ModuleException("m_helpop: Helpop file is missing important entry 'nohelp'. Please check the example conf.");
-                       }
-
-               }
-
-
-               virtual void OnRehash(User* user)
-               {
-                       ReadConfig();
-               }
+                               std::string indexline;
+                               for (size_t column = 0; column != maxcolumns; )
+                               {
+                                       if (iter == newhelp.end())
+                                               break;
 
-               virtual void OnWhois(User* src, User* dst)
-               {
-                       if (dst->IsModeSet('h'))
-                       {
-                               ServerInstance->SendWhoisLine(src, dst, 310, std::string(src->nick)+" "+std::string(dst->nick)+" :is available for help.");
+                                       indexline.append(iter->first);
+                                       if (++column != maxcolumns)
+                                               indexline.append(longestkey - iter->first.length() + 2, ' ');
+                                       iter++;
+                               }
+                               indexmsg.push_back(indexline);
                        }
+                       cmd.help.swap(newhelp);
+
+                       ConfigTag* tag = ServerInstance->Config->ConfValue("helpmsg");
+                       cmd.nohelp = tag->getString("nohelp", "There is no help for the topic you searched for. Please try again.", 1);
                }
 
-               virtual ~ModuleHelpop()
+               void OnWhois(Whois::Context& whois) CXX11_OVERRIDE
                {
+                       if (whois.GetTarget()->IsModeSet(ho))
+                               whois.SendLine(RPL_WHOISHELPOP, "is available for help.");
                }
 
-               virtual Version GetVersion()
+               Version GetVersion() CXX11_OVERRIDE
                {
-                       return Version("/helpop Command, Works like Unreal helpop", VF_VENDOR | VF_COMMON);
+                       return Version("Provides help to users via the HELPOP command", VF_VENDOR);
                }
 };