Only assign NewServices once the duplicate check is done.

[user/henk/code/inspircd.git] / src / modules / m_hostchange.cpp

diff --git a/src/modules/m_hostchange.cpp b/src/modules/m_hostchange.cpp
index 78ef68759737f999c642fcc5accd17a8ba1ba7cb..8d7abede47bbaca538b9db5465900bd5095ce5fd 100644 (file)
--- a/src/modules/m_hostchange.cpp
+++ b/src/modules/m_hostchange.cpp
@@ -1,7 +1,7 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
- *   Copyright (C) 2013, 2018-2019 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2013, 2018-2020 Sadie Powell <sadie@witchery.services>
  *   Copyright (C) 2012-2014 Attila Molnar <attilamolnar@hush.com>
  *   Copyright (C) 2012 Robby <robby@chatbelgie.be>
  *   Copyright (C) 2009 Robin Burchell <robin+git@viroteck.net>
@@ -140,7 +140,7 @@ private:
 
                        insp::flat_set<int> ports;
                        const std::string portlist = tag->getString("ports");
-                       if (!ports.empty())
+                       if (!portlist.empty())
                        {
                                irc::portparser portrange(portlist, false);
                                while (int port = portrange.GetToken())
@@ -187,7 +187,7 @@ private:
 
        Version GetVersion() CXX11_OVERRIDE
        {
-               return Version("Provides rule-based masking of user hostnames", VF_VENDOR);
+               return Version("Allows the server administrator to define custom rules for applying hostnames to users.", VF_VENDOR);
        }
 
        void OnUserConnect(LocalUser* user) CXX11_OVERRIDE