Fix the cloaking module on C++98 compilers.

[user/henk/code/inspircd.git] / src / modules / m_hostcycle.cpp

diff --git a/src/modules/m_hostcycle.cpp b/src/modules/m_hostcycle.cpp
index 0f7405dcc8b83f45ca93428cffeadc97c3f343c0..95fa3fab35f5fb2493da8f5f592f5f0c450c79c5 100644 (file)
--- a/src/modules/m_hostcycle.cpp
+++ b/src/modules/m_hostcycle.cpp
@@ -1,8 +1,8 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
- *   Copyright (C) 2013 Attila Molnar <attilamolnar@hush.com>
- *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2017-2018 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2013-2015, 2018 Attila Molnar <attilamolnar@hush.com>
  *
  * This file is part of InspIRCd.  InspIRCd is free software: you can
  * redistribute it and/or modify it under the terms of the GNU General Public
@@ -24,13 +24,16 @@
 class ModuleHostCycle : public Module
 {
        Cap::Reference chghostcap;
+       const std::string quitmsghost;
+       const std::string quitmsgident;
 
        /** Send fake quit/join/mode messages for host or ident cycle.
         */
-       void DoHostCycle(User* user, const std::string& newident, const std::string& newhost, const char* quitmsg)
+       void DoHostCycle(User* user, const std::string& newident, const std::string& newhost, const std::string& reason)
        {
-               // GetFullHost() returns the original data at the time this function is called
-               const std::string quitline = ":" + user->GetFullHost() + " QUIT :" + quitmsg;
+               // The user has the original ident/host at the time this function is called
+               ClientProtocol::Messages::Quit quitmsg(user, reason);
+               ClientProtocol::Event quitevent(ServerInstance->GetRFCEvents().quit, quitmsg);
 
                already_sent_t silent_id = ServerInstance->Users.NextAlreadySentId();
                already_sent_t seen_id = ServerInstance->Users.NextAlreadySentId();
@@ -50,7 +53,7 @@ class ModuleHostCycle : public Module
                                if (i->second)
                                {
                                        u->already_sent = seen_id;
-                                       u->Write(quitline);
+                                       u->Send(quitevent);
                                }
                                else
                                {
@@ -65,17 +68,8 @@ class ModuleHostCycle : public Module
                {
                        Membership* memb = *i;
                        Channel* c = memb->chan;
-                       const std::string joinline = ":" + newfullhost + " JOIN " + c->name;
-                       std::string modeline;
 
-                       if (!memb->modes.empty())
-                       {
-                               modeline = ":" + (ServerInstance->Config->CycleHostsFromUser ? newfullhost : ServerInstance->Config->ServerName)
-                                       + " MODE " + c->name + " +" + memb->modes;
-
-                               for (size_t j = 0; j < memb->modes.length(); j++)
-                                       modeline.append(" ").append(user->nick);
-                       }
+                       ClientProtocol::Events::Join joinevent(memb, newfullhost);
 
                        const Channel::MemberMap& ulist = c->GetUsers();
                        for (Channel::MemberMap::const_iterator j = ulist.begin(); j != ulist.end(); ++j)
@@ -90,13 +84,11 @@ class ModuleHostCycle : public Module
 
                                if (u->already_sent != seen_id)
                                {
-                                       u->Write(quitline);
+                                       u->Send(quitevent);
                                        u->already_sent = seen_id;
                                }
 
-                               u->Write(joinline);
-                               if (!memb->modes.empty())
-                                       u->Write(modeline);
+                               u->Send(joinevent);
                        }
                }
        }
@@ -104,22 +96,24 @@ class ModuleHostCycle : public Module
  public:
        ModuleHostCycle()
                : chghostcap(this, "chghost")
+               , quitmsghost("Changing host")
+               , quitmsgident("Changing ident")
        {
        }
 
        void OnChangeIdent(User* user, const std::string& newident) CXX11_OVERRIDE
        {
-               DoHostCycle(user, newident, user->GetDisplayedHost(), "Changing ident");
+               DoHostCycle(user, newident, user->GetDisplayedHost(), quitmsgident);
        }
 
        void OnChangeHost(User* user, const std::string& newhost) CXX11_OVERRIDE
        {
-               DoHostCycle(user, user->ident, newhost, "Changing host");
+               DoHostCycle(user, user->ident, newhost, quitmsghost);
        }
 
        Version GetVersion() CXX11_OVERRIDE
        {
-               return Version("Cycles users in all their channels when their host or ident changes", VF_VENDOR);
+               return Version("Sends a fake disconnection and reconnection when a user's username (ident) or hostname changes to allow clients to update their internal caches.", VF_VENDOR);
        }
 };