]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_ident.cpp
Remove an extern, partly because it's unused, partly because it then gets shadowed...
[user/henk/code/inspircd.git] / src / modules / m_ident.cpp
index eb8f4df162cfb94cedc42aacb86a3fc3e1cff333..2c6e40c8ca3ff15337256797a56542cf31b184ab 100644 (file)
@@ -18,16 +18,6 @@ using namespace std;
 
 #include <stdio.h>
 #include <string>
-#include <stdlib.h>
-#include <time.h>
-#include <sys/types.h>
-#include <sys/socket.h>
-#include <sys/time.h>
-#include <string.h>
-#include <unistd.h>
-#include <errno.h>
-#include <fcntl.h>
-#include <poll.h>
 #include "users.h"
 #include "channels.h"
 #include "modules.h"
@@ -49,12 +39,9 @@ class RFC1413 : public InspSocket
        char ident_request[128]; // buffer used to make up the request string
  public:
 
-       // The destructor makes damn sure the socket is freed :)
-       RFC1413(userrec* user, int maxtime, Server* S) : InspSocket(user->host, 113, false, maxtime)
+       RFC1413(userrec* user, int maxtime, Server* S) : InspSocket((char*)inet_ntoa(user->ip4), 113, false, maxtime), Srv(S), u(user)
        {
-               Srv->Log(DEBUG,"Ident: associated with user "+std::string(user->nick));
-               u = user;
-               Srv = S;
+               Srv->Log(DEBUG,"Ident: associated.");
        }
 
        virtual void OnTimeout()
@@ -67,12 +54,9 @@ class RFC1413 : public InspSocket
 
        virtual bool OnDataReady()
        {
-               std::string databuf = this->Read();
-               if (databuf != "")
+               char* ibuf = this->Read();
+               if (ibuf)
                {
-                       char ibuf[1024];
-                       strlcpy(ibuf,databuf.c_str(),1024);
-                       Srv->Log(DEBUG,"Received ident response");
                        char* savept;
                        char* section = strtok_r(ibuf,":",&savept);
                        while (section)
@@ -87,17 +71,16 @@ class RFC1413 : public InspSocket
                                                if (section)
                                                {
                                                        while (*section == ' ') section++; // strip leading spaces
-                                                        int t = strlen(section);
-                                                        for (int j = 0; j < t; j++)
-                                                        if ((section[j] < 33) || (section[j]>126))
-                                                               section[j] = '\0'; // truncate at invalid chars
-                                                        if (strlen(section))
-                                                        {
-                                                               strlcpy(u->ident,section,IDENTMAX);
-                                                                Srv->Log(DEBUG,"IDENT SET: "+std::string(u->ident));
-                                                                Srv->SendServ(u->fd,"NOTICE "+std::string(u->nick)+" :*** Found your ident: "+std::string(u->ident));
-                                                        }
-                                                        return false;
+                                                       for (char* j = section; *j; j++)
+                                                       if ((*j < 33) || (*j > 126))
+                                                               *j = '\0'; // truncate at invalid chars
+                                                       if (*section)
+                                                       {
+                                                               strlcpy(u->ident,section,IDENTMAX);
+                                                               Srv->Log(DEBUG,"IDENT SET: "+std::string(u->ident));
+                                                               Srv->SendServ(u->fd,"NOTICE "+std::string(u->nick)+" :*** Found your ident: "+std::string(u->ident));
+                                                       }
+                                                       return false;
                                                }
                                        }
                                }
@@ -114,6 +97,11 @@ class RFC1413 : public InspSocket
                u->Shrink("ident_data");
        }
 
+       virtual void OnError(InspSocketError e)
+       {
+               u->Shrink("ident_data");
+       }
+
        virtual bool OnConnected()
        {
                uslen = sizeof(sock_us);
@@ -160,49 +148,76 @@ class ModuleIdent : public Module
 
        void Implements(char* List)
        {
-               List[I_OnRehash] = List[I_OnUserRegister] = List[I_OnCheckReady] = List[I_OnUserDisconnect] = 1;
+               List[I_OnCleanup] = List[I_OnRehash] = List[I_OnUserRegister] = List[I_OnCheckReady] = List[I_OnUserDisconnect] = 1;
        }
 
-       virtual void OnRehash(std::string parameter)
+       virtual void OnRehash(const std::string &parameter)
        {
                ReadSettings();
        }
 
        virtual void OnUserRegister(userrec* user)
        {
-               // when the new user connects, before they authenticate with USER/NICK/PASS, we do
-               // their ident lookup. We do this by instantiating an object of type RFC1413, which
-               // is derived from InspSocket, and inserting it into the socket engine using the
-               // Server::AddSocket() call.
+               /*
+                * when the new user connects, before they authenticate with USER/NICK/PASS, we do
+                * their ident lookup. We do this by instantiating an object of type RFC1413, which
+                * is derived from InspSocket, and inserting it into the socket engine using the
+                * Server::AddSocket() call.
+                */
                Srv->SendServ(user->fd,"NOTICE "+std::string(user->nick)+" :*** Looking up your ident...");
                RFC1413* ident = new RFC1413(user, IdentTimeout, Srv);
-               user->Extend("ident_data", (char*)ident);
-               Srv->AddSocket(ident);
+               if (ident->GetState() != I_ERROR)
+               {
+                       user->Extend("ident_data", (char*)ident);
+                       Srv->AddSocket(ident);
+               }
+               else
+               {
+                       Srv->SendServ(user->fd,"NOTICE "+std::string(user->nick)+" :*** Could not find your ident, using "+std::string(user->ident)+" instead.");
+                       delete ident;
+               }
        }
 
        virtual bool OnCheckReady(userrec* user)
        {
-               // The socket engine will clean up their ident request for us when it completes,
-               // either due to timeout or due to closing, so, we just hold them until they dont
-               // have an ident field any more.
+               /*
+                * The socket engine will clean up their ident request for us when it completes,
+                * either due to timeout or due to closing, so, we just hold them until they dont
+                * have an ident field any more.
+                */
                RFC1413* ident = (RFC1413*)user->GetExt("ident_data");
                return (!ident);
        }
 
-        virtual void OnUserDisconnect(userrec* user)
-        {
-                // when the user quits tidy up any ident lookup they have pending to keep things tidy.
-                // When we call RemoveSocket, the abstractions tied into the system evnetually work their
-               // way to RFC1459::OnClose(), which shrinks off the ident_data for us, so we dont need
-               // to do it here. If we don't tidy this up, there may still be lingering idents for users
-               // who have quit, as class RFC1459 is only loosely bound to userrec* via a pair of pointers
-               // and this would leave at least one of the invalid ;)
+       virtual void OnCleanup(int target_type, void* item)
+       {
+               if (target_type == TYPE_USER)
+               {
+                       userrec* user = (userrec*)item;
+                       RFC1413* ident = (RFC1413*)user->GetExt("ident_data");
+                       if (ident)
+                       {
+                               Srv->RemoveSocket(ident);
+                       }
+               }
+       }
+
+       virtual void OnUserDisconnect(userrec* user)
+       {
+               /*
+                * when the user quits tidy up any ident lookup they have pending to keep things tidy.
+                * When we call RemoveSocket, the abstractions tied into the system evnetually work their
+                * way to RFC1459::OnClose(), which shrinks off the ident_data for us, so we dont need
+                * to do it here. If we don't tidy this up, there may still be lingering idents for users
+                * who have quit, as class RFC1459 is only loosely bound to userrec* via a pair of pointers
+                * and this would leave at least one of the invalid ;)
+                */
                RFC1413* ident = (RFC1413*)user->GetExt("ident_data");
-                if (ident)
-                {
+               if (ident)
+               {
                        Srv->RemoveSocket(ident);
-                }
-        }
+               }
+       }
        
        virtual ~ModuleIdent()
        {