]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_ident.cpp
Replace hardcoded mode letters, part 3
[user/henk/code/inspircd.git] / src / modules / m_ident.cpp
index f38ad2241a774527f55c113206f17a915351b9e7..737d47b52dfbb22eae48701afee422009ff09f62 100644 (file)
@@ -24,8 +24,6 @@
 
 #include "inspircd.h"
 
-/* $ModDesc: Provides support for RFC1413 ident lookups */
-
 /* --------------------------------------------------------------
  * Note that this is the third incarnation of m_ident. The first
  * two attempts were pretty crashy, mainly due to the fact we tried
@@ -142,9 +140,9 @@ class IdentRequestSocket : public EventHandler
                }
        }
 
-       virtual void OnConnected()
+       void OnConnected()
        {
-               ServerInstance->Logs->Log("m_ident",LOG_DEBUG,"OnConnected()");
+               ServerInstance->Logs->Log("m_ident", LOG_DEBUG, "OnConnected()");
                ServerInstance->SE->ChangeEventMask(this, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
 
                char req[32];
@@ -165,7 +163,7 @@ class IdentRequestSocket : public EventHandler
                        done = true;
        }
 
-       virtual void HandleEvent(EventType et, int errornum = 0)
+       void HandleEvent(EventType et, int errornum = 0)
        {
                switch (et)
                {
@@ -179,7 +177,7 @@ class IdentRequestSocket : public EventHandler
                        break;
                        case EVENT_ERROR:
                                /* fd error event, ohshi- */
-                               ServerInstance->Logs->Log("m_ident",LOG_DEBUG,"EVENT_ERROR");
+                               ServerInstance->Logs->Log("m_ident", LOG_DEBUG, "EVENT_ERROR");
                                /* We *must* Close() here immediately or we get a
                                 * huge storm of EVENT_ERROR events!
                                 */
@@ -196,7 +194,7 @@ class IdentRequestSocket : public EventHandler
                 */
                if (GetFd() > -1)
                {
-                       ServerInstance->Logs->Log("m_ident",LOG_DEBUG,"Close ident socket %d", GetFd());
+                       ServerInstance->Logs->Log("m_ident", LOG_DEBUG, "Close ident socket %d", GetFd());
                        ServerInstance->SE->DelFd(this);
                        ServerInstance->SE->Close(GetFd());
                        this->SetFd(-1);
@@ -213,8 +211,8 @@ class IdentRequestSocket : public EventHandler
                /* We don't really need to buffer for incomplete replies here, since IDENT replies are
                 * extremely short - there is *no* sane reason it'd be in more than one packet
                 */
-               char ibuf[MAXBUF];
-               int recvresult = ServerInstance->SE->Recv(this, ibuf, MAXBUF-1, 0);
+               char ibuf[256];
+               int recvresult = ServerInstance->SE->Recv(this, ibuf, sizeof(ibuf)-1, 0);
 
                /* Close (but don't delete from memory) our socket
                 * and flag as done since the ident lookup has finished
@@ -228,7 +226,7 @@ class IdentRequestSocket : public EventHandler
                if (recvresult < 3)
                        return;
 
-               ServerInstance->Logs->Log("m_ident",LOG_DEBUG,"ReadResponse()");
+               ServerInstance->Logs->Log("m_ident", LOG_DEBUG, "ReadResponse()");
 
                /* Truncate at the first null character, but first make sure
                 * there is at least one null char (at the end of the buffer).
@@ -278,7 +276,7 @@ class ModuleIdent : public Module
        {
        }
 
-       void init()
+       void init() CXX11_OVERRIDE
        {
                ServerInstance->Modules->AddService(ext);
                OnRehash(NULL);
@@ -289,25 +287,25 @@ class ModuleIdent : public Module
                ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
        }
 
-       virtual Version GetVersion()
+       Version GetVersion() CXX11_OVERRIDE
        {
                return Version("Provides support for RFC1413 ident lookups", VF_VENDOR);
        }
 
-       virtual void OnRehash(User *user)
+       void OnRehash(User *user) CXX11_OVERRIDE
        {
                RequestTimeout = ServerInstance->Config->ConfValue("ident")->getInt("timeout", 5);
                if (!RequestTimeout)
                        RequestTimeout = 5;
        }
 
-       void OnUserInit(LocalUser *user)
+       void OnUserInit(LocalUser *user) CXX11_OVERRIDE
        {
                ConfigTag* tag = user->MyClass->config;
                if (!tag->getBool("useident", true))
                        return;
 
-               user->WriteServ("NOTICE Auth :*** Looking up your ident...");
+               user->WriteNotice("*** Looking up your ident...");
 
                try
                {
@@ -316,7 +314,7 @@ class ModuleIdent : public Module
                }
                catch (ModuleException &e)
                {
-                       ServerInstance->Logs->Log("m_ident",LOG_DEBUG,"Ident exception: %s", e.GetReason());
+                       ServerInstance->Logs->Log("m_ident", LOG_DEBUG, "Ident exception: %s", e.GetReason());
                }
        }
 
@@ -324,17 +322,17 @@ class ModuleIdent : public Module
         * creating a Timer object and especially better than creating a
         * Timer per ident lookup!
         */
-       virtual ModResult OnCheckReady(LocalUser *user)
+       ModResult OnCheckReady(LocalUser *user) CXX11_OVERRIDE
        {
                /* Does user have an ident socket attached at all? */
                IdentRequestSocket *isock = ext.get(user);
                if (!isock)
                {
-                       ServerInstance->Logs->Log("m_ident",LOG_DEBUG, "No ident socket :(");
+                       ServerInstance->Logs->Log("m_ident", LOG_DEBUG, "No ident socket :(");
                        return MOD_RES_PASSTHRU;
                }
 
-               ServerInstance->Logs->Log("m_ident",LOG_DEBUG, "Has ident_socket");
+               ServerInstance->Logs->Log("m_ident", LOG_DEBUG, "Has ident_socket");
 
                time_t compare = isock->age;
                compare += RequestTimeout;
@@ -343,43 +341,44 @@ class ModuleIdent : public Module
                if (ServerInstance->Time() >= compare)
                {
                        /* Ident timeout */
-                       user->WriteServ("NOTICE Auth :*** Ident request timed out.");
-                       ServerInstance->Logs->Log("m_ident",LOG_DEBUG, "Timeout");
+                       user->WriteNotice("*** Ident request timed out.");
+                       ServerInstance->Logs->Log("m_ident", LOG_DEBUG, "Timeout");
                }
                else if (!isock->HasResult())
                {
                        // time still good, no result yet... hold the registration
-                       ServerInstance->Logs->Log("m_ident",LOG_DEBUG, "No result yet");
+                       ServerInstance->Logs->Log("m_ident", LOG_DEBUG, "No result yet");
                        return MOD_RES_DENY;
                }
 
-               ServerInstance->Logs->Log("m_ident",LOG_DEBUG, "Yay, result!");
+               ServerInstance->Logs->Log("m_ident", LOG_DEBUG, "Yay, result!");
 
                /* wooo, got a result (it will be good, or bad) */
                if (isock->result.empty())
                {
                        user->ident.insert(0, 1, '~');
-                       user->WriteServ("NOTICE Auth :*** Could not find your ident, using %s instead.", user->ident.c_str());
+                       user->WriteNotice("*** Could not find your ident, using " + user->ident + " instead.");
                }
                else
                {
                        user->ident = isock->result;
-                       user->WriteServ("NOTICE Auth :*** Found your ident, '%s'", user->ident.c_str());
+                       user->WriteNotice("*** Found your ident, '" + user->ident + "'");
                }
 
+               user->InvalidateCache();
                isock->Close();
                ext.unset(user);
                return MOD_RES_PASSTHRU;
        }
 
-       ModResult OnSetConnectClass(LocalUser* user, ConnectClass* myclass)
+       ModResult OnSetConnectClass(LocalUser* user, ConnectClass* myclass) CXX11_OVERRIDE
        {
                if (myclass->config->getBool("requireident") && user->ident[0] == '~')
                        return MOD_RES_DENY;
                return MOD_RES_PASSTHRU;
        }
 
-       virtual void OnCleanup(int target_type, void *item)
+       void OnCleanup(int target_type, void *item) CXX11_OVERRIDE
        {
                /* Module unloading, tidy up users */
                if (target_type == TYPE_USER)
@@ -390,7 +389,7 @@ class ModuleIdent : public Module
                }
        }
 
-       virtual void OnUserDisconnect(LocalUser *user)
+       void OnUserDisconnect(LocalUser *user) CXX11_OVERRIDE
        {
                /* User disconnect (generic socket detatch event) */
                IdentRequestSocket *isock = ext.get(user);