Only assign NewServices once the duplicate check is done.

[user/henk/code/inspircd.git] / src / modules / m_ident.cpp

diff --git a/src/modules/m_ident.cpp b/src/modules/m_ident.cpp
index df80cd82f910f0c90bff270a9e02d8b5054d4353..73dc64cf02dd02be4ddb816e12a802e5ac32b8cf 100644 (file)
--- a/src/modules/m_ident.cpp
+++ b/src/modules/m_ident.cpp
@@ -1,7 +1,7 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
- *   Copyright (C) 2013, 2018-2019 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2013, 2018-2020 Sadie Powell <sadie@witchery.services>
  *   Copyright (C) 2012-2015 Attila Molnar <attilamolnar@hush.com>
  *   Copyright (C) 2012-2013 Robby <robby@chatbelgie.be>
  *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
@@ -61,7 +61,7 @@ enum
  * our ident lookup class that is outside of this module, or out-
  * side of the control of the class. There are no timers, internal
  * events, or such, which will cause the socket to be deleted,
- * queued for deletion, etc. In fact, theres not even any queueing!
+ * queued for deletion, etc. In fact, there's not even any queueing!
  *
  * Using this framework we have a much more stable module.
  *
@@ -183,7 +183,7 @@ class IdentRequestSocket : public EventHandler
 
        void Close()
        {
-               /* Remove ident socket from engine, and close it, but dont detatch it
+               /* Remove ident socket from engine, and close it, but dont detach it
                 * from its parent user class, or attempt to delete its memory.
                 */
                if (HasFd())
@@ -410,7 +410,11 @@ class ModuleIdent : public Module
        ModResult OnSetConnectClass(LocalUser* user, ConnectClass* myclass) CXX11_OVERRIDE
        {
                if (myclass->config->getBool("requireident") && state.get(user) != IDENT_FOUND)
+               {
+                       ServerInstance->Logs->Log("CONNECTCLASS", LOG_DEBUG, "The %s connect class is not suitable as it requires an identd response",
+                               myclass->GetName().c_str());
                        return MOD_RES_DENY;
+               }
                return MOD_RES_PASSTHRU;
        }