Fix for bug #791, if an error is set treat this as 'could not get certificate'

[user/henk/code/inspircd.git] / src / modules / m_ident.cpp

diff --git a/src/modules/m_ident.cpp b/src/modules/m_ident.cpp
index 3eded4daf59e2eb7a21eb59076d8c6647a05bfb3..90b09a46d681abd1bece8d8257739037c1307df3 100644 (file)
--- a/src/modules/m_ident.cpp
+++ b/src/modules/m_ident.cpp
@@ -2,8 +2,8 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *         the file COPYING for details.
@@ -12,9 +12,6 @@
  */
 
 #include "inspircd.h"
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
 
 /* $ModDesc: Provides support for RFC1413 ident lookups */
 
@@ -77,12 +74,10 @@
 class IdentRequestSocket : public EventHandler
 {
  private:
-
-        User *user;                    /* User we are attached to */
-        InspIRCd* ServerInstance;      /* Server instance */
-        bool done;                     /* True if lookup is finished */
-        std::string result;            /* Holds the ident string if done */
-
+       User *user;                     /* User we are attached to */
+       InspIRCd* ServerInstance;       /* Server instance */
+       bool done;                      /* True if lookup is finished */
+       std::string result;             /* Holds the ident string if done */
  public:
 
        IdentRequestSocket(InspIRCd *Server, User* u, const std::string &bindip) : user(u), ServerInstance(Server), result(u->ident)
@@ -103,6 +98,8 @@ class IdentRequestSocket : public EventHandler
                if (GetFd() == -1)
                        throw ModuleException("Could not create socket");
 
+               done = false;
+
                /* We allocate two of these because sizeof(sockaddr_in6) > sizeof(sockaddr_in) */
                sockaddr* s = new sockaddr[2];
                sockaddr* addr = new sockaddr[2];
@@ -337,32 +334,51 @@ class ModuleIdent : public Module
 {
  private:
        int RequestTimeout;
+       ConfigReader *Conf;
  public:
-       ModuleIdent(InspIRCd *Me)
-               : Module(Me)
+       ModuleIdent(InspIRCd *Me) : Module(Me)
        {
+               Conf = new ConfigReader(ServerInstance);
                OnRehash(NULL, "");
                Implementation eventlist[] = { I_OnRehash, I_OnUserRegister, I_OnCheckReady, I_OnCleanup, I_OnUserDisconnect };
                ServerInstance->Modules->Attach(eventlist, this, 5);
        }
 
-       virtual Version GetVersion()
+       ~ModuleIdent()
        {
-               return Version(1, 2, 1, 0, VF_VENDOR, API_VERSION);
+               delete Conf;
        }
 
+       virtual Version GetVersion()
+       {
+               return Version("$Id$", VF_VENDOR, API_VERSION);
+       }
 
        virtual void OnRehash(User *user, const std::string &param)
        {
-               ConfigReader MyConf(ServerInstance);
+               delete Conf;
+               Conf = new ConfigReader(ServerInstance);
 
-               RequestTimeout = MyConf.ReadInteger("ident", "timeout", 0, true);
+               RequestTimeout = Conf->ReadInteger("ident", "timeout", 0, true);
                if (!RequestTimeout)
                        RequestTimeout = 5;
        }
 
        virtual int OnUserRegister(User *user)
        {
+               for (int j = 0; j < Conf->Enumerate("connect"); j++)
+               {
+                       std::string hostn = Conf->ReadValue("connect","allow",j);
+                       /* XXX: Fixme: does not respect port, limit, etc */
+                       if ((InspIRCd::MatchCIDR(user->GetIPString(),hostn, ascii_case_insensitive_map)) || (InspIRCd::Match(user->host,hostn, ascii_case_insensitive_map)))
+                       {
+                               bool useident = Conf->ReadFlag("connect", "useident", "yes", j);
+
+                               if (!useident)
+                                       return 0;
+                       }
+               }
+
                /* User::ident is currently the username field from USER; with m_ident loaded, that
                 * should be preceded by a ~. The field is actually IdentMax+2 characters wide. */
                if (user->ident.length() > ServerInstance->Config->Limits.IdentMax + 1)