]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_ident.cpp
Avoid doing "IP changed" event stuff on quitting users.
[user/henk/code/inspircd.git] / src / modules / m_ident.cpp
index 6e8fd3367d63c02d451ac2e7a5b69b264dd68e04..a0d5443d6050ed606cd0568c0283dec73d77fb0c 100644 (file)
@@ -1,11 +1,13 @@
 /*
  * InspIRCd -- Internet Relay Chat Daemon
  *
+ *   Copyright (C) 2013, 2018-2020 Sadie Powell <sadie@witchery.services>
+ *   Copyright (C) 2012-2015 Attila Molnar <attilamolnar@hush.com>
+ *   Copyright (C) 2012-2013 Robby <robby@chatbelgie.be>
  *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
- *   Copyright (C) 2007, 2009 John Brooks <john.brooks@dereferenced.net>
- *   Copyright (C) 2006-2008 Robin Burchell <robin+git@viroteck.net>
- *   Copyright (C) 2005-2008 Craig Edwards <craigedwards@brainbox.cc>
- *   Copyright (C) 2008 Thomas Stagner <aquanight@inspircd.org>
+ *   Copyright (C) 2008 Robin Burchell <robin+git@viroteck.net>
+ *   Copyright (C) 2007, 2010 Craig Edwards <brain@inspircd.org>
+ *   Copyright (C) 2007 John Brooks <special@inspircd.org>
  *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
  *
  * This file is part of InspIRCd.  InspIRCd is free software: you can
 
 #include "inspircd.h"
 
-/* $ModDesc: Provides support for RFC1413 ident lookups */
+enum
+{
+       // Either the ident looup has not started yet or the user is registered.
+       IDENT_UNKNOWN = 0,
+
+       // Ident lookups are not enabled and a user has been marked as being skipped.
+       IDENT_SKIPPED,
+
+       // Ident looups are not enabled and a user has been an insecure ident prefix.
+       IDENT_PREFIXED,
+
+       // An ident lookup was done and an ident was found.
+       IDENT_FOUND,
+
+       // An ident lookup was done but no ident was found
+       IDENT_MISSING
+};
 
 /* --------------------------------------------------------------
  * Note that this is the third incarnation of m_ident. The first
@@ -43,7 +61,7 @@
  * our ident lookup class that is outside of this module, or out-
  * side of the control of the class. There are no timers, internal
  * events, or such, which will cause the socket to be deleted,
- * queued for deletion, etc. In fact, theres not even any queueing!
+ * queued for deletion, etc. In fact, there's not even any queueing!
  *
  * Using this framework we have a much more stable module.
  *
@@ -94,9 +112,8 @@ class IdentRequestSocket : public EventHandler
        {
                age = ServerInstance->Time();
 
-               SetFd(socket(user->server_sa.sa.sa_family, SOCK_STREAM, 0));
-
-               if (GetFd() == -1)
+               SetFd(socket(user->server_sa.family(), SOCK_STREAM, 0));
+               if (!HasFd())
                        throw ModuleException("Could not create socket");
 
                done = false;
@@ -107,7 +124,7 @@ class IdentRequestSocket : public EventHandler
                memcpy(&bindaddr, &user->server_sa, sizeof(bindaddr));
                memcpy(&connaddr, &user->client_sa, sizeof(connaddr));
 
-               if (connaddr.sa.sa_family == AF_INET6)
+               if (connaddr.family() == AF_INET6)
                {
                        bindaddr.in6.sin6_port = 0;
                        connaddr.in6.sin6_port = htons(113);
@@ -119,39 +136,38 @@ class IdentRequestSocket : public EventHandler
                }
 
                /* Attempt to bind (ident requests must come from the ip the query is referring to */
-               if (ServerInstance->SE->Bind(GetFd(), bindaddr) < 0)
+               if (SocketEngine::Bind(GetFd(), bindaddr) < 0)
                {
                        this->Close();
                        throw ModuleException("failed to bind()");
                }
 
-               ServerInstance->SE->NonBlocking(GetFd());
+               SocketEngine::NonBlocking(GetFd());
 
                /* Attempt connection (nonblocking) */
-               if (ServerInstance->SE->Connect(this, &connaddr.sa, connaddr.sa_size()) == -1 && errno != EINPROGRESS)
+               if (SocketEngine::Connect(this, connaddr) == -1 && errno != EINPROGRESS)
                {
                        this->Close();
                        throw ModuleException("connect() failed");
                }
 
                /* Add fd to socket engine */
-               if (!ServerInstance->SE->AddFd(this, FD_WANT_NO_READ | FD_WANT_POLL_WRITE))
+               if (!SocketEngine::AddFd(this, FD_WANT_NO_READ | FD_WANT_POLL_WRITE))
                {
                        this->Close();
                        throw ModuleException("out of fds");
                }
        }
 
-       void OnConnected()
+       void OnEventHandlerWrite() CXX11_OVERRIDE
        {
-               ServerInstance->Logs->Log("m_ident",LOG_DEBUG,"OnConnected()");
-               ServerInstance->SE->ChangeEventMask(this, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
+               SocketEngine::ChangeEventMask(this, FD_WANT_POLL_READ | FD_WANT_NO_WRITE);
 
                char req[32];
 
                /* Build request in the form 'localport,remoteport\r\n' */
                int req_size;
-               if (user->client_sa.sa.sa_family == AF_INET6)
+               if (user->client_sa.family() == AF_INET6)
                        req_size = snprintf(req, sizeof(req), "%d,%d\r\n",
                                ntohs(user->client_sa.in6.sin6_port), ntohs(user->server_sa.in6.sin6_port));
                else
@@ -161,45 +177,19 @@ class IdentRequestSocket : public EventHandler
                /* Send failed if we didnt write the whole ident request --
                 * might as well give up if this happens!
                 */
-               if (ServerInstance->SE->Send(this, req, req_size, 0) < req_size)
+               if (SocketEngine::Send(this, req, req_size, 0) < req_size)
                        done = true;
        }
 
-       void HandleEvent(EventType et, int errornum = 0)
-       {
-               switch (et)
-               {
-                       case EVENT_READ:
-                               /* fd readable event, received ident response */
-                               ReadResponse();
-                       break;
-                       case EVENT_WRITE:
-                               /* fd writeable event, successfully connected! */
-                               OnConnected();
-                       break;
-                       case EVENT_ERROR:
-                               /* fd error event, ohshi- */
-                               ServerInstance->Logs->Log("m_ident",LOG_DEBUG,"EVENT_ERROR");
-                               /* We *must* Close() here immediately or we get a
-                                * huge storm of EVENT_ERROR events!
-                                */
-                               Close();
-                               done = true;
-                       break;
-               }
-       }
-
        void Close()
        {
-               /* Remove ident socket from engine, and close it, but dont detatch it
+               /* Remove ident socket from engine, and close it, but dont detach it
                 * from its parent user class, or attempt to delete its memory.
                 */
-               if (GetFd() > -1)
+               if (HasFd())
                {
-                       ServerInstance->Logs->Log("m_ident",LOG_DEBUG,"Close ident socket %d", GetFd());
-                       ServerInstance->SE->DelFd(this);
-                       ServerInstance->SE->Close(GetFd());
-                       this->SetFd(-1);
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "Close ident socket %d", GetFd());
+                       SocketEngine::Close(this);
                }
        }
 
@@ -208,13 +198,13 @@ class IdentRequestSocket : public EventHandler
                return done;
        }
 
-       void ReadResponse()
+       void OnEventHandlerRead() CXX11_OVERRIDE
        {
                /* We don't really need to buffer for incomplete replies here, since IDENT replies are
                 * extremely short - there is *no* sane reason it'd be in more than one packet
                 */
-               char ibuf[MAXBUF];
-               int recvresult = ServerInstance->SE->Recv(this, ibuf, MAXBUF-1, 0);
+               char ibuf[256];
+               int recvresult = SocketEngine::Recv(this, ibuf, sizeof(ibuf)-1, 0);
 
                /* Close (but don't delete from memory) our socket
                 * and flag as done since the ident lookup has finished
@@ -228,7 +218,7 @@ class IdentRequestSocket : public EventHandler
                if (recvresult < 3)
                        return;
 
-               ServerInstance->Logs->Log("m_ident",LOG_DEBUG,"ReadResponse()");
+               ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "ReadResponse()");
 
                /* Truncate at the first null character, but first make sure
                 * there is at least one null char (at the end of the buffer).
@@ -260,63 +250,107 @@ class IdentRequestSocket : public EventHandler
                         * we're done.
                         */
                        result += *i;
-                       if (!ServerInstance->IsIdent(result.c_str()))
+                       if (!ServerInstance->IsIdent(result))
                        {
                                result.erase(result.end()-1);
                                break;
                        }
                }
        }
+
+       void OnEventHandlerError(int errornum) CXX11_OVERRIDE
+       {
+               Close();
+               done = true;
+       }
+
+       CullResult cull() CXX11_OVERRIDE
+       {
+               Close();
+               return EventHandler::cull();
+       }
 };
 
 class ModuleIdent : public Module
 {
-       int RequestTimeout;
-       SimpleExtItem<IdentRequestSocket> ext;
- public:
-       ModuleIdent() : ext("ident_socket", this)
+ private:
+       unsigned int timeout;
+       bool prefixunqueried;
+       SimpleExtItem<IdentRequestSocket, stdalgo::culldeleter> socket;
+       LocalIntExt state;
+
+       static void PrefixIdent(LocalUser* user)
        {
+               // Check that they haven't been prefixed already.
+               if (user->ident[0] == '~')
+                       return;
+
+               // All invalid usernames are prefixed with a tilde.
+               std::string newident(user->ident);
+               newident.insert(newident.begin(), '~');
+
+               // If the username is too long then truncate it.
+               if (newident.length() > ServerInstance->Config->Limits.IdentMax)
+                       newident.erase(ServerInstance->Config->Limits.IdentMax);
+
+               // Apply the new username.
+               user->ChangeIdent(newident);
        }
 
-       void init() CXX11_OVERRIDE
+ public:
+       ModuleIdent()
+               : socket("ident_socket", ExtensionItem::EXT_USER, this)
+               , state("ident_state", ExtensionItem::EXT_USER, this)
        {
-               ServerInstance->Modules->AddService(ext);
-               OnRehash(NULL);
-               Implementation eventlist[] = {
-                       I_OnRehash, I_OnUserInit, I_OnCheckReady,
-                       I_OnUserDisconnect, I_OnSetConnectClass
-               };
-               ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
        }
 
        Version GetVersion() CXX11_OVERRIDE
        {
-               return Version("Provides support for RFC1413 ident lookups", VF_VENDOR);
+               return Version("Allows the usernames (idents) of users to be looked up using the RFC 1413 Identification Protocol.", VF_VENDOR);
        }
 
-       void OnRehash(User *user) CXX11_OVERRIDE
+       void ReadConfig(ConfigStatus& status) CXX11_OVERRIDE
        {
-               RequestTimeout = ServerInstance->Config->ConfValue("ident")->getInt("timeout", 5);
-               if (!RequestTimeout)
-                       RequestTimeout = 5;
+               ConfigTag* tag = ServerInstance->Config->ConfValue("ident");
+               timeout = tag->getDuration("timeout", 5, 1, 60);
+               prefixunqueried = tag->getBool("prefixunqueried");
        }
 
-       void OnUserInit(LocalUser *user) CXX11_OVERRIDE
+       void OnSetUserIP(LocalUser* user) CXX11_OVERRIDE
        {
+               IdentRequestSocket* isock = socket.get(user);
+               if (isock)
+               {
+                       // If an ident lookup request was in progress then cancel it.
+                       isock->Close();
+                       socket.unset(user);
+               }
+
+               // The ident protocol requires that clients are connecting over a protocol with ports.
+               if (user->client_sa.family() != AF_INET && user->client_sa.family() != AF_INET6)
+                       return;
+
+               // We don't want to look this up once the user has connected.
+               if (user->registered == REG_ALL || user->quitting)
+                       return;
+
                ConfigTag* tag = user->MyClass->config;
                if (!tag->getBool("useident", true))
+               {
+                       state.set(user, IDENT_SKIPPED);
                        return;
+               }
 
                user->WriteNotice("*** Looking up your ident...");
 
                try
                {
-                       IdentRequestSocket *isock = new IdentRequestSocket(IS_LOCAL(user));
-                       ext.set(user, isock);
+                       isock = new IdentRequestSocket(user);
+                       socket.set(user, isock);
                }
                catch (ModuleException &e)
                {
-                       ServerInstance->Logs->Log("m_ident",LOG_DEBUG,"Ident exception: %s", e.GetReason());
+                       ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "Ident exception: " + e.GetReason());
                }
        }
 
@@ -327,79 +361,67 @@ class ModuleIdent : public Module
        ModResult OnCheckReady(LocalUser *user) CXX11_OVERRIDE
        {
                /* Does user have an ident socket attached at all? */
-               IdentRequestSocket *isock = ext.get(user);
+               IdentRequestSocket* isock = socket.get(user);
                if (!isock)
                {
-                       ServerInstance->Logs->Log("m_ident",LOG_DEBUG, "No ident socket :(");
+                       if (prefixunqueried && state.get(user) == IDENT_SKIPPED)
+                       {
+                               PrefixIdent(user);
+                               state.set(user, IDENT_PREFIXED);
+                       }
                        return MOD_RES_PASSTHRU;
                }
 
-               ServerInstance->Logs->Log("m_ident",LOG_DEBUG, "Has ident_socket");
-
-               time_t compare = isock->age;
-               compare += RequestTimeout;
+               time_t compare = isock->age + timeout;
 
                /* Check for timeout of the socket */
                if (ServerInstance->Time() >= compare)
                {
                        /* Ident timeout */
-                       user->WriteNotice("*** Ident request timed out.");
-                       ServerInstance->Logs->Log("m_ident",LOG_DEBUG, "Timeout");
+                       state.set(user, IDENT_MISSING);
+                       PrefixIdent(user);
+                       user->WriteNotice("*** Ident lookup timed out, using " + user->ident + " instead.");
                }
                else if (!isock->HasResult())
                {
                        // time still good, no result yet... hold the registration
-                       ServerInstance->Logs->Log("m_ident",LOG_DEBUG, "No result yet");
                        return MOD_RES_DENY;
                }
 
-               ServerInstance->Logs->Log("m_ident",LOG_DEBUG, "Yay, result!");
-
                /* wooo, got a result (it will be good, or bad) */
-               if (isock->result.empty())
+               else if (isock->result.empty())
                {
-                       user->ident.insert(0, 1, '~');
+                       state.set(user, IDENT_MISSING);
+                       PrefixIdent(user);
                        user->WriteNotice("*** Could not find your ident, using " + user->ident + " instead.");
                }
                else
                {
-                       user->ident = isock->result;
+                       state.set(user, IDENT_FOUND);
+                       user->ChangeIdent(isock->result);
                        user->WriteNotice("*** Found your ident, '" + user->ident + "'");
                }
 
-               user->InvalidateCache();
                isock->Close();
-               ext.unset(user);
+               socket.unset(user);
                return MOD_RES_PASSTHRU;
        }
 
        ModResult OnSetConnectClass(LocalUser* user, ConnectClass* myclass) CXX11_OVERRIDE
        {
-               if (myclass->config->getBool("requireident") && user->ident[0] == '~')
-                       return MOD_RES_DENY;
-               return MOD_RES_PASSTHRU;
-       }
-
-       void OnCleanup(int target_type, void *item) CXX11_OVERRIDE
-       {
-               /* Module unloading, tidy up users */
-               if (target_type == TYPE_USER)
+               if (myclass->config->getBool("requireident") && state.get(user) != IDENT_FOUND)
                {
-                       LocalUser* user = IS_LOCAL((User*) item);
-                       if (user)
-                               OnUserDisconnect(user);
+                       ServerInstance->Logs->Log("CONNECTCLASS", LOG_DEBUG, "The %s connect class is not suitable as it requires an identd response",
+                               myclass->GetName().c_str());
+                       return MOD_RES_DENY;
                }
+               return MOD_RES_PASSTHRU;
        }
 
-       void OnUserDisconnect(LocalUser *user) CXX11_OVERRIDE
+       void OnUserConnect(LocalUser* user) CXX11_OVERRIDE
        {
-               /* User disconnect (generic socket detatch event) */
-               IdentRequestSocket *isock = ext.get(user);
-               if (isock)
-               {
-                       isock->Close();
-                       ext.unset(user);
-               }
+               // Clear this as it is no longer necessary.
+               state.unset(user);
        }
 };