Annotations

[user/henk/code/inspircd.git] / src / modules / m_knock.cpp

diff --git a/src/modules/m_knock.cpp b/src/modules/m_knock.cpp
index 7d0f8ea4c511239a988bcbce252af84be6430130..1e490ad12a9bdedafd5390c6c689ab3630622674 100644 (file)
--- a/src/modules/m_knock.cpp
+++ b/src/modules/m_knock.cpp
@@ -21,32 +21,30 @@ using namespace std;
 #include "users.h"
 #include "channels.h"
 #include "modules.h"
-#include "helperfuncs.h"
 #include "configreader.h"
 #include "inspircd.h"
 
 /* $ModDesc: Provides support for /KNOCK and mode +K */
 
-static Server *Srv;
-extern InspIRCd* ServerInstance;
-
+/** Handles the /KNOCK command
+ */
 class cmd_knock : public command_t
 {
  public:
-       cmd_knock () : command_t("KNOCK", 0, 2)
+       cmd_knock (InspIRCd* Instance) : command_t(Instance,"KNOCK", 0, 2)
        {
                this->source = "m_knock.so";
                syntax = "<channel> <reason>";
        }
        
-       void Handle (const char** parameters, int pcnt, userrec *user)
+       CmdResult Handle (const char** parameters, int pcnt, userrec *user)
        {
                chanrec* c = ServerInstance->FindChan(parameters[0]);
 
                if (!c)
                {
                        user->WriteServ("401 %s %s :No such channel",user->nick, parameters[0]);
-                       return;
+                       return CMD_FAILURE;
                }
 
                std::string line = "";
@@ -54,7 +52,7 @@ class cmd_knock : public command_t
                if (c->IsModeSet('K'))
                {
                        user->WriteServ("480 %s :Can't KNOCK on %s, +K is set.",user->nick, c->name);
-                       return;
+                       return CMD_FAILURE;
                }
 
                for (int i = 1; i < pcnt - 1; i++)
@@ -67,16 +65,20 @@ class cmd_knock : public command_t
                {
                        c->WriteChannelWithServ((char*)ServerInstance->Config->ServerName,  "NOTICE %s :User %s is KNOCKing on %s (%s)", c->name, user->nick, c->name, line.c_str());
                        user->WriteServ("NOTICE %s :KNOCKing on %s",user->nick,c->name);
-                       return;
+                       return CMD_SUCCESS;
                }
                else
                {
                        user->WriteServ("480 %s :Can't KNOCK on %s, channel is not invite only so knocking is pointless!",user->nick, c->name);
-                       return;
+                       return CMD_FAILURE;
                }
+
+               return CMD_SUCCESS;
        }
 };
 
+/** Handles channel mode +K
+ */
 class Knock : public ModeHandler
 {
  public:
@@ -114,29 +116,24 @@ class ModuleKnock : public Module
        {
                
                kn = new Knock(ServerInstance);
-               Srv->AddMode(kn, 'K');
-               mycommand = new cmd_knock();
-               Srv->AddCommand(mycommand);
+               ServerInstance->AddMode(kn, 'K');
+               mycommand = new cmd_knock(ServerInstance);
+               ServerInstance->AddCommand(mycommand);
        }
 
        void Implements(char* List)
        {
-               List[I_On005Numeric] = 1;
-       }
-
-       virtual void On005Numeric(std::string &output)
-       {
-               ServerInstance->ModeGrok->InsertMode(output,"K",4);
        }
 
        virtual ~ModuleKnock()
        {
+               ServerInstance->Modes->DelMode(kn);
                DELETE(kn);
        }
 
        virtual Version GetVersion()
        {
-               return Version(1,0,0,1,VF_STATIC|VF_VENDOR);
+               return Version(1,0,0,1,VF_COMMON|VF_VENDOR);
        }
 };