Fix a regression in m_cloaking

[user/henk/code/inspircd.git] / src / modules / m_namesx.cpp

diff --git a/src/modules/m_namesx.cpp b/src/modules/m_namesx.cpp
index 1ab8243881cfcb0adc69038aa0f5aaaac1444463..f211b01d88a75af838c527b283ef68c81517750d 100644 (file)
--- a/src/modules/m_namesx.cpp
+++ b/src/modules/m_namesx.cpp
@@ -21,44 +21,34 @@
 
 
 #include "inspircd.h"
-#include "m_cap.h"
-
-/* $ModDesc: Provides the NAMESX (CAP multi-prefix) capability. */
+#include "modules/cap.h"
 
 class ModuleNamesX : public Module
 {
- public:
        GenericCap cap;
+ public:
        ModuleNamesX() : cap(this, "multi-prefix")
-       {
-               Implementation eventlist[] = { I_OnPreCommand, I_OnNamesListItem, I_On005Numeric, I_OnEvent };
-               ServerInstance->Modules->Attach(eventlist, this, 4);
-       }
-
-
-       ~ModuleNamesX()
        {
        }
 
-       Version GetVersion()
+       Version GetVersion() CXX11_OVERRIDE
        {
                return Version("Provides the NAMESX (CAP multi-prefix) capability.",VF_VENDOR);
        }
 
-       void On005Numeric(std::string &output)
+       void On005Numeric(std::map<std::string, std::string>& tokens) CXX11_OVERRIDE
        {
-               output.append(" NAMESX");
+               tokens["NAMESX"];
        }
 
-       ModResult OnPreCommand(std::string &command, std::vector<std::string> &parameters, LocalUser *user, bool validated, const std::string &original_line)
+       ModResult OnPreCommand(std::string &command, std::vector<std::string> &parameters, LocalUser *user, bool validated, const std::string &original_line) CXX11_OVERRIDE
        {
-               irc::string c = command.c_str();
                /* We don't actually create a proper command handler class for PROTOCTL,
                 * because other modules might want to have PROTOCTL hooks too.
                 * Therefore, we just hook its as an unvalidated command therefore we
                 * can capture it even if it doesnt exist! :-)
                 */
-               if (c == "PROTOCTL")
+               if (command == "PROTOCTL")
                {
                        if ((parameters.size()) && (!strcasecmp(parameters[0].c_str(),"NAMESX")))
                        {
@@ -69,19 +59,43 @@ class ModuleNamesX : public Module
                return MOD_RES_PASSTHRU;
        }
 
-       void OnNamesListItem(User* issuer, Membership* memb, std::string &prefixes, std::string &nick)
+       ModResult OnNamesListItem(User* issuer, Membership* memb, std::string& prefixes, std::string& nick) CXX11_OVERRIDE
+       {
+               if (cap.ext.get(issuer))
+                       prefixes = memb->GetAllPrefixChars();
+
+               return MOD_RES_PASSTHRU;
+       }
+
+       void OnSendWhoLine(User* source, const std::vector<std::string>& params, User* user, Membership* memb, std::string& line) CXX11_OVERRIDE
        {
-               if (!cap.ext.get(issuer))
+               if ((!memb) || (!cap.ext.get(source)))
                        return;
 
-               /* Some module hid this from being displayed, dont bother */
-               if (nick.empty())
+               // Channel names can contain ":", and ":" as a 'start-of-token' delimiter is
+               // only ever valid after whitespace, so... find the actual delimiter first!
+               // Thanks to FxChiP for pointing this out.
+               std::string::size_type pos = line.find(" :");
+               if (pos == std::string::npos || pos == 0)
+                       return;
+               pos--;
+               // Don't do anything if the user has no prefixes
+               if ((line[pos] == 'H') || (line[pos] == 'G') || (line[pos] == '*'))
+                       return;
+
+               // 352 21DAAAAAB #chan ident localhost insp21.test 21DAAAAAB H@ :0 a
+               //                                                            pos
+
+               // Don't do anything if the user has only one prefix
+               std::string prefixes = memb->GetAllPrefixChars();
+               if (prefixes.length() <= 1)
                        return;
 
-               prefixes = memb->chan->GetAllPrefixChars(memb->user);
+               line.erase(pos, 1);
+               line.insert(pos, prefixes);
        }
 
-       void OnEvent(Event& ev)
+       void OnEvent(Event& ev) CXX11_OVERRIDE
        {
                cap.HandleEvent(ev);
        }