Fix previous module mismatch message; "remote" is misleading when sent as an ERROR

[user/henk/code/inspircd.git] / src / modules / m_override.cpp

diff --git a/src/modules/m_override.cpp b/src/modules/m_override.cpp
index 67dea3dc9d51befeb5b8b15eb435ca6352a07918..3010e1e4648d157a3c2c0156ded3483249821a11 100644 (file)
--- a/src/modules/m_override.cpp
+++ b/src/modules/m_override.cpp
@@ -12,6 +12,7 @@
  */
 
 #include "inspircd.h"
+#include "m_override.h"
 
 /* $ModDesc: Provides support for unreal-style oper-override */
 
@@ -34,9 +35,13 @@ class ModuleOverride : public Module
                OnRehash(NULL,"");
                ServerInstance->SNO->EnableSnomask('G', "GODMODE");
                OverriddenMode = false;
+               if (!ServerInstance->Modules->PublishFeature("Override", this))
+               {
+                       throw ModuleException("m_override: Unable to publish feature 'Override'");
+               }
                OverOps = OverDeops = OverVoices = OverDevoices = OverHalfops = OverDehalfops = 0;
-               Implementation eventlist[] = { I_OnRehash, I_OnAccessCheck, I_On005Numeric, I_OnUserPreJoin, I_OnUserPreKick, I_OnPostCommand, I_OnLocalTopicChange };
-               ServerInstance->Modules->Attach(eventlist, this, 7);
+               Implementation eventlist[] = { I_OnRehash, I_OnAccessCheck, I_On005Numeric, I_OnUserPreJoin, I_OnUserPreKick, I_OnPostCommand, I_OnLocalTopicChange, I_OnRequest };
+               ServerInstance->Modules->Attach(eventlist, this, 8);
        }
 
        virtual void OnRehash(User* user, const std::string &parameter)
@@ -66,7 +71,7 @@ class ModuleOverride : public Module
                if ((OverriddenMode) && (irc::string(command.c_str()) == "MODE") && (result == CMD_SUCCESS))
                {
                        int Total = OverOps + OverDeops + OverVoices + OverDevoices + OverHalfops + OverDehalfops;
-                       if (Total == 0)
+                       if (Total == 0 || ServerInstance->Modes->GetLastParse().empty())
                                return;
 
                        ServerInstance->SNO->WriteToSnoMask('G',std::string(user->nick)+" Overriding modes: "+ServerInstance->Modes->GetLastParse()+" "+(Total ? "[Detail: " : "")+
@@ -110,7 +115,7 @@ class ModuleOverride : public Module
                {
                        if (!channel->HasUser(source) || (channel->IsModeSet('t') && channel->GetStatus(source) < STATUS_HOP))
                        {
-                               ServerInstance->SNO->WriteToSnoMask('G',std::string(source->nick)+"  used oper override to change a topic on "+std::string(channel->name));
+                               ServerInstance->SNO->WriteToSnoMask('G',std::string(source->nick)+" used oper override to change a topic on "+std::string(channel->name));
                        }
 
                        // Explicit allow
@@ -126,7 +131,7 @@ class ModuleOverride : public Module
                {
                        // If the kicker's status is less than the target's,                    or      the kicker's status is less than or equal to voice
                        if ((chan->GetStatus(source) < chan->GetStatus(user))                   || (chan->GetStatus(source) <= STATUS_VOICE))
-                       {                               
+                       {
                                ServerInstance->SNO->WriteToSnoMask('G',std::string(source->nick)+" used oper override to kick "+std::string(user->nick)+" on "+std::string(chan->name)+" ("+reason+")");
                        }
                        /* Returning -1 explicitly allows the kick */
@@ -279,7 +284,7 @@ class ModuleOverride : public Module
                                        return -1;
                                }
 
-                               if ((chan->modes[CM_LIMIT]) && (chan->GetUserCounter() >=  atoi(chan->GetModeParameter('l').c_str())) && (CanOverride(user,"LIMIT")))
+                               if ((chan->modes[CM_LIMIT]) && (chan->GetUserCounter() >= atoi(chan->GetModeParameter('l').c_str())) && (CanOverride(user,"LIMIT")))
                                {
                                        if (RequireKey && keygiven != "override")
                                        {
@@ -313,8 +318,19 @@ class ModuleOverride : public Module
                return 0;
        }
 
+       virtual const char* OnRequest(Request* request)
+       {
+               if(strcmp(OVRREQID, request->GetId()) == 0)
+               {
+                       OVRrequest* req = static_cast<OVRrequest*>(request);
+                       return this->CanOverride(req->requser,req->reqtoken.c_str()) ? "yes":"";
+               }
+               return NULL;
+       }
+
        virtual ~ModuleOverride()
        {
+               ServerInstance->Modules->UnpublishFeature("Override");
                ServerInstance->SNO->DisableSnomask('G');
        }