]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_redirect.cpp
Fix SetModeParam to use std::string and handle edge cases.
[user/henk/code/inspircd.git] / src / modules / m_redirect.cpp
index 331b29f40d9d4db45f4bcbe0ab19a38e67019dd1..00c191d26a74c30cebe3143662d4f5696160d63c 100644 (file)
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd is copyright (C) 2002-2006 ChatSpike-Dev.
- *                       E-mail:
- *                <brain@chatspike.net>
- *               <Craig@chatspike.net>
- *     
- * Written by Craig Edwards, Craig McLure, and others.
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
+ *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
  *
  * ---------------------------------------------------
  */
 
-using namespace std;
-
-#include <stdio.h>
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
-#include "helperfuncs.h"
 #include "inspircd.h"
 
 /* $ModDesc: Provides channel mode +L (limit redirection) */
 
-extern InspIRCd* ServerInstance;
-
+/** Handle channel mode +L
+ */
 class Redirect : public ModeHandler
 {
  public:
        Redirect(InspIRCd* Instance) : ModeHandler(Instance, 'L', 1, 0, false, MODETYPE_CHANNEL, false) { }
 
-        ModePair ModeSet(userrec* source, userrec* dest, chanrec* channel, const std::string &parameter)
-        {
-                if (channel->IsModeSet('L'))
-                        return std::make_pair(true, channel->GetModeParameter('L'));
-                else
-                        return std::make_pair(false, parameter);
-        }
+       ModePair ModeSet(User* source, User* dest, Channel* channel, const std::string &parameter)
+       {
+               if (channel->IsModeSet('L'))
+                       return std::make_pair(true, channel->GetModeParameter('L'));
+               else
+                       return std::make_pair(false, parameter);
+       }
 
-        bool CheckTimeStamp(time_t theirs, time_t ours, const std::string &their_param, const std::string &our_param, chanrec* channel)
+       bool CheckTimeStamp(time_t theirs, time_t ours, const std::string &their_param, const std::string &our_param, Channel* channel)
        {
                /* When TS is equal, the alphabetically later one wins */
                return (their_param < our_param);
-        }
-       
-       ModeAction OnModeChange(userrec* source, userrec* dest, chanrec* channel, std::string &parameter, bool adding)
+       }
+
+       ModeAction OnModeChange(User* source, User* dest, Channel* channel, std::string &parameter, bool adding, bool)
        {
                if (adding)
                {
-                       chanrec* c = NULL;
+                       Channel* c = NULL;
 
-                       if (!ServerInstance->IsChannel(parameter.c_str()))
+                       if (IS_LOCAL(source) && !ServerInstance->IsChannel(parameter.c_str(), ServerInstance->Config->Limits.ChanMax))
                        {
-                               source->WriteServ("403 %s %s :Invalid channel name",source->nick, parameter.c_str());
-                               parameter = "";
+                               source->WriteNumeric(403, "%s %s :Invalid channel name", source->nick.c_str(), parameter.c_str());
+                               parameter.clear();
                                return MODEACTION_DENY;
                        }
 
                        c = ServerInstance->FindChan(parameter);
-                       if (c)
+                       if (!c && !IS_OPER(source))
                        {
-                               /* Fix by brain: Dont let a channel be linked to *itself* either */
-                               if (IS_LOCAL(source))
-                               {
-                                       if ((c == channel) || (c->IsModeSet('L')))
-                                       {
-                                               source->WriteServ("690 %s :Circular or chained +L to %s not allowed (Channel already has +L). Pack of wild dogs has been unleashed.",source->nick,parameter.c_str());
-                                               parameter = "";
-                                               return MODEACTION_DENY;
-                                       }
-                                       else
-                                       {
-                                               for (chan_hash::const_iterator i = ServerInstance->chanlist.begin(); i != ServerInstance->chanlist.end(); i++)
-                                               {
-                                                       if ((i->second != channel) && (i->second->IsModeSet('L')) && (irc::string(i->second->GetModeParameter('L').c_str()) == irc::string(channel->name)))
-                                                       {
-                                                               source->WriteServ("690 %s :Circular or chained +L to %s not allowed (Already forwarded here from %s). Angry monkeys dispatched.",source->nick,parameter.c_str(),i->second->name);
-                                                               return MODEACTION_DENY;
-                                                       }
-                                               }
-                                       }
-                               }
+                               source->WriteNumeric(690, "%s :Target channel %s must exist to be set as a redirect.",source->nick.c_str(),parameter.c_str());
+                               parameter.clear();
+                               return MODEACTION_DENY;
+                       }
+
+                       if (c && c->GetStatus(source) < STATUS_OP && !IS_OPER(source))
+                       {
+                               source->WriteNumeric(690, "%s :You must be opped on %s to set it as a redirect.",source->nick.c_str(),parameter.c_str());
+                               parameter.clear();
+                               return MODEACTION_DENY;
                        }
 
-                       channel->SetMode('L', true);
-                       channel->SetModeParam('L', parameter.c_str(), true);
+                       /*
+                        * We used to do some checking for circular +L here, but there is no real need for this any more especially as we
+                        * now catch +L looping in PreJoin. Remove it, since O(n) logic makes me sad, and we catch it anyway. :) -- w00t
+                        */
+                       channel->SetMode('L', parameter);
                        return MODEACTION_ALLOW;
                }
                else
                {
                        if (channel->IsModeSet('L'))
                        {
-                               channel->SetMode('L', false);
+                               channel->SetMode('L', "");
                                return MODEACTION_ALLOW;
                        }
                }
 
                return MODEACTION_DENY;
-               
+
        }
 };
 
 class ModuleRedirect : public Module
 {
-       Server *Srv;
+
        Redirect* re;
-       
+
  public:
+
        ModuleRedirect(InspIRCd* Me)
-               : Module::Module(Me)
+               : Module(Me)
        {
-               
+
                re = new Redirect(ServerInstance);
-               Srv->AddMode(re, 'L');
-       }
-       
-       void Implements(char* List)
-       {
-               List[I_On005Numeric] = List[I_OnUserPreJoin] = 1;
+               if (!ServerInstance->Modes->AddMode(re))
+                       throw ModuleException("Could not add new modes!");
+               Implementation eventlist[] = { I_OnUserPreJoin };
+               ServerInstance->Modules->Attach(eventlist, this, 1);
        }
 
-       virtual void On005Numeric(std::string &output)
-       {
-               ServerInstance->ModeGrok->InsertMode(output, "L", 3);
-       }
-       
-       virtual int OnUserPreJoin(userrec* user, chanrec* chan, const char* cname)
+
+       virtual int OnUserPreJoin(User* user, Channel* chan, const char* cname, std::string &privs, const std::string &keygiven)
        {
                if (chan)
                {
-                       if (chan->IsModeSet('L'))
+                       if (chan->IsModeSet('L') && chan->modes[CM_LIMIT])
                        {
-                               if (chan->GetUserCounter() >= chan->limit)
+                               if (chan->GetUserCounter() >= atoi(chan->GetModeParameter('l').c_str()))
                                {
                                        std::string channel = chan->GetModeParameter('L');
-                                       user->WriteServ("470 %s :%s has become full, so you are automatically being transferred to the linked channel %s",user->nick,cname,channel.c_str());
-                                       chanrec::JoinUser(ServerInstance, user, channel.c_str(), false);
+
+                                       /* sometimes broken ulines can make circular or chained +L, avoid this */
+                                       Channel* destchan = NULL;
+                                       destchan = ServerInstance->FindChan(channel);
+                                       if (destchan && destchan->IsModeSet('L'))
+                                       {
+                                               user->WriteNumeric(470, "%s %s * :You may not join this channel. A redirect is set, but you may not be redirected as it is a circular loop.", user->nick.c_str(), cname);
+                                               return 1;
+                                       }
+
+                                       user->WriteNumeric(470, "%s %s %s :You may not join this channel, so you are automatically being transferred to the redirect channel.", user->nick.c_str(), cname, channel.c_str());
+                                       Channel::JoinUser(ServerInstance, user, channel.c_str(), false, "", false, ServerInstance->Time());
                                        return 1;
                                }
                        }
@@ -148,37 +134,14 @@ class ModuleRedirect : public Module
 
        virtual ~ModuleRedirect()
        {
-               DELETE(re);
-       }
-       
-       virtual Version GetVersion()
-       {
-               return Version(1,0,0,0,VF_STATIC|VF_VENDOR);
+               ServerInstance->Modes->DelMode(re);
+               delete re;
        }
-};
-
 
-class ModuleRedirectFactory : public ModuleFactory
-{
- public:
-       ModuleRedirectFactory()
-       {
-       }
-       
-       ~ModuleRedirectFactory()
-       {
-       }
-       
-       virtual Module * CreateModule(InspIRCd* Me)
+       virtual Version GetVersion()
        {
-               return new ModuleRedirect(Me);
+               return Version("$Id$", VF_COMMON | VF_VENDOR, API_VERSION);
        }
-       
 };
 
-
-extern "C" void * init_module( void )
-{
-       return new ModuleRedirectFactory;
-}
-
+MODULE_INIT(ModuleRedirect)