Clean up the WEBIRC command handler.

[user/henk/code/inspircd.git] / src / modules / m_sethost.cpp

diff --git a/src/modules/m_sethost.cpp b/src/modules/m_sethost.cpp
index 75dbe1c6a6c00f84a4ce09661b720c4327d60210..e2a5dc281b603b38c8a5e9afd831956e7a9113f8 100644 (file)
--- a/src/modules/m_sethost.cpp
+++ b/src/modules/m_sethost.cpp
@@ -36,8 +36,13 @@ class CommandSethost : public Command
 
        CmdResult Handle (const std::vector<std::string>& parameters, User *user)
        {
-               size_t len = 0;
-               for (std::string::const_iterator x = parameters[0].begin(); x != parameters[0].end(); x++, len++)
+               if (parameters[0].length() > ServerInstance->Config->Limits.MaxHost)
+               {
+                       user->WriteNotice("*** SETHOST: Host too long");
+                       return CMD_FAILURE;
+               }
+
+               for (std::string::const_iterator x = parameters[0].begin(); x != parameters[0].end(); x++)
                {
                        if (!hostmap[(const unsigned char)*x])
                        {
@@ -46,12 +51,6 @@ class CommandSethost : public Command
                        }
                }
 
-               if (len > ServerInstance->Config->Limits.MaxHost)
-               {
-                       user->WriteNotice("*** SETHOST: Host too long");
-                       return CMD_FAILURE;
-               }
-
                if (user->ChangeDisplayedHost(parameters[0]))
                {
                        ServerInstance->SNO->WriteGlobalSno('a', user->nick+" used SETHOST to change their displayed host to "+user->dhost);