Add comments

[user/henk/code/inspircd.git] / src / modules / m_sha256.cpp

diff --git a/src/modules/m_sha256.cpp b/src/modules/m_sha256.cpp
index 618229c1ab2e29baeb35f4effebc76cb78f9119a..22937abf5bdab9dc27144b63d2047fb92af07a5c 100644 (file)
--- a/src/modules/m_sha256.cpp
+++ b/src/modules/m_sha256.cpp
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
@@ -186,7 +186,26 @@ class ModuleSHA256 : public Module
        
        void SHA256Update(SHA256Context *ctx, unsigned char *message, unsigned int len)
        {
-               unsigned int rem_len = SHA256_BLOCK_SIZE - ctx->len;
+               /*
+                * XXX here be dragons!
+                * After many hours of pouring over this, I think I've found the problem.
+                * When Special created our module from the reference one, he used:
+                *
+                *     unsigned int rem_len = SHA256_BLOCK_SIZE - ctx->len;
+                *
+                * instead of the reference's version of:
+                *
+                *     unsigned int tmp_len = SHA256_BLOCK_SIZE - ctx->len;
+                *     unsigned int rem_len = len < tmp_len ? len : tmp_len;
+                *
+                * I've changed back to the reference version of this code, and it seems to work with no errors.
+                * So I'm inclined to believe this was the problem..
+                *             -- w00t (January 06, 2008)
+                */
+               unsigned int tmp_len = SHA256_BLOCK_SIZE - ctx->len;
+               unsigned int rem_len = len < tmp_len ? len : tmp_len;
+
+               
                memcpy(&ctx->block[ctx->len], message, rem_len);
                if (ctx->len + len < SHA256_BLOCK_SIZE)
                {
@@ -251,10 +270,6 @@ class ModuleSHA256 : public Module
                ServerInstance->Modules->UnpublishInterface("HashRequest", this);
        }
 
-       void Implements(char *List)
-       {
-               List[I_OnRequest] = 1;
-       }
 
        virtual char* OnRequest(Request* request)
        {