]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/capab.cpp
Improve X-line text consistency.
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / capab.cpp
index 7f9f9edb7b4575b753c24f7f20c3b5b7df3b9bc5..c29330516952f1324481fd63116c6840eafb7233 100644 (file)
@@ -79,16 +79,28 @@ std::string TreeSocket::MyModules(int filter)
        return capabilities;
 }
 
-static std::string BuildModeList(ModeType type)
+std::string TreeSocket::BuildModeList(ModeType mtype)
 {
        std::vector<std::string> modes;
-       const ModeParser::ModeHandlerMap& mhs = ServerInstance->Modes.GetModes(type);
+       const ModeParser::ModeHandlerMap& mhs = ServerInstance->Modes.GetModes(mtype);
        for (ModeParser::ModeHandlerMap::const_iterator i = mhs.begin(); i != mhs.end(); ++i)
        {
                const ModeHandler* const mh = i->second;
-               std::string mdesc = mh->name;
-               mdesc.push_back('=');
                const PrefixMode* const pm = mh->IsPrefixMode();
+               std::string mdesc;
+               if (proto_version != 1202)
+               {
+                       if (pm)
+                               mdesc.append("prefix:").append(ConvToStr(pm->GetPrefixRank())).push_back(':');
+                       else if (mh->IsListMode())
+                               mdesc.append("list:");
+                       else if (mh->NeedsParam(true))
+                               mdesc.append(mh->NeedsParam(false) ? "param:" : "param-set:");
+                       else
+                               mdesc.append("simple:");
+               }
+               mdesc.append(mh->name);
+               mdesc.push_back('=');
                if (pm)
                {
                        if (pm->GetPrefix())
@@ -98,7 +110,7 @@ static std::string BuildModeList(ModeType type)
                modes.push_back(mdesc);
        }
        std::sort(modes.begin(), modes.end());
-       return irc::stringjoiner(modes);
+       return stdalgo::string::join(modes);
 }
 
 void TreeSocket::SendCapabilities(int phase)
@@ -163,9 +175,15 @@ void TreeSocket::SendCapabilities(int phase)
                extra = " CHALLENGE=" + this->GetOurChallenge();
        }
 
-       // 2.0 needs this key
+       // 2.0 needs these keys.
        if (proto_version == 1202)
-               extra.append(" PROTOCOL="+ConvToStr(ProtocolVersion));
+       {
+               extra.append(" PROTOCOL="+ConvToStr(ProtocolVersion))
+                       .append(" MAXGECOS="+ConvToStr(ServerInstance->Config->Limits.MaxReal))
+                       .append(" CHANMODES="+ServerInstance->Modes->GiveModeList(MODETYPE_CHANNEL))
+                       .append(" USERMODES="+ServerInstance->Modes->GiveModeList(MODETYPE_USER))
+                       .append(" PREFIX="+ ServerInstance->Modes->BuildPrefixes());
+       }
 
        this->WriteLine("CAPAB CAPABILITIES " /* Preprocessor does this one. */
                        ":NICKMAX="+ConvToStr(ServerInstance->Config->Limits.NickMax)+
@@ -175,13 +193,10 @@ void TreeSocket::SendCapabilities(int phase)
                        " MAXQUIT="+ConvToStr(ServerInstance->Config->Limits.MaxQuit)+
                        " MAXTOPIC="+ConvToStr(ServerInstance->Config->Limits.MaxTopic)+
                        " MAXKICK="+ConvToStr(ServerInstance->Config->Limits.MaxKick)+
-                       " MAXGECOS="+ConvToStr(ServerInstance->Config->Limits.MaxGecos)+
+                       " MAXREAL="+ConvToStr(ServerInstance->Config->Limits.MaxReal)+
                        " MAXAWAY="+ConvToStr(ServerInstance->Config->Limits.MaxAway)+
                        " MAXHOST="+ConvToStr(ServerInstance->Config->Limits.MaxHost)+
                        extra+
-                       " PREFIX="+ServerInstance->Modes->BuildPrefixes()+
-                       " CHANMODES="+ServerInstance->Modes->GiveModeList(MODETYPE_CHANNEL)+
-                       " USERMODES="+ServerInstance->Modes->GiveModeList(MODETYPE_USER)+
                        " CASEMAPPING="+ServerInstance->Config->CaseMapping+
                        // XXX: Advertise the presence or absence of m_globops in CAPAB CAPABILITIES.
                        // Services want to know about it, and since m_globops was not marked as VF_(OPT)COMMON
@@ -221,7 +236,7 @@ void TreeSocket::ListDifference(const std::string &one, const std::string &two,
        }
 }
 
-bool TreeSocket::Capab(const parameterlist &params)
+bool TreeSocket::Capab(const CommandBase::Params& params)
 {
        if (params.size() < 1)
        {
@@ -234,7 +249,7 @@ bool TreeSocket::Capab(const parameterlist &params)
                capab->OptModuleList.clear();
                capab->CapKeys.clear();
                if (params.size() > 1)
-                       proto_version = ConvToInt(params[1]);
+                       proto_version = ConvToNum<unsigned int>(params[1]);
 
                if (proto_version < MinCompatProtocol)
                {
@@ -272,6 +287,7 @@ bool TreeSocket::Capab(const parameterlist &params)
                                return false;
                        }
                }
+
                if (this->capab->OptModuleList != this->MyModules(VF_OPTCOMMON) && this->capab->OptModuleList.length())
                {
                        std::string diffIneed, diffUneed;
@@ -287,7 +303,7 @@ bool TreeSocket::Capab(const parameterlist &params)
                                }
                                else
                                {
-                                       reason = "Optional modules incorrectly matched on these servers, and options::allowmismatch not set.";
+                                       reason = "Optional modules incorrectly matched on these servers and <options:allowmismatch> is not enabled.";
                                        if (diffIneed.length())
                                                reason += " Not loaded here:" + diffIneed;
                                        if (diffUneed.length())
@@ -298,9 +314,6 @@ bool TreeSocket::Capab(const parameterlist &params)
                        }
                }
 
-               if(this->capab->CapKeys.find("PREFIX") != this->capab->CapKeys.end() && this->capab->CapKeys.find("PREFIX")->second != ServerInstance->Modes->BuildPrefixes())
-                       reason = "One or more of the prefixes on the remote server are invalid on this server.";
-
                if (!capab->ChanModes.empty())
                {
                        if (capab->ChanModes != BuildModeList(MODETYPE_CHANNEL))
@@ -317,10 +330,25 @@ bool TreeSocket::Capab(const parameterlist &params)
                                }
                        }
                }
-               else if (this->capab->CapKeys.find("CHANMODES") != this->capab->CapKeys.end())
+               else if (proto_version == 1202)
+               {
+                       if (this->capab->CapKeys.find("CHANMODES") != this->capab->CapKeys.end())
+                       {
+                               if (this->capab->CapKeys.find("CHANMODES")->second != ServerInstance->Modes->GiveModeList(MODETYPE_CHANNEL))
+                                       reason = "One or more of the channel modes on the remote server are invalid on this server.";
+                       }
+
+                       else if (this->capab->CapKeys.find("PREFIX") != this->capab->CapKeys.end())
+                       {
+                               if (this->capab->CapKeys.find("PREFIX")->second != ServerInstance->Modes->BuildPrefixes())
+                                       reason = "One or more of the prefixes on the remote server are invalid on this server.";
+                       }
+               }
+
+               if (!reason.empty())
                {
-                       if (this->capab->CapKeys.find("CHANMODES")->second != ServerInstance->Modes->GiveModeList(MODETYPE_CHANNEL))
-                               reason = "One or more of the channel modes on the remote server are invalid on this server.";
+                       this->SendError("CAPAB negotiation failed: " + reason);
+                       return false;
                }
 
                if (!capab->UserModes.empty())
@@ -339,28 +367,29 @@ bool TreeSocket::Capab(const parameterlist &params)
                                }
                        }
                }
-               else if (this->capab->CapKeys.find("USERMODES") != this->capab->CapKeys.end())
+               else if (proto_version == 1202 && this->capab->CapKeys.find("USERMODES") != this->capab->CapKeys.end())
                {
                        if (this->capab->CapKeys.find("USERMODES")->second != ServerInstance->Modes->GiveModeList(MODETYPE_USER))
                                reason = "One or more of the user modes on the remote server are invalid on this server.";
                }
-               else
+
+               if (!reason.empty())
                {
-                       // We default to rfc1459 here because if this key is not sent then
-                       // the remote server is running the 2.0 protocol which uses rfc1459
-                       // by default.
-                       std::string casemapping = "rfc1459";
-                       std::map<std::string, std::string>::iterator citer = this->capab->CapKeys.find("CASEMAPPING");
-                       if (citer != this->capab->CapKeys.end())
-                               casemapping = citer->second;
+                       this->SendError("CAPAB negotiation failed: " + reason);
+                       return false;
+               }
 
+               if (this->capab->CapKeys.find("CASEMAPPING") != this->capab->CapKeys.end())
+               {
+                       const std::string casemapping = this->capab->CapKeys.find("CASEMAPPING")->second;
                        if (casemapping != ServerInstance->Config->CaseMapping)
                        {
                                reason = "The casemapping of the remote server differs to that of the local server."
                                        " Local casemapping: " + ServerInstance->Config->CaseMapping +
                                        " Remote casemapping: " + casemapping;
+                               this->SendError("CAPAB negotiation failed: " + reason);
+                               return false;
                        }
-
                }
 
                /* Challenge response, store their challenge for our password */
@@ -384,12 +413,6 @@ bool TreeSocket::Capab(const parameterlist &params)
                                this->WriteLine("SERVER "+ServerInstance->Config->ServerName+" "+capab->link->SendPass+" 0 "+ServerInstance->Config->GetSID()+" :"+ServerInstance->Config->ServerDesc);
                        }
                }
-
-               if (reason.length())
-               {
-                       this->SendError("CAPAB negotiation failed: "+reason);
-                       return false;
-               }
        }
        else if ((params[0] == "MODULES") && (params.size() == 2))
        {
@@ -425,7 +448,7 @@ bool TreeSocket::Capab(const parameterlist &params)
        }
        else if ((params[0] == "CAPABILITIES") && (params.size() == 2))
        {
-               irc::tokenstream capabs(params[1]);
+               irc::spacesepstream capabs(params[1]);
                std::string item;
                while (capabs.GetToken(item))
                {