]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/capab.cpp
Verify cloak keys match during CAPAB negotiation
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / capab.cpp
index 8b02b954526f5d61bb553522777fd04598771543..de97b6c70dbc39ca0d303990987bcd06e36a5c4e 100644 (file)
@@ -2,8 +2,8 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *  InspIRCd: (C) 2002-2010 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
 #include "inspircd.h"
 #include "xline.h"
 
-#include "m_spanningtree/treesocket.h"
-#include "m_spanningtree/treeserver.h"
-#include "m_spanningtree/utils.h"
-#include "m_spanningtree/main.h"
+#include "treesocket.h"
+#include "treeserver.h"
+#include "utils.h"
+#include "main.h"
 
 /* $ModDep: m_spanningtree/utils.h m_spanningtree/treeserver.h m_spanningtree/treesocket.h */
 
-
-std::string TreeSocket::MyCapabilities()
+std::string TreeSocket::MyModules(int filter)
 {
-       std::vector<std::string> modlist = this->ServerInstance->Modules->GetAllModuleNames(VF_COMMON);
+       std::vector<std::string> modlist = ServerInstance->Modules->GetAllModuleNames(filter);
+
+       if (filter == VF_COMMON && proto_version != ProtocolVersion)
+               CompatAddModules(modlist);
+
        std::string capabilities;
        sort(modlist.begin(),modlist.end());
        for (unsigned int i = 0; i < modlist.size(); i++)
        {
                if (i)
-                       capabilities = capabilities + ",";
-               capabilities = capabilities + modlist[i];
+                       capabilities.push_back(',');
+               capabilities.append(modlist[i]);
+               Module* m = ServerInstance->Modules->Find(modlist[i]);
+               if (m && proto_version >= 1202)
+               {
+                       Version v = m->GetVersion();
+                       if (!v.link_data.empty())
+                       {
+                               capabilities.push_back('=');
+                               capabilities.append(v.link_data);
+                       }
+               }
        }
        return capabilities;
 }
 
-void TreeSocket::SendCapabilities()
+void TreeSocket::SendCapabilities(int phase)
 {
-       if (sentcapab)
+       if (capab_phase >= phase)
                return;
 
-       sentcapab = true;
-       irc::commasepstream modulelist(MyCapabilities());
-       this->WriteLine("CAPAB START");
+       if (capab_phase < 1 && phase >= 1)
+               WriteLine("CAPAB START " + ConvToStr(ProtocolVersion));
 
+       capab_phase = phase;
+       if (phase < 2)
+               return;
+
+       irc::commasepstream modulelist(MyModules(VF_COMMON));
+       irc::commasepstream optmodulelist(MyModules(VF_OPTCOMMON));
        /* Send module names, split at 509 length */
        std::string item;
        std::string line = "CAPAB MODULES ";
@@ -64,13 +82,27 @@ void TreeSocket::SendCapabilities()
        if (line != "CAPAB MODULES ")
                this->WriteLine(line);
 
+       line = "CAPAB MODSUPPORT ";
+       while (optmodulelist.GetToken(item))
+       {
+               if (line.length() + item.length() + 1 > 509)
+               {
+                       this->WriteLine(line);
+                       line = "CAPAB MODSUPPORT ";
+               }
+
+               if (line != "CAPAB MODSUPPORT ")
+                       line.append(",");
+
+               line.append(item);
+       }
+       if (line != "CAPAB MODSUPPORT ")
+               this->WriteLine(line);
+
+
        int ip6 = 0;
-       int ip6support = 0;
 #ifdef IPV6
        ip6 = 1;
-#endif
-#ifdef SUPPORT_IP6LINKS
-       ip6support = 1;
 #endif
        std::string extra;
        /* Do we have sha256 available? If so, we send a challenge */
@@ -82,7 +114,6 @@ void TreeSocket::SendCapabilities()
 
        this->WriteLine("CAPAB CAPABILITIES " /* Preprocessor does this one. */
                        ":NICKMAX="+ConvToStr(ServerInstance->Config->Limits.NickMax)+
-                       " HALFOP="+ConvToStr(ServerInstance->Config->AllowHalfop)+
                        " CHANMAX="+ConvToStr(ServerInstance->Config->Limits.ChanMax)+
                        " MAXMODES="+ConvToStr(ServerInstance->Config->Limits.MaxModes)+
                        " IDENTMAX="+ConvToStr(ServerInstance->Config->Limits.IdentMax)+
@@ -92,10 +123,11 @@ void TreeSocket::SendCapabilities()
                        " MAXGECOS="+ConvToStr(ServerInstance->Config->Limits.MaxGecos)+
                        " MAXAWAY="+ConvToStr(ServerInstance->Config->Limits.MaxAway)+
                        " IP6NATIVE="+ConvToStr(ip6)+
-                       " IP6SUPPORT="+ConvToStr(ip6support)+
+                       " IP6SUPPORT=1"+
                        " PROTOCOL="+ConvToStr(ProtocolVersion)+extra+
                        " PREFIX="+ServerInstance->Modes->BuildPrefixes()+
-                       " CHANMODES="+ServerInstance->Modes->ChanModes()+
+                       " CHANMODES="+ServerInstance->Modes->GiveModeList(MASK_CHANNEL)+
+                       " USERMODES="+ServerInstance->Modes->GiveModeList(MASK_USER)+
                        " SVSPART=1");
 
        this->WriteLine("CAPAB END");
@@ -132,7 +164,7 @@ std::string TreeSocket::ListDifference(const std::string &one, const std::string
        return result;
 }
 
-bool TreeSocket::Capab(const std::deque<std::string> &params)
+bool TreeSocket::Capab(const parameterlist &params)
 {
        if (params.size() < 1)
        {
@@ -141,53 +173,87 @@ bool TreeSocket::Capab(const std::deque<std::string> &params)
        }
        if (params[0] == "START")
        {
-               this->ModuleList.clear();
-               this->CapKeys.clear();
+               ModuleList.clear();
+               OptModuleList.clear();
+               CapKeys.clear();
+               if (params.size() > 1)
+                       proto_version = atoi(params[1].c_str());
+               SendCapabilities(2);
        }
        else if (params[0] == "END")
        {
                std::string reason;
-               int ip6support = 0;
-#ifdef SUPPORT_IP6LINKS
-               ip6support = 1;
-#endif
-               /* Compare ModuleList and check CapKeys...
-                * Maybe this could be tidier? -- Brain
-                */
-               if ((this->ModuleList != this->MyCapabilities()) && (this->ModuleList.length()))
+               /* Compare ModuleList and check CapKeys */
+               if ((this->ModuleList != this->MyModules(VF_COMMON)) && (this->ModuleList.length()))
                {
-                       std::string diff = ListDifference(this->ModuleList, this->MyCapabilities());
-                       if (!diff.length())
+                       std::string diffIneed = ListDifference(this->ModuleList, this->MyModules(VF_COMMON));
+                       std::string diffUneed = ListDifference(this->MyModules(VF_COMMON), this->ModuleList);
+                       if (diffIneed.length() == 0 && diffUneed.length() == 0)
                        {
-                               diff = "your server:" + ListDifference(this->MyCapabilities(), this->ModuleList);
+                               reason = "Module list in CAPAB is not alphabetically ordered, cannot compare lists.";
                        }
                        else
                        {
-                               diff = "this server:" + diff;
+                               reason = "Modules incorrectly matched on these servers.";
+                               if (diffIneed.length())
+                                       reason += " Not loaded here:" + diffIneed;
+                               if (diffUneed.length())
+                                       reason += " Not loaded there:" + diffUneed;
+                       }
+                       this->SendError("CAPAB negotiation failed: "+reason);
+                       return false;
+               }
+               if (this->OptModuleList != this->MyModules(VF_OPTCOMMON) && this->OptModuleList.length())
+               {
+                       std::string diffIneed = ListDifference(this->OptModuleList, this->MyModules(VF_OPTCOMMON));
+                       std::string diffUneed = ListDifference(this->MyModules(VF_OPTCOMMON), this->OptModuleList);
+                       if (diffIneed.length() == 0 && diffUneed.length() == 0)
+                       {
+                               reason = "Optional Module list in CAPAB is not alphabetically ordered, cannot compare lists.";
+                       }
+                       else if (Utils->AllowOptCommon)
+                       {
+                               ServerInstance->SNO->WriteToSnoMask('l',
+                                       "Optional module lists do not match, some commands may not work globally.%s%s%s%s",
+                                       diffIneed.length() ? " Not loaded here:" : "", diffIneed.c_str(),
+                                       diffUneed.length() ? " Not loaded there:" : "", diffUneed.c_str());
                        }
-                       if (diff.length() == 12)
-                               reason = "Module list in CAPAB is not alphabetically ordered, cannot compare lists.";
                        else
-                               reason = "Modules loaded on these servers are not correctly matched, these modules are not loaded on " + diff;
+                       {
+                               reason = "Optional modules incorrectly matched on these servers, and options::allowmismatch not set.";
+                               if (diffIneed.length())
+                                       reason += " Not loaded here:" + diffIneed;
+                               if (diffUneed.length())
+                                       reason += " Not loaded there:" + diffUneed;
+                               this->SendError("CAPAB negotiation failed: "+reason);
+                               return false;
+                       }
                }
 
-               if (((this->CapKeys.find("IP6SUPPORT") == this->CapKeys.end()) && (ip6support)) || ((this->CapKeys.find("IP6SUPPORT") != this->CapKeys.end()) && (this->CapKeys.find("IP6SUPPORT")->second != ConvToStr(ip6support))))
-                       reason = "We don't both support linking to IPV6 servers";
-               if (((this->CapKeys.find("IP6NATIVE") != this->CapKeys.end()) && (this->CapKeys.find("IP6NATIVE")->second == "1")) && (!ip6support))
-                       reason = "The remote server is IPV6 native, and we don't support linking to IPV6 servers";
-               if (((this->CapKeys.find("PROTOCOL") == this->CapKeys.end()) || ((this->CapKeys.find("PROTOCOL") != this->CapKeys.end()) && (this->CapKeys.find("PROTOCOL")->second != ConvToStr(ProtocolVersion)))))
+               if (this->CapKeys.find("PROTOCOL") == this->CapKeys.end())
                {
-                       if (this->CapKeys.find("PROTOCOL") != this->CapKeys.end())
-                               reason = "Mismatched protocol versions "+this->CapKeys.find("PROTOCOL")->second+" and "+ConvToStr(ProtocolVersion);
-                       else
-                               reason = "Protocol version not specified";
+                       reason = "Protocol version not specified";
+               }
+               else
+               {
+                       proto_version = atoi(CapKeys.find("PROTOCOL")->second.c_str());
+                       if (proto_version < MinCompatProtocol)
+                       {
+                               reason = "Server is using protocol version " + ConvToStr(proto_version) +
+                                       " which is too old to link with this server (version " + ConvToStr(ProtocolVersion)
+                                       + (ProtocolVersion != MinCompatProtocol ? ", links with " + ConvToStr(MinCompatProtocol) + " and above)" : ")");
+                       }
                }
 
-               if(this->CapKeys.find("PREFIX") != this->CapKeys.end() && this->CapKeys.find("PREFIX")->second != this->ServerInstance->Modes->BuildPrefixes())
+               if(this->CapKeys.find("PREFIX") != this->CapKeys.end() && this->CapKeys.find("PREFIX")->second != ServerInstance->Modes->BuildPrefixes())
                        reason = "One or more of the prefixes on the remote server are invalid on this server.";
 
-               if (((this->CapKeys.find("HALFOP") == this->CapKeys.end()) && (ServerInstance->Config->AllowHalfop)) || ((this->CapKeys.find("HALFOP") != this->CapKeys.end()) && (this->CapKeys.find("HALFOP")->second != ConvToStr(ServerInstance->Config->AllowHalfop))))
-                       reason = "We don't both have halfop support enabled/disabled identically";
+               if(this->CapKeys.find("CHANMODES") != this->CapKeys.end() && this->CapKeys.find("CHANMODES")->second != ServerInstance->Modes->GiveModeList(MASK_CHANNEL))
+                       reason = "One or more of the channel modes on the remote server are invalid on this server.";
+
+               if(this->CapKeys.find("USERMODES") != this->CapKeys.end() && this->CapKeys.find("USERMODES")->second != ServerInstance->Modes->GiveModeList(MASK_USER))
+                       reason = "One or more of the user modes on the remote server are invalid on this server.";
+
 
                /* Challenge response, store their challenge for our password */
                std::map<std::string,std::string>::iterator n = this->CapKeys.find("CHALLENGE");
@@ -197,9 +263,9 @@ bool TreeSocket::Capab(const std::deque<std::string> &params)
                        this->SetTheirChallenge(n->second);
                        if (!this->GetTheirChallenge().empty() && (this->LinkState == CONNECTING))
                        {
-                               this->SendCapabilities();
-                               this->WriteLine(std::string("SERVER ")+this->ServerInstance->Config->ServerName+" "+this->MakePass(OutboundPass, this->GetTheirChallenge())+" 0 "+
-                                               ServerInstance->Config->GetSID()+" :"+this->ServerInstance->Config->ServerDesc);
+                               this->SendCapabilities(2);
+                               this->WriteLine(std::string("SERVER ")+ServerInstance->Config->ServerName+" "+this->MakePass(OutboundPass, this->GetTheirChallenge())+" 0 "+
+                                               ServerInstance->Config->GetSID()+" :"+ServerInstance->Config->ServerDesc);
                        }
                }
                else
@@ -207,8 +273,8 @@ bool TreeSocket::Capab(const std::deque<std::string> &params)
                        /* They didnt specify a challenge or we don't have m_sha256.so, we use plaintext */
                        if (this->LinkState == CONNECTING)
                        {
-                               this->SendCapabilities();
-                               this->WriteLine(std::string("SERVER ")+this->ServerInstance->Config->ServerName+" "+OutboundPass+" 0 "+ServerInstance->Config->GetSID()+" :"+this->ServerInstance->Config->ServerDesc);
+                               this->SendCapabilities(2);
+                               this->WriteLine(std::string("SERVER ")+ServerInstance->Config->ServerName+" "+OutboundPass+" 0 "+ServerInstance->Config->GetSID()+" :"+ServerInstance->Config->ServerDesc);
                        }
                }
 
@@ -230,7 +296,18 @@ bool TreeSocket::Capab(const std::deque<std::string> &params)
                        this->ModuleList.append(params[1]);
                }
        }
-
+       else if ((params[0] == "MODSUPPORT") && (params.size() == 2))
+       {
+               if (!this->OptModuleList.length())
+               {
+                       this->OptModuleList.append(params[1]);
+               }
+               else
+               {
+                       this->OptModuleList.append(",");
+                       this->OptModuleList.append(params[1]);
+               }
+       }
        else if ((params[0] == "CAPABILITIES") && (params.size() == 2))
        {
                irc::tokenstream capabs(params[1]);