]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/main.cpp
Add <autoconnect> blocks [jackmcbarn]
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / main.cpp
index 9e8fa7035636ddb46f81e64eddf87ef55c1e68c9..1bc3dfe3925b9f7fed8c62b400ea438f0f337316 100644 (file)
@@ -14,8 +14,6 @@
 /* $ModDesc: Provides a spanning tree server link protocol */
 
 #include "inspircd.h"
-#include "commands/cmd_whois.h"
-#include "commands/cmd_stats.h"
 #include "socket.h"
 #include "xline.h"
 #include "../transport.h"
@@ -38,32 +36,30 @@ ModuleSpanningTree::ModuleSpanningTree(InspIRCd* Me)
 {
        ServerInstance->Modules->UseInterface("BufferedSocketHook");
        Utils = new SpanningTreeUtilities(ServerInstance, this);
-       command_rconnect = new CommandRConnect(ServerInstance, this, Utils);
+       command_rconnect = new CommandRConnect(this, Utils);
        ServerInstance->AddCommand(command_rconnect);
-       command_rsquit = new CommandRSQuit(ServerInstance, this, Utils);
+       command_rsquit = new CommandRSQuit(this, Utils);
        ServerInstance->AddCommand(command_rsquit);
        RefreshTimer = new CacheRefreshTimer(ServerInstance, Utils);
        ServerInstance->Timers->AddTimer(RefreshTimer);
 
        Implementation eventlist[] =
        {
-               I_OnPreCommand, I_OnGetServerDescription, I_OnUserInvite, I_OnPostLocalTopicChange,
-               I_OnWallops, I_OnUserNotice, I_OnUserMessage, I_OnBackgroundTimer,
-               I_OnUserJoin, I_OnChangeLocalUserHost, I_OnChangeName, I_OnUserPart, I_OnUnloadModule,
+               I_OnPreCommand, I_OnGetServerDescription, I_OnUserInvite, I_OnPostTopicChange,
+               I_OnWallops, I_OnUserNotice, I_OnUserMessage, I_OnBackgroundTimer, I_OnUserJoin,
+               I_OnChangeLocalUserHost, I_OnChangeName, I_OnChangeIdent, I_OnUserPart, I_OnUnloadModule,
                I_OnUserQuit, I_OnUserPostNick, I_OnUserKick, I_OnRemoteKill, I_OnRehash, I_OnPreRehash,
-               I_OnOper, I_OnAddLine, I_OnDelLine, I_ProtoSendMode, I_OnMode, I_OnLoadModule,
-               I_OnStats, I_ProtoSendMetaData, I_OnEvent, I_OnSetAway, I_OnPostCommand
+               I_OnOper, I_OnAddLine, I_OnDelLine, I_OnMode, I_OnLoadModule, I_OnStats, I_OnEvent,
+               I_OnSetAway, I_OnPostCommand, I_OnUserConnect
        };
-       ServerInstance->Modules->Attach(eventlist, this, 30);
+       ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 
        delete ServerInstance->PI;
        ServerInstance->PI = new SpanningTreeProtocolInterface(this, Utils, ServerInstance);
        loopCall = false;
 
-       for (std::vector<User*>::const_iterator i = ServerInstance->Users->local_users.begin(); i != ServerInstance->Users->local_users.end(); i++)
-       {
-               ServerInstance->PI->Introduce(*i);
-       }
+       // update our local user count
+       Utils->TreeRoot->SetUserCount(ServerInstance->Users->local_users.size());
 }
 
 void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
@@ -248,13 +244,13 @@ void ModuleSpanningTree::DoPingChecks(time_t curtime)
        }
 }
 
-void ModuleSpanningTree::ConnectServer(Link* x)
+void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
 {
        bool ipvalid = true;
 
        if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name)))
        {
-               this->ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Not connecting to myself.");
+               ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Not connecting to myself.");
                return;
        }
 
@@ -279,17 +275,17 @@ void ModuleSpanningTree::ConnectServer(Link* x)
                /* Gave a hook, but it wasnt one we know */
                if ((!x->Hook.empty()) && (Utils->hooks.find(x->Hook.c_str()) == Utils->hooks.end()))
                        return;
-               TreeSocket* newsocket = new TreeSocket(Utils, ServerInstance, x->IPAddr,x->Port, x->Timeout ? x->Timeout : 10,x->Name.c_str(), x->Bind, x->Hook.empty() ? NULL : Utils->hooks[x->Hook.c_str()]);
+               TreeSocket* newsocket = new TreeSocket(Utils, ServerInstance, x->IPAddr,x->Port, x->Timeout ? x->Timeout : 10,x->Name.c_str(), x->Bind, y, x->Hook.empty() ? NULL : Utils->hooks[x->Hook.c_str()]);
                if (newsocket->GetFd() > -1)
                {
                        /* Handled automatically on success */
                }
                else
                {
-                       this->ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",x->Name.c_str(),strerror(errno));
+                       ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",x->Name.c_str(),strerror(errno));
                        if (ServerInstance->SocketCull.find(newsocket) == ServerInstance->SocketCull.end())
                                ServerInstance->SocketCull[newsocket] = newsocket;
-                       Utils->DoFailOver(x);
+                       Utils->DoFailOver(y);
                }
        }
        else
@@ -297,25 +293,26 @@ void ModuleSpanningTree::ConnectServer(Link* x)
                try
                {
                        bool cached;
-                       ServernameResolver* snr = new ServernameResolver((Module*)this, Utils, ServerInstance,x->IPAddr, *x, cached, start_type);
+                       ServernameResolver* snr = new ServernameResolver((Module*)this, Utils, ServerInstance,x->IPAddr, *x, cached, start_type, y);
                        ServerInstance->AddResolver(snr, cached);
                }
                catch (ModuleException& e)
                {
-                       this->ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",x->Name.c_str(), e.GetReason());
-                       Utils->DoFailOver(x);
+                       ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",x->Name.c_str(), e.GetReason());
+                       Utils->DoFailOver(y);
                }
        }
 }
 
 void ModuleSpanningTree::AutoConnectServers(time_t curtime)
 {
-       for (std::vector<Link>::iterator x = Utils->LinkBlocks.begin(); x < Utils->LinkBlocks.end(); x++)
+       for (std::vector<Autoconnect>::iterator x = Utils->AutoconnectBlocks.begin(); x < Utils->AutoconnectBlocks.end(); ++x)
        {
-               if ((x->AutoConnect) && (curtime >= x->NextConnectTime))
+               if (curtime >= x->NextConnectTime)
                {
-                       x->NextConnectTime = curtime + x->AutoConnect;
-                       TreeServer* CheckDupe = Utils->FindServer(x->Name.c_str());
+                       x->NextConnectTime = curtime + x->Period;
+                       TreeServer* CheckDupe = Utils->FindServer(x->Server.c_str());
+                       Link* y = Utils->FindLink(x->Server);
                        if (x->FailOver.length())
                        {
                                TreeServer* CheckFailOver = Utils->FindServer(x->FailOver.c_str());
@@ -331,8 +328,8 @@ void ModuleSpanningTree::AutoConnectServers(time_t curtime)
                        if (!CheckDupe)
                        {
                                // an autoconnected server is not connected. Check if its time to connect it
-                               ServerInstance->SNO->WriteToSnoMask('l',"AUTOCONNECT: Auto-connecting server \002%s\002 (%lu seconds until next attempt)",x->Name.c_str(),x->AutoConnect);
-                               this->ConnectServer(&(*x));
+                               ServerInstance->SNO->WriteToSnoMask('l',"AUTOCONNECT: Auto-connecting server \002%s\002 (%lu seconds until next attempt)",y->Name.c_str(),x->Period);
+                               this->ConnectServer(&(*y), &(*x));
                        }
                }
        }
@@ -340,7 +337,7 @@ void ModuleSpanningTree::AutoConnectServers(time_t curtime)
 
 void ModuleSpanningTree::DoConnectTimeout(time_t curtime)
 {
-       std::vector<Link*> failovers;
+       std::vector<Autoconnect*> failovers;
        for (std::map<TreeSocket*, std::pair<std::string, int> >::iterator i = Utils->timeoutlist.begin(); i != Utils->timeoutlist.end(); i++)
        {
                TreeSocket* s = i->first;
@@ -348,21 +345,19 @@ void ModuleSpanningTree::DoConnectTimeout(time_t curtime)
                if (curtime > s->age + p.second)
                {
                        ServerInstance->SNO->WriteToSnoMask('l',"CONNECT: Error connecting \002%s\002 (timeout of %d seconds)",p.first.c_str(),p.second);
+                       failovers.push_back(s->myautoconnect);
                        ServerInstance->SE->DelFd(s);
                        s->Close();
-                       Link* MyLink = Utils->FindLink(p.first);
-                       if (MyLink)
-                               failovers.push_back(MyLink);
                }
        }
        /* Trigger failover for each timed out socket */
-       for (std::vector<Link*>::const_iterator n = failovers.begin(); n != failovers.end(); ++n)
+       for (std::vector<Autoconnect*>::const_iterator n = failovers.begin(); n != failovers.end(); ++n)
        {
                Utils->DoFailOver(*n);
        }
 }
 
-int ModuleSpanningTree::HandleVersion(const std::vector<std::string>& parameters, User* user)
+ModResult ModuleSpanningTree::HandleVersion(const std::vector<std::string>& parameters, User* user)
 {
        // we've already checked if pcnt > 0, so this is safe
        TreeServer* found = Utils->FindServerMask(parameters[0]);
@@ -379,7 +374,7 @@ int ModuleSpanningTree::HandleVersion(const std::vector<std::string>& parameters
        {
                user->WriteNumeric(402, "%s %s :No such server",user->nick.c_str(),parameters[0].c_str());
        }
-       return 1;
+       return MOD_RES_DENY;
 }
 
 /* This method will attempt to get a message to a remote user.
@@ -399,7 +394,7 @@ void ModuleSpanningTree::RemoteMessage(User* user, const char* format, ...)
                ServerInstance->PI->SendUserNotice(user, text);
 }
 
-int ModuleSpanningTree::HandleConnect(const std::vector<std::string>& parameters, User* user)
+ModResult ModuleSpanningTree::HandleConnect(const std::vector<std::string>& parameters, User* user)
 {
        for (std::vector<Link>::iterator x = Utils->LinkBlocks.begin(); x < Utils->LinkBlocks.end(); x++)
        {
@@ -408,25 +403,25 @@ int ModuleSpanningTree::HandleConnect(const std::vector<std::string>& parameters
                        if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name)))
                        {
                                RemoteMessage(user, "*** CONNECT: Server \002%s\002 is ME, not connecting.",x->Name.c_str());
-                               return 1;
+                               return MOD_RES_DENY;
                        }
 
                        TreeServer* CheckDupe = Utils->FindServer(x->Name.c_str());
                        if (!CheckDupe)
                        {
                                RemoteMessage(user, "*** CONNECT: Connecting to server: \002%s\002 (%s:%d)",x->Name.c_str(),(x->HiddenFromStats ? "<hidden>" : x->IPAddr.c_str()),x->Port);
-                               ConnectServer(&(*x));
-                               return 1;
+                               ConnectServer(&(*x), NULL);
+                               return MOD_RES_DENY;
                        }
                        else
                        {
                                RemoteMessage(user, "*** CONNECT: Server \002%s\002 already exists on the network and is connected via \002%s\002",x->Name.c_str(),CheckDupe->GetParent()->GetName().c_str());
-                               return 1;
+                               return MOD_RES_DENY;
                        }
                }
        }
        RemoteMessage(user, "*** CONNECT: No server matching \002%s\002 could be found in the config file.",parameters[0].c_str());
-       return 1;
+       return MOD_RES_DENY;
 }
 
 void ModuleSpanningTree::OnGetServerDescription(const std::string &servername,std::string &description)
@@ -442,7 +437,7 @@ void ModuleSpanningTree::OnUserInvite(User* source,User* dest,Channel* channel,
 {
        if (IS_LOCAL(source))
        {
-               std::deque<std::string> params;
+               parameterlist params;
                params.push_back(dest->uuid);
                params.push_back(channel->name);
                params.push_back(ConvToStr(expiry));
@@ -450,9 +445,13 @@ void ModuleSpanningTree::OnUserInvite(User* source,User* dest,Channel* channel,
        }
 }
 
-void ModuleSpanningTree::OnPostLocalTopicChange(User* user, Channel* chan, const std::string &topic)
+void ModuleSpanningTree::OnPostTopicChange(User* user, Channel* chan, const std::string &topic)
 {
-       std::deque<std::string> params;
+       // Drop remote events on the floor.
+       if (!IS_LOCAL(user))
+               return;
+
+       parameterlist params;
        params.push_back(chan->name);
        params.push_back(":"+topic);
        Utils->DoOneToMany(user->uuid,"TOPIC",params);
@@ -462,7 +461,7 @@ void ModuleSpanningTree::OnWallops(User* user, const std::string &text)
 {
        if (IS_LOCAL(user))
        {
-               std::deque<std::string> params;
+               parameterlist params;
                params.push_back(":"+text);
                Utils->DoOneToMany(user->uuid,"WALLOPS",params);
        }
@@ -479,8 +478,7 @@ void ModuleSpanningTree::OnUserNotice(User* user, void* dest, int target_type, c
                User* d = (User*)dest;
                if ((d->GetFd() < 0) && (IS_LOCAL(user)))
                {
-                       std::deque<std::string> params;
-                       params.clear();
+                       parameterlist params;
                        params.push_back(d->uuid);
                        params.push_back(":"+text);
                        Utils->DoOneToOne(user->uuid,"NOTICE",params,d->server);
@@ -512,7 +510,7 @@ void ModuleSpanningTree::OnUserNotice(User* user, void* dest, int target_type, c
                if (IS_LOCAL(user))
                {
                        char* target = (char*)dest;
-                       std::deque<std::string> par;
+                       parameterlist par;
                        par.push_back(target);
                        par.push_back(":"+text);
                        Utils->DoOneToMany(user->uuid,"NOTICE",par);
@@ -533,8 +531,7 @@ void ModuleSpanningTree::OnUserMessage(User* user, void* dest, int target_type,
                User* d = (User*)dest;
                if ((d->GetFd() < 0) && (IS_LOCAL(user)))
                {
-                       std::deque<std::string> params;
-                       params.clear();
+                       parameterlist params;
                        params.push_back(d->uuid);
                        params.push_back(":"+text);
                        Utils->DoOneToOne(user->uuid,"PRIVMSG",params,d->server);
@@ -566,7 +563,7 @@ void ModuleSpanningTree::OnUserMessage(User* user, void* dest, int target_type,
                if (IS_LOCAL(user))
                {
                        char* target = (char*)dest;
-                       std::deque<std::string> par;
+                       parameterlist par;
                        par.push_back(target);
                        par.push_back(":"+text);
                        Utils->DoOneToMany(user->uuid,"PRIVMSG",par);
@@ -581,32 +578,53 @@ void ModuleSpanningTree::OnBackgroundTimer(time_t curtime)
        DoConnectTimeout(curtime);
 }
 
-void ModuleSpanningTree::OnUserJoin(User* user, Channel* channel, bool sync, bool &silent)
+void ModuleSpanningTree::OnUserConnect(User* user)
+{
+       if (user->quitting)
+               return;
+
+       parameterlist params;
+       params.push_back(user->uuid);
+       params.push_back(ConvToStr(user->age));
+       params.push_back(user->nick);
+       params.push_back(user->host);
+       params.push_back(user->dhost);
+       params.push_back(user->ident);
+       params.push_back(user->GetIPString());
+       params.push_back(ConvToStr(user->signon));
+       params.push_back("+"+std::string(user->FormatModes(true)));
+       params.push_back(":"+std::string(user->fullname));
+       Utils->DoOneToMany(ServerInstance->Config->GetSID(), "UID", params);
+
+       Utils->TreeRoot->SetUserCount(1); // increment by 1
+}
+
+void ModuleSpanningTree::OnUserJoin(Membership* memb, bool sync, bool created, CUList& excepts)
 {
        // Only do this for local users
-       if (IS_LOCAL(user))
+       if (IS_LOCAL(memb->user))
        {
-               std::deque<std::string> params;
+               parameterlist params;
                // set up their permissions and the channel TS with FJOIN.
                // All users are FJOINed now, because a module may specify
                // new joining permissions for the user.
-               params.push_back(channel->name);
-               params.push_back(ConvToStr(channel->age));
-               params.push_back(std::string("+") + channel->ChanModes(true));
-               params.push_back(ServerInstance->Modes->ModeString(user, channel, false)+","+std::string(user->uuid));
+               params.push_back(memb->chan->name);
+               params.push_back(ConvToStr(memb->chan->age));
+               params.push_back(std::string("+") + memb->chan->ChanModes(true));
+               params.push_back(memb->modes+","+std::string(memb->user->uuid));
                Utils->DoOneToMany(ServerInstance->Config->GetSID(),"FJOIN",params);
        }
 }
 
-int ModuleSpanningTree::OnChangeLocalUserHost(User* user, const std::string &newhost)
+ModResult ModuleSpanningTree::OnChangeLocalUserHost(User* user, const std::string &newhost)
 {
        if (user->registered != REG_ALL)
-               return 0;
+               return MOD_RES_PASSTHRU;
 
-       std::deque<std::string> params;
+       parameterlist params;
        params.push_back(newhost);
        Utils->DoOneToMany(user->uuid,"FHOST",params);
-       return 0;
+       return MOD_RES_PASSTHRU;
 }
 
 void ModuleSpanningTree::OnChangeName(User* user, const std::string &gecos)
@@ -615,20 +633,31 @@ void ModuleSpanningTree::OnChangeName(User* user, const std::string &gecos)
        if (user->registered != REG_ALL)
                return;
 
-       std::deque<std::string> params;
+       parameterlist params;
        params.push_back(gecos);
        Utils->DoOneToMany(user->uuid,"FNAME",params);
 }
 
-void ModuleSpanningTree::OnUserPart(User* user, Channel* channel,  std::string &partmessage, bool &silent)
+void ModuleSpanningTree::OnChangeIdent(User* user, const std::string &ident)
 {
-       if (IS_LOCAL(user))
+       // only occurs for local clients
+       if (user->registered != REG_ALL)
+               return;
+
+       parameterlist params;
+       params.push_back(ident);
+       Utils->DoOneToMany(user->uuid,"FIDENT",params);
+}
+
+void ModuleSpanningTree::OnUserPart(Membership* memb, std::string &partmessage, CUList& excepts)
+{
+       if (IS_LOCAL(memb->user))
        {
-               std::deque<std::string> params;
-               params.push_back(channel->name);
+               parameterlist params;
+               params.push_back(memb->chan->name);
                if (!partmessage.empty())
                        params.push_back(":"+partmessage);
-               Utils->DoOneToMany(user->uuid,"PART",params);
+               Utils->DoOneToMany(memb->user->uuid,"PART",params);
        }
 }
 
@@ -636,7 +665,7 @@ void ModuleSpanningTree::OnUserQuit(User* user, const std::string &reason, const
 {
        if ((IS_LOCAL(user)) && (user->registered == REG_ALL))
        {
-               std::deque<std::string> params;
+               parameterlist params;
 
                if (oper_message != reason)
                {
@@ -660,7 +689,7 @@ void ModuleSpanningTree::OnUserPostNick(User* user, const std::string &oldnick)
 {
        if (IS_LOCAL(user))
        {
-               std::deque<std::string> params;
+               parameterlist params;
                params.push_back(user->nick);
 
                /** IMPORTANT: We don't update the TS if the oldnick is just a case change of the newnick!
@@ -671,13 +700,20 @@ void ModuleSpanningTree::OnUserPostNick(User* user, const std::string &oldnick)
                params.push_back(ConvToStr(user->age));
                Utils->DoOneToMany(user->uuid,"NICK",params);
        }
+       else if (!loopCall && user->nick == user->uuid)
+       {
+               parameterlist params;
+               params.push_back(user->uuid);
+               params.push_back(ConvToStr(user->age));
+               Utils->DoOneToMany(ServerInstance->Config->GetSID(),"SAVE",params);
+       }
 }
 
-void ModuleSpanningTree::OnUserKick(User* source, User* user, Channel* chan, const std::string &reason, bool &silent)
+void ModuleSpanningTree::OnUserKick(User* source, Membership* memb, const std::string &reason, CUList& excepts)
 {
-       std::deque<std::string> params;
-       params.push_back(chan->name);
-       params.push_back(user->uuid);
+       parameterlist params;
+       params.push_back(memb->chan->name);
+       params.push_back(memb->user->uuid);
        params.push_back(":"+reason);
        if (IS_LOCAL(source))
        {
@@ -694,13 +730,13 @@ void ModuleSpanningTree::OnRemoteKill(User* source, User* dest, const std::strin
        if (!IS_LOCAL(source))
                return; // Only start routing if we're origin.
 
-       std::deque<std::string> params;
-       params.push_back(":"+reason);
+       User::OperQuit.set(dest, operreason);
+       parameterlist params;
+       params.push_back(":"+operreason);
        Utils->DoOneToMany(dest->uuid,"OPERQUIT",params);
        params.clear();
        params.push_back(dest->uuid);
        params.push_back(":"+reason);
-       dest->SetOperQuit(operreason);
        Utils->DoOneToMany(source->uuid,"KILL",params);
 }
 
@@ -711,7 +747,7 @@ void ModuleSpanningTree::OnPreRehash(User* user, const std::string &parameter)
        // Send out to other servers
        if (!parameter.empty() && parameter[0] != '-')
        {
-               std::deque<std::string> params;
+               parameterlist params;
                params.push_back(parameter);
                Utils->DoOneToAllButSender(user ? user->uuid : ServerInstance->Config->GetSID(), "REHASH", params, user ? user->server : ServerInstance->Config->ServerName);
        }
@@ -758,7 +794,7 @@ void ModuleSpanningTree::OnOper(User* user, const std::string &opertype)
 {
        if (IS_LOCAL(user))
        {
-               std::deque<std::string> params;
+               parameterlist params;
                params.push_back(opertype);
                Utils->DoOneToMany(user->uuid,"OPERTYPE",params);
        }
@@ -771,8 +807,8 @@ void ModuleSpanningTree::OnAddLine(User* user, XLine *x)
 
        char data[MAXBUF];
        snprintf(data,MAXBUF,"%s %s %s %lu %lu :%s", x->type.c_str(), x->Displayable(),
-       ServerInstance->Config->ServerName, (unsigned long)x->set_time, (unsigned long)x->duration, x->reason);
-       std::deque<std::string> params;
+       ServerInstance->Config->ServerName, (unsigned long)x->set_time, (unsigned long)x->duration, x->reason.c_str());
+       parameterlist params;
        params.push_back(data);
 
        if (!user)
@@ -794,7 +830,7 @@ void ModuleSpanningTree::OnDelLine(User* user, XLine *x)
 
        char data[MAXBUF];
        snprintf(data,MAXBUF,"%s %s", x->type.c_str(), x->Displayable());
-       std::deque<std::string> params;
+       parameterlist params;
        params.push_back(data);
 
        if (!user)
@@ -809,11 +845,11 @@ void ModuleSpanningTree::OnDelLine(User* user, XLine *x)
        }
 }
 
-void ModuleSpanningTree::OnMode(User* user, void* dest, int target_type, const std::deque<std::string> &text, const std::deque<TranslateType> &translate)
+void ModuleSpanningTree::OnMode(User* user, void* dest, int target_type, const parameterlist &text, const std::vector<TranslateType> &translate)
 {
        if ((IS_LOCAL(user)) && (user->registered == REG_ALL))
        {
-               std::deque<std::string> params;
+               parameterlist params;
                std::string command;
                std::string output_text;
 
@@ -839,28 +875,28 @@ void ModuleSpanningTree::OnMode(User* user, void* dest, int target_type, const s
        }
 }
 
-int ModuleSpanningTree::OnSetAway(User* user, const std::string &awaymsg)
+ModResult ModuleSpanningTree::OnSetAway(User* user, const std::string &awaymsg)
 {
        if (IS_LOCAL(user))
        {
                if (awaymsg.empty())
                {
-                       std::deque<std::string> params;
-                       params.clear();
+                       parameterlist params;
                        Utils->DoOneToMany(user->uuid,"AWAY",params);
                }
                else
                {
-                       std::deque<std::string> params;
+                       parameterlist params;
+                       params.push_back(ConvToStr(user->awaytime));
                        params.push_back(":" + awaymsg);
                        Utils->DoOneToMany(user->uuid,"AWAY",params);
                }
        }
 
-       return 0;
+       return MOD_RES_PASSTHRU;
 }
 
-void ModuleSpanningTree::ProtoSendMode(void* opaque, TargetTypeFlags target_type, void* target, const std::deque<std::string> &modeline, const std::deque<TranslateType> &translate)
+void ModuleSpanningTree::ProtoSendMode(void* opaque, TargetTypeFlags target_type, void* target, const parameterlist &modeline, const std::vector<TranslateType> &translate)
 {
        TreeSocket* s = (TreeSocket*)opaque;
        std::string output_text;
@@ -882,26 +918,17 @@ void ModuleSpanningTree::ProtoSendMode(void* opaque, TargetTypeFlags target_type
        }
 }
 
-void ModuleSpanningTree::ProtoSendMetaData(void* opaque, TargetTypeFlags target_type, void* target, const std::string &extname, const std::string &extdata)
+void ModuleSpanningTree::ProtoSendMetaData(void* opaque, Extensible* target, const std::string &extname, const std::string &extdata)
 {
-       TreeSocket* s = (TreeSocket*)opaque;
-       if (target)
-       {
-               if (target_type == TYPE_USER)
-               {
-                       User* u = (User*)target;
-                       s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" METADATA "+u->uuid+" "+extname+" :"+extdata);
-               }
-               else if (target_type == TYPE_CHANNEL)
-               {
-                       Channel* c = (Channel*)target;
-                       s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" METADATA "+c->name+" "+extname+" :"+extdata);
-               }
-       }
-       if (target_type == TYPE_OTHER)
-       {
+       TreeSocket* s = static_cast<TreeSocket*>(opaque);
+       User* u = dynamic_cast<User*>(target);
+       Channel* c = dynamic_cast<Channel*>(target);
+       if (u)
+               s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" METADATA "+u->uuid+" "+extname+" :"+extdata);
+       else if (c)
+               s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" METADATA "+c->name+" "+extname+" :"+extdata);
+       else if (!target)
                s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" METADATA * "+extname+" :"+extdata);
-       }
 }
 
 void ModuleSpanningTree::OnEvent(Event* event)
@@ -921,6 +948,9 @@ ModuleSpanningTree::~ModuleSpanningTree()
        /* This will also free the listeners */
        delete Utils;
 
+       delete command_rconnect;
+       delete command_rsquit;
+
        ServerInstance->Timers->DelTimer(RefreshTimer);
 
        ServerInstance->Modules->DoneWithInterface("BufferedSocketHook");