]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/main.cpp
Fix an shadowing warning in the spanningtree module.
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / main.cpp
index e5e6e522bf8216b837b3cdbffb52cee60e0c21fd..3e992f39f90f043355c76437e2e778d74df10dd8 100644 (file)
 #include "translate.h"
 
 ModuleSpanningTree::ModuleSpanningTree()
-       : rconnect(this), rsquit(this), map(this)
-       , commands(NULL)
+       : Away::EventListener(this)
+       , Stats::EventListener(this)
+       , CTCTags::EventListener(this)
+       , rconnect(this)
+       , rsquit(this)
+       , map(this)
+       , commands(this)
        , currmembid(0)
-       , eventprov(this, "event/spanningtree")
+       , broadcasteventprov(this, "event/server-broadcast")
+       , linkeventprov(this, "event/server-link")
+       , messageeventprov(this, "event/server-message")
+       , synceventprov(this, "event/server-sync")
+       , sslapi(this)
        , DNS(this, "DNS")
+       , tagevprov(this, "event/messagetag")
        , loopCall(false)
 {
 }
@@ -50,9 +60,9 @@ SpanningTreeCommands::SpanningTreeCommands(ModuleSpanningTree* module)
        uid(module), opertype(module), fjoin(module), ijoin(module), resync(module),
        fmode(module), ftopic(module), fhost(module), fident(module), fname(module),
        away(module), addline(module), delline(module), encap(module), idle(module),
-       nick(module), ping(module), pong(module), push(module), save(module),
+       nick(module), ping(module), pong(module), save(module),
        server(module), squit(module), snonotice(module),
-       endburst(module), sinfo(module)
+       endburst(module), sinfo(module), num(module)
 {
 }
 
@@ -89,7 +99,6 @@ void ModuleSpanningTree::init()
 
        Utils = new SpanningTreeUtilities(this);
        Utils->TreeRoot = new TreeServer;
-       commands = new SpanningTreeCommands(this);
 
        ServerInstance->PI = &protocolinterface;
 
@@ -128,30 +137,15 @@ void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
        else if ((Current->Hidden) && (!user->IsOper()))
                return;
 
-       user->WriteNumeric(RPL_LINKS, "%s %s :%d %s",   Current->GetName().c_str(),
-                       (Utils->FlatLinks && (!user->IsOper())) ? ServerInstance->Config->ServerName.c_str() : Parent.c_str(),
-                       (Utils->FlatLinks && (!user->IsOper())) ? 0 : hops,
-                       Current->GetDesc().c_str());
+       user->WriteNumeric(RPL_LINKS, Current->GetName(),
+                       (((Utils->FlatLinks) && (!user->IsOper())) ? ServerInstance->Config->ServerName : Parent),
+                       InspIRCd::Format("%d %s", (((Utils->FlatLinks) && (!user->IsOper())) ? 0 : hops), Current->GetDesc().c_str()));
 }
 
-void ModuleSpanningTree::HandleLinks(const std::vector<std::string>& parameters, User* user)
+void ModuleSpanningTree::HandleLinks(const CommandBase::Params& parameters, User* user)
 {
        ShowLinks(Utils->TreeRoot,user,0);
-       user->WriteNumeric(RPL_ENDOFLINKS, "* :End of /LINKS list.");
-}
-
-std::string ModuleSpanningTree::TimeToStr(time_t secs)
-{
-       time_t mins_up = secs / 60;
-       time_t hours_up = mins_up / 60;
-       time_t days_up = hours_up / 24;
-       secs = secs % 60;
-       mins_up = mins_up % 60;
-       hours_up = hours_up % 24;
-       return ((days_up ? (ConvToStr(days_up) + "d") : "")
-                       + (hours_up ? (ConvToStr(hours_up) + "h") : "")
-                       + (mins_up ? (ConvToStr(mins_up) + "m") : "")
-                       + ConvToStr(secs) + "s");
+       user->WriteNumeric(RPL_ENDOFLINKS, '*', "End of /LINKS list.");
 }
 
 void ModuleSpanningTree::ConnectServer(Autoconnect* a, bool on_timer)
@@ -193,33 +187,35 @@ void ModuleSpanningTree::ConnectServer(Autoconnect* a, bool on_timer)
 
 void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
 {
-       bool ipvalid = true;
-
-       if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name), rfc_case_insensitive_map))
+       if (InspIRCd::Match(ServerInstance->Config->ServerName, x->Name, ascii_case_insensitive_map))
        {
                ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Not connecting to myself.");
                return;
        }
 
-       DNS::QueryType start_type = DNS::QUERY_AAAA;
-       if (strchr(x->IPAddr.c_str(),':'))
+       irc::sockets::sockaddrs sa;
+       if (x->IPAddr.find('/') != std::string::npos)
        {
-               in6_addr n;
-               if (inet_pton(AF_INET6, x->IPAddr.c_str(), &n) < 1)
-                       ipvalid = false;
+               if (!irc::sockets::isunix(x->IPAddr) || !irc::sockets::untosa(x->IPAddr, sa))
+               {
+                       // We don't use the family() != AF_UNSPEC check below for UNIX sockets as
+                       // that results in a DNS lookup.
+                       ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s is not a UNIX socket!",
+                               x->Name.c_str(), x->IPAddr.c_str());
+                       return;
+               }
        }
        else
        {
-               in_addr n;
-               if (inet_aton(x->IPAddr.c_str(),&n) < 1)
-                       ipvalid = false;
+               // If this fails then the IP sa will be AF_UNSPEC.
+               irc::sockets::aptosa(x->IPAddr, x->Port, sa);
        }
-
+       
        /* Do we already have an IP? If so, no need to resolve it. */
-       if (ipvalid)
+       if (sa.family() != AF_UNSPEC)
        {
-               /* Gave a hook, but it wasnt one we know */
-               TreeSocket* newsocket = new TreeSocket(x, y, x->IPAddr);
+               // Create a TreeServer object that will start connecting immediately in the background
+               TreeSocket* newsocket = new TreeSocket(x, y, sa);
                if (newsocket->GetFd() > -1)
                {
                        /* Handled automatically on success */
@@ -233,10 +229,19 @@ void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
        }
        else if (!DNS)
        {
-               ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: Hostname given and m_dns.so is not loaded, unable to resolve.", x->Name.c_str());
+               ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: Hostname given and core_dns is not loaded, unable to resolve.", x->Name.c_str());
        }
        else
        {
+               // Guess start_type from bindip aftype
+               DNS::QueryType start_type = DNS::QUERY_AAAA;
+               irc::sockets::sockaddrs bind;
+               if ((!x->Bind.empty()) && (irc::sockets::aptosa(x->Bind, 0, bind)))
+               {
+                       if (bind.family() == AF_INET)
+                               start_type = DNS::QUERY_A;
+               }
+
                ServernameResolver* snr = new ServernameResolver(*DNS, x->IPAddr, x, start_type, y);
                try
                {
@@ -266,12 +271,12 @@ void ModuleSpanningTree::AutoConnectServers(time_t curtime)
 
 void ModuleSpanningTree::DoConnectTimeout(time_t curtime)
 {
-       std::map<TreeSocket*, std::pair<std::string, int> >::iterator i = Utils->timeoutlist.begin();
+       SpanningTreeUtilities::TimeoutList::iterator i = Utils->timeoutlist.begin();
        while (i != Utils->timeoutlist.end())
        {
                TreeSocket* s = i->first;
-               std::pair<std::string, int> p = i->second;
-               std::map<TreeSocket*, std::pair<std::string, int> >::iterator me = i;
+               std::pair<std::string, unsigned int> p = i->second;
+               SpanningTreeUtilities::TimeoutList::iterator me = i;
                i++;
                if (s->GetLinkState() == DYING)
                {
@@ -280,16 +285,16 @@ void ModuleSpanningTree::DoConnectTimeout(time_t curtime)
                }
                else if (curtime > s->age + p.second)
                {
-                       ServerInstance->SNO->WriteToSnoMask('l',"CONNECT: Error connecting \002%s\002 (timeout of %d seconds)",p.first.c_str(),p.second);
+                       ServerInstance->SNO->WriteToSnoMask('l',"CONNECT: Error connecting \002%s\002 (timeout of %u seconds)",p.first.c_str(),p.second);
                        Utils->timeoutlist.erase(me);
                        s->Close();
                }
        }
 }
 
-ModResult ModuleSpanningTree::HandleVersion(const std::vector<std::string>& parameters, User* user)
+ModResult ModuleSpanningTree::HandleVersion(const CommandBase::Params& parameters, User* user)
 {
-       // we've already checked if pcnt > 0, so this is safe
+       // We've already confirmed that !parameters.empty(), so this is safe
        TreeServer* found = Utils->FindServerMask(parameters[0]);
        if (found)
        {
@@ -304,73 +309,76 @@ ModResult ModuleSpanningTree::HandleVersion(const std::vector<std::string>& para
                // If it's empty it might be that the server is still syncing (full version hasn't arrived yet)
                // or the server is a 2.0 server and does not send a full version.
                bool showfull = ((user->IsOper()) && (!found->GetFullVersion().empty()));
-               const std::string& Version = (showfull ? found->GetFullVersion() : found->GetVersion());
-               user->WriteNumeric(RPL_VERSION, ":%s", Version.c_str());
+
+               Numeric::Numeric numeric(RPL_VERSION);
+               irc::tokenstream tokens(showfull ? found->GetFullVersion() : found->GetVersion());
+               for (std::string token; tokens.GetTrailing(token); )
+                       numeric.push(token);
+               user->WriteNumeric(numeric);
        }
        else
        {
-               user->WriteNumeric(ERR_NOSUCHSERVER, "%s :No such server", parameters[0].c_str());
+               user->WriteNumeric(ERR_NOSUCHSERVER, parameters[0], "No such server");
        }
        return MOD_RES_DENY;
 }
 
-/* This method will attempt to get a message to a remote user.
- */
-void ModuleSpanningTree::RemoteMessage(User* user, const char* format, ...)
-{
-       std::string text;
-       VAFORMAT(text, format, format);
-
-       if (IS_LOCAL(user))
-               user->WriteNotice(text);
-       else
-               ServerInstance->PI->SendUserNotice(user, text);
-}
-
-ModResult ModuleSpanningTree::HandleConnect(const std::vector<std::string>& parameters, User* user)
+ModResult ModuleSpanningTree::HandleConnect(const CommandBase::Params& parameters, User* user)
 {
        for (std::vector<reference<Link> >::iterator i = Utils->LinkBlocks.begin(); i < Utils->LinkBlocks.end(); i++)
        {
                Link* x = *i;
-               if (InspIRCd::Match(x->Name.c_str(),parameters[0], rfc_case_insensitive_map))
+               if (InspIRCd::Match(x->Name, parameters[0], ascii_case_insensitive_map))
                {
-                       if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name), rfc_case_insensitive_map))
+                       if (InspIRCd::Match(ServerInstance->Config->ServerName, x->Name, ascii_case_insensitive_map))
                        {
-                               RemoteMessage(user, "*** CONNECT: Server \002%s\002 is ME, not connecting.",x->Name.c_str());
+                               user->WriteRemoteNotice(InspIRCd::Format("*** CONNECT: Server \002%s\002 is ME, not connecting.", x->Name.c_str()));
                                return MOD_RES_DENY;
                        }
 
-                       TreeServer* CheckDupe = Utils->FindServer(x->Name.c_str());
+                       TreeServer* CheckDupe = Utils->FindServer(x->Name);
                        if (!CheckDupe)
                        {
-                               RemoteMessage(user, "*** CONNECT: Connecting to server: \002%s\002 (%s:%d)",x->Name.c_str(),(x->HiddenFromStats ? "<hidden>" : x->IPAddr.c_str()),x->Port);
+                               user->WriteRemoteNotice(InspIRCd::Format("*** CONNECT: Connecting to server: \002%s\002 (%s:%d)", x->Name.c_str(), (x->HiddenFromStats ? "<hidden>" : x->IPAddr.c_str()), x->Port));
                                ConnectServer(x);
                                return MOD_RES_DENY;
                        }
                        else
                        {
-                               RemoteMessage(user, "*** CONNECT: Server \002%s\002 already exists on the network and is connected via \002%s\002", x->Name.c_str(), CheckDupe->GetParent()->GetName().c_str());
+                               user->WriteRemoteNotice(InspIRCd::Format("*** CONNECT: Server \002%s\002 already exists on the network and is connected via \002%s\002", x->Name.c_str(), CheckDupe->GetParent()->GetName().c_str()));
                                return MOD_RES_DENY;
                        }
                }
        }
-       RemoteMessage(user, "*** CONNECT: No server matching \002%s\002 could be found in the config file.",parameters[0].c_str());
+       user->WriteRemoteNotice(InspIRCd::Format("*** CONNECT: No server matching \002%s\002 could be found in the config file.", parameters[0].c_str()));
        return MOD_RES_DENY;
 }
 
-void ModuleSpanningTree::OnUserInvite(User* source,User* dest,Channel* channel, time_t expiry)
+void ModuleSpanningTree::OnUserInvite(User* source, User* dest, Channel* channel, time_t expiry, unsigned int notifyrank, CUList& notifyexcepts)
 {
        if (IS_LOCAL(source))
        {
                CmdBuilder params(source, "INVITE");
-               params.push_back(dest->uuid);
-               params.push_back(channel->name);
+               params.push(dest->uuid);
+               params.push(channel->name);
                params.push_int(channel->age);
-               params.push_back(ConvToStr(expiry));
+               params.push(ConvToStr(expiry));
                params.Broadcast();
        }
 }
 
+ModResult ModuleSpanningTree::OnPreTopicChange(User* user, Channel* chan, const std::string& topic)
+{
+       // XXX: Deny topic changes if the current topic set time is the current time or is in the future because
+       // other servers will drop our FTOPIC. This restriction will be removed when the protocol is updated.
+       if ((chan->topicset >= ServerInstance->Time()) && (Utils->serverlist.size() > 1))
+       {
+               user->WriteNumeric(ERR_CHANOPRIVSNEEDED, chan->name, "Retry topic change later");
+               return MOD_RES_DENY;
+       }
+       return MOD_RES_PASSTHRU;
+}
+
 void ModuleSpanningTree::OnPostTopicChange(User* user, Channel* chan, const std::string &topic)
 {
        // Drop remote events on the floor.
@@ -380,34 +388,78 @@ void ModuleSpanningTree::OnPostTopicChange(User* user, Channel* chan, const std:
        CommandFTopic::Builder(user, chan).Broadcast();
 }
 
-void ModuleSpanningTree::OnUserMessage(User* user, void* dest, int target_type, const std::string& text, char status, const CUList& exempt_list, MessageType msgtype)
+void ModuleSpanningTree::OnUserPostMessage(User* user, const MessageTarget& target, const MessageDetails& details)
 {
        if (!IS_LOCAL(user))
                return;
 
-       const char* message_type = (msgtype == MSG_PRIVMSG ? "PRIVMSG" : "NOTICE");
-       if (target_type == TYPE_USER)
+       const char* message_type = (details.type == MSG_PRIVMSG ? "PRIVMSG" : "NOTICE");
+       switch (target.type)
        {
-               User* d = (User*) dest;
-               if (!IS_LOCAL(d))
+               case MessageTarget::TYPE_USER:
                {
-                       CmdBuilder params(user, message_type);
-                       params.push_back(d->uuid);
-                       params.push_last(text);
-                       params.Unicast(d);
+                       User* d = target.Get<User>();
+                       if (!IS_LOCAL(d))
+                       {
+                               CmdBuilder params(user, message_type);
+                               params.push_tags(details.tags_out);
+                               params.push(d->uuid);
+                               params.push_last(details.text);
+                               params.Unicast(d);
+                       }
+                       break;
+               }
+               case MessageTarget::TYPE_CHANNEL:
+               {
+                       Utils->SendChannelMessage(user, target.Get<Channel>(), details.text, target.status, details.tags_out, details.exemptions, message_type);
+                       break;
+               }
+               case MessageTarget::TYPE_SERVER:
+               {
+                       const std::string* serverglob = target.Get<std::string>();
+                       CmdBuilder par(user, message_type);
+                       par.push_tags(details.tags_out);
+                       par.push(*serverglob);
+                       par.push_last(details.text);
+                       par.Broadcast();
+                       break;
                }
        }
-       else if (target_type == TYPE_CHANNEL)
-       {
-               Utils->SendChannelMessage(user->uuid, (Channel*)dest, text, status, exempt_list, message_type);
-       }
-       else if (target_type == TYPE_SERVER)
+}
+
+void ModuleSpanningTree::OnUserPostTagMessage(User* user, const MessageTarget& target, const CTCTags::TagMessageDetails& details)
+{
+       if (!IS_LOCAL(user))
+               return;
+
+       switch (target.type)
        {
-               char* target = (char*) dest;
-               CmdBuilder par(user, message_type);
-               par.push_back(target);
-               par.push_last(text);
-               par.Broadcast();
+               case MessageTarget::TYPE_USER:
+               {
+                       User* d = target.Get<User>();
+                       if (!IS_LOCAL(d))
+                       {
+                               CmdBuilder params(user, "TAGMSG");
+                               params.push_tags(details.tags_out);
+                               params.push(d->uuid);
+                               params.Unicast(d);
+                       }
+                       break;
+               }
+               case MessageTarget::TYPE_CHANNEL:
+               {
+                       Utils->SendChannelMessage(user, target.Get<Channel>(), "", target.status, details.tags_out, details.exemptions, "TAGMSG");
+                       break;
+               }
+               case MessageTarget::TYPE_SERVER:
+               {
+                       const std::string* serverglob = target.Get<std::string>();
+                       CmdBuilder par(user, "TAGMSG");
+                       par.push_tags(details.tags_out);
+                       par.push(*serverglob);
+                       par.Broadcast();
+                       break;
+               }
        }
 }
 
@@ -422,6 +474,10 @@ void ModuleSpanningTree::OnUserConnect(LocalUser* user)
        if (user->quitting)
                return;
 
+       // Create the lazy ssl_cert metadata for this user if not already created.
+       if (sslapi)
+               sslapi->GetCertificate(user);
+
        CommandUID::Builder(user).Broadcast();
 
        if (user->IsOper())
@@ -430,7 +486,7 @@ void ModuleSpanningTree::OnUserConnect(LocalUser* user)
        for(Extensible::ExtensibleStore::const_iterator i = user->GetExtList().begin(); i != user->GetExtList().end(); i++)
        {
                ExtensionItem* item = i->first;
-               std::string value = item->serialize(FORMAT_NETWORK, user, i->second);
+               std::string value = item->ToNetwork(user, i->second);
                if (!value.empty())
                        ServerInstance->PI->SendMetaData(user, item->name, value);
        }
@@ -457,12 +513,12 @@ void ModuleSpanningTree::OnUserJoin(Membership* memb, bool sync, bool created_by
        else
        {
                CmdBuilder params(memb->user, "IJOIN");
-               params.push_back(memb->chan->name);
+               params.push(memb->chan->name);
                params.push_int(memb->id);
                if (!memb->modes.empty())
                {
-                       params.push_back(ConvToStr(memb->chan->age));
-                       params.push_back(memb->modes);
+                       params.push(ConvToStr(memb->chan->age));
+                       params.push(memb->modes);
                }
                params.Broadcast();
        }
@@ -476,12 +532,12 @@ void ModuleSpanningTree::OnChangeHost(User* user, const std::string &newhost)
        CmdBuilder(user, "FHOST").push(newhost).Broadcast();
 }
 
-void ModuleSpanningTree::OnChangeName(User* user, const std::string &gecos)
+void ModuleSpanningTree::OnChangeRealName(User* user, const std::string& real)
 {
        if (user->registered != REG_ALL || !IS_LOCAL(user))
                return;
 
-       CmdBuilder(user, "FNAME").push_last(gecos).Broadcast();
+       CmdBuilder(user, "FNAME").push_last(real).Broadcast();
 }
 
 void ModuleSpanningTree::OnChangeIdent(User* user, const std::string &ident)
@@ -497,7 +553,7 @@ void ModuleSpanningTree::OnUserPart(Membership* memb, std::string &partmessage,
        if (IS_LOCAL(memb->user))
        {
                CmdBuilder params(memb->user, "PART");
-               params.push_back(memb->chan->name);
+               params.push(memb->chan->name);
                if (!partmessage.empty())
                        params.push_last(partmessage);
                params.Broadcast();
@@ -527,7 +583,7 @@ void ModuleSpanningTree::OnUserQuit(User* user, const std::string &reason, const
                }
        }
 
-       // Regardless, We need to modify the user Counts..
+       // Regardless, update the UserCount
        TreeServer::Get(user)->UserCount--;
 }
 
@@ -537,8 +593,8 @@ void ModuleSpanningTree::OnUserPostNick(User* user, const std::string &oldnick)
        {
                // The nick TS is updated by the core, we don't do it
                CmdBuilder params(user, "NICK");
-               params.push_back(user->nick);
-               params.push_back(ConvToStr(user->age));
+               params.push(user->nick);
+               params.push(ConvToStr(user->age));
                params.Broadcast();
        }
        else if (!loopCall)
@@ -553,8 +609,8 @@ void ModuleSpanningTree::OnUserKick(User* source, Membership* memb, const std::s
                return;
 
        CmdBuilder params(source, "KICK");
-       params.push_back(memb->chan->name);
-       params.push_back(memb->user->uuid);
+       params.push(memb->chan->name);
+       params.push(memb->user->uuid);
        // If a remote user is being kicked by us then send the membership id in the kick too
        if (!IS_LOCAL(memb->user))
                params.push_int(memb->id);
@@ -564,16 +620,13 @@ void ModuleSpanningTree::OnUserKick(User* source, Membership* memb, const std::s
 
 void ModuleSpanningTree::OnPreRehash(User* user, const std::string &parameter)
 {
-       if (loopCall)
-               return; // Don't generate a REHASH here if we're in the middle of processing a message that generated this one
-
        ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "OnPreRehash called with param %s", parameter.c_str());
 
        // Send out to other servers
        if (!parameter.empty() && parameter[0] != '-')
        {
-               CmdBuilder params((user ? user->uuid : ServerInstance->Config->GetSID()), "REHASH");
-               params.push_back(parameter);
+               CmdBuilder params(user ? user : ServerInstance->FakeClient, "REHASH");
+               params.push(parameter);
                params.Forward(user ? TreeServer::Get(user)->GetRoute() : NULL);
        }
 }
@@ -628,13 +681,28 @@ void ModuleSpanningTree::OnUnloadModule(Module* mod)
                return;
        ServerInstance->PI->SendMetaData("modules", "-" + mod->ModuleSourceFile);
 
+       if (mod == this)
+       {
+               // We are being unloaded, inform modules about all servers splitting which cannot be done later when the servers are actually disconnected
+               const server_hash& servers = Utils->serverlist;
+               for (server_hash::const_iterator i = servers.begin(); i != servers.end(); ++i)
+               {
+                       TreeServer* server = i->second;
+                       if (!server->IsRoot())
+                               FOREACH_MOD_CUSTOM(GetLinkEventProvider(), ServerProtocol::LinkEventListener, OnServerSplit, (server, false));
+               }
+               return;
+       }
+
+       // Some other module is being unloaded. If it provides an IOHook we use, we must close that server connection now.
+
 restart:
        // Close all connections which use an IO hook provided by this module
        const TreeServer::ChildServers& list = Utils->TreeRoot->GetChildren();
        for (TreeServer::ChildServers::const_iterator i = list.begin(); i != list.end(); ++i)
        {
                TreeSocket* sock = (*i)->GetSocket();
-               if (sock->GetIOHook() && sock->GetIOHook()->prov->creator == mod)
+               if (sock->GetModHook(mod))
                {
                        sock->SendError("SSL module unloaded");
                        sock->Close();
@@ -646,18 +714,18 @@ restart:
        for (SpanningTreeUtilities::TimeoutList::const_iterator i = Utils->timeoutlist.begin(); i != Utils->timeoutlist.end(); ++i)
        {
                TreeSocket* sock = i->first;
-               if (sock->GetIOHook() && sock->GetIOHook()->prov->creator == mod)
+               if (sock->GetModHook(mod))
                        sock->Close();
        }
 }
 
-// note: the protocol does not allow direct umode +o except
-// via NICK with 8 params. sending OPERTYPE infers +o modechange
-// locally.
 void ModuleSpanningTree::OnOper(User* user, const std::string &opertype)
 {
        if (user->registered != REG_ALL || !IS_LOCAL(user))
                return;
+
+       // Note: The protocol does not allow direct umode +o;
+       // sending OPERTYPE infers +o modechange locally.
        CommandOpertype::Builder(user).Broadcast();
 }
 
@@ -681,20 +749,24 @@ void ModuleSpanningTree::OnDelLine(User* user, XLine *x)
                user = ServerInstance->FakeClient;
 
        CmdBuilder params(user, "DELLINE");
-       params.push_back(x->type);
-       params.push_back(x->Displayable());
+       params.push(x->type);
+       params.push(x->Displayable());
        params.Broadcast();
 }
 
-ModResult ModuleSpanningTree::OnSetAway(User* user, const std::string &awaymsg)
+void ModuleSpanningTree::OnUserAway(User* user)
 {
        if (IS_LOCAL(user))
-               CommandAway::Builder(user, awaymsg).Broadcast();
+               CommandAway::Builder(user).Broadcast();
+}
 
-       return MOD_RES_PASSTHRU;
+void ModuleSpanningTree::OnUserBack(User* user)
+{
+       if (IS_LOCAL(user))
+               CommandAway::Builder(user).Broadcast();
 }
 
-void ModuleSpanningTree::OnMode(User* source, User* u, Channel* c, const Modes::ChangeList& modes, ModeParser::ModeProcessFlag processflags, const std::string& output_mode)
+void ModuleSpanningTree::OnMode(User* source, User* u, Channel* c, const Modes::ChangeList& modes, ModeParser::ModeProcessFlag processflags)
 {
        if (processflags & ModeParser::MODE_LOCALONLY)
                return;
@@ -706,7 +778,7 @@ void ModuleSpanningTree::OnMode(User* source, User* u, Channel* c, const Modes::
 
                CmdBuilder params(source, "MODE");
                params.push(u->uuid);
-               params.push(output_mode);
+               params.push(ClientProtocol::Messages::Mode::ToModeLetters(modes));
                params.push_raw(Translate::ModeChangeListToParams(modes.getlist()));
                params.Broadcast();
        }
@@ -715,7 +787,7 @@ void ModuleSpanningTree::OnMode(User* source, User* u, Channel* c, const Modes::
                CmdBuilder params(source, "FMODE");
                params.push(c->name);
                params.push_int(c->age);
-               params.push(output_mode);
+               params.push(ClientProtocol::Messages::Mode::ToModeLetters(modes));
                params.push_raw(Translate::ModeChangeListToParams(modes.getlist()));
                params.Broadcast();
        }
@@ -732,13 +804,10 @@ ModuleSpanningTree::~ModuleSpanningTree()
 {
        ServerInstance->PI = &ServerInstance->DefaultProtocolInterface;
 
-       Server* newsrv = new Server(ServerInstance->Config->ServerName, ServerInstance->Config->ServerDesc);
+       Server* newsrv = new Server(ServerInstance->Config->GetSID(), ServerInstance->Config->ServerName, ServerInstance->Config->ServerDesc);
        SetLocalUsersServer(newsrv);
 
-       /* This will also free the listeners */
        delete Utils;
-
-       delete commands;
 }
 
 Version ModuleSpanningTree::GetVersion()
@@ -750,12 +819,13 @@ Version ModuleSpanningTree::GetVersion()
  * so that any activity it sees is FINAL, e.g. we arent going to send out
  * a NICK message before m_cloaking has finished putting the +x on the user,
  * etc etc.
- * Therefore, we return PRIORITY_LAST to make sure we end up at the END of
+ * Therefore, we set our priority to PRIORITY_LAST to make sure we end up at the END of
  * the module call queue.
  */
 void ModuleSpanningTree::Prioritize()
 {
        ServerInstance->Modules->SetPriority(this, PRIORITY_LAST);
+       ServerInstance->Modules.SetPriority(this, I_OnPreTopicChange, PRIORITY_FIRST);
 }
 
 MODULE_INIT(ModuleSpanningTree)