]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/main.cpp
Improve UserManager::QuitUser() and related code
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / main.cpp
index 57fe2090cb8340e95383f7cb9ddd74f6f55c7d9f..8c04d6c909797cacebf09dbcbdb7c34d6ee7bd51 100644 (file)
 #include "protocolinterface.h"
 
 ModuleSpanningTree::ModuleSpanningTree()
-       : commands(NULL), DNS(this, "DNS")
+       : rconnect(this), rsquit(this), map(this)
+       , commands(NULL), DNS(this, "DNS")
 {
 }
 
 SpanningTreeCommands::SpanningTreeCommands(ModuleSpanningTree* module)
-       : rconnect(module), rsquit(module), map(module),
-       svsjoin(module), svspart(module), svsnick(module), metadata(module),
+       : svsjoin(module), svspart(module), svsnick(module), metadata(module),
        uid(module), opertype(module), fjoin(module), ijoin(module), resync(module),
        fmode(module), ftopic(module), fhost(module), fident(module), fname(module),
        away(module), addline(module), delline(module), encap(module), idle(module),
@@ -59,13 +59,11 @@ void ModuleSpanningTree::init()
        Utils = new SpanningTreeUtilities(this);
        Utils->TreeRoot = new TreeServer;
        commands = new SpanningTreeCommands(this);
-       ServerInstance->Modules->AddService(commands->rconnect);
-       ServerInstance->Modules->AddService(commands->rsquit);
-       ServerInstance->Modules->AddService(commands->map);
 
        delete ServerInstance->PI;
        ServerInstance->PI = new SpanningTreeProtocolInterface;
        loopCall = false;
+       SplitInProgress = false;
 
        // update our local user count
        Utils->TreeRoot->UserCount = ServerInstance->Users->local_users.size();
@@ -102,7 +100,7 @@ void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
        else if ((Current->Hidden) && (!user->IsOper()))
                return;
 
-       user->WriteNumeric(364, "%s %s %s :%d %s",      user->nick.c_str(), Current->GetName().c_str(),
+       user->WriteNumeric(RPL_LINKS, "%s %s :%d %s",   Current->GetName().c_str(),
                        (Utils->FlatLinks && (!user->IsOper())) ? ServerInstance->Config->ServerName.c_str() : Parent.c_str(),
                        (Utils->FlatLinks && (!user->IsOper())) ? 0 : hops,
                        Current->GetDesc().c_str());
@@ -111,7 +109,7 @@ void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
 void ModuleSpanningTree::HandleLinks(const std::vector<std::string>& parameters, User* user)
 {
        ShowLinks(Utils->TreeRoot,user,0);
-       user->WriteNumeric(365, "%s * :End of /LINKS list.",user->nick.c_str());
+       user->WriteNumeric(RPL_ENDOFLINKS, "* :End of /LINKS list.");
 }
 
 std::string ModuleSpanningTree::TimeToStr(time_t secs)
@@ -283,7 +281,7 @@ void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
                catch (DNS::Exception& e)
                {
                        delete snr;
-                       ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",x->Name.c_str(), e.GetReason());
+                       ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",x->Name.c_str(), e.GetReason().c_str());
                        ConnectServer(y, false);
                }
        }
@@ -337,11 +335,11 @@ ModResult ModuleSpanningTree::HandleVersion(const std::vector<std::string>& para
                        return MOD_RES_PASSTHRU;
                }
                std::string Version = found->GetVersion();
-               user->WriteNumeric(351, "%s :%s",user->nick.c_str(),Version.c_str());
+               user->WriteNumeric(RPL_VERSION, ":%s", Version.c_str());
        }
        else
        {
-               user->WriteNumeric(402, "%s %s :No such server",user->nick.c_str(),parameters[0].c_str());
+               user->WriteNumeric(ERR_NOSUCHSERVER, "%s :No such server", parameters[0].c_str());
        }
        return MOD_RES_DENY;
 }
@@ -408,11 +406,11 @@ void ModuleSpanningTree::OnUserInvite(User* source,User* dest,Channel* channel,
 {
        if (IS_LOCAL(source))
        {
-               parameterlist params;
+               CmdBuilder params(source, "INVITE");
                params.push_back(dest->uuid);
                params.push_back(channel->name);
                params.push_back(ConvToStr(expiry));
-               Utils->DoOneToMany(source->uuid,"INVITE",params);
+               params.Broadcast();
        }
 }
 
@@ -422,10 +420,7 @@ void ModuleSpanningTree::OnPostTopicChange(User* user, Channel* chan, const std:
        if (!IS_LOCAL(user))
                return;
 
-       parameterlist params;
-       params.push_back(chan->name);
-       params.push_back(":"+topic);
-       Utils->DoOneToMany(user->uuid,"TOPIC",params);
+       CommandFTopic::Builder(user, chan).Broadcast();
 }
 
 void ModuleSpanningTree::OnUserMessage(User* user, void* dest, int target_type, const std::string& text, char status, const CUList& exempt_list, MessageType msgtype)
@@ -439,10 +434,10 @@ void ModuleSpanningTree::OnUserMessage(User* user, void* dest, int target_type,
                User* d = (User*) dest;
                if (!IS_LOCAL(d))
                {
-                       parameterlist params;
+                       CmdBuilder params(user, message_type);
                        params.push_back(d->uuid);
-                       params.push_back(":"+text);
-                       Utils->DoOneToOne(user->uuid, message_type, params, d->server);
+                       params.push_last(text);
+                       params.Unicast(d);
                }
        }
        else if (target_type == TYPE_CHANNEL)
@@ -452,10 +447,10 @@ void ModuleSpanningTree::OnUserMessage(User* user, void* dest, int target_type,
        else if (target_type == TYPE_SERVER)
        {
                char* target = (char*) dest;
-               parameterlist par;
+               CmdBuilder par(user, message_type);
                par.push_back(target);
-               par.push_back(":"+text);
-               Utils->DoOneToMany(user->uuid, message_type, par);
+               par.push_last(text);
+               par.Broadcast();
        }
 }
 
@@ -471,26 +466,10 @@ void ModuleSpanningTree::OnUserConnect(LocalUser* user)
        if (user->quitting)
                return;
 
-       parameterlist params;
-       params.push_back(user->uuid);
-       params.push_back(ConvToStr(user->age));
-       params.push_back(user->nick);
-       params.push_back(user->host);
-       params.push_back(user->dhost);
-       params.push_back(user->ident);
-       params.push_back(user->GetIPString());
-       params.push_back(ConvToStr(user->signon));
-       params.push_back("+"+std::string(user->FormatModes(true)));
-       params.push_back(":"+user->fullname);
-       Utils->DoOneToMany(ServerInstance->Config->GetSID(), "UID", params);
+       CommandUID::Builder(user).Broadcast();
 
        if (user->IsOper())
-       {
-               params.clear();
-               params.push_back(":");
-               params[0].append(user->oper->name);
-               Utils->DoOneToMany(user->uuid,"OPERTYPE",params);
-       }
+               CommandOpertype::Builder(user).Broadcast();
 
        for(Extensible::ExtensibleStore::const_iterator i = user->GetExtList().begin(); i != user->GetExtList().end(); i++)
        {
@@ -506,26 +485,28 @@ void ModuleSpanningTree::OnUserConnect(LocalUser* user)
 void ModuleSpanningTree::OnUserJoin(Membership* memb, bool sync, bool created_by_local, CUList& excepts)
 {
        // Only do this for local users
-       if (IS_LOCAL(memb->user))
+       if (!IS_LOCAL(memb->user))
+               return;
+
+       if (created_by_local)
+       {
+               CmdBuilder params("FJOIN");
+               params.push_back(memb->chan->name);
+               params.push_back(ConvToStr(memb->chan->age));
+               params.push_raw(" +").push_raw(memb->chan->ChanModes(true));
+               params.push(memb->modes).push_raw(',').push_raw(memb->user->uuid);
+               params.Broadcast();
+       }
+       else
        {
-               parameterlist params;
+               CmdBuilder params(memb->user, "IJOIN");
                params.push_back(memb->chan->name);
-               if (created_by_local)
+               if (!memb->modes.empty())
                {
                        params.push_back(ConvToStr(memb->chan->age));
-                       params.push_back(std::string("+") + memb->chan->ChanModes(true));
-                       params.push_back(memb->modes+","+memb->user->uuid);
-                       Utils->DoOneToMany(ServerInstance->Config->GetSID(),"FJOIN",params);
-               }
-               else
-               {
-                       if (!memb->modes.empty())
-                       {
-                               params.push_back(ConvToStr(memb->chan->age));
-                               params.push_back(memb->modes);
-                       }
-                       Utils->DoOneToMany(memb->user->uuid, "IJOIN", params);
+                       params.push_back(memb->modes);
                }
+               params.Broadcast();
        }
 }
 
@@ -534,9 +515,7 @@ void ModuleSpanningTree::OnChangeHost(User* user, const std::string &newhost)
        if (user->registered != REG_ALL || !IS_LOCAL(user))
                return;
 
-       parameterlist params;
-       params.push_back(newhost);
-       Utils->DoOneToMany(user->uuid,"FHOST",params);
+       CmdBuilder(user, "FHOST").push(newhost).Broadcast();
 }
 
 void ModuleSpanningTree::OnChangeName(User* user, const std::string &gecos)
@@ -544,9 +523,7 @@ void ModuleSpanningTree::OnChangeName(User* user, const std::string &gecos)
        if (user->registered != REG_ALL || !IS_LOCAL(user))
                return;
 
-       parameterlist params;
-       params.push_back(gecos);
-       Utils->DoOneToMany(user->uuid,"FNAME",params);
+       CmdBuilder(user, "FNAME").push(gecos).Broadcast();
 }
 
 void ModuleSpanningTree::OnChangeIdent(User* user, const std::string &ident)
@@ -554,34 +531,41 @@ void ModuleSpanningTree::OnChangeIdent(User* user, const std::string &ident)
        if ((user->registered != REG_ALL) || (!IS_LOCAL(user)))
                return;
 
-       parameterlist params;
-       params.push_back(ident);
-       Utils->DoOneToMany(user->uuid,"FIDENT",params);
+       CmdBuilder(user, "FIDENT").push(ident).Broadcast();
 }
 
 void ModuleSpanningTree::OnUserPart(Membership* memb, std::string &partmessage, CUList& excepts)
 {
        if (IS_LOCAL(memb->user))
        {
-               parameterlist params;
+               CmdBuilder params(memb->user, "PART");
                params.push_back(memb->chan->name);
                if (!partmessage.empty())
-                       params.push_back(":"+partmessage);
-               Utils->DoOneToMany(memb->user->uuid,"PART",params);
+                       params.push_last(partmessage);
+               params.Broadcast();
        }
 }
 
 void ModuleSpanningTree::OnUserQuit(User* user, const std::string &reason, const std::string &oper_message)
 {
-       if ((IS_LOCAL(user)) && (user->registered == REG_ALL))
+       if (IS_LOCAL(user))
        {
-               parameterlist params;
-
                if (oper_message != reason)
                        ServerInstance->PI->SendMetaData(user, "operquit", oper_message);
 
-               params.push_back(":"+reason);
-               Utils->DoOneToMany(user->uuid,"QUIT",params);
+               CmdBuilder(user, "QUIT").push_last(reason).Broadcast();
+       }
+       else
+       {
+               // Hide the message if one of the following is true:
+               // - User is being quit due to a netsplit and quietbursts is on
+               // - Server is a silent uline
+               bool hide = (((this->SplitInProgress) && (Utils->quiet_bursts)) || (ServerInstance->SilentULine(user->server)));
+               if (!hide)
+               {
+                       ServerInstance->SNO->WriteToSnoMask('Q', "Client exiting on server %s: %s (%s) [%s]",
+                               user->server.c_str(), user->GetFullRealHost().c_str(), user->GetIPString().c_str(), oper_message.c_str());
+               }
        }
 
        // Regardless, We need to modify the user Counts..
@@ -596,7 +580,7 @@ void ModuleSpanningTree::OnUserPostNick(User* user, const std::string &oldnick)
 {
        if (IS_LOCAL(user))
        {
-               parameterlist params;
+               CmdBuilder params(user, "NICK");
                params.push_back(user->nick);
 
                /** IMPORTANT: We don't update the TS if the oldnick is just a case change of the newnick!
@@ -605,31 +589,27 @@ void ModuleSpanningTree::OnUserPostNick(User* user, const std::string &oldnick)
                        user->age = ServerInstance->Time();
 
                params.push_back(ConvToStr(user->age));
-               Utils->DoOneToMany(user->uuid,"NICK",params);
+               params.Broadcast();
        }
        else if (!loopCall && user->nick == user->uuid)
        {
-               parameterlist params;
+               CmdBuilder params("SAVE");
                params.push_back(user->uuid);
                params.push_back(ConvToStr(user->age));
-               Utils->DoOneToMany(ServerInstance->Config->GetSID(),"SAVE",params);
+               params.Broadcast();
        }
 }
 
 void ModuleSpanningTree::OnUserKick(User* source, Membership* memb, const std::string &reason, CUList& excepts)
 {
-       parameterlist params;
+       if ((!IS_LOCAL(source)) && (source != ServerInstance->FakeClient))
+               return;
+
+       CmdBuilder params(source, "KICK");
        params.push_back(memb->chan->name);
        params.push_back(memb->user->uuid);
-       params.push_back(":"+reason);
-       if (IS_LOCAL(source))
-       {
-               Utils->DoOneToMany(source->uuid,"KICK",params);
-       }
-       else if (source == ServerInstance->FakeClient)
-       {
-               Utils->DoOneToMany(ServerInstance->Config->GetSID(),"KICK",params);
-       }
+       params.push_last(reason);
+       params.Broadcast();
 }
 
 void ModuleSpanningTree::OnPreRehash(User* user, const std::string &parameter)
@@ -642,13 +622,13 @@ void ModuleSpanningTree::OnPreRehash(User* user, const std::string &parameter)
        // Send out to other servers
        if (!parameter.empty() && parameter[0] != '-')
        {
-               parameterlist params;
+               CmdBuilder params((user ? user->uuid : ServerInstance->Config->GetSID()), "REHASH");
                params.push_back(parameter);
-               Utils->DoOneToAllButSender(user ? user->uuid : ServerInstance->Config->GetSID(), "REHASH", params, user ? Utils->BestRouteTo(user->server) : NULL);
+               params.Forward(user ? Utils->BestRouteTo(user->server) : NULL);
        }
 }
 
-void ModuleSpanningTree::OnRehash(User* user)
+void ModuleSpanningTree::ReadConfig(ConfigStatus& status)
 {
        // Re-read config stuff
        try
@@ -663,8 +643,8 @@ void ModuleSpanningTree::OnRehash(User* user)
                std::string msg = "Error in configuration: ";
                msg.append(e.GetReason());
                ServerInstance->SNO->WriteToSnoMask('l', msg);
-               if (user && !IS_LOCAL(user))
-                       ServerInstance->PI->SendSNONotice("L", msg);
+               if (status.srcuser && !IS_LOCAL(status.srcuser))
+                       ServerInstance->PI->SendSNONotice('L', msg);
        }
 }
 
@@ -679,14 +659,14 @@ void ModuleSpanningTree::OnLoadModule(Module* mod)
                data.push_back('=');
                data.append(v.link_data);
        }
-       ServerInstance->PI->SendMetaData(NULL, "modules", data);
+       ServerInstance->PI->SendMetaData("modules", data);
 }
 
 void ModuleSpanningTree::OnUnloadModule(Module* mod)
 {
        if (!Utils)
                return;
-       ServerInstance->PI->SendMetaData(NULL, "modules", "-" + mod->ModuleSourceFile);
+       ServerInstance->PI->SendMetaData("modules", "-" + mod->ModuleSourceFile);
 
        // Close all connections which use an IO hook provided by this module
        const TreeServer::ChildServers& list = Utils->TreeRoot->GetChildren();
@@ -699,6 +679,13 @@ void ModuleSpanningTree::OnUnloadModule(Module* mod)
                        sock->Close();
                }
        }
+
+       for (SpanningTreeUtilities::TimeoutList::const_iterator i = Utils->timeoutlist.begin(); i != Utils->timeoutlist.end(); ++i)
+       {
+               TreeSocket* sock = i->first;
+               if (sock->GetIOHook() && sock->GetIOHook()->creator == mod)
+                       sock->Close();
+       }
 }
 
 // note: the protocol does not allow direct umode +o except
@@ -708,107 +695,42 @@ void ModuleSpanningTree::OnOper(User* user, const std::string &opertype)
 {
        if (user->registered != REG_ALL || !IS_LOCAL(user))
                return;
-       parameterlist params;
-       params.push_back(":");
-       params[0].append(opertype);
-       Utils->DoOneToMany(user->uuid,"OPERTYPE",params);
+       CommandOpertype::Builder(user).Broadcast();
 }
 
 void ModuleSpanningTree::OnAddLine(User* user, XLine *x)
 {
-       if (!x->IsBurstable() || loopCall)
+       if (!x->IsBurstable() || loopCall || (user && !IS_LOCAL(user)))
                return;
 
-       parameterlist params;
-       params.push_back(x->type);
-       params.push_back(x->Displayable());
-       params.push_back(ServerInstance->Config->ServerName);
-       params.push_back(ConvToStr(x->set_time));
-       params.push_back(ConvToStr(x->duration));
-       params.push_back(":" + x->reason);
-
        if (!user)
-       {
-               /* Server-set lines */
-               Utils->DoOneToMany(ServerInstance->Config->GetSID(), "ADDLINE", params);
-       }
-       else if (IS_LOCAL(user))
-       {
-               /* User-set lines */
-               Utils->DoOneToMany(user->uuid, "ADDLINE", params);
-       }
+               user = ServerInstance->FakeClient;
+
+       CommandAddLine::Builder(x, user).Broadcast();
 }
 
 void ModuleSpanningTree::OnDelLine(User* user, XLine *x)
 {
-       if (!x->IsBurstable() || loopCall)
+       if (!x->IsBurstable() || loopCall || (user && !IS_LOCAL(user)))
                return;
 
-       parameterlist params;
+       if (!user)
+               user = ServerInstance->FakeClient;
+
+       CmdBuilder params(user, "DELLINE");
        params.push_back(x->type);
        params.push_back(x->Displayable());
-
-       if (!user)
-       {
-               /* Server-unset lines */
-               Utils->DoOneToMany(ServerInstance->Config->GetSID(), "DELLINE", params);
-       }
-       else if (IS_LOCAL(user))
-       {
-               /* User-unset lines */
-               Utils->DoOneToMany(user->uuid, "DELLINE", params);
-       }
+       params.Broadcast();
 }
 
 ModResult ModuleSpanningTree::OnSetAway(User* user, const std::string &awaymsg)
 {
        if (IS_LOCAL(user))
-       {
-               parameterlist params;
-               if (!awaymsg.empty())
-               {
-                       params.push_back(ConvToStr(user->awaytime));
-                       params.push_back(":" + awaymsg);
-               }
-               Utils->DoOneToMany(user->uuid, "AWAY", params);
-       }
+               CommandAway::Builder(user, awaymsg).Broadcast();
 
        return MOD_RES_PASSTHRU;
 }
 
-void ModuleSpanningTree::ProtoSendMode(void* opaque, TargetTypeFlags target_type, void* target, const parameterlist &modeline, const std::vector<TranslateType> &translate)
-{
-       TreeSocket* s = (TreeSocket*)opaque;
-       std::string output_text = CommandParser::TranslateUIDs(translate, modeline);
-
-       if (target)
-       {
-               if (target_type == TYPE_USER)
-               {
-                       User* u = (User*)target;
-                       s->WriteLine(":"+ServerInstance->Config->GetSID()+" MODE "+u->uuid+" "+output_text);
-               }
-               else if (target_type == TYPE_CHANNEL)
-               {
-                       Channel* c = (Channel*)target;
-                       s->WriteLine(":"+ServerInstance->Config->GetSID()+" FMODE "+c->name+" "+ConvToStr(c->age)+" "+output_text);
-               }
-       }
-}
-
-void ModuleSpanningTree::ProtoSendMetaData(void* opaque, Extensible* target, const std::string &extname, const std::string &extdata)
-{
-       TreeSocket* s = static_cast<TreeSocket*>(opaque);
-       User* u = dynamic_cast<User*>(target);
-       Channel* c = dynamic_cast<Channel*>(target);
-       if (u)
-               s->WriteLine(":"+ServerInstance->Config->GetSID()+" METADATA "+u->uuid+" "+extname+" :"+extdata);
-       else if (c)
-               s->WriteLine(":"+ServerInstance->Config->GetSID()+" METADATA "+c->name+" "+ConvToStr(c->age)+" "+extname+" :"+extdata);
-       else if (!target)
-               s->WriteLine(":"+ServerInstance->Config->GetSID()+" METADATA * "+extname+" :"+extdata);
-}
-
 CullResult ModuleSpanningTree::cull()
 {
        if (Utils)