]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/main.cpp
Fixes found by removing User inheritance from StreamSocket
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / main.cpp
index 8b9f40e0b5f3d25237cd57cc630b031f79b7c0d2..8da34af53f3e5e364d1fad425df29feb3a93d2b6 100644 (file)
@@ -16,7 +16,6 @@
 #include "inspircd.h"
 #include "socket.h"
 #include "xline.h"
-#include "../transport.h"
 
 #include "cachetimer.h"
 #include "resolvers.h"
@@ -47,10 +46,10 @@ ModuleSpanningTree::ModuleSpanningTree()
        {
                I_OnPreCommand, I_OnGetServerDescription, I_OnUserInvite, I_OnPostTopicChange,
                I_OnWallops, I_OnUserNotice, I_OnUserMessage, I_OnBackgroundTimer, I_OnUserJoin,
-               I_OnChangeLocalUserHost, I_OnChangeName, I_OnChangeIdent, I_OnUserPart, I_OnUnloadModule,
+               I_OnChangeHost, I_OnChangeName, I_OnChangeIdent, I_OnUserPart, I_OnUnloadModule,
                I_OnUserQuit, I_OnUserPostNick, I_OnUserKick, I_OnRemoteKill, I_OnRehash, I_OnPreRehash,
-               I_OnOper, I_OnAddLine, I_OnDelLine, I_OnMode, I_OnLoadModule, I_OnStats, I_OnEvent,
-               I_OnSetAway, I_OnPostCommand, I_OnUserConnect
+               I_OnOper, I_OnAddLine, I_OnDelLine, I_OnMode, I_OnLoadModule, I_OnStats,
+               I_OnSetAway, I_OnPostCommand, I_OnUserConnect, I_OnAcceptConnection
        };
        ServerInstance->Modules->Attach(eventlist, this, sizeof(eventlist)/sizeof(Implementation));
 
@@ -91,7 +90,7 @@ void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
                return;
 
        user->WriteNumeric(364, "%s %s %s :%d %s",      user->nick.c_str(),Current->GetName().c_str(),
-                       (Utils->FlatLinks && (!IS_OPER(user))) ? ServerInstance->Config->ServerName : Parent.c_str(),
+                       (Utils->FlatLinks && (!IS_OPER(user))) ? ServerInstance->Config->ServerName.c_str() : Parent.c_str(),
                        (Utils->FlatLinks && (!IS_OPER(user))) ? 0 : hops,
                        Current->GetDesc().c_str());
 }
@@ -244,25 +243,41 @@ void ModuleSpanningTree::DoPingChecks(time_t curtime)
        }
 }
 
-void ModuleSpanningTree::ConnectServer(Autoconnect* y)
+void ModuleSpanningTree::ConnectServer(Autoconnect* a, bool on_timer)
 {
-       if (!y)
+       if (!a)
                return;
-       y->position++;
-       while (y->position < (int)y->servers.size())
+       for(unsigned int j=0; j < a->servers.size(); j++)
        {
-               Link* x = Utils->FindLink(y->servers[y->position]);
+               if (Utils->FindServer(a->servers[j]))
+               {
+                       // found something in this block. Should the server fail,
+                       // we want to start at the start of the list, not in the
+                       // middle where we left off
+                       a->position = -1;
+                       return;
+               }
+       }
+       if (on_timer && a->position >= 0)
+               return;
+       if (!on_timer && a->position < 0)
+               return;
+
+       a->position++;
+       while (a->position < (int)a->servers.size())
+       {
+               Link* x = Utils->FindLink(a->servers[a->position]);
                if (x)
                {
                        ServerInstance->SNO->WriteToSnoMask('l', "AUTOCONNECT: Auto-connecting server \002%s\002", x->Name.c_str());
-                       ConnectServer(x, y);
+                       ConnectServer(x, a);
                        return;
                }
-               y->position++;
+               a->position++;
        }
        // Autoconnect chain has been fully iterated; start at the beginning on the
        // next AutoConnectServers run
-       y->position = -1;
+       a->position = -1;
 }
 
 void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
@@ -294,18 +309,17 @@ void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
        if (ipvalid)
        {
                /* Gave a hook, but it wasnt one we know */
-               if ((!x->Hook.empty()) && (Utils->hooks.find(x->Hook.c_str()) == Utils->hooks.end()))
-                       return;
-               TreeSocket* newsocket = new TreeSocket(Utils, x->IPAddr,x->Port, x->Timeout ? x->Timeout : 10,x->Name.c_str(), x->Bind, y, x->Hook.empty() ? NULL : Utils->hooks[x->Hook.c_str()]);
+               TreeSocket* newsocket = new TreeSocket(Utils, x->IPAddr, x->Port, x->Timeout ? x->Timeout : 10,
+                       x->Name.c_str(), x->Bind, y, x->Hook);
                if (newsocket->GetFd() > -1)
                {
                        /* Handled automatically on success */
                }
                else
                {
-                       ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",x->Name.c_str(),strerror(errno));
+                       ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",
+                               x->Name.c_str(), newsocket->getError().c_str());
                        ServerInstance->GlobalCulls.AddItem(newsocket);
-                       ConnectServer(y);
                }
        }
        else
@@ -313,13 +327,13 @@ void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
                try
                {
                        bool cached;
-                       ServernameResolver* snr = new ServernameResolver((Module*)this, Utils, x->IPAddr, x, cached, start_type, y);
+                       ServernameResolver* snr = new ServernameResolver(Utils, x->IPAddr, x, cached, start_type, y);
                        ServerInstance->AddResolver(snr, cached);
                }
                catch (ModuleException& e)
                {
                        ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",x->Name.c_str(), e.GetReason());
-                       ConnectServer(y);
+                       ConnectServer(y, false);
                }
        }
 }
@@ -332,28 +346,13 @@ void ModuleSpanningTree::AutoConnectServers(time_t curtime)
                if (curtime >= x->NextConnectTime)
                {
                        x->NextConnectTime = curtime + x->Period;
-                       for(unsigned int j=0; j < x->servers.size(); j++)
-                       {
-                               if (Utils->FindServer(x->servers[j]))
-                               {
-                                       // found something in this block. Should the server fail,
-                                       // we want to start at the start of the list, not in the
-                                       // middle where we left off
-                                       x->position = -1;
-                                       goto dupe_found; // next autoconnect block
-                               }
-                       }
-                       // only start a new chain if we aren't running
-                       if (x->position == -1)
-                               ConnectServer(x);
+                       ConnectServer(x, true);
                }
-dupe_found:;
        }
 }
 
 void ModuleSpanningTree::DoConnectTimeout(time_t curtime)
 {
-       std::vector<Autoconnect*> failovers;
        std::map<TreeSocket*, std::pair<std::string, int> >::iterator i = Utils->timeoutlist.begin();
        while (i != Utils->timeoutlist.end())
        {
@@ -364,18 +363,11 @@ void ModuleSpanningTree::DoConnectTimeout(time_t curtime)
                if (curtime > s->age + p.second)
                {
                        ServerInstance->SNO->WriteToSnoMask('l',"CONNECT: Error connecting \002%s\002 (timeout of %d seconds)",p.first.c_str(),p.second);
-                       if (s->myautoconnect)
-                               failovers.push_back(s->myautoconnect);
                        Utils->timeoutlist.erase(me);
                        s->Close();
                        ServerInstance->GlobalCulls.AddItem(s);
                }
        }
-       for(unsigned int j=0; j < failovers.size(); j++)
-       {
-               if (failovers[j]->position >= 0)
-                       ConnectServer(failovers[j]);
-       }
 }
 
 ModResult ModuleSpanningTree::HandleVersion(const std::vector<std::string>& parameters, User* user)
@@ -498,7 +490,7 @@ void ModuleSpanningTree::OnUserNotice(User* user, void* dest, int target_type, c
        if (target_type == TYPE_USER)
        {
                User* d = (User*)dest;
-               if ((d->GetFd() < 0) && (IS_LOCAL(user)))
+               if (!IS_LOCAL(d) && IS_LOCAL(user))
                {
                        parameterlist params;
                        params.push_back(d->uuid);
@@ -551,7 +543,7 @@ void ModuleSpanningTree::OnUserMessage(User* user, void* dest, int target_type,
                // route private messages which are targetted at clients only to the server
                // which needs to receive them
                User* d = (User*)dest;
-               if ((d->GetFd() < 0) && (IS_LOCAL(user)))
+               if (!IS_LOCAL(d) && (IS_LOCAL(user)))
                {
                        parameterlist params;
                        params.push_back(d->uuid);
@@ -600,7 +592,7 @@ void ModuleSpanningTree::OnBackgroundTimer(time_t curtime)
        DoConnectTimeout(curtime);
 }
 
-void ModuleSpanningTree::OnUserConnect(User* user)
+void ModuleSpanningTree::OnUserConnect(LocalUser* user)
 {
        if (user->quitting)
                return;
@@ -638,21 +630,19 @@ void ModuleSpanningTree::OnUserJoin(Membership* memb, bool sync, bool created, C
        }
 }
 
-ModResult ModuleSpanningTree::OnChangeLocalUserHost(User* user, const std::string &newhost)
+void ModuleSpanningTree::OnChangeHost(User* user, const std::string &newhost)
 {
-       if (user->registered != REG_ALL)
-               return MOD_RES_PASSTHRU;
+       if (user->registered != REG_ALL || !IS_LOCAL(user))
+               return;
 
        parameterlist params;
        params.push_back(newhost);
        Utils->DoOneToMany(user->uuid,"FHOST",params);
-       return MOD_RES_PASSTHRU;
 }
 
 void ModuleSpanningTree::OnChangeName(User* user, const std::string &gecos)
 {
-       // only occurs for local clients
-       if (user->registered != REG_ALL)
+       if (user->registered != REG_ALL || !IS_LOCAL(user))
                return;
 
        parameterlist params;
@@ -741,7 +731,7 @@ void ModuleSpanningTree::OnUserKick(User* source, Membership* memb, const std::s
        {
                Utils->DoOneToMany(source->uuid,"KICK",params);
        }
-       else if (IS_SERVER(source) && source != Utils->ServerUser)
+       else if (source == ServerInstance->FakeClient)
        {
                Utils->DoOneToMany(ServerInstance->Config->GetSID(),"KICK",params);
        }
@@ -752,7 +742,7 @@ void ModuleSpanningTree::OnRemoteKill(User* source, User* dest, const std::strin
        if (!IS_LOCAL(source))
                return; // Only start routing if we're origin.
 
-       User::OperQuit.set(dest, operreason);
+       ServerInstance->OperQuit.set(dest, operreason);
        parameterlist params;
        params.push_back(":"+operreason);
        Utils->DoOneToMany(dest->uuid,"OPERQUIT",params);
@@ -778,20 +768,20 @@ void ModuleSpanningTree::OnPreRehash(User* user, const std::string &parameter)
 void ModuleSpanningTree::OnRehash(User* user)
 {
        // Re-read config stuff
-       Utils->ReadConfiguration(true);
+       Utils->ReadConfiguration();
 }
 
-void ModuleSpanningTree::OnLoadModule(Module* mod, const std::string &name)
+void ModuleSpanningTree::OnLoadModule(Module* mod)
 {
-       this->RedoConfig(mod, name);
+       this->RedoConfig(mod);
 }
 
-void ModuleSpanningTree::OnUnloadModule(Module* mod, const std::string &name)
+void ModuleSpanningTree::OnUnloadModule(Module* mod)
 {
-       this->RedoConfig(mod, name);
+       this->RedoConfig(mod);
 }
 
-void ModuleSpanningTree::RedoConfig(Module* mod, const std::string &name)
+void ModuleSpanningTree::RedoConfig(Module* mod)
 {
        /* If m_sha256.so is loaded (we use this for HMAC) or any module implementing a BufferedSocket interface is loaded,
         * then we need to re-read our config again taking this into account.
@@ -803,9 +793,9 @@ void ModuleSpanningTree::RedoConfig(Module* mod, const std::string &name)
        if (ml && std::find(ml->begin(), ml->end(), mod) != ml->end())
                IsBufferSocketModule = true;
 
-       if (name == "m_sha256.so" || IsBufferSocketModule)
+       if (mod->ModuleSourceFile == "m_sha256.so" || IsBufferSocketModule)
        {
-               Utils->ReadConfiguration(true);
+               Utils->ReadConfiguration();
        }
 }
 
@@ -829,7 +819,7 @@ void ModuleSpanningTree::OnAddLine(User* user, XLine *x)
 
        char data[MAXBUF];
        snprintf(data,MAXBUF,"%s %s %s %lu %lu :%s", x->type.c_str(), x->Displayable(),
-       ServerInstance->Config->ServerName, (unsigned long)x->set_time, (unsigned long)x->duration, x->reason.c_str());
+       ServerInstance->Config->ServerName.c_str(), (unsigned long)x->set_time, (unsigned long)x->duration, x->reason.c_str());
        parameterlist params;
        params.push_back(data);
 
@@ -953,16 +943,7 @@ void ModuleSpanningTree::ProtoSendMetaData(void* opaque, Extensible* target, con
                s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" METADATA * "+extname+" :"+extdata);
 }
 
-void ModuleSpanningTree::OnEvent(Event* event)
-{
-       if ((event->GetEventID() == "send_encap") || (event->GetEventID() == "send_metadata") || (event->GetEventID() == "send_topic") || (event->GetEventID() == "send_mode") || (event->GetEventID() == "send_mode_explicit") || (event->GetEventID() == "send_opers")
-               || (event->GetEventID() == "send_modeset") || (event->GetEventID() == "send_snoset") || (event->GetEventID() == "send_push"))
-       {
-               ServerInstance->Logs->Log("m_spanningtree", DEBUG, "WARNING: Deprecated use of old 1.1 style m_spanningtree event ignored, type '"+event->GetEventID()+"'!");
-       }
-}
-
-bool ModuleSpanningTree::cull()
+CullResult ModuleSpanningTree::cull()
 {
        Utils->cull();
        ServerInstance->Timers->DelTimer(RefreshTimer);