]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/main.cpp
Convert WriteNumeric() calls to pass the parameters of the numeric as method parameters
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / main.cpp
index fed55d4fd9e53ea0d0352eb4f1e6c2d1f1a61193..ade8359ba4a85463ad714e1e7c40243544f553bc 100644 (file)
 #include "link.h"
 #include "treesocket.h"
 #include "commands.h"
-#include "protocolinterface.h"
+#include "translate.h"
 
 ModuleSpanningTree::ModuleSpanningTree()
-       : commands(NULL), DNS(this, "DNS")
+       : rconnect(this), rsquit(this), map(this)
+       , commands(this)
+       , currmembid(0)
+       , eventprov(this, "event/spanningtree")
+       , DNS(this, "DNS")
+       , loopCall(false)
 {
 }
 
 SpanningTreeCommands::SpanningTreeCommands(ModuleSpanningTree* module)
-       : rconnect(module), rsquit(module), map(module),
-       svsjoin(module), svspart(module), svsnick(module), metadata(module),
+       : svsjoin(module), svspart(module), svsnick(module), metadata(module),
        uid(module), opertype(module), fjoin(module), ijoin(module), resync(module),
        fmode(module), ftopic(module), fhost(module), fident(module), fname(module),
        away(module), addline(module), delline(module), encap(module), idle(module),
        nick(module), ping(module), pong(module), push(module), save(module),
-       server(module), squit(module), snonotice(module), version(module),
-       burst(module), endburst(module)
+       server(module), squit(module), snonotice(module),
+       endburst(module), sinfo(module)
 {
 }
 
+namespace
+{
+       void SetLocalUsersServer(Server* newserver)
+       {
+               // Does not change the server of quitting users because those are not in the list
+
+               ServerInstance->FakeClient->server = newserver;
+               const UserManager::LocalList& list = ServerInstance->Users.GetLocalUsers();
+               for (UserManager::LocalList::const_iterator i = list.begin(); i != list.end(); ++i)
+                       (*i)->server = newserver;
+       }
+
+       void ResetMembershipIds()
+       {
+               // Set all membership ids to 0
+               const UserManager::LocalList& list = ServerInstance->Users.GetLocalUsers();
+               for (UserManager::LocalList::iterator i = list.begin(); i != list.end(); ++i)
+               {
+                       LocalUser* user = *i;
+                       for (User::ChanList::iterator j = user->chans.begin(); j != user->chans.end(); ++j)
+                               (*j)->id = 0;
+               }
+       }
+}
+
 void ModuleSpanningTree::init()
 {
        ServerInstance->SNO->EnableSnomask('l', "LINK");
 
+       ResetMembershipIds();
+
        Utils = new SpanningTreeUtilities(this);
        Utils->TreeRoot = new TreeServer;
-       commands = new SpanningTreeCommands(this);
 
-       delete ServerInstance->PI;
-       ServerInstance->PI = new SpanningTreeProtocolInterface;
-       loopCall = false;
+       ServerInstance->PI = &protocolinterface;
 
-       // update our local user count
-       Utils->TreeRoot->UserCount = ServerInstance->Users->local_users.size();
+       delete ServerInstance->FakeClient->server;
+       SetLocalUsersServer(Utils->TreeRoot);
 }
 
 void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
@@ -80,7 +108,7 @@ void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
        for (TreeServer::ChildServers::const_iterator i = children.begin(); i != children.end(); ++i)
        {
                TreeServer* server = *i;
-               if ((server->Hidden) || ((Utils->HideULines) && (ServerInstance->ULine(server->GetName()))))
+               if ((server->Hidden) || ((Utils->HideULines) && (server->IsULine())))
                {
                        if (user->IsOper())
                        {
@@ -93,22 +121,21 @@ void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
                }
        }
        /* Don't display the line if its a uline, hide ulines is on, and the user isnt an oper */
-       if ((Utils->HideULines) && (ServerInstance->ULine(Current->GetName())) && (!user->IsOper()))
+       if ((Utils->HideULines) && (Current->IsULine()) && (!user->IsOper()))
                return;
        /* Or if the server is hidden and they're not an oper */
        else if ((Current->Hidden) && (!user->IsOper()))
                return;
 
-       user->WriteNumeric(364, "%s %s %s :%d %s",      user->nick.c_str(), Current->GetName().c_str(),
-                       (Utils->FlatLinks && (!user->IsOper())) ? ServerInstance->Config->ServerName.c_str() : Parent.c_str(),
-                       (Utils->FlatLinks && (!user->IsOper())) ? 0 : hops,
-                       Current->GetDesc().c_str());
+       user->WriteNumeric(RPL_LINKS, Current->GetName(),
+                       (((Utils->FlatLinks) && (!user->IsOper())) ? ServerInstance->Config->ServerName : Parent),
+                       InspIRCd::Format("%d %s", (((Utils->FlatLinks) && (!user->IsOper())) ? 0 : hops), Current->GetDesc().c_str()));
 }
 
 void ModuleSpanningTree::HandleLinks(const std::vector<std::string>& parameters, User* user)
 {
        ShowLinks(Utils->TreeRoot,user,0);
-       user->WriteNumeric(365, "%s * :End of /LINKS list.",user->nick.c_str());
+       user->WriteNumeric(RPL_ENDOFLINKS, '*', "End of /LINKS list.");
 }
 
 std::string ModuleSpanningTree::TimeToStr(time_t secs)
@@ -125,70 +152,6 @@ std::string ModuleSpanningTree::TimeToStr(time_t secs)
                        + ConvToStr(secs) + "s");
 }
 
-void ModuleSpanningTree::DoPingChecks(time_t curtime)
-{
-       /*
-        * Cancel remote burst mode on any servers which still have it enabled due to latency/lack of data.
-        * This prevents lost REMOTECONNECT notices
-        */
-       long ts = ServerInstance->Time() * 1000 + (ServerInstance->Time_ns() / 1000000);
-
-restart:
-       for (server_hash::iterator i = Utils->serverlist.begin(); i != Utils->serverlist.end(); i++)
-       {
-               TreeServer *s = i->second;
-
-               // Skip myself
-               if (s->IsRoot())
-                       continue;
-
-               if (s->GetSocket()->GetLinkState() == DYING)
-               {
-                       s->GetSocket()->Close();
-                       goto restart;
-               }
-
-               // Do not ping servers that are not fully connected yet!
-               // Servers which are connected to us have IsLocal() == true and if they're fully connected
-               // then Socket->LinkState == CONNECTED. Servers that are linked to another server are always fully connected.
-               if (s->IsLocal() && s->GetSocket()->GetLinkState() != CONNECTED)
-                       continue;
-
-               // Now do PING checks on all servers
-               // Only ping if this server needs one
-               if (curtime >= s->NextPingTime())
-               {
-                       // And if they answered the last
-                       if (s->AnsweredLastPing())
-                       {
-                               // They did, send a ping to them
-                               s->SetNextPingTime(curtime + Utils->PingFreq);
-                               s->GetSocket()->WriteLine(":" + ServerInstance->Config->GetSID() + " PING " + s->GetID());
-                               s->LastPingMsec = ts;
-                       }
-                       else
-                       {
-                               // They didn't answer the last ping, if they are locally connected, get rid of them.
-                               if (s->IsLocal())
-                               {
-                                       TreeSocket* sock = s->GetSocket();
-                                       sock->SendError("Ping timeout");
-                                       sock->Close();
-                                       goto restart;
-                               }
-                       }
-               }
-
-               // If warn on ping enabled and not warned and the difference is sufficient and they didn't answer the last ping...
-               if ((Utils->PingWarnTime) && (!s->Warned) && (curtime >= s->NextPingTime() - (Utils->PingFreq - Utils->PingWarnTime)) && (!s->AnsweredLastPing()))
-               {
-                       /* The server hasnt responded, send a warning to opers */
-                       ServerInstance->SNO->WriteToSnoMask('l',"Server \002%s\002 has not responded to PING for %d seconds, high latency.", s->GetName().c_str(), Utils->PingWarnTime);
-                       s->Warned = true;
-               }
-       }
-}
-
 void ModuleSpanningTree::ConnectServer(Autoconnect* a, bool on_timer)
 {
        if (!a)
@@ -230,7 +193,7 @@ void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
 {
        bool ipvalid = true;
 
-       if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name)))
+       if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name), rfc_case_insensitive_map))
        {
                ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Not connecting to myself.");
                return;
@@ -253,7 +216,7 @@ void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
        /* Do we already have an IP? If so, no need to resolve it. */
        if (ipvalid)
        {
-               /* Gave a hook, but it wasnt one we know */
+               // Create a TreeServer object that will start connecting immediately in the background
                TreeSocket* newsocket = new TreeSocket(x, y, x->IPAddr);
                if (newsocket->GetFd() > -1)
                {
@@ -280,7 +243,7 @@ void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
                catch (DNS::Exception& e)
                {
                        delete snr;
-                       ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",x->Name.c_str(), e.GetReason());
+                       ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Error connecting \002%s\002: %s.",x->Name.c_str(), e.GetReason().c_str());
                        ConnectServer(y, false);
                }
        }
@@ -324,7 +287,7 @@ void ModuleSpanningTree::DoConnectTimeout(time_t curtime)
 
 ModResult ModuleSpanningTree::HandleVersion(const std::vector<std::string>& parameters, User* user)
 {
-       // we've already checked if pcnt > 0, so this is safe
+       // We've already confirmed that !parameters.empty(), so this is safe
        TreeServer* found = Utils->FindServerMask(parameters[0]);
        if (found)
        {
@@ -333,12 +296,18 @@ ModResult ModuleSpanningTree::HandleVersion(const std::vector<std::string>& para
                        // Pass to default VERSION handler.
                        return MOD_RES_PASSTHRU;
                }
-               std::string Version = found->GetVersion();
-               user->WriteNumeric(351, "%s :%s",user->nick.c_str(),Version.c_str());
+
+               // If an oper wants to see the version then show the full version string instead of the normal,
+               // but only if it is non-empty.
+               // If it's empty it might be that the server is still syncing (full version hasn't arrived yet)
+               // or the server is a 2.0 server and does not send a full version.
+               bool showfull = ((user->IsOper()) && (!found->GetFullVersion().empty()));
+               const std::string& Version = (showfull ? found->GetFullVersion() : found->GetVersion());
+               user->WriteNumeric(RPL_VERSION, Version);
        }
        else
        {
-               user->WriteNumeric(402, "%s %s :No such server",user->nick.c_str(),parameters[0].c_str());
+               user->WriteNumeric(ERR_NOSUCHSERVER, parameters[0], "No such server");
        }
        return MOD_RES_DENY;
 }
@@ -361,9 +330,9 @@ ModResult ModuleSpanningTree::HandleConnect(const std::vector<std::string>& para
        for (std::vector<reference<Link> >::iterator i = Utils->LinkBlocks.begin(); i < Utils->LinkBlocks.end(); i++)
        {
                Link* x = *i;
-               if (InspIRCd::Match(x->Name.c_str(),parameters[0]))
+               if (InspIRCd::Match(x->Name.c_str(),parameters[0], rfc_case_insensitive_map))
                {
-                       if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name)))
+                       if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name), rfc_case_insensitive_map))
                        {
                                RemoteMessage(user, "*** CONNECT: Server \002%s\002 is ME, not connecting.",x->Name.c_str());
                                return MOD_RES_DENY;
@@ -387,27 +356,14 @@ ModResult ModuleSpanningTree::HandleConnect(const std::vector<std::string>& para
        return MOD_RES_DENY;
 }
 
-void ModuleSpanningTree::On005Numeric(std::map<std::string, std::string>& tokens)
-{
-       tokens["MAP"];
-}
-
-void ModuleSpanningTree::OnGetServerDescription(const std::string &servername,std::string &description)
-{
-       TreeServer* s = Utils->FindServer(servername);
-       if (s)
-       {
-               description = s->GetDesc();
-       }
-}
-
-void ModuleSpanningTree::OnUserInvite(User* source,User* dest,Channel* channel, time_t expiry)
+void ModuleSpanningTree::OnUserInvite(User* source, User* dest, Channel* channel, time_t expiry, unsigned int notifyrank, CUList& notifyexcepts)
 {
        if (IS_LOCAL(source))
        {
                CmdBuilder params(source, "INVITE");
                params.push_back(dest->uuid);
                params.push_back(channel->name);
+               params.push_int(channel->age);
                params.push_back(ConvToStr(expiry));
                params.Broadcast();
        }
@@ -456,7 +412,6 @@ void ModuleSpanningTree::OnUserMessage(User* user, void* dest, int target_type,
 void ModuleSpanningTree::OnBackgroundTimer(time_t curtime)
 {
        AutoConnectServers(curtime);
-       DoPingChecks(curtime);
        DoConnectTimeout(curtime);
 }
 
@@ -487,19 +442,21 @@ void ModuleSpanningTree::OnUserJoin(Membership* memb, bool sync, bool created_by
        if (!IS_LOCAL(memb->user))
                return;
 
+       // Assign the current membership id to the new Membership and increase it
+       memb->id = currmembid++;
+
        if (created_by_local)
        {
-               CmdBuilder params("FJOIN");
-               params.push_back(memb->chan->name);
-               params.push_back(ConvToStr(memb->chan->age));
-               params.push_raw(" +").push_raw(memb->chan->ChanModes(true));
-               params.push(memb->modes).push_raw(',').push_raw(memb->user->uuid);
+               CommandFJoin::Builder params(memb->chan);
+               params.add(memb);
+               params.finalize();
                params.Broadcast();
        }
        else
        {
                CmdBuilder params(memb->user, "IJOIN");
                params.push_back(memb->chan->name);
+               params.push_int(memb->id);
                if (!memb->modes.empty())
                {
                        params.push_back(ConvToStr(memb->chan->age));
@@ -522,7 +479,7 @@ void ModuleSpanningTree::OnChangeName(User* user, const std::string &gecos)
        if (user->registered != REG_ALL || !IS_LOCAL(user))
                return;
 
-       CmdBuilder(user, "FNAME").push(gecos).Broadcast();
+       CmdBuilder(user, "FNAME").push_last(gecos).Broadcast();
 }
 
 void ModuleSpanningTree::OnChangeIdent(User* user, const std::string &ident)
@@ -547,54 +504,58 @@ void ModuleSpanningTree::OnUserPart(Membership* memb, std::string &partmessage,
 
 void ModuleSpanningTree::OnUserQuit(User* user, const std::string &reason, const std::string &oper_message)
 {
-       if ((IS_LOCAL(user)) && (user->registered == REG_ALL))
+       if (IS_LOCAL(user))
        {
                if (oper_message != reason)
                        ServerInstance->PI->SendMetaData(user, "operquit", oper_message);
 
                CmdBuilder(user, "QUIT").push_last(reason).Broadcast();
        }
-
-       // Regardless, We need to modify the user Counts..
-       TreeServer* SourceServer = Utils->FindServer(user->server);
-       if (SourceServer)
+       else
        {
-               SourceServer->UserCount--;
+               // Hide the message if one of the following is true:
+               // - User is being quit due to a netsplit and quietbursts is on
+               // - Server is a silent uline
+               TreeServer* server = TreeServer::Get(user);
+               bool hide = (((server->IsDead()) && (Utils->quiet_bursts)) || (server->IsSilentULine()));
+               if (!hide)
+               {
+                       ServerInstance->SNO->WriteToSnoMask('Q', "Client exiting on server %s: %s (%s) [%s]",
+                               user->server->GetName().c_str(), user->GetFullRealHost().c_str(), user->GetIPString().c_str(), oper_message.c_str());
+               }
        }
+
+       // Regardless, update the UserCount
+       TreeServer::Get(user)->UserCount--;
 }
 
 void ModuleSpanningTree::OnUserPostNick(User* user, const std::string &oldnick)
 {
        if (IS_LOCAL(user))
        {
+               // The nick TS is updated by the core, we don't do it
                CmdBuilder params(user, "NICK");
                params.push_back(user->nick);
-
-               /** IMPORTANT: We don't update the TS if the oldnick is just a case change of the newnick!
-                */
-               if (irc::string(user->nick.c_str()) != assign(oldnick))
-                       user->age = ServerInstance->Time();
-
                params.push_back(ConvToStr(user->age));
                params.Broadcast();
        }
-       else if (!loopCall && user->nick == user->uuid)
+       else if (!loopCall)
        {
-               CmdBuilder params("SAVE");
-               params.push_back(user->uuid);
-               params.push_back(ConvToStr(user->age));
-               params.Broadcast();
+               ServerInstance->Logs->Log(MODNAME, LOG_DEFAULT, "WARNING: Changed nick of remote user %s from %s to %s TS %lu by ourselves!", user->uuid.c_str(), oldnick.c_str(), user->nick.c_str(), (unsigned long) user->age);
        }
 }
 
 void ModuleSpanningTree::OnUserKick(User* source, Membership* memb, const std::string &reason, CUList& excepts)
 {
-       if ((!IS_LOCAL(source) || source != ServerInstance->FakeClient))
+       if ((!IS_LOCAL(source)) && (source != ServerInstance->FakeClient))
                return;
 
        CmdBuilder params(source, "KICK");
        params.push_back(memb->chan->name);
        params.push_back(memb->user->uuid);
+       // If a remote user is being kicked by us then send the membership id in the kick too
+       if (!IS_LOCAL(memb->user))
+               params.push_int(memb->id);
        params.push_last(reason);
        params.Broadcast();
 }
@@ -611,12 +572,22 @@ void ModuleSpanningTree::OnPreRehash(User* user, const std::string &parameter)
        {
                CmdBuilder params((user ? user->uuid : ServerInstance->Config->GetSID()), "REHASH");
                params.push_back(parameter);
-               params.Forward(user ? Utils->BestRouteTo(user->server) : NULL);
+               params.Forward(user ? TreeServer::Get(user)->GetRoute() : NULL);
        }
 }
 
 void ModuleSpanningTree::ReadConfig(ConfigStatus& status)
 {
+       // Did this rehash change the description of this server?
+       const std::string& newdesc = ServerInstance->Config->ServerDesc;
+       if (newdesc != Utils->TreeRoot->GetDesc())
+       {
+               // Broadcast a SINFO desc message to let the network know about the new description. This is the description
+               // string that is sent in the SERVER message initially and shown for example in WHOIS.
+               // We don't need to update the field itself in the Server object - the core does that.
+               CommandSInfo::Builder(Utils->TreeRoot, "desc", newdesc).Broadcast();
+       }
+
        // Re-read config stuff
        try
        {
@@ -631,7 +602,7 @@ void ModuleSpanningTree::ReadConfig(ConfigStatus& status)
                msg.append(e.GetReason());
                ServerInstance->SNO->WriteToSnoMask('l', msg);
                if (status.srcuser && !IS_LOCAL(status.srcuser))
-                       ServerInstance->PI->SendSNONotice("L", msg);
+                       ServerInstance->PI->SendSNONotice('L', msg);
        }
 }
 
@@ -646,42 +617,45 @@ void ModuleSpanningTree::OnLoadModule(Module* mod)
                data.push_back('=');
                data.append(v.link_data);
        }
-       ServerInstance->PI->SendMetaData(NULL, "modules", data);
+       ServerInstance->PI->SendMetaData("modules", data);
 }
 
 void ModuleSpanningTree::OnUnloadModule(Module* mod)
 {
        if (!Utils)
                return;
-       ServerInstance->PI->SendMetaData(NULL, "modules", "-" + mod->ModuleSourceFile);
+       ServerInstance->PI->SendMetaData("modules", "-" + mod->ModuleSourceFile);
 
+restart:
        // Close all connections which use an IO hook provided by this module
        const TreeServer::ChildServers& list = Utils->TreeRoot->GetChildren();
        for (TreeServer::ChildServers::const_iterator i = list.begin(); i != list.end(); ++i)
        {
                TreeSocket* sock = (*i)->GetSocket();
-               if (sock && sock->GetIOHook() && sock->GetIOHook()->creator == mod)
+               if (sock->GetIOHook() && sock->GetIOHook()->prov->creator == mod)
                {
                        sock->SendError("SSL module unloaded");
                        sock->Close();
+                       // XXX: The list we're iterating is modified by TreeServer::SQuit() which is called by Close()
+                       goto restart;
                }
        }
 
        for (SpanningTreeUtilities::TimeoutList::const_iterator i = Utils->timeoutlist.begin(); i != Utils->timeoutlist.end(); ++i)
        {
                TreeSocket* sock = i->first;
-               if (sock->GetIOHook() && sock->GetIOHook()->creator == mod)
+               if (sock->GetIOHook() && sock->GetIOHook()->prov->creator == mod)
                        sock->Close();
        }
 }
 
-// note: the protocol does not allow direct umode +o except
-// via NICK with 8 params. sending OPERTYPE infers +o modechange
-// locally.
 void ModuleSpanningTree::OnOper(User* user, const std::string &opertype)
 {
        if (user->registered != REG_ALL || !IS_LOCAL(user))
                return;
+
+       // Note: The protocol does not allow direct umode +o;
+       // sending OPERTYPE infers +o modechange locally.
        CommandOpertype::Builder(user).Broadcast();
 }
 
@@ -718,37 +692,31 @@ ModResult ModuleSpanningTree::OnSetAway(User* user, const std::string &awaymsg)
        return MOD_RES_PASSTHRU;
 }
 
-void ModuleSpanningTree::ProtoSendMode(void* opaque, TargetTypeFlags target_type, void* target, const parameterlist &modeline, const std::vector<TranslateType> &translate)
+void ModuleSpanningTree::OnMode(User* source, User* u, Channel* c, const Modes::ChangeList& modes, ModeParser::ModeProcessFlag processflags, const std::string& output_mode)
 {
-       TreeSocket* s = (TreeSocket*)opaque;
-       std::string output_text = CommandParser::TranslateUIDs(translate, modeline);
+       if (processflags & ModeParser::MODE_LOCALONLY)
+               return;
 
-       if (target)
+       if (u)
        {
-               if (target_type == TYPE_USER)
-               {
-                       User* u = (User*)target;
-                       s->WriteLine(":"+ServerInstance->Config->GetSID()+" MODE "+u->uuid+" "+output_text);
-               }
-               else if (target_type == TYPE_CHANNEL)
-               {
-                       Channel* c = (Channel*)target;
-                       s->WriteLine(":"+ServerInstance->Config->GetSID()+" FMODE "+c->name+" "+ConvToStr(c->age)+" "+output_text);
-               }
-       }
-}
+               if (u->registered != REG_ALL)
+                       return;
 
-void ModuleSpanningTree::ProtoSendMetaData(void* opaque, Extensible* target, const std::string &extname, const std::string &extdata)
-{
-       TreeSocket* s = static_cast<TreeSocket*>(opaque);
-       User* u = dynamic_cast<User*>(target);
-       Channel* c = dynamic_cast<Channel*>(target);
-       if (u)
-               s->WriteLine(":"+ServerInstance->Config->GetSID()+" METADATA "+u->uuid+" "+extname+" :"+extdata);
-       else if (c)
-               s->WriteLine(":"+ServerInstance->Config->GetSID()+" METADATA "+c->name+" "+ConvToStr(c->age)+" "+extname+" :"+extdata);
-       else if (!target)
-               s->WriteLine(":"+ServerInstance->Config->GetSID()+" METADATA * "+extname+" :"+extdata);
+               CmdBuilder params(source, "MODE");
+               params.push(u->uuid);
+               params.push(output_mode);
+               params.push_raw(Translate::ModeChangeListToParams(modes.getlist()));
+               params.Broadcast();
+       }
+       else
+       {
+               CmdBuilder params(source, "FMODE");
+               params.push(c->name);
+               params.push_int(c->age);
+               params.push(output_mode);
+               params.push_raw(Translate::ModeChangeListToParams(modes.getlist()));
+               params.Broadcast();
+       }
 }
 
 CullResult ModuleSpanningTree::cull()
@@ -760,13 +728,12 @@ CullResult ModuleSpanningTree::cull()
 
 ModuleSpanningTree::~ModuleSpanningTree()
 {
-       delete ServerInstance->PI;
-       ServerInstance->PI = new ProtocolInterface;
+       ServerInstance->PI = &ServerInstance->DefaultProtocolInterface;
 
-       /* This will also free the listeners */
-       delete Utils;
+       Server* newsrv = new Server(ServerInstance->Config->ServerName, ServerInstance->Config->ServerDesc);
+       SetLocalUsersServer(newsrv);
 
-       delete commands;
+       delete Utils;
 }
 
 Version ModuleSpanningTree::GetVersion()
@@ -778,7 +745,7 @@ Version ModuleSpanningTree::GetVersion()
  * so that any activity it sees is FINAL, e.g. we arent going to send out
  * a NICK message before m_cloaking has finished putting the +x on the user,
  * etc etc.
- * Therefore, we return PRIORITY_LAST to make sure we end up at the END of
+ * Therefore, we set our priority to PRIORITY_LAST to make sure we end up at the END of
  * the module call queue.
  */
 void ModuleSpanningTree::Prioritize()