]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/main.cpp
Windows: In-depth cleanup (see details)
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / main.cpp
index b9e36ba257eec2f517e69e50b31994bf6c3376f9..b8540cf2769f946b64bdb94e0455adeddaa584c1 100644 (file)
@@ -1,16 +1,26 @@
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
  *
- *  InspIRCd: (C) 2002-2010 InspIRCd Development Team
- * See: http://wiki.inspircd.org/Credits
+ *   Copyright (C) 2009-2010 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2007-2009 Craig Edwards <craigedwards@brainbox.cc>
+ *   Copyright (C) 2007-2008 Robin Burchell <robin+git@viroteck.net>
+ *   Copyright (C) 2008 Thomas Stagner <aquanight@inspircd.org>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
  *
- * This program is free but copyrighted software; see
- *         the file COPYING for details.
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+
 /* $ModDesc: Provides a spanning tree server link protocol */
 
 #include "inspircd.h"
@@ -89,7 +99,7 @@ void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
        }
        for (unsigned int q = 0; q < Current->ChildCount(); q++)
        {
-               if ((Current->GetChild(q)->Hidden) || ((Utils->HideULines) && (ServerInstance->ULine(Current->GetChild(q)->GetName().c_str()))))
+               if ((Current->GetChild(q)->Hidden) || ((Utils->HideULines) && (ServerInstance->ULine(Current->GetChild(q)->GetName()))))
                {
                        if (IS_OPER(user))
                        {
@@ -102,13 +112,14 @@ void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
                }
        }
        /* Don't display the line if its a uline, hide ulines is on, and the user isnt an oper */
-       if ((Utils->HideULines) && (ServerInstance->ULine(Current->GetName().c_str())) && (!IS_OPER(user)))
+       if ((Utils->HideULines) && (ServerInstance->ULine(Current->GetName())) && (!IS_OPER(user)))
                return;
        /* Or if the server is hidden and they're not an oper */
        else if ((Current->Hidden) && (!IS_OPER(user)))
                return;
 
-       user->WriteNumeric(364, "%s %s %s :%d %s",      user->nick.c_str(),Current->GetName().c_str(),
+       std::string servername = Current->GetName();
+       user->WriteNumeric(364, "%s %s %s :%d %s",      user->nick.c_str(), servername.c_str(),
                        (Utils->FlatLinks && (!IS_OPER(user))) ? ServerInstance->Config->ServerName.c_str() : Parent.c_str(),
                        (Utils->FlatLinks && (!IS_OPER(user))) ? 0 : hops,
                        Current->GetDesc().c_str());
@@ -134,9 +145,9 @@ std::string ModuleSpanningTree::TimeToStr(time_t secs)
        secs = secs % 60;
        mins_up = mins_up % 60;
        hours_up = hours_up % 24;
-       return ((days_up ? (ConvToStr(days_up) + "d") : std::string(""))
-                       + (hours_up ? (ConvToStr(hours_up) + "h") : std::string(""))
-                       + (mins_up ? (ConvToStr(mins_up) + "m") : std::string(""))
+       return ((days_up ? (ConvToStr(days_up) + "d") : "")
+                       + (hours_up ? (ConvToStr(hours_up) + "h") : "")
+                       + (mins_up ? (ConvToStr(mins_up) + "m") : "")
                        + ConvToStr(secs) + "s");
 }
 
@@ -152,7 +163,7 @@ restart:
        for (server_hash::iterator i = Utils->serverlist.begin(); i != Utils->serverlist.end(); i++)
        {
                TreeServer *s = i->second;
-               
+
                if (s->GetSocket() && s->GetSocket()->GetLinkState() == DYING)
                {
                        s->GetSocket()->Close();
@@ -183,7 +194,7 @@ restart:
                                        // ... if we can find a proper route to them
                                        if (tsock)
                                        {
-                                               tsock->WriteLine(std::string(":") + ServerInstance->Config->GetSID() + " PING " +
+                                               tsock->WriteLine(":" + ServerInstance->Config->GetSID() + " PING " +
                                                                ServerInstance->Config->GetSID() + " " + s->GetID());
                                                s->LastPingMsec = ts;
                                        }
@@ -205,7 +216,8 @@ restart:
                        if ((Utils->PingWarnTime) && (!s->Warned) && (curtime >= s->NextPingTime() - (Utils->PingFreq - Utils->PingWarnTime)) && (!s->AnsweredLastPing()))
                        {
                                /* The server hasnt responded, send a warning to opers */
-                               ServerInstance->SNO->WriteToSnoMask('l',"Server \002%s\002 has not responded to PING for %d seconds, high latency.", s->GetName().c_str(), Utils->PingWarnTime);
+                               std::string servername = s->GetName();
+                               ServerInstance->SNO->WriteToSnoMask('l',"Server \002%s\002 has not responded to PING for %d seconds, high latency.", servername.c_str(), Utils->PingWarnTime);
                                s->Warned = true;
                        }
                }
@@ -294,7 +306,7 @@ void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
        {
                try
                {
-                       bool cached;
+                       bool cached = false;
                        ServernameResolver* snr = new ServernameResolver(Utils, x->IPAddr, x, cached, start_type, y);
                        ServerInstance->AddResolver(snr, cached);
                }
@@ -333,7 +345,7 @@ void ModuleSpanningTree::DoConnectTimeout(time_t curtime)
                        Utils->timeoutlist.erase(me);
                        s->Close();
                }
-               if (curtime > s->age + p.second)
+               else if (curtime > s->age + p.second)
                {
                        ServerInstance->SNO->WriteToSnoMask('l',"CONNECT: Error connecting \002%s\002 (timeout of %d seconds)",p.first.c_str(),p.second);
                        Utils->timeoutlist.erase(me);
@@ -401,7 +413,8 @@ ModResult ModuleSpanningTree::HandleConnect(const std::vector<std::string>& para
                        }
                        else
                        {
-                               RemoteMessage(user, "*** CONNECT: Server \002%s\002 already exists on the network and is connected via \002%s\002",x->Name.c_str(),CheckDupe->GetParent()->GetName().c_str());
+                               std::string servername = CheckDupe->GetParent()->GetName();
+                               RemoteMessage(user, "*** CONNECT: Server \002%s\002 already exists on the network and is connected via \002%s\002", x->Name.c_str(), servername.c_str());
                                return MOD_RES_DENY;
                        }
                }
@@ -579,7 +592,7 @@ void ModuleSpanningTree::OnUserConnect(LocalUser* user)
        params.push_back(user->GetIPString());
        params.push_back(ConvToStr(user->signon));
        params.push_back("+"+std::string(user->FormatModes(true)));
-       params.push_back(":"+std::string(user->fullname));
+       params.push_back(":"+user->fullname);
        Utils->DoOneToMany(ServerInstance->Config->GetSID(), "UID", params);
 
        if (IS_OPER(user))
@@ -612,7 +625,7 @@ void ModuleSpanningTree::OnUserJoin(Membership* memb, bool sync, bool created, C
                params.push_back(memb->chan->name);
                params.push_back(ConvToStr(memb->chan->age));
                params.push_back(std::string("+") + memb->chan->ChanModes(true));
-               params.push_back(memb->modes+","+std::string(memb->user->uuid));
+               params.push_back(memb->modes+","+memb->user->uuid);
                Utils->DoOneToMany(ServerInstance->Config->GetSID(),"FJOIN",params);
        }
 }
@@ -755,7 +768,21 @@ void ModuleSpanningTree::OnPreRehash(User* user, const std::string &parameter)
 void ModuleSpanningTree::OnRehash(User* user)
 {
        // Re-read config stuff
-       Utils->ReadConfiguration();
+       try
+       {
+               Utils->ReadConfiguration();
+       }
+       catch (ModuleException& e)
+       {
+               // Refresh the IP cache anyway, so servers read before the error will be allowed to connect
+               Utils->RefreshIPCache();
+               // Always warn local opers with snomask +l, also warn globally (snomask +L) if the rehash was issued by a remote user
+               std::string msg = "Error in configuration: ";
+               msg.append(e.GetReason());
+               ServerInstance->SNO->WriteToSnoMask('l', msg);
+               if (!IS_LOCAL(user))
+                       ServerInstance->PI->SendSNONotice("L", msg);
+       }
 }
 
 void ModuleSpanningTree::OnLoadModule(Module* mod)
@@ -789,10 +816,6 @@ void ModuleSpanningTree::OnUnloadModule(Module* mod)
        }
 }
 
-void ModuleSpanningTree::RedoConfig(Module* mod)
-{
-}
-
 // note: the protocol does not allow direct umode +o except
 // via NICK with 8 params. sending OPERTYPE infers +o modechange
 // locally.
@@ -810,11 +833,13 @@ void ModuleSpanningTree::OnAddLine(User* user, XLine *x)
        if (!x->IsBurstable() || loopCall)
                return;
 
-       char data[MAXBUF];
-       snprintf(data,MAXBUF,"%s %s %s %lu %lu :%s", x->type.c_str(), x->Displayable(),
-       ServerInstance->Config->ServerName.c_str(), (unsigned long)x->set_time, (unsigned long)x->duration, x->reason.c_str());
        parameterlist params;
-       params.push_back(data);
+       params.push_back(x->type);
+       params.push_back(x->Displayable());
+       params.push_back(ServerInstance->Config->ServerName);
+       params.push_back(ConvToStr(x->set_time));
+       params.push_back(ConvToStr(x->duration));
+       params.push_back(":" + x->reason);
 
        if (!user)
        {
@@ -830,13 +855,12 @@ void ModuleSpanningTree::OnAddLine(User* user, XLine *x)
 
 void ModuleSpanningTree::OnDelLine(User* user, XLine *x)
 {
-       if (x->type == "K")
+       if (!x->IsBurstable() || loopCall)
                return;
 
-       char data[MAXBUF];
-       snprintf(data,MAXBUF,"%s %s", x->type.c_str(), x->Displayable());
        parameterlist params;
-       params.push_back(data);
+       params.push_back(x->type);
+       params.push_back(x->Displayable());
 
        if (!user)
        {
@@ -855,7 +879,6 @@ void ModuleSpanningTree::OnMode(User* user, void* dest, int target_type, const p
        if ((IS_LOCAL(user)) && (user->registered == REG_ALL))
        {
                parameterlist params;
-               std::string command;
                std::string output_text;
 
                ServerInstance->Parser->TranslateUIDs(translate, text, output_text);
@@ -865,7 +888,7 @@ void ModuleSpanningTree::OnMode(User* user, void* dest, int target_type, const p
                        User* u = (User*)dest;
                        params.push_back(u->uuid);
                        params.push_back(output_text);
-                       command = "MODE";
+                       Utils->DoOneToMany(user->uuid, "MODE", params);
                }
                else
                {
@@ -873,10 +896,8 @@ void ModuleSpanningTree::OnMode(User* user, void* dest, int target_type, const p
                        params.push_back(c->name);
                        params.push_back(ConvToStr(c->age));
                        params.push_back(output_text);
-                       command = "FMODE";
+                       Utils->DoOneToMany(user->uuid, "FMODE", params);
                }
-
-               Utils->DoOneToMany(user->uuid, command, params);
        }
 }
 
@@ -884,18 +905,13 @@ ModResult ModuleSpanningTree::OnSetAway(User* user, const std::string &awaymsg)
 {
        if (IS_LOCAL(user))
        {
-               if (awaymsg.empty())
-               {
-                       parameterlist params;
-                       Utils->DoOneToMany(user->uuid,"AWAY",params);
-               }
-               else
+               parameterlist params;
+               if (!awaymsg.empty())
                {
-                       parameterlist params;
                        params.push_back(ConvToStr(user->awaytime));
                        params.push_back(":" + awaymsg);
-                       Utils->DoOneToMany(user->uuid,"AWAY",params);
                }
+               Utils->DoOneToMany(user->uuid, "AWAY", params);
        }
 
        return MOD_RES_PASSTHRU;
@@ -913,12 +929,12 @@ void ModuleSpanningTree::ProtoSendMode(void* opaque, TargetTypeFlags target_type
                if (target_type == TYPE_USER)
                {
                        User* u = (User*)target;
-                       s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" MODE "+u->uuid+" "+output_text);
+                       s->WriteLine(":"+ServerInstance->Config->GetSID()+" MODE "+u->uuid+" "+output_text);
                }
                else if (target_type == TYPE_CHANNEL)
                {
                        Channel* c = (Channel*)target;
-                       s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" FMODE "+c->name+" "+ConvToStr(c->age)+" "+output_text);
+                       s->WriteLine(":"+ServerInstance->Config->GetSID()+" FMODE "+c->name+" "+ConvToStr(c->age)+" "+output_text);
                }
        }
 }
@@ -929,11 +945,11 @@ void ModuleSpanningTree::ProtoSendMetaData(void* opaque, Extensible* target, con
        User* u = dynamic_cast<User*>(target);
        Channel* c = dynamic_cast<Channel*>(target);
        if (u)
-               s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" METADATA "+u->uuid+" "+extname+" :"+extdata);
+               s->WriteLine(":"+ServerInstance->Config->GetSID()+" METADATA "+u->uuid+" "+extname+" :"+extdata);
        else if (c)
-               s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" METADATA "+c->name+" "+extname+" :"+extdata);
+               s->WriteLine(":"+ServerInstance->Config->GetSID()+" METADATA "+c->name+" "+extname+" :"+extdata);
        else if (!target)
-               s->WriteLine(std::string(":")+ServerInstance->Config->GetSID()+" METADATA * "+extname+" :"+extdata);
+               s->WriteLine(":"+ServerInstance->Config->GetSID()+" METADATA * "+extname+" :"+extdata);
 }
 
 CullResult ModuleSpanningTree::cull()