]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/main.cpp
m_spanningtree Replace manual string building of outgoing commands with CmdBuilder...
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / main.cpp
index 9a7cddec3ce6e395ef48625641ac23dd77d67ea6..e10781198dca3f080887f9898dd542ccb910c16b 100644 (file)
 #include "link.h"
 #include "treesocket.h"
 #include "commands.h"
-#include "protocolinterface.h"
 
 ModuleSpanningTree::ModuleSpanningTree()
        : rconnect(this), rsquit(this), map(this)
-       , commands(NULL), DNS(this, "DNS")
+       , commands(NULL)
+       , currmembid(0)
+       , DNS(this, "DNS")
+       , loopCall(false)
+       , SplitInProgress(false)
 {
 }
 
@@ -47,8 +50,8 @@ SpanningTreeCommands::SpanningTreeCommands(ModuleSpanningTree* module)
        fmode(module), ftopic(module), fhost(module), fident(module), fname(module),
        away(module), addline(module), delline(module), encap(module), idle(module),
        nick(module), ping(module), pong(module), push(module), save(module),
-       server(module), squit(module), snonotice(module), version(module),
-       burst(module), endburst(module)
+       server(module), squit(module), snonotice(module),
+       burst(module), endburst(module), sinfo(module)
 {
 }
 
@@ -61,27 +64,34 @@ namespace
                for (LocalUserList::const_iterator i = list.begin(); i != list.end(); ++i)
                        (*i)->server = newserver;
        }
+
+       void ResetMembershipIds()
+       {
+               // Set all membership ids to 0
+               const LocalUserList& list = ServerInstance->Users->local_users;
+               for (LocalUserList::iterator i = list.begin(); i != list.end(); ++i)
+               {
+                       LocalUser* user = *i;
+                       for (UCListIter j = user->chans.begin(); j != user->chans.end(); ++j)
+                               (*j)->id = 0;
+               }
+       }
 }
 
 void ModuleSpanningTree::init()
 {
        ServerInstance->SNO->EnableSnomask('l', "LINK");
 
+       ResetMembershipIds();
+
        Utils = new SpanningTreeUtilities(this);
        Utils->TreeRoot = new TreeServer;
        commands = new SpanningTreeCommands(this);
 
-       delete ServerInstance->PI;
-       ServerInstance->PI = new SpanningTreeProtocolInterface;
+       ServerInstance->PI = &protocolinterface;
 
        delete ServerInstance->FakeClient->server;
        SetLocalUsersServer(Utils->TreeRoot);
-
-       loopCall = false;
-       SplitInProgress = false;
-
-       // update our local user count
-       Utils->TreeRoot->UserCount = ServerInstance->Users->local_users.size();
 }
 
 void ModuleSpanningTree::ShowLinks(TreeServer* Current, User* user, int hops)
@@ -179,7 +189,7 @@ restart:
                        {
                                // They did, send a ping to them
                                s->SetNextPingTime(curtime + Utils->PingFreq);
-                               s->GetSocket()->WriteLine(":" + ServerInstance->Config->GetSID() + " PING " + s->GetID());
+                               s->GetSocket()->WriteLine(CmdBuilder("PING").push(s->GetID()));
                                s->LastPingMsec = ts;
                        }
                        else
@@ -246,7 +256,7 @@ void ModuleSpanningTree::ConnectServer(Link* x, Autoconnect* y)
 {
        bool ipvalid = true;
 
-       if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name)))
+       if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name), rfc_case_insensitive_map))
        {
                ServerInstance->SNO->WriteToSnoMask('l', "CONNECT: Not connecting to myself.");
                return;
@@ -349,7 +359,13 @@ ModResult ModuleSpanningTree::HandleVersion(const std::vector<std::string>& para
                        // Pass to default VERSION handler.
                        return MOD_RES_PASSTHRU;
                }
-               std::string Version = found->GetVersion();
+
+               // If an oper wants to see the version then show the full version string instead of the normal,
+               // but only if it is non-empty.
+               // If it's empty it might be that the server is still syncing (full version hasn't arrived yet)
+               // or the server is a 2.0 server and does not send a full version.
+               bool showfull = ((user->IsOper()) && (!found->GetFullVersion().empty()));
+               const std::string& Version = (showfull ? found->GetFullVersion() : found->GetVersion());
                user->WriteNumeric(RPL_VERSION, ":%s", Version.c_str());
        }
        else
@@ -377,9 +393,9 @@ ModResult ModuleSpanningTree::HandleConnect(const std::vector<std::string>& para
        for (std::vector<reference<Link> >::iterator i = Utils->LinkBlocks.begin(); i < Utils->LinkBlocks.end(); i++)
        {
                Link* x = *i;
-               if (InspIRCd::Match(x->Name.c_str(),parameters[0]))
+               if (InspIRCd::Match(x->Name.c_str(),parameters[0], rfc_case_insensitive_map))
                {
-                       if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name)))
+                       if (InspIRCd::Match(ServerInstance->Config->ServerName, assign(x->Name), rfc_case_insensitive_map))
                        {
                                RemoteMessage(user, "*** CONNECT: Server \002%s\002 is ME, not connecting.",x->Name.c_str());
                                return MOD_RES_DENY;
@@ -415,6 +431,7 @@ void ModuleSpanningTree::OnUserInvite(User* source,User* dest,Channel* channel,
                CmdBuilder params(source, "INVITE");
                params.push_back(dest->uuid);
                params.push_back(channel->name);
+               params.push_int(channel->age);
                params.push_back(ConvToStr(expiry));
                params.Broadcast();
        }
@@ -494,19 +511,21 @@ void ModuleSpanningTree::OnUserJoin(Membership* memb, bool sync, bool created_by
        if (!IS_LOCAL(memb->user))
                return;
 
+       // Assign the current membership id to the new Membership and increase it
+       memb->id = currmembid++;
+
        if (created_by_local)
        {
-               CmdBuilder params("FJOIN");
-               params.push_back(memb->chan->name);
-               params.push_back(ConvToStr(memb->chan->age));
-               params.push_raw(" +").push_raw(memb->chan->ChanModes(true));
-               params.push(memb->modes).push_raw(',').push_raw(memb->user->uuid);
+               CommandFJoin::Builder params(memb->chan);
+               params.add(memb);
+               params.finalize();
                params.Broadcast();
        }
        else
        {
                CmdBuilder params(memb->user, "IJOIN");
                params.push_back(memb->chan->name);
+               params.push_int(memb->id);
                if (!memb->modes.empty())
                {
                        params.push_back(ConvToStr(memb->chan->age));
@@ -529,7 +548,7 @@ void ModuleSpanningTree::OnChangeName(User* user, const std::string &gecos)
        if (user->registered != REG_ALL || !IS_LOCAL(user))
                return;
 
-       CmdBuilder(user, "FNAME").push(gecos).Broadcast();
+       CmdBuilder(user, "FNAME").push_last(gecos).Broadcast();
 }
 
 void ModuleSpanningTree::OnChangeIdent(User* user, const std::string &ident)
@@ -582,14 +601,9 @@ void ModuleSpanningTree::OnUserPostNick(User* user, const std::string &oldnick)
 {
        if (IS_LOCAL(user))
        {
+               // The nick TS is updated by the core, we don't do it
                CmdBuilder params(user, "NICK");
                params.push_back(user->nick);
-
-               /** IMPORTANT: We don't update the TS if the oldnick is just a case change of the newnick!
-                */
-               if (irc::string(user->nick.c_str()) != assign(oldnick))
-                       user->age = ServerInstance->Time();
-
                params.push_back(ConvToStr(user->age));
                params.Broadcast();
        }
@@ -610,6 +624,9 @@ void ModuleSpanningTree::OnUserKick(User* source, Membership* memb, const std::s
        CmdBuilder params(source, "KICK");
        params.push_back(memb->chan->name);
        params.push_back(memb->user->uuid);
+       // If a remote user is being kicked by us then send the membership id in the kick too
+       if (!IS_LOCAL(memb->user))
+               params.push_int(memb->id);
        params.push_last(reason);
        params.Broadcast();
 }
@@ -632,6 +649,16 @@ void ModuleSpanningTree::OnPreRehash(User* user, const std::string &parameter)
 
 void ModuleSpanningTree::ReadConfig(ConfigStatus& status)
 {
+       // Did this rehash change the description of this server?
+       const std::string& newdesc = ServerInstance->Config->ServerDesc;
+       if (newdesc != Utils->TreeRoot->GetDesc())
+       {
+               // Broadcast a SINFO desc message to let the network know about the new description. This is the description
+               // string that is sent in the SERVER message initially and shown for example in WHOIS.
+               // We don't need to update the field itself in the Server object - the core does that.
+               CommandSInfo::Builder(Utils->TreeRoot, "desc", newdesc).Broadcast();
+       }
+
        // Re-read config stuff
        try
        {
@@ -675,7 +702,7 @@ void ModuleSpanningTree::OnUnloadModule(Module* mod)
        for (TreeServer::ChildServers::const_iterator i = list.begin(); i != list.end(); ++i)
        {
                TreeSocket* sock = (*i)->GetSocket();
-               if (sock && sock->GetIOHook() && sock->GetIOHook()->creator == mod)
+               if (sock->GetIOHook() && sock->GetIOHook()->prov->creator == mod)
                {
                        sock->SendError("SSL module unloaded");
                        sock->Close();
@@ -685,7 +712,7 @@ void ModuleSpanningTree::OnUnloadModule(Module* mod)
        for (SpanningTreeUtilities::TimeoutList::const_iterator i = Utils->timeoutlist.begin(); i != Utils->timeoutlist.end(); ++i)
        {
                TreeSocket* sock = i->first;
-               if (sock->GetIOHook() && sock->GetIOHook()->creator == mod)
+               if (sock->GetIOHook() && sock->GetIOHook()->prov->creator == mod)
                        sock->Close();
        }
 }
@@ -742,8 +769,7 @@ CullResult ModuleSpanningTree::cull()
 
 ModuleSpanningTree::~ModuleSpanningTree()
 {
-       delete ServerInstance->PI;
-       ServerInstance->PI = new ProtocolInterface;
+       ServerInstance->PI = &ServerInstance->DefaultProtocolInterface;
 
        Server* newsrv = new Server(ServerInstance->Config->ServerName, ServerInstance->Config->ServerDesc);
        SetLocalUsersServer(newsrv);