m_spanningtree Replace manual string building of outgoing commands with CmdBuilder...

[user/henk/code/inspircd.git] / src / modules / m_spanningtree / nickcollide.cpp

diff --git a/src/modules/m_spanningtree/nickcollide.cpp b/src/modules/m_spanningtree/nickcollide.cpp
index 39490e953b28d3684376712b3ab23d5a106a98e7..e6bcb21b29cf6f36a0b8f8a7e83b345f8d98f5c7 100644 (file)
--- a/src/modules/m_spanningtree/nickcollide.cpp
+++ b/src/modules/m_spanningtree/nickcollide.cpp
@@ -23,6 +23,7 @@
 #include "treesocket.h"
 #include "treeserver.h"
 #include "utils.h"
+#include "commandbuilder.h"
 
 /*
  * Yes, this function looks a little ugly.
@@ -32,6 +33,9 @@
  */
 int SpanningTreeUtilities::DoCollision(User* u, TreeServer* server, time_t remotets, const std::string& remoteident, const std::string& remoteip, const std::string& remoteuid)
 {
+       // At this point we're sure that a collision happened, increment the counter regardless of who wins
+       ServerInstance->stats.Collisions++;
+
        /*
         * Under old protocol rules, we would have had to kill both clients.
         * Really, this sucks.
@@ -105,12 +109,12 @@ int SpanningTreeUtilities::DoCollision(User* u, TreeServer* server, time_t remot
                 * Local-side nick needs to change. Just in case we are hub, and
                 * this "local" nick is actually behind us, send an SAVE out.
                 */
-               parameterlist params;
+               CmdBuilder params("SAVE");
                params.push_back(u->uuid);
                params.push_back(ConvToStr(u->age));
-               this->DoOneToMany(ServerInstance->Config->GetSID(),"SAVE",params);
+               params.Broadcast();
 
-               u->ForceNickChange(u->uuid);
+               u->ChangeNick(u->uuid);
 
                if (!bChangeRemote)
                        return 1;
@@ -123,13 +127,13 @@ int SpanningTreeUtilities::DoCollision(User* u, TreeServer* server, time_t remot
                 * the UID or halt the propagation of the nick change command,
                 * so other servers don't need to see the SAVE
                 */
-               TreeSocket* sock = server->GetRoute()->GetSocket();
-               sock->WriteLine(":"+ServerInstance->Config->GetSID()+" SAVE "+remoteuid+" "+ ConvToStr(remotets));
+               TreeSocket* sock = server->GetSocket();
+               sock->WriteLine(CmdBuilder("SAVE").push(remoteuid).push_int(remotets));
 
                if (remote)
                {
                        /* nick change collide. Force change their nick. */
-                       remote->ForceNickChange(remoteuid);
+                       remote->ChangeNick(remoteuid);
                }
 
                if (!bChangeLocal)
@@ -138,4 +142,3 @@ int SpanningTreeUtilities::DoCollision(User* u, TreeServer* server, time_t remot
 
        return 3;
 }
-