m_spanningtree Fix rare desync when a KILL crosses a message that has the killed...

[user/henk/code/inspircd.git] / src / modules / m_spanningtree / postcommand.cpp

diff --git a/src/modules/m_spanningtree/postcommand.cpp b/src/modules/m_spanningtree/postcommand.cpp
index 6afe8e2c9c1fe808adf9176a7c26037b0a8a1206..471bbfcb970670c895ec304df5e30bcef15c44d2 100644 (file)
--- a/src/modules/m_spanningtree/postcommand.cpp
+++ b/src/modules/m_spanningtree/postcommand.cpp
@@ -39,10 +39,10 @@ void ModuleSpanningTree::OnPostCommand(const std::string &command, const std::ve
 
 void SpanningTreeUtilities::RouteCommand(TreeServer* origin, const std::string &command, const parameterlist& parameters, User *user)
 {
-       if (!ServerInstance->IsValidModuleCommand(command, parameters.size(), user))
+       if (!ServerInstance->Parser->IsValidCommand(command, parameters.size(), user))
                return;
 
-       /* We know it's non-null because IsValidModuleCommand returned true */
+       /* We know it's non-null because IsValidCommand returned true */
        Command* thiscmd = ServerInstance->Parser->GetHandler(command);
 
        RouteDescriptor routing = thiscmd->GetRouting(user, parameters);
@@ -52,15 +52,15 @@ void SpanningTreeUtilities::RouteCommand(TreeServer* origin, const std::string &
 
        if (routing.type == ROUTE_TYPE_LOCALONLY)
        {
-               Module* srcmodule = thiscmd->creator;
-               Version ver = srcmodule->GetVersion();
+               /* Broadcast when it's a core command with the default route descriptor and the source is a
+                * remote user or a remote server
+                */
 
-               if ((ver.Flags & VF_CORE) && !IS_LOCAL(user))
-                       routing = ROUTE_BROADCAST;
-               else
-                       return;
-               if (IS_SERVER(user) && user != ServerInstance->FakeClient)
+               Version ver = thiscmd->creator->GetVersion();
+               if ((!(ver.Flags & VF_CORE)) || (IS_LOCAL(user)) || (IS_SERVER(user) == ServerInstance->FakeClient))
                        return;
+
+               routing = ROUTE_BROADCAST;
        }
        else if (routing.type == ROUTE_TYPE_OPT_BCAST)
        {