]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/server.cpp
Remove InspIRCd* parameters and fields
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / server.cpp
index b609202d56a92a3e3b68011a10c74b87560ad5ca..b1c6c2cb45f3c30b7fdc6b46fdf7ac96bafb82d5 100644 (file)
@@ -2,8 +2,8 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
- * See: http://www.inspircd.org/wiki/index.php/Credits
+ *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
  *            the file COPYING for details.
  */
 
 #include "inspircd.h"
-#include "commands/cmd_whois.h"
-#include "commands/cmd_stats.h"
 #include "socket.h"
-#include "wildcard.h"
 #include "xline.h"
-#include "transport.h"
+#include "../transport.h"
 #include "socketengine.h"
 
-#include "m_spanningtree/main.h"
-#include "m_spanningtree/utils.h"
-#include "m_spanningtree/treeserver.h"
-#include "m_spanningtree/link.h"
-#include "m_spanningtree/treesocket.h"
-#include "m_spanningtree/resolvers.h"
-#include "m_spanningtree/handshaketimer.h"
+#include "main.h"
+#include "utils.h"
+#include "link.h"
+#include "treeserver.h"
+#include "treesocket.h"
 
-/* $ModDep: m_spanningtree/timesynctimer.h m_spanningtree/resolvers.h m_spanningtree/main.h m_spanningtree/utils.h m_spanningtree/treeserver.h m_spanningtree/link.h m_spanningtree/treesocket.h */
+/* $ModDep: m_spanningtree/main.h m_spanningtree/utils.h m_spanningtree/treeserver.h m_spanningtree/treesocket.h m_spanningtree/link.h */
 
 /*
  * Some server somewhere in the network introducing another server.
  *     -- w
  */
-bool TreeSocket::RemoteServer(const std::string &prefix, std::deque<std::string> &params)
+bool TreeSocket::RemoteServer(const std::string &prefix, parameterlist &params)
 {
        if (params.size() < 5)
        {
-               SendError("Protocol error - Missing SID");
+               SendError("Protocol error - Not enough parameters for SERVER command");
                return false;
        }
 
        std::string servername = params[0];
-       std::string password = params[1];
-       // hopcount is not used for a remote server, we calculate this ourselves
+       // password is not used for a remote server
+       // hopcount is not used (ever)
        std::string sid = params[3];
        std::string description = params[4];
        TreeServer* ParentOfThis = Utils->FindServer(prefix);
@@ -54,7 +49,7 @@ bool TreeSocket::RemoteServer(const std::string &prefix, std::deque<std::string>
                this->SendError("Protocol error - Introduced remote server from unknown server "+ParentOfThis->GetName());
                return false;
        }
-       if (!this->Instance->IsSID(sid))
+       if (!ServerInstance->IsSID(sid))
        {
                this->SendError("Invalid format server ID: "+sid+"!");
                return false;
@@ -62,26 +57,27 @@ bool TreeSocket::RemoteServer(const std::string &prefix, std::deque<std::string>
        TreeServer* CheckDupe = Utils->FindServer(servername);
        if (CheckDupe)
        {
-               this->SendError("Server "+CheckDupe->GetName()+" already exists!");
-               this->Instance->SNO->WriteToSnoMask('l',"Server \2"+CheckDupe->GetName()+"\2 being introduced from \2" + ParentOfThis->GetName() + "\2 denied, already exists. Closing link with " + ParentOfThis->GetName());
+               this->SendError("Server "+servername+" already exists!");
+               ServerInstance->SNO->WriteToSnoMask('L', "Server \2"+CheckDupe->GetName()+"\2 being introduced from \2" + ParentOfThis->GetName() + "\2 denied, already exists. Closing link with " + ParentOfThis->GetName());
                return false;
        }
-
-       Link* lnk = Utils->FindLink(servername);
-
-       TreeServer *Node = new TreeServer(this->Utils, this->Instance, servername, description, sid, ParentOfThis,NULL, lnk ? lnk->Hidden : false);
-
-       if (Node->DuplicateID())
+       CheckDupe = Utils->FindServer(sid);
+       if (CheckDupe)
        {
-               this->SendError("Server ID "+servername+" already exists on the network!");
-               this->Instance->SNO->WriteToSnoMask('l',"Server \2"+servername+"\2 being introduced from \2" + ParentOfThis->GetName() + "\2 denied, server ID already exists on the network. Closing link with " + ParentOfThis->GetName());
+               this->SendError("Server ID "+sid+" already exists! You may want to specify the server ID for the server manually with <server:id> so they do not conflict.");
+               ServerInstance->SNO->WriteToSnoMask('L', "Server \2"+servername+"\2 being introduced from \2" + ParentOfThis->GetName() + "\2 denied, server ID already exists on the network. Closing link with " + ParentOfThis->GetName());
                return false;
        }
 
+
+       Link* lnk = Utils->FindLink(servername);
+
+       TreeServer *Node = new TreeServer(Utils, servername, description, sid, ParentOfThis,NULL, lnk ? lnk->Hidden : false);
+
        ParentOfThis->AddChild(Node);
        params[4] = ":" + params[4];
        Utils->DoOneToAllButSender(prefix,"SERVER",params,prefix);
-       this->Instance->SNO->WriteToSnoMask('l',"Server \002"+ParentOfThis->GetName()+"\002 introduced server \002"+servername+"\002 ("+description+")");
+       ServerInstance->SNO->WriteToSnoMask('L', "Server \002"+ParentOfThis->GetName()+"\002 introduced server \002"+servername+"\002 ("+description+")");
        return true;
 }
 
@@ -90,11 +86,11 @@ bool TreeSocket::RemoteServer(const std::string &prefix, std::deque<std::string>
  * This is used after the other side of a connection has accepted our credentials.
  * They are then introducing themselves to us, BEFORE either of us burst. -- w
  */
-bool TreeSocket::Outbound_Reply_Server(std::deque<std::string> &params)
+bool TreeSocket::Outbound_Reply_Server(parameterlist &params)
 {
        if (params.size() < 5)
        {
-               SendError("Protocol error - Missing SID");
+               SendError("Protocol error - Not enough parameters for SERVER command");
                return false;
        }
 
@@ -109,17 +105,16 @@ bool TreeSocket::Outbound_Reply_Server(std::deque<std::string> &params)
        this->InboundDescription = description;
        this->InboundSID = sid;
 
-       if (!sentcapab)
-               this->SendCapabilities();
+       this->SendCapabilities(2);
 
        if (hops)
        {
                this->SendError("Server too far away for authentication");
-               this->Instance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, server is too far away for authentication");
+               ServerInstance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, server is too far away for authentication");
                return false;
        }
 
-       if (!this->Instance->IsSID(sid))
+       if (!ServerInstance->IsSID(sid))
        {
                this->SendError("Invalid format server ID: "+sid+"!");
                return false;
@@ -130,15 +125,24 @@ bool TreeSocket::Outbound_Reply_Server(std::deque<std::string> &params)
                if (x->Name != servername && x->Name != "*") // open link allowance
                        continue;
 
-               if (!ComparePass(this->MakePass(x->RecvPass, this->GetOurChallenge()), password) ||
-                       (x->RecvPass != password && !this->GetTheirChallenge().empty()))
+               if (!ComparePass(*x, password))
+               {
+                       ServerInstance->SNO->WriteToSnoMask('l',"Invalid password on link: %s", x->Name.c_str());
                        continue;
+               }
 
                TreeServer* CheckDupe = Utils->FindServer(sname);
                if (CheckDupe)
                {
                        this->SendError("Server "+sname+" already exists on server "+CheckDupe->GetParent()->GetName()+"!");
-                       this->Instance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, already exists on server "+CheckDupe->GetParent()->GetName());
+                       ServerInstance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, already exists on server "+CheckDupe->GetParent()->GetName());
+                       return false;
+               }
+               CheckDupe = Utils->FindServer(sid);
+               if (CheckDupe)
+               {
+                       this->SendError("Server ID "+sid+" already exists on the network! You may want to specify the server ID for the server manually with <server:id> so they do not conflict.");
+                       ServerInstance->SNO->WriteToSnoMask('l',"Server \2"+assign(servername)+"\2 being introduced denied, server ID already exists on the network. Closing link.");
                        return false;
                }
 
@@ -152,25 +156,24 @@ bool TreeSocket::Outbound_Reply_Server(std::deque<std::string> &params)
                 */
                this->LinkState = CONNECTED;
 
-               TreeServer *Node = new TreeServer(this->Utils, this->Instance, sname, description, sid, Utils->TreeRoot, this, x->Hidden);
+               Utils->timeoutlist.erase(this);
 
-               if (Node->DuplicateID())
-               {
-                       this->SendError("Server ID "+sid+" already exists on the network!");
-                       this->Instance->SNO->WriteToSnoMask('l',"Server \2"+assign(servername)+"\2 being introduced denied, server ID already exists on the network. Closing link.");
-                       return false;
-               }
+               TreeServer *Node = new TreeServer(Utils, sname, description, sid, Utils->TreeRoot, this, x->Hidden);
 
                Utils->TreeRoot->AddChild(Node);
                params[4] = ":" + params[4];
-               Utils->DoOneToAllButSender(Instance->Config->GetSID(),"SERVER",params,sname);
-               Node->bursting = true;
+
+
+               /* IMPORTANT: Take password/hmac hash OUT of here before we broadcast the introduction! */
+               params[1] = "*";
+               Utils->DoOneToAllButSender(ServerInstance->Config->GetSID(),"SERVER",params,sname);
+
                this->DoBurst(Node);
                return true;
        }
 
-       this->SendError("Invalid credentials");
-       this->Instance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, invalid link credentials");
+       this->SendError("Invalid credentials (check the other server's linking snomask for more information)");
+       ServerInstance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, invalid link credentials");
        return false;
 }
 
@@ -178,7 +181,7 @@ bool TreeSocket::Outbound_Reply_Server(std::deque<std::string> &params)
  * Someone else is attempting to connect to us if this is called. Validate their credentials etc.
  *             -- w
  */
-bool TreeSocket::Inbound_Server(std::deque<std::string> &params)
+bool TreeSocket::Inbound_Server(parameterlist &params)
 {
        if (params.size() < 5)
        {
@@ -197,17 +200,16 @@ bool TreeSocket::Inbound_Server(std::deque<std::string> &params)
        this->InboundDescription = description;
        this->InboundSID = sid;
 
-       if (!sentcapab)
-               this->SendCapabilities();
+       this->SendCapabilities(2);
 
        if (hops)
        {
                this->SendError("Server too far away for authentication");
-               this->Instance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, server is too far away for authentication");
+               ServerInstance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, server is too far away for authentication");
                return false;
        }
 
-       if (!this->Instance->IsSID(sid))
+       if (!ServerInstance->IsSID(sid))
        {
                this->SendError("Invalid format server ID: "+sid+"!");
                return false;
@@ -218,49 +220,52 @@ bool TreeSocket::Inbound_Server(std::deque<std::string> &params)
                if (x->Name != servername && x->Name != "*") // open link allowance
                        continue;
 
-               if (!ComparePass(this->MakePass(x->RecvPass, this->GetOurChallenge()), password) ||
-                       (x->RecvPass != password && !this->GetTheirChallenge().empty()))
+               if (!ComparePass(*x, password))
+               {
+                       ServerInstance->SNO->WriteToSnoMask('l',"Invalid password on link: %s", x->Name.c_str());
                        continue;
+               }
 
-               /* Check for fully initialized instances of the server by id */
-               Instance->Logs->Log("m_spanningtree",DEBUG,"Looking for dupe SID %s", sid.c_str());
-               TreeServer* CheckDupeSID = Utils->FindServerID(sid);
-
-               if (CheckDupeSID)
+               /* Now check for fully initialized ServerInstances of the server by name */
+               TreeServer* CheckDupe = Utils->FindServer(sname);
+               if (CheckDupe)
                {
-                       this->SendError("Server ID "+CheckDupeSID->GetID()+" already exists on server "+CheckDupeSID->GetName()+"!");
-                       this->Instance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, server ID '"+CheckDupeSID->GetID()+
-                                       "' already exists on server "+CheckDupeSID->GetName());
+                       this->SendError("Server "+sname+" already exists on server "+CheckDupe->GetParent()->GetName()+"!");
+                       ServerInstance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, already exists on server "+CheckDupe->GetParent()->GetName());
                        return false;
                }
 
-               /* Now check for fully initialized instances of the server by name */
-               TreeServer* CheckDupe = Utils->FindServer(sname);
+               /* Check for fully initialized instances of the server by id */
+               ServerInstance->Logs->Log("m_spanningtree",DEBUG,"Looking for dupe SID %s", sid.c_str());
+               CheckDupe = Utils->FindServerID(sid);
+
                if (CheckDupe)
                {
-                       this->SendError("Server "+sname+" already exists on server "+CheckDupe->GetParent()->GetName()+"!");
-                       this->Instance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, already exists on server "+CheckDupe->GetParent()->GetName());
+                       this->SendError("Server ID "+CheckDupe->GetID()+" already exists on server "+CheckDupe->GetName()+"! You may want to specify the server ID for the server manually with <server:id> so they do not conflict.");
+                       ServerInstance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, server ID '"+CheckDupe->GetID()+
+                                       "' already exists on server "+CheckDupe->GetName());
                        return false;
                }
 
-               this->Instance->SNO->WriteToSnoMask('l',"Verified incoming server connection from \002"+sname+"\002["+(x->HiddenFromStats ? "<hidden>" : this->GetIP())+"] ("+description+")");
-               if (this->Hook)
+
+               ServerInstance->SNO->WriteToSnoMask('l',"Verified incoming server connection from \002"+sname+"\002["+(x->HiddenFromStats ? "<hidden>" : this->IP)+"] ("+description+")");
+               if (this->GetIOHook())
                {
-                       std::string name = BufferedSocketNameRequest((Module*)Utils->Creator, this->Hook).Send();
-                       this->Instance->SNO->WriteToSnoMask('l',"Connection from \2"+sname+"\2["+(x->HiddenFromStats ? "<hidden>" : this->GetIP())+"] using transport \2"+name+"\2");
+                       std::string name = BufferedSocketNameRequest(Utils->Creator, this->GetIOHook()).Send();
+                       ServerInstance->SNO->WriteToSnoMask('l',"Connection from \2"+sname+"\2["+(x->HiddenFromStats ? "<hidden>" : this->IP)+"] using transport \2"+name+"\2");
                }
 
                // this is good. Send our details: Our server name and description and hopcount of 0,
                // along with the sendpass from this block.
-               this->SendCapabilities();
-               this->WriteLine(std::string("SERVER ")+this->Instance->Config->ServerName+" "+this->MakePass(x->SendPass, this->GetTheirChallenge())+" 0 "+Instance->Config->GetSID()+" :"+this->Instance->Config->ServerDesc);
+               this->SendCapabilities(2);
+               this->WriteLine(std::string("SERVER ")+ServerInstance->Config->ServerName+" "+this->MakePass(x->SendPass, this->GetTheirChallenge())+" 0 "+ServerInstance->Config->GetSID()+" :"+ServerInstance->Config->ServerDesc);
                // move to the next state, we are now waiting for THEM.
                this->LinkState = WAIT_AUTH_2;
                return true;
        }
 
        this->SendError("Invalid credentials");
-       this->Instance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, invalid link credentials");
+       ServerInstance->SNO->WriteToSnoMask('l',"Server connection from \2"+sname+"\2 denied, invalid link credentials");
        return false;
 }