]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/treeserver.cpp
m_spanningtree Remove duplicate code for sending channel messages from RouteCommand()
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / treeserver.cpp
index 65e1191495fe5d4b59157a4e310c1f06f4474c20..54ea5922fbaa56a770c31935c91455bc9cddfb65 100644 (file)
 
 
 #include "inspircd.h"
-#include "socket.h"
 #include "xline.h"
 #include "main.h"
-#include "../spanningtree.h"
+#include "modules/spanningtree.h"
 
 #include "utils.h"
 #include "treeserver.h"
 
-/* $ModDep: m_spanningtree/utils.h m_spanningtree/treeserver.h */
-
 /** We use this constructor only to create the 'root' item, Utils->TreeRoot, which
  * represents our own server. Therefore, it has no route, no parent, and
  * no socket associated with it. Its version string is our own local version.
  */
-TreeServer::TreeServer(SpanningTreeUtilities* Util, std::string Name, std::string Desc, const std::string &id)
-       : ServerName(Name.c_str()), ServerDesc(Desc), Utils(Util), ServerUser(ServerInstance->FakeClient)
+TreeServer::TreeServer()
+       : Parent(NULL), Route(NULL), ServerName(ServerInstance->Config->ServerName), ServerDesc(ServerInstance->Config->ServerDesc)
+       , VersionString(ServerInstance->GetVersionString()), Socket(NULL), sid(ServerInstance->Config->GetSID()), ServerUser(ServerInstance->FakeClient)
+       , age(ServerInstance->Time()), Warned(false), bursting(false), UserCount(0), OperCount(0), rtt(0), StartBurst(0), Hidden(false)
 {
-       age = ServerInstance->Time();
-       bursting = false;
-       Parent = NULL;
-       VersionString.clear();
-       ServerUserCount = ServerOperCount = 0;
-       VersionString = ServerInstance->GetVersionString();
-       Route = NULL;
-       Socket = NULL; /* Fix by brain */
-       StartBurst = rtt = 0;
-       Warned = Hidden = false;
        AddHashEntry();
-       SetID(id);
 }
 
 /** When we create a new server, we call this constructor to initialize it.
  * This constructor initializes the server's Route and Parent, and sets up
  * its ping counters so that it will be pinged one minute from now.
  */
-TreeServer::TreeServer(SpanningTreeUtilities* Util, std::string Name, std::string Desc, const std::string &id, TreeServer* Above, TreeSocket* Sock, bool Hide)
-       : Parent(Above), ServerName(Name.c_str()), ServerDesc(Desc), Socket(Sock), Utils(Util), ServerUser(new FakeUser(id, Name)), Hidden(Hide)
+TreeServer::TreeServer(const std::string& Name, const std::string& Desc, const std::string& id, TreeServer* Above, TreeSocket* Sock, bool Hide)
+       : Parent(Above), ServerName(Name), ServerDesc(Desc), Socket(Sock), sid(id), ServerUser(new FakeUser(id, Name))
+       , age(ServerInstance->Time()), Warned(false), bursting(true), UserCount(0), OperCount(0), rtt(0), Hidden(Hide)
 {
-       age = ServerInstance->Time();
-       bursting = true;
-       VersionString.clear();
-       ServerUserCount = ServerOperCount = 0;
        SetNextPingTime(ServerInstance->Time() + Utils->PingFreq);
        SetPingFlag();
-       Warned = false;
-       rtt = 0;
 
        long ts = ServerInstance->Time() * 1000 + (ServerInstance->Time_ns() / 1000000);
        this->StartBurst = ts;
-       ServerInstance->Logs->Log("m_spanningtree",DEBUG, "Started bursting at time %lu", ts);
+       ServerInstance->Logs->Log(MODNAME, LOG_DEBUG, "Server %s started bursting at time %lu", sid.c_str(), ts);
 
        /* find the 'route' for this server (e.g. the one directly connected
         * to the local server, which we can use to reach it)
@@ -124,8 +107,6 @@ TreeServer::TreeServer(SpanningTreeUtilities* Util, std::string Name, std::strin
         */
 
        this->AddHashEntry();
-
-       SetID(id);
 }
 
 const std::string& TreeServer::GetID()
@@ -153,14 +134,7 @@ void TreeServer::FinishBurst()
        unsigned long bursttime = ts - this->StartBurst;
        ServerInstance->SNO->WriteToSnoMask(Parent == Utils->TreeRoot ? 'l' : 'L', "Received end of netburst from \2%s\2 (burst time: %lu %s)",
                ServerName.c_str(), (bursttime > 10000 ? bursttime / 1000 : bursttime), (bursttime > 10000 ? "secs" : "msecs"));
-       AddServerEvent(Utils->Creator, ServerName.c_str());
-}
-
-void TreeServer::SetID(const std::string &id)
-{
-       ServerInstance->Logs->Log("m_spanningtree",DEBUG, "Setting SID to " + id);
-       sid = id;
-       Utils->sidlist[sid] = this;
+       AddServerEvent(Utils->Creator, ServerName);
 }
 
 int TreeServer::QuitUsers(const std::string &reason)
@@ -179,7 +153,7 @@ int TreeServer::QuitUsers(const std::string &reason)
                User* a = (User*)*n;
                if (!IS_LOCAL(a))
                {
-                       if (this->Utils->quiet_bursts)
+                       if (Utils->quiet_bursts)
                                a->quietquit = true;
 
                        if (ServerInstance->Config->HideSplits)
@@ -197,20 +171,8 @@ int TreeServer::QuitUsers(const std::string &reason)
  */
 void TreeServer::AddHashEntry()
 {
-       server_hash::iterator iter = Utils->serverlist.find(this->ServerName.c_str());
-       if (iter == Utils->serverlist.end())
-               Utils->serverlist[this->ServerName.c_str()] = this;
-}
-
-/** This method removes the reference to this object
- * from the hash_map which is used for linear searches.
- * It is only called by the default destructor.
- */
-void TreeServer::DelHashEntry()
-{
-       server_hash::iterator iter = Utils->serverlist.find(this->ServerName.c_str());
-       if (iter != Utils->serverlist.end())
-               Utils->serverlist.erase(iter);
+       Utils->serverlist[ServerName] = this;
+       Utils->sidlist[sid] = this;
 }
 
 /** These accessors etc should be pretty self-
@@ -221,11 +183,6 @@ TreeServer* TreeServer::GetRoute()
        return Route;
 }
 
-std::string TreeServer::GetName()
-{
-       return ServerName.c_str();
-}
-
 const std::string& TreeServer::GetDesc()
 {
        return ServerDesc;
@@ -257,26 +214,6 @@ void TreeServer::SetPingFlag()
        LastPingWasGood = true;
 }
 
-unsigned int TreeServer::GetUserCount()
-{
-       return ServerUserCount;
-}
-
-void TreeServer::SetUserCount(int diff)
-{
-       ServerUserCount += diff;
-}
-
-void TreeServer::SetOperCount(int diff)
-{
-       ServerOperCount += diff;
-}
-
-unsigned int TreeServer::GetOperCount()
-{
-       return ServerOperCount;
-}
-
 TreeSocket* TreeServer::GetSocket()
 {
        return Socket;
@@ -321,13 +258,11 @@ void TreeServer::AddChild(TreeServer* Child)
 
 bool TreeServer::DelChild(TreeServer* Child)
 {
-       for (std::vector<TreeServer*>::iterator a = Children.begin(); a != Children.end(); a++)
+       std::vector<TreeServer*>::iterator it = std::find(Children.begin(), Children.end(), Child);
+       if (it != Children.end())
        {
-               if (*a == Child)
-               {
-                       Children.erase(a);
-                       return true;
-               }
+               Children.erase(it);
+               return true;
        }
        return false;
 }
@@ -336,13 +271,13 @@ bool TreeServer::DelChild(TreeServer* Child)
  * This is used during netsplits to automatically tidy up the
  * server tree. It is slow, we don't use it for much else.
  */
-bool TreeServer::Tidy()
+void TreeServer::Tidy()
 {
        while (1)
        {
                std::vector<TreeServer*>::iterator a = Children.begin();
                if (a == Children.end())
-                       return true;
+                       return;
                TreeServer* s = *a;
                s->Tidy();
                s->cull();
@@ -353,7 +288,7 @@ bool TreeServer::Tidy()
 
 CullResult TreeServer::cull()
 {
-       if (ServerUser != ServerInstance->FakeClient)
+       if (!IsRoot())
                ServerUser->cull();
        return classbase::cull();
 }
@@ -361,11 +296,9 @@ CullResult TreeServer::cull()
 TreeServer::~TreeServer()
 {
        /* We'd better tidy up after ourselves, eh? */
-       this->DelHashEntry();
-       if (ServerUser != ServerInstance->FakeClient)
+       if (!IsRoot())
                delete ServerUser;
 
-       server_hash::iterator iter = Utils->sidlist.find(GetID());
-       if (iter != Utils->sidlist.end())
-               Utils->sidlist.erase(iter);
+       Utils->sidlist.erase(sid);
+       Utils->serverlist.erase(ServerName);
 }