]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/treesocket1.cpp
In the grand tradition of huge fucking commits:
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / treesocket1.cpp
index c650eff3c3d86a182b985c211c1a8b1665166cc2..4f6dae56ad4903e4604df531b16b615bfcca254e 100644 (file)
  */
 
 #include "inspircd.h"
-#include "configreader.h"
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
 #include "commands/cmd_whois.h"
 #include "commands/cmd_stats.h"
 #include "socket.h"
@@ -129,7 +125,7 @@ std::string TreeSocket::MakePass(const std::string &password, const std::string
         * Note: If m_sha256.so is not loaded, we MUST fall back to plaintext with no
         *       HMAC challenge/response.
         */
-       Module* sha256 = Instance->FindModule("m_sha256.so");
+       Module* sha256 = Instance->Modules->Find("m_sha256.so");
        if (Utils->ChallengeResponse && sha256 && !challenge.empty())
        {
                /* XXX: This is how HMAC is supposed to be done:
@@ -268,7 +264,9 @@ void TreeSocket::SendServers(TreeServer* Current, TreeServer* s, int hops)
                TreeServer* recursive_server = Current->GetChild(q);
                if (recursive_server != s)
                {
-                       snprintf(command,1024,":%s SERVER %s * %d :%s",Current->GetName().c_str(),recursive_server->GetName().c_str(),hops,recursive_server->GetDesc().c_str());
+                       snprintf(command,1024,":%s SERVER %s * %d %s :%s",Current->GetName().c_str(),recursive_server->GetName().c_str(),hops,
+                                       recursive_server->GetID().c_str(),
+                                       recursive_server->GetDesc().c_str());
                        this->WriteLine(command);
                        this->WriteLine(":"+recursive_server->GetName()+" VERSION :"+recursive_server->GetVersion());
                        /* down to next level */
@@ -281,9 +279,9 @@ std::string TreeSocket::MyCapabilities()
 {
        std::vector<std::string> modlist;
        std::string capabilities;
-       for (int i = 0; i <= this->Instance->GetModuleCount(); i++)
+       for (int i = 0; i <= this->Instance->Modules->GetCount(); i++)
        {
-               if (this->Instance->modules[i]->GetVersion().Flags & VF_COMMON)
+               if (this->Instance->Modules->modules[i]->GetVersion().Flags & VF_COMMON)
                        modlist.push_back(this->Instance->Config->module_names[i]);
        }
        sort(modlist.begin(),modlist.end());
@@ -367,13 +365,13 @@ void TreeSocket::SendCapabilities()
 #endif
        std::string extra;
        /* Do we have sha256 available? If so, we send a challenge */
-       if (Utils->ChallengeResponse && (Instance->FindModule("m_sha256.so")))
+       if (Utils->ChallengeResponse && (Instance->Modules->Find("m_sha256.so")))
        {
                this->SetOurChallenge(RandString(20));
                extra = " CHALLENGE=" + this->GetOurChallenge();
        }
 
-       this->WriteLine("CAPAB CAPABILITIES :NICKMAX="+ConvToStr(NICKMAX)+" HALFOP="+ConvToStr(this->Instance->Config->AllowHalfop)+" CHANMAX="+ConvToStr(CHANMAX)+" MAXMODES="+ConvToStr(MAXMODES)+" IDENTMAX="+ConvToStr(IDENTMAX)+" MAXQUIT="+ConvToStr(MAXQUIT)+" MAXTOPIC="+ConvToStr(MAXTOPIC)+" MAXKICK="+ConvToStr(MAXKICK)+" MAXGECOS="+ConvToStr(MAXGECOS)+" MAXAWAY="+ConvToStr(MAXAWAY)+" IP6NATIVE="+ConvToStr(ip6)+" IP6SUPPORT="+ConvToStr(ip6support)+" PROTOCOL="+ConvToStr(ProtocolVersion)+extra+" PREFIX="+Instance->Modes->BuildPrefixes()+" CHANMODES="+Instance->Modes->ChanModes());
+       this->WriteLine("CAPAB CAPABILITIES :NICKMAX="+ConvToStr(NICKMAX)+" HALFOP="+ConvToStr(this->Instance->Config->AllowHalfop)+" CHANMAX="+ConvToStr(CHANMAX)+" MAXMODES="+ConvToStr(MAXMODES)+" IDENTMAX="+ConvToStr(IDENTMAX)+" MAXQUIT="+ConvToStr(MAXQUIT)+" MAXTOPIC="+ConvToStr(MAXTOPIC)+" MAXKICK="+ConvToStr(MAXKICK)+" MAXGECOS="+ConvToStr(MAXGECOS)+" MAXAWAY="+ConvToStr(MAXAWAY)+" IP6NATIVE="+ConvToStr(ip6)+" IP6SUPPORT="+ConvToStr(ip6support)+" PROTOCOL="+ConvToStr(ProtocolVersion)+extra+" PREFIX="+Instance->Modes->BuildPrefixes()+" CHANMODES="+Instance->Modes->ChanModes()+" SVSPART=1");
 
        this->WriteLine("CAPAB END");
 }
@@ -412,8 +410,8 @@ std::string TreeSocket::ListDifference(const std::string &one, const std::string
 void TreeSocket::SendError(const std::string &errormessage)
 {
        /* Display the error locally as well as sending it remotely */
-       this->WriteLine("ERROR :"+errormessage);
        Utils->Creator->RemoteMessage(NULL, "Sent \2ERROR\2 to %s: %s", (this->InboundServerName.empty() ? "<unknown>" : this->InboundServerName.c_str()), errormessage.c_str());
+       this->WriteLine("ERROR :"+errormessage);
        /* One last attempt to make sure the error reaches its target */
        this->FlushWriteBuffer();
 }
@@ -497,20 +495,21 @@ bool TreeSocket::Capab(const std::deque<std::string> &params)
        
                /* Challenge response, store their challenge for our password */
                std::map<std::string,std::string>::iterator n = this->CapKeys.find("CHALLENGE");
-               if (Utils->ChallengeResponse && (n != this->CapKeys.end()) && (Instance->FindModule("m_sha256.so")))
+               if (Utils->ChallengeResponse && (n != this->CapKeys.end()) && (Instance->Modules->Find("m_sha256.so")))
                {
                        /* Challenge-response is on now */
                        this->SetTheirChallenge(n->second);
                        if (!this->GetTheirChallenge().empty() && (this->LinkState == CONNECTING))
                        {
-                               this->WriteLine(std::string("SERVER ")+this->Instance->Config->ServerName+" "+this->MakePass(OutboundPass, this->GetTheirChallenge())+" 0 :"+this->Instance->Config->ServerDesc);
+                               this->WriteLine(std::string("SERVER ")+this->Instance->Config->ServerName+" "+this->MakePass(OutboundPass, this->GetTheirChallenge())+" 0 "+
+                                               Instance->Config->GetSID()+" :"+this->Instance->Config->ServerDesc);
                        }
                }
                else
                {
                        /* They didnt specify a challenge or we don't have m_sha256.so, we use plaintext */
                        if (this->LinkState == CONNECTING)
-                               this->WriteLine(std::string("SERVER ")+this->Instance->Config->ServerName+" "+OutboundPass+" 0 :"+this->Instance->Config->ServerDesc);
+                               this->WriteLine(std::string("SERVER ")+this->Instance->Config->ServerName+" "+OutboundPass+" 0 "+Instance->Config->GetSID()+" :"+this->Instance->Config->ServerDesc);
                }
 
                if (reason.length())
@@ -623,7 +622,7 @@ bool TreeSocket::ForceMode(const std::string &source, std::deque<std::string> &p
        bool smode = false;
        std::string sourceserv;
        /* Are we dealing with an FMODE from a user, or from a server? */
-       userrec* who = this->Instance->FindNick(source);
+       User* who = this->Instance->FindNick(source);
        if (who)
        {
                /* FMODE from a user, set sourceserv to the users server name */
@@ -631,10 +630,9 @@ bool TreeSocket::ForceMode(const std::string &source, std::deque<std::string> &p
        }
        else
        {
-               /* FMODE from a server, create a fake user to receive mode feedback */
-               who = new userrec(this->Instance);
-               who->SetFd(FD_MAGIC_NUMBER);
-               smode = true;      /* Setting this flag tells us we should free the userrec later */
+               /* FMODE from a server, use a fake user to receive mode feedback */
+               who = this->Instance->FakeClient;
+               smode = true;      /* Setting this flag tells us we should free the User later */
                sourceserv = source;    /* Set sourceserv to the actual source string */
        }
        const char* modelist[64];
@@ -658,9 +656,9 @@ bool TreeSocket::ForceMode(const std::string &source, std::deque<std::string> &p
                }
 
        }
-       /* Extract the TS value of the object, either userrec or chanrec */
-       userrec* dst = this->Instance->FindNick(params[0]);
-       chanrec* chan = NULL;
+       /* Extract the TS value of the object, either User or Channel */
+       User* dst = this->Instance->FindNick(params[0]);
+       Channel* chan = NULL;
        time_t ourTS = 0;
        if (dst)
        {
@@ -705,10 +703,6 @@ bool TreeSocket::ForceMode(const std::string &source, std::deque<std::string> &p
        }
        /* If the TS is greater than ours, we drop the mode and dont pass it anywhere.
         */
-
-       if (smode)
-               DELETE(who);
-
        return true;
 }
 
@@ -719,7 +713,7 @@ bool TreeSocket::ForceTopic(const std::string &source, std::deque<std::string> &
                return true;
        time_t ts = atoi(params[1].c_str());
        std::string nsource = source;
-       chanrec* c = this->Instance->FindChan(params[0]);
+       Channel* c = this->Instance->FindChan(params[0]);
        if (c)
        {
                if ((ts >= c->topicset) || (!*c->topic))
@@ -734,7 +728,7 @@ bool TreeSocket::ForceTopic(const std::string &source, std::deque<std::string> &
                         */
                        if (oldtopic != params[3])
                        {
-                               userrec* user = this->Instance->FindNick(source);
+                               User* user = this->Instance->FindNick(source);
                                if (!user)
                                {
                                        c->WriteChannelWithServ(Instance->Config->ServerName, "TOPIC %s :%s", c->name, c->topic);
@@ -795,12 +789,12 @@ bool TreeSocket::ForceJoin(const std::string &source, std::deque<std::string> &p
                return true;
 
        irc::modestacker modestack(true);                               /* Modes to apply from the users in the user list */
-       userrec* who = NULL;                                            /* User we are currently checking */
+       User* who = NULL;                                               /* User we are currently checking */
        std::string channel = params[0];                                /* Channel name, as a string */
        time_t TS = atoi(params[1].c_str());                            /* Timestamp given to us for remote side */
        irc::tokenstream users(params[2]);                              /* Users from the user list */
        bool apply_other_sides_modes = true;                            /* True if we are accepting the other side's modes */
-       chanrec* chan = this->Instance->FindChan(channel);              /* The channel we're sending joins to */
+       Channel* chan = this->Instance->FindChan(channel);              /* The channel we're sending joins to */
        time_t ourTS = chan ? chan->age : Instance->Time(true)+600;     /* The TS of our side of the link */
        bool created = !chan;                                           /* True if the channel doesnt exist here yet */
        std::string item;                                               /* One item in the list of nicks */
@@ -830,7 +824,7 @@ bool TreeSocket::ForceJoin(const std::string &source, std::deque<std::string> &p
                {
                        chan->age = TS;
                        param_list.push_back(channel);
-                       this->RemoveStatus(Instance->Config->ServerName, param_list);
+                       this->RemoveStatus(Instance->Config->GetSID(), param_list);
                }
        }
 
@@ -872,7 +866,7 @@ bool TreeSocket::ForceJoin(const std::string &source, std::deque<std::string> &p
                                for (std::string::iterator x = modes.begin(); x != modes.end(); ++x)
                                        modestack.Push(*x, who->nick);
 
-                               chanrec::JoinUser(this->Instance, who, channel.c_str(), true, "", TS);
+                               Channel::JoinUser(this->Instance, who, channel.c_str(), true, "", TS);
                        }
                        else
                        {
@@ -887,8 +881,6 @@ bool TreeSocket::ForceJoin(const std::string &source, std::deque<std::string> &p
        {
                std::deque<std::string> stackresult;
                const char* mode_junk[MAXMODES+2];
-               userrec* n = new userrec(Instance);
-               n->SetFd(FD_MAGIC_NUMBER);
                mode_junk[0] = channel.c_str();
 
                while (modestack.GetStackedLine(stackresult))
@@ -897,55 +889,149 @@ bool TreeSocket::ForceJoin(const std::string &source, std::deque<std::string> &p
                        {
                                mode_junk[j+1] = stackresult[j].c_str();
                        }
-                       Instance->SendMode(mode_junk, stackresult.size() + 1, n);
+                       Instance->SendMode(mode_junk, stackresult.size() + 1, Instance->FakeClient);
                }
-
-               delete n;
        }
 
        return true;
 }
 
+/*
+ * Yes, this function looks a little ugly.
+ * However, in some circumstances we may not have a User, so we need to do things this way.
+ * Returns 1 if colliding local client, 2 if colliding remote, 3 if colliding both.
+ * Sends SVSNICKs as appropriate and forces nickchanges too.
+ */
+int TreeSocket::DoCollision(User *u, time_t remotets, const char *remoteident, const char *remoteip, const char *remoteuid)
+{
+       /*
+        *  Under old protocol rules, we would have had to kill both clients.
+        *  Really, this sucks.
+        * These days, we have UID. And, so what we do is, force nick change client(s)
+        * involved according to timestamp rules.
+        *
+        * RULES:        
+        *  user@ip equal:       
+        *   Force nick change on OLDER timestamped client       
+        *  user@ip differ:      
+        *   Force nick change on NEWER timestamped client       
+        *  TS EQUAL:    
+        *   FNC both.   
+        *       
+        * This stops abusive use of collisions, simplifies problems with loops, and so on.      
+        *   -- w00t
+        */
+       bool bChangeLocal = true;
+       bool bChangeRemote = true;
+
+       /* for brevity, don't use the User */
+       time_t localts = u->age;
+       const char *localident = u->ident;
+       const char *localip = u->GetIPString();
+
+       /* mmk. let's do this again. */
+       if (remotets == localts)
+       {
+               /* equal. fuck them both! do nada, let the handler at the bottom figure this out. */
+       }
+       else
+       {
+               /* fuck. now it gets complex. */
+
+               /* first, let's see if ident@host matches. */
+               bool SamePerson = !strcmp(localident, remoteident)
+                               && !strcmp(localip, remoteip);
+
+               /*
+                * if ident@ip is equal, and theirs is newer, or
+                * ident@ip differ, and ours is newer
+                */
+               if((SamePerson && remotets < localts) ||
+                  (!SamePerson && remotets > localts))
+               {
+                       /* remote needs to change */
+                       bChangeLocal = false;
+               }
+               else
+               {
+                       /* ours needs to change */
+                       bChangeRemote = false;
+               }
+       }
+
+
+       if (bChangeLocal)
+       {
+               u->ForceNickChange(u->uuid);
+
+               if (!bChangeRemote)
+                       return 1;
+       }
+       if (bChangeRemote)
+       {
+               /*
+                * Cheat a little here. Instead of a dedicated command to change UID,
+                * use SVSNICK and accept their client with it's UID (as we know the SVSNICK will
+                * not fail under any circumstances -- UIDs are netwide exclusive).
+                *
+                * This means that each side of a collide will generate one extra NICK back to where
+                * they have just linked (and where it got the SVSNICK from), however, it will
+                * be dropped harmlessly as it will come in as :928AAAB NICK 928AAAB, and we already
+                * have 928AAAB's nick set to that.
+                *   -- w00t
+                */
+               User *remote = this->Instance->FindUUID(remoteuid);
+
+               if (remote)
+               {
+                       /* buh.. nick change collide. force change their nick. */
+                       remote->ForceNickChange(remote->uuid);
+               }
+               else
+               {
+                       /* user has not been introduced yet, just inform their server */
+                       this->WriteLine(std::string(":")+this->Instance->Config->GetSID()+" SVSNICK "+remoteuid+" " + remoteuid + " " + ConvToStr(remotets));
+               }
+
+               if (!bChangeLocal)
+                       return 2;
+       }
+
+       return 3;
+}
+
 bool TreeSocket::ParseUID(const std::string &source, std::deque<std::string> &params)
 {
        /** Do we have enough parameters:
         * UID uuid age nick host dhost ident +modestr ip.string :gecos
         */
-       if (params.size() != 9)
+       if (params.size() != 10)
        {
-               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[0]+" :Invalid client introduction ("+params[0]+"?)");
+               this->WriteLine(std::string(":")+this->Instance->Config->GetSID()+" KILL "+params[0]+" :Invalid client introduction ("+params[0]+" with only "+
+                               ConvToStr(params.size())+" of 10 parameters?)");
                return true;
        }
 
        time_t age = ConvToInt(params[1]);
+       time_t signon = ConvToInt(params[8]);
        const char* tempnick = params[2].c_str();
        std::string empty;
 
        /* XXX probably validate UID length too -- w00t */
-       cmd_validation valid[] = { {"Nickname", 2, NICKMAX}, {"Hostname", 3, 64}, {"Displayed hostname", 4, 64}, {"Ident", 5, IDENTMAX}, {"GECOS", 7, MAXGECOS}, {"", 0, 0} };
+       cmd_validation valid[] = { {"Nickname", 2, NICKMAX}, {"Hostname", 3, 64}, {"Displayed hostname", 4, 64}, {"Ident", 5, IDENTMAX}, {"GECOS", 9, MAXGECOS}, {"", 0, 0} };
 
        TreeServer* remoteserver = Utils->FindServer(source);
 
        if (!remoteserver)
        {
-               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[0]+" :Invalid client introduction (Unknown server "+source+")");
-               return true;
-       }
-
-       userrec *u = this->Instance->FindUUID(params[0]);
-
-       if (u)
-       {
-               /* barf! */
-               userrec::QuitUser(this->Instance, u, "UID collision (?!)");
-               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[0]+" :Invalid client introduction (UID collision (?!))");
+               this->WriteLine(std::string(":")+this->Instance->Config->GetSID()+" KILL "+params[0]+" :Invalid client introduction (Unknown server "+source+")");
                return true;
        }
 
        /* Check parameters for validity before introducing the client, discovered by dmb */
        if (!age)
        {
-               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[0]+" :Invalid client introduction (Invalid TS?)");
+               this->WriteLine(std::string(":")+this->Instance->Config->GetSID()+" KILL "+params[0]+" :Invalid client introduction (Invalid TS?)");
                return true;
        }
 
@@ -953,7 +1039,7 @@ bool TreeSocket::ParseUID(const std::string &source, std::deque<std::string> &pa
        {
                if (params[valid[x].param].length() > valid[x].length)
                {
-                       this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[0]+" :Invalid client introduction (" + valid[x].item + " > " + ConvToStr(valid[x].length) + ")");
+                       this->WriteLine(std::string(":")+this->Instance->Config->GetSID()+" KILL "+params[0]+" :Invalid client introduction (" + valid[x].item + " > " + ConvToStr(valid[x].length) + ")");
                        return true;
                }
        }
@@ -966,99 +1052,41 @@ bool TreeSocket::ParseUID(const std::string &source, std::deque<std::string> &pa
        {
                /*
                 * Nick collision.
-                *  Under old protocol rules, we would have had to kill both clients.
-                *  Really, this sucks.
-                * These days, we have UID. And, so what we do is, force nick change client(s)
-                * involved according to timestamp rules.
-                *
-                * RULES:        
-                *  user@ip equal:       
-                *   Force nick change on OLDER timestamped client       
-                *  user@ip differ:      
-                *   Force nick change on NEWER timestamped client       
-                *  TS EQUAL:    
-                *   FNC both.   
-                *       
-                * Note that remote clients MUST be dealt with also to remove desyncs.   
-                *  XXX we don't do this yet.    
-                *       
-                * This stops abusive use of collisions, simplifies problems with loops, and so on.      
-                *   -- w00t
                 */
                Instance->Log(DEBUG,"*** Collision on %s", tempnick);
+               int collide = this->DoCollision(iter->second, age, params[5].c_str(), params[7].c_str(), params[0].c_str());
 
-               bool bChangeLocal = true;
-               bool bChangeRemote = true;
-
-               /* mmk. let's do this again. */
-               if (age == iter->second->age)
-               {
-                       /* equal. fuck them both! do nada, let the handler at the bottom figure this out. */
-               }
-               else
-               {
-                       /* fuck. now it gets complex. */
-
-                       /* first, let's see if ident@host matches. */
-                       bool SamePerson = strcmp(iter->second->ident, params[5].c_str())
-                                       && !strcmp(iter->second->GetIPString(), params[7].c_str());
-
-                       /*
-                        * if ident@ip is equal, and theirs is newer, or
-                        * ident@ip differ, and ours is newer
-                        */
-                       if((SamePerson && age < iter->second->age) ||
-                          (!SamePerson && age > iter->second->age))
-                       {
-                               /* remote needs to change */
-                               bChangeLocal = false;
-                       }
-                       else
-                       {
-                               /* ours needs to change */
-                               bChangeRemote = false;
-                       }
-               }
-
-
-               if (bChangeLocal)
-               {
-                       iter->second->ForceNickChange(iter->second->uuid);
-               }
-               if (bChangeRemote)
+               if (collide == 2)
                {
-                       /*
-                        * Cheat a little here. Instead of a dedicated command to change UID,
-                        * use SVSNICK and accept their client with it's UID (as we know the SVSNICK will
-                        * not fail under any circumstances -- UIDs are netwide exclusive).
-                        *
-                        * This means that each side of a collide will generate one extra NICK back to where
-                        * they have just linked (and where it got the SVSNICK from), however, it will
-                        * be dropped harmlessly as it will come in as :928AAAB NICK 928AAAB, and we already
-                        * have 928AAAB's nick set to that.
-                        *   -- w00t
-                        */
-                       this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" SVSNICK "+params[0]+" " + params[0]);
-                       /* also, don't trample on the hash - use their UID as nick */
+                       /* remote client changed, make sure we change their nick for the hash too */
                        tempnick = params[0].c_str();
                }
        }
 
        /* IMPORTANT NOTE: For remote users, we pass the UUID in the constructor. This automatically
         * sets it up in the UUID hash for us.
-        * TODO: Make this throw an exception maybe, on UUID collision?
         */
-       userrec* _new = new userrec(this->Instance, params[0]);
+       User* _new = NULL;
+       try
+       {
+               _new = new User(this->Instance, params[0]);
+       }
+       catch (...)
+       {
+               SendError("Protocol violation - Duplicate UUID '" + params[0] + "' on introduction of new user");
+               return false;
+       }
        (*(this->Instance->clientlist))[tempnick] = _new;
        _new->SetFd(FD_MAGIC_NUMBER);
        strlcpy(_new->nick, tempnick, NICKMAX - 1);
        strlcpy(_new->host, params[3].c_str(),64);
        strlcpy(_new->dhost, params[4].c_str(),64);
-       _new->server = this->Instance->FindServerNamePtr(source.c_str());
+       _new->server = this->Instance->FindServerNamePtr(remoteserver->GetName().c_str());
        strlcpy(_new->ident, params[5].c_str(),IDENTMAX);
-       strlcpy(_new->fullname, params[8].c_str(),MAXGECOS);
+       strlcpy(_new->fullname, params[9].c_str(),MAXGECOS);
        _new->registered = REG_ALL;
-       _new->signon = age;
+       _new->signon = signon;
+       _new->age = age;
 
        /* we need to remove the + from the modestring, so we can do our stuff */
        std::string::size_type pos_after_plus = params[6].find_first_not_of('+');
@@ -1095,7 +1123,7 @@ bool TreeSocket::ParseUID(const std::string &source, std::deque<std::string> &pa
        if (dosend)
                this->Instance->SNO->WriteToSnoMask('C',"Client connecting at %s: %s!%s@%s [%s] [%s]",_new->server,_new->nick,_new->ident,_new->host, _new->GetIPString(), _new->fullname);
 
-       params[8] = ":" + params[8];
+       params[9] = ":" + params[9];
        Utils->DoOneToAllButSender(source, "UID", params, source);
 
        // Increment the Source Servers User Count..
@@ -1114,14 +1142,14 @@ bool TreeSocket::ParseUID(const std::string &source, std::deque<std::string> &pa
  * If the length of a single line is more than 480-NICKMAX
  * in length, it is split over multiple lines.
  */
-void TreeSocket::SendFJoins(TreeServer* Current, chanrec* c)
+void TreeSocket::SendFJoins(TreeServer* Current, Channel* c)
 {
        std::string buffer;
        char list[MAXBUF];
-       std::string individual_halfops = std::string(":")+this->Instance->Config->ServerName+" FMODE "+c->name+" "+ConvToStr(c->age);
+       std::string individual_halfops = std::string(":")+this->Instance->Config->GetSID()+" FMODE "+c->name+" "+ConvToStr(c->age);
 
        size_t dlen, curlen;
-       dlen = curlen = snprintf(list,MAXBUF,":%s FJOIN %s %lu",this->Instance->Config->ServerName,c->name,(unsigned long)c->age);
+       dlen = curlen = snprintf(list,MAXBUF,":%s FJOIN %s %lu",this->Instance->Config->GetSID().c_str(),c->name,(unsigned long)c->age);
        int numusers = 0;
        char* ptr = list + dlen;
 
@@ -1142,7 +1170,7 @@ void TreeSocket::SendFJoins(TreeServer* Current, chanrec* c)
                if (curlen > (480-NICKMAX))
                {
                        buffer.append(list).append("\r\n");
-                       dlen = curlen = snprintf(list,MAXBUF,":%s FJOIN %s %lu",this->Instance->Config->ServerName,c->name,(unsigned long)c->age);
+                       dlen = curlen = snprintf(list,MAXBUF,":%s FJOIN %s %lu",this->Instance->Config->GetSID().c_str(),c->name,(unsigned long)c->age);
                        ptr = list + dlen;
                        ptrlen = 0;
                        numusers = 0;
@@ -1152,7 +1180,7 @@ void TreeSocket::SendFJoins(TreeServer* Current, chanrec* c)
        if (numusers)
                buffer.append(list).append("\r\n");
 
-       buffer.append(":").append(this->Instance->Config->ServerName).append(" FMODE ").append(c->name).append(" ").append(ConvToStr(c->age)).append(" +").append(c->ChanModes(true)).append("\r\n");
+       buffer.append(":").append(this->Instance->Config->GetSID()).append(" FMODE ").append(c->name).append(" ").append(ConvToStr(c->age)).append(" +").append(c->ChanModes(true)).append("\r\n");
 
        int linesize = 1;
        for (BanList::iterator b = c->bans.begin(); b != c->bans.end(); b++)
@@ -1168,7 +1196,7 @@ void TreeSocket::SendFJoins(TreeServer* Current, chanrec* c)
                if ((params.length() >= MAXMODES) || (currsize > 350))
                {
                        /* Wrap at MAXMODES */
-                       buffer.append(":").append(this->Instance->Config->ServerName).append(" FMODE ").append(c->name).append(" ").append(ConvToStr(c->age)).append(" +").append(modes).append(params).append("\r\n");
+                       buffer.append(":").append(this->Instance->Config->GetSID()).append(" FMODE ").append(c->name).append(" ").append(ConvToStr(c->age)).append(" +").append(modes).append(params).append("\r\n");
                        modes.clear();
                        params.clear();
                        linesize = 1;
@@ -1177,7 +1205,7 @@ void TreeSocket::SendFJoins(TreeServer* Current, chanrec* c)
 
        /* Only send these if there are any */
        if (!modes.empty())
-               buffer.append(":").append(this->Instance->Config->ServerName).append(" FMODE ").append(c->name).append(" ").append(ConvToStr(c->age)).append(" +").append(modes).append(params);
+               buffer.append(":").append(this->Instance->Config->GetSID()).append(" FMODE ").append(c->name).append(" ").append(ConvToStr(c->age)).append(" +").append(modes).append(params);
 
        this->WriteLine(buffer);
 }
@@ -1187,7 +1215,7 @@ void TreeSocket::SendXLines(TreeServer* Current)
 {
        char data[MAXBUF];
        std::string buffer;
-       std::string n = this->Instance->Config->ServerName;
+       std::string n = this->Instance->Config->GetSID();
        const char* sn = n.c_str();
        /* Yes, these arent too nice looking, but they get the job done */
        for (std::vector<ZLine*>::iterator i = Instance->XLines->zlines.begin(); i != Instance->XLines->zlines.end(); i++)
@@ -1240,7 +1268,7 @@ void TreeSocket::SendChannelModes(TreeServer* Current)
 {
        char data[MAXBUF];
        std::deque<std::string> list;
-       std::string n = this->Instance->Config->ServerName;
+       std::string n = this->Instance->Config->GetSID();
        const char* sn = n.c_str();
        Instance->Log(DEBUG,"Sending channels and modes, %d to send", this->Instance->chanlist->size());
        for (chan_hash::iterator c = this->Instance->chanlist->begin(); c != this->Instance->chanlist->end(); c++)
@@ -1271,31 +1299,35 @@ void TreeSocket::SendUsers(TreeServer* Current)
        {
                if (u->second->registered == REG_ALL)
                {
-                       snprintf(data,MAXBUF,":%s UID %s %lu %s %s %s %s +%s %s :%s", u->second->server, u->second->uuid, (unsigned long)u->second->age,u->second->nick,u->second->host,u->second->dhost,u->second->ident,u->second->FormatModes(),u->second->GetIPString(),u->second->fullname);
-                       this->WriteLine(data);
-                       if (*u->second->oper)
+                       TreeServer* theirserver = Utils->FindServer(u->second->server);
+                       if (theirserver)
                        {
-                               snprintf(data,MAXBUF,":%s OPERTYPE %s", u->second->uuid, u->second->oper);
+                               snprintf(data,MAXBUF,":%s UID %s %lu %s %s %s %s +%s %s %lu :%s", theirserver->GetID().c_str(), u->second->uuid,
+                                               (unsigned long)u->second->age, u->second->nick, u->second->host, u->second->dhost,
+                                               u->second->ident, u->second->FormatModes(), u->second->GetIPString(),
+                                               (unsigned long)u->second->signon, u->second->fullname);
                                this->WriteLine(data);
+                               if (*u->second->oper)
+                               {
+                                       snprintf(data,MAXBUF,":%s OPERTYPE %s", u->second->uuid, u->second->oper);
+                                       this->WriteLine(data);
+                               }
+                               if (*u->second->awaymsg)
+                               {
+                                       snprintf(data,MAXBUF,":%s AWAY :%s", u->second->uuid, u->second->awaymsg);
+                                       this->WriteLine(data);
+                               }
                        }
-                       if (*u->second->awaymsg)
+
+                       FOREACH_MOD_I(this->Instance,I_OnSyncUser,OnSyncUser(u->second,(Module*)Utils->Creator,(void*)this));
+                       list.clear();
+                       u->second->GetExtList(list);
+                       for (unsigned int j = 0; j < list.size(); j++)
                        {
-                               snprintf(data,MAXBUF,":%s AWAY :%s", u->second->uuid, u->second->awaymsg);
-                               this->WriteLine(data);
+                               FOREACH_MOD_I(this->Instance,I_OnSyncUserMetaData,OnSyncUserMetaData(u->second,(Module*)Utils->Creator,(void*)this,list[j]));
                        }
                }
        }
-
-       for (user_hash::iterator u = this->Instance->clientlist->begin(); u != this->Instance->clientlist->end(); u++)
-       {
-               FOREACH_MOD_I(this->Instance,I_OnSyncUser,OnSyncUser(u->second,(Module*)Utils->Creator,(void*)this));
-               list.clear();
-               u->second->GetExtList(list);
-               for (unsigned int j = 0; j < list.size(); j++)
-               {
-                       FOREACH_MOD_I(this->Instance,I_OnSyncUserMetaData,OnSyncUserMetaData(u->second,(Module*)Utils->Creator,(void*)this,list[j]));
-               }
-       }
 }
 
 /** This function is called when we want to send a netburst to a local
@@ -1311,7 +1343,7 @@ void TreeSocket::DoBurst(TreeServer* s)
        this->Instance->SNO->WriteToSnoMask('l',"Bursting to \2%s\2 (Authentication: %s).", name.c_str(), this->GetTheirChallenge().empty() ? "plaintext password" : "SHA256-HMAC challenge-response");
        this->WriteLine(burst);
        /* send our version string */
-       this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" VERSION :"+this->Instance->GetVersionString());
+       this->WriteLine(std::string(":")+this->Instance->Config->GetSID()+" VERSION :"+this->Instance->GetVersionString());
        /* Send server tree */
        this->SendServers(Utils->TreeRoot,s,1);
        /* Send users and their oper status */
@@ -1367,4 +1399,3 @@ bool TreeSocket::OnDataReady()
         */
        return (data && !*data);
 }
-