]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/treesocket1.cpp
Remove unneeded headers from spanningtree. This was done to the rest of the source...
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / treesocket1.cpp
index 168ca9e996619dc1ac73a02a849bd87cfe4b0817..748a44b45d76fd4cb99d6b51cf6b3bf4bf6cd0ea 100644 (file)
  */
 
 #include "inspircd.h"
-#include "configreader.h"
-#include "users.h"
-#include "channels.h"
-#include "modules.h"
 #include "commands/cmd_whois.h"
 #include "commands/cmd_stats.h"
 #include "socket.h"
@@ -73,6 +69,7 @@ TreeSocket::TreeSocket(SpanningTreeUtilities* Util, InspIRCd* SI, int newfd, cha
        this->LinkState = WAIT_AUTH_1;
        theirchallenge.clear();
        ourchallenge.clear();
+       sentcapab = false;
        /* If we have a transport module hooked to the parent, hook the same module to this
         * socket, and set a timer waiting for handshake before we send CAPAB etc.
         */
@@ -179,13 +176,15 @@ bool TreeSocket::OnConnected()
                {
                        if (x->Name == this->myhost)
                        {
-                               this->Instance->SNO->WriteToSnoMask('l',"Connection to \2"+myhost+"\2["+(x->HiddenFromStats ? "<hidden>" : this->GetIP())+"] started.");
+                               Utils->Creator->RemoteMessage(NULL,"Connection to \2%s\2[%s] started.", myhost.c_str(), (x->HiddenFromStats ? "<hidden>" : this->GetIP().c_str()));
                                if (Hook)
                                {
                                        InspSocketHookRequest(this, (Module*)Utils->Creator, Hook).Send();
-                                       this->Instance->SNO->WriteToSnoMask('l',"Connection to \2"+myhost+"\2["+(x->HiddenFromStats ? "<hidden>" : this->GetIP())+"] using transport \2"+x->Hook+"\2");
+                                       Utils->Creator->RemoteMessage(NULL,"Connection to \2%s\2[%s] using transport \2%s\2", myhost.c_str(), (x->HiddenFromStats ? "<hidden>" : this->GetIP().c_str()),
+                                                       x->Hook.c_str());
                                }
                                this->OutboundPass = x->SendPass;
+                               sentcapab = false;
 
                                /* found who we're supposed to be connecting to, send the neccessary gubbins. */
                                if (this->GetHook())
@@ -202,7 +201,7 @@ bool TreeSocket::OnConnected()
         * If that happens the connection hangs here until it's closed. Unlikely
         * and rather harmless.
         */
-       this->Instance->SNO->WriteToSnoMask('l',"Connection to \2"+myhost+"\2 lost link tag(!)");
+       this->Utils->Creator->RemoteMessage(NULL,"Connection to \2%s\2 lost link tag(!)", myhost.c_str());
        return true;
 }
 
@@ -210,32 +209,32 @@ void TreeSocket::OnError(InspSocketError e)
 {
        Link* MyLink;
 
+       if (this->LinkState == LISTENER)
+               return;
+
        switch (e)
        {
                case I_ERR_CONNECT:
-                       this->Instance->SNO->WriteToSnoMask('l',"Connection failed: Connection to \002"+myhost+"\002 refused");
+                       Utils->Creator->RemoteMessage(NULL,"Connection failed: Connection to \002%s\002 refused", myhost.c_str());
                        MyLink = Utils->FindLink(myhost);
                        if (MyLink)
                                Utils->DoFailOver(MyLink);
                break;
                case I_ERR_SOCKET:
-                       this->Instance->SNO->WriteToSnoMask('l',"Connection failed: Could not create socket");
+                       Utils->Creator->RemoteMessage(NULL,"Connection failed: Could not create socket");
                break;
                case I_ERR_BIND:
-                       this->Instance->SNO->WriteToSnoMask('l',"Connection failed: Error binding socket to address or port");
+                       Utils->Creator->RemoteMessage(NULL,"Connection failed: Error binding socket to address or port");
                break;
                case I_ERR_WRITE:
-                       this->Instance->SNO->WriteToSnoMask('l',"Connection failed: I/O error on connection");
+                       Utils->Creator->RemoteMessage(NULL,"Connection failed: I/O error on connection");
                break;
                case I_ERR_NOMOREFDS:
-                       this->Instance->SNO->WriteToSnoMask('l',"Connection failed: Operating system is out of file descriptors!");
+                       Utils->Creator->RemoteMessage(NULL,"Connection failed: Operating system is out of file descriptors!");
                break;
                default:
                        if ((errno) && (errno != EINPROGRESS) && (errno != EAGAIN))
-                       {
-                               std::string errstr = strerror(errno);
-                               this->Instance->SNO->WriteToSnoMask('l',"Connection to \002"+myhost+"\002 failed with OS error: " + errstr);
-                       }
+                               Utils->Creator->RemoteMessage(NULL,"Connection to \002%s\002 failed with OS error: %s", myhost.c_str(), strerror(errno));
                break;
        }
 }
@@ -265,7 +264,9 @@ void TreeSocket::SendServers(TreeServer* Current, TreeServer* s, int hops)
                TreeServer* recursive_server = Current->GetChild(q);
                if (recursive_server != s)
                {
-                       snprintf(command,1024,":%s SERVER %s * %d :%s",Current->GetName().c_str(),recursive_server->GetName().c_str(),hops,recursive_server->GetDesc().c_str());
+                       snprintf(command,1024,":%s SERVER %s * %d %s :%s",Current->GetName().c_str(),recursive_server->GetName().c_str(),hops,
+                                       recursive_server->GetID().c_str(),
+                                       recursive_server->GetDesc().c_str());
                        this->WriteLine(command);
                        this->WriteLine(":"+recursive_server->GetName()+" VERSION :"+recursive_server->GetVersion());
                        /* down to next level */
@@ -328,13 +329,17 @@ std::string TreeSocket::RandString(unsigned int length)
 
 void TreeSocket::SendCapabilities()
 {
+       if (sentcapab)
+               return;
+
+       sentcapab = true;
        irc::commasepstream modulelist(MyCapabilities());
        this->WriteLine("CAPAB START");
 
        /* Send module names, split at 509 length */
-       std::string item = "*";
+       std::string item;
        std::string line = "CAPAB MODULES ";
-       while ((item = modulelist.GetToken()) != "")
+       while (modulelist.GetToken(item))
        {
                if (line.length() + item.length() + 1 > 509)
                {
@@ -375,8 +380,9 @@ void TreeSocket::SendCapabilities()
 bool TreeSocket::HasItem(const std::string &list, const std::string &item)
 {
        irc::commasepstream seplist(list);
-       std::string item2 = "*";
-       while ((item2 = seplist.GetToken()) != "")
+       std::string item2;
+
+       while (seplist.GetToken(item2))
        {
                if (item2 == item)
                        return true;
@@ -388,9 +394,9 @@ bool TreeSocket::HasItem(const std::string &list, const std::string &item)
 std::string TreeSocket::ListDifference(const std::string &one, const std::string &two)
 {
        irc::commasepstream list_one(one);
-       std::string item = "*";
+       std::string item;
        std::string result;
-       while ((item = list_one.GetToken()) != "")
+       while (list_one.GetToken(item))
        {
                if (!HasItem(two, item))
                {
@@ -405,7 +411,7 @@ void TreeSocket::SendError(const std::string &errormessage)
 {
        /* Display the error locally as well as sending it remotely */
        this->WriteLine("ERROR :"+errormessage);
-       this->Instance->SNO->WriteToSnoMask('l',"Sent \2ERROR\2 to "+this->InboundServerName+": "+errormessage);
+       Utils->Creator->RemoteMessage(NULL, "Sent \2ERROR\2 to %s: %s", (this->InboundServerName.empty() ? "<unknown>" : this->InboundServerName.c_str()), errormessage.c_str());
        /* One last attempt to make sure the error reaches its target */
        this->FlushWriteBuffer();
 }
@@ -424,6 +430,12 @@ bool TreeSocket::Capab(const std::deque<std::string> &params)
        }
        else if (params[0] == "END")
        {
+               std::string OurSID;
+
+               OurSID += (char)((Instance->Config->sid / 100) + 48);
+               OurSID += (char)((Instance->Config->sid / 10) % 10 + 48);
+               OurSID += (char)(Instance->Config->sid % 10 + 48);
+
                std::string reason;
                int ip6support = 0;
 #ifdef SUPPORT_IP6LINKS
@@ -474,6 +486,9 @@ bool TreeSocket::Capab(const std::deque<std::string> &params)
                                reason = "Protocol version not specified";
                }
 
+               if(this->CapKeys.find("PREFIX") != this->CapKeys.end() && this->CapKeys.find("PREFIX")->second != this->Instance->Modes->BuildPrefixes())
+                       reason = "One or more of the prefixes on the remote server are invalid on this server.";
+
                if (((this->CapKeys.find("HALFOP") == this->CapKeys.end()) && (Instance->Config->AllowHalfop)) || ((this->CapKeys.find("HALFOP") != this->CapKeys.end()) && (this->CapKeys.find("HALFOP")->second != ConvToStr(Instance->Config->AllowHalfop))))
                        reason = "We don't both have halfop support enabled/disabled identically";
 
@@ -492,14 +507,15 @@ bool TreeSocket::Capab(const std::deque<std::string> &params)
                        this->SetTheirChallenge(n->second);
                        if (!this->GetTheirChallenge().empty() && (this->LinkState == CONNECTING))
                        {
-                               this->WriteLine(std::string("SERVER ")+this->Instance->Config->ServerName+" "+this->MakePass(OutboundPass, this->GetTheirChallenge())+" 0 :"+this->Instance->Config->ServerDesc);
+                               this->WriteLine(std::string("SERVER ")+this->Instance->Config->ServerName+" "+this->MakePass(OutboundPass, this->GetTheirChallenge())+" 0 "+
+                                               OurSID+" :"+this->Instance->Config->ServerDesc);
                        }
                }
                else
                {
                        /* They didnt specify a challenge or we don't have m_sha256.so, we use plaintext */
                        if (this->LinkState == CONNECTING)
-                               this->WriteLine(std::string("SERVER ")+this->Instance->Config->ServerName+" "+OutboundPass+" 0 :"+this->Instance->Config->ServerDesc);
+                               this->WriteLine(std::string("SERVER ")+this->Instance->Config->ServerName+" "+OutboundPass+" 0 "+OurSID+" :"+this->Instance->Config->ServerDesc);
                }
 
                if (reason.length())
@@ -620,9 +636,8 @@ bool TreeSocket::ForceMode(const std::string &source, std::deque<std::string> &p
        }
        else
        {
-               /* FMODE from a server, create a fake user to receive mode feedback */
-               who = new userrec(this->Instance);
-               who->SetFd(FD_MAGIC_NUMBER);
+               /* FMODE from a server, use a fake user to receive mode feedback */
+               who = this->Instance->FakeClient;
                smode = true;      /* Setting this flag tells us we should free the userrec later */
                sourceserv = source;    /* Set sourceserv to the actual source string */
        }
@@ -667,6 +682,13 @@ bool TreeSocket::ForceMode(const std::string &source, std::deque<std::string> &p
                        return true;
        }
 
+       if (!TS)
+       {
+               Instance->Log(DEFAULT,"*** BUG? *** TS of 0 sent to FMODE. Are some services authors smoking craq, or is it 1970 again?. Dropped.");
+               Instance->SNO->WriteToSnoMask('d', "WARNING: The server %s is sending FMODE with a TS of zero. Total craq. Mode was dropped.", sourceserv.c_str());
+               return true;
+       }
+
        /* TS is equal or less: Merge the mode changes into ours and pass on.
         */
        if (TS <= ourTS)
@@ -687,10 +709,6 @@ bool TreeSocket::ForceMode(const std::string &source, std::deque<std::string> &p
        }
        /* If the TS is greater than ours, we drop the mode and dont pass it anywhere.
         */
-
-       if (smode)
-               DELETE(who);
-
        return true;
 }
 
@@ -790,6 +808,13 @@ bool TreeSocket::ForceJoin(const std::string &source, std::deque<std::string> &p
        params[2] = ":" + params[2];
        Utils->DoOneToAllButSender(source,"FJOIN",params,source);
 
+        if (!TS)
+       {
+               Instance->Log(DEFAULT,"*** BUG? *** TS of 0 sent to FJOIN. Are some services authors smoking craq, or is it 1970 again?. Dropped.");
+               Instance->SNO->WriteToSnoMask('d', "WARNING: The server %s is sending FJOIN with a TS of zero. Total craq. Command was dropped.", source.c_str());
+               return true;
+       }
+
        /* If our TS is less than theirs, we dont accept their modes */
        if (ourTS < TS)
                apply_other_sides_modes = false;
@@ -835,7 +860,7 @@ bool TreeSocket::ForceJoin(const std::string &source, std::deque<std::string> &p
                        usr++;
                        
                        /* Check the user actually exists */
-                       who = this->Instance->FindNick(usr);
+                       who = this->Instance->FindUUID(usr);
                        if (who)
                        {
                                /* Check that the user's 'direction' is correct */
@@ -861,9 +886,7 @@ bool TreeSocket::ForceJoin(const std::string &source, std::deque<std::string> &p
        if (apply_other_sides_modes)
        {
                std::deque<std::string> stackresult;
-               const char* mode_junk[MAXMODES+1];
-               userrec* n = new userrec(Instance);
-               n->SetFd(FD_MAGIC_NUMBER);
+               const char* mode_junk[MAXMODES+2];
                mode_junk[0] = channel.c_str();
 
                while (modestack.GetStackedLine(stackresult))
@@ -872,102 +895,230 @@ bool TreeSocket::ForceJoin(const std::string &source, std::deque<std::string> &p
                        {
                                mode_junk[j+1] = stackresult[j].c_str();
                        }
-                       Instance->SendMode(mode_junk, stackresult.size() + 1, n);
+                       Instance->SendMode(mode_junk, stackresult.size() + 1, Instance->FakeClient);
                }
-
-               delete n;
        }
 
        return true;
 }
 
-/** NICK command */
-bool TreeSocket::IntroduceClient(const std::string &source, std::deque<std::string> &params)
+/*
+ * Yes, this function looks a little ugly.
+ * However, in some circumstances we may not have a userrec, so we need to do things this way.
+ * Returns 1 if colliding local client, 2 if colliding remote, 3 if colliding both.
+ * Sends SVSNICKs as appropriate and forces nickchanges too.
+ */
+int TreeSocket::DoCollision(userrec *u, time_t remotets, const char *remoteident, const char *remoteip, const char *remoteuid)
+{
+       /*
+        *  Under old protocol rules, we would have had to kill both clients.
+        *  Really, this sucks.
+        * These days, we have UID. And, so what we do is, force nick change client(s)
+        * involved according to timestamp rules.
+        *
+        * RULES:        
+        *  user@ip equal:       
+        *   Force nick change on OLDER timestamped client       
+        *  user@ip differ:      
+        *   Force nick change on NEWER timestamped client       
+        *  TS EQUAL:    
+        *   FNC both.   
+        *       
+        * This stops abusive use of collisions, simplifies problems with loops, and so on.      
+        *   -- w00t
+        */
+       bool bChangeLocal = true;
+       bool bChangeRemote = true;
+
+       /* for brevity, don't use the userrec */
+       time_t localts = u->age;
+       const char *localident = u->ident;
+       const char *localip = u->GetIPString();
+
+       /* mmk. let's do this again. */
+       if (remotets == localts)
+       {
+               /* equal. fuck them both! do nada, let the handler at the bottom figure this out. */
+       }
+       else
+       {
+               /* fuck. now it gets complex. */
+
+               /* first, let's see if ident@host matches. */
+               bool SamePerson = strcmp(localident, remoteident)
+                               && !strcmp(localip, remoteip);
+
+               /*
+                * if ident@ip is equal, and theirs is newer, or
+                * ident@ip differ, and ours is newer
+                */
+               if((SamePerson && remotets < localts) ||
+                  (!SamePerson && remotets > localts))
+               {
+                       /* remote needs to change */
+                       bChangeLocal = false;
+               }
+               else
+               {
+                       /* ours needs to change */
+                       bChangeRemote = false;
+               }
+       }
+
+
+       if (bChangeLocal)
+       {
+               u->ForceNickChange(u->uuid);
+
+               if (!bChangeRemote)
+                       return 1;
+       }
+       if (bChangeRemote)
+       {
+               /*
+                * Cheat a little here. Instead of a dedicated command to change UID,
+                * use SVSNICK and accept their client with it's UID (as we know the SVSNICK will
+                * not fail under any circumstances -- UIDs are netwide exclusive).
+                *
+                * This means that each side of a collide will generate one extra NICK back to where
+                * they have just linked (and where it got the SVSNICK from), however, it will
+                * be dropped harmlessly as it will come in as :928AAAB NICK 928AAAB, and we already
+                * have 928AAAB's nick set to that.
+                *   -- w00t
+                */
+               userrec *remote = this->Instance->FindUUID(remoteuid);
+
+               if (remote)
+               {
+                       /* buh.. nick change collide. force change their nick. */
+                       remote->ForceNickChange(remote->uuid);
+               }
+               else
+               {
+                       /* user has not been introduced yet, just inform their server */
+                       this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" SVSNICK "+remoteuid+" " + remoteuid);
+               }
+
+               if (!bChangeRemote)
+                       return 2;
+       }
+
+       return 3;
+}
+
+bool TreeSocket::ParseUID(const std::string &source, std::deque<std::string> &params)
 {
        /** Do we have enough parameters:
-        * NICK age nick host dhost ident +modes ip :gecos
+        * UID uuid age nick host dhost ident +modestr ip.string :gecos
         */
-       if (params.size() != 8)
+       if (params.size() != 9)
        {
-               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[1]+" :Invalid client introduction ("+params[1]+"?)");
+               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[0]+" :Invalid client introduction ("+params[0]+"?)");
                return true;
        }
 
-       time_t age = ConvToInt(params[0]);
-       const char* tempnick = params[1].c_str();
+       time_t age = ConvToInt(params[1]);
+       const char* tempnick = params[2].c_str();
+       std::string empty;
 
-       cmd_validation valid[] = { {"Nickname", 1, NICKMAX}, {"Hostname", 2, 64}, {"Displayed hostname", 3, 64}, {"Ident", 4, IDENTMAX}, {"GECOS", 7, MAXGECOS}, {"", 0, 0} };
+       /* XXX probably validate UID length too -- w00t */
+       cmd_validation valid[] = { {"Nickname", 2, NICKMAX}, {"Hostname", 3, 64}, {"Displayed hostname", 4, 64}, {"Ident", 5, IDENTMAX}, {"GECOS", 7, MAXGECOS}, {"", 0, 0} };
 
        TreeServer* remoteserver = Utils->FindServer(source);
+
        if (!remoteserver)
        {
-               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[1]+" :Invalid client introduction (Unknown server "+source+")");
+               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[0]+" :Invalid client introduction (Unknown server "+source+")");
                return true;
        }
 
        /* Check parameters for validity before introducing the client, discovered by dmb */
        if (!age)
        {
-               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[1]+" :Invalid client introduction (Invalid TS?)");
+               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[0]+" :Invalid client introduction (Invalid TS?)");
                return true;
        }
+
        for (size_t x = 0; valid[x].length; ++x)
        {
                if (params[valid[x].param].length() > valid[x].length)
                {
-                       this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[1]+" :Invalid client introduction (" + valid[x].item + " > " + ConvToStr(valid[x].length) + ")");
+                       this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+params[0]+" :Invalid client introduction (" + valid[x].item + " > " + ConvToStr(valid[x].length) + ")");
                        return true;
                }
        }
 
-       /** Our client looks ok, lets introduce it now
-        */
-       Instance->Log(DEBUG,"New remote client %s",tempnick);
+
+       /* check for collision */
        user_hash::iterator iter = this->Instance->clientlist->find(tempnick);
 
        if (iter != this->Instance->clientlist->end())
        {
-               /* nick collision */
-               this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+tempnick+" :Nickname collision");
-               userrec::QuitUser(this->Instance, iter->second, "Nickname collision");
-               return true;
+               /*
+                * Nick collision.
+                */
+               Instance->Log(DEBUG,"*** Collision on %s", tempnick);
+               int collide = this->DoCollision(iter->second, age, params[5].c_str(), params[7].c_str(), params[0].c_str());
+
+               if (collide == 2)
+               {
+                       /* remote client changed, make sure we change their nick for the hash too */
+                       tempnick = params[0].c_str();
+               }
        }
 
-       userrec* _new = new userrec(this->Instance);
+       /* IMPORTANT NOTE: For remote users, we pass the UUID in the constructor. This automatically
+        * sets it up in the UUID hash for us.
+        */
+       userrec* _new = NULL;
+       try
+       {
+               _new = new userrec(this->Instance, params[0]);
+       }
+       catch (CoreException &e)
+       {
+               /** TODO: SQUIT the server here, the remote server is fucking with us
+                * and has sent us the same UID twice!
+                */
+       }
        (*(this->Instance->clientlist))[tempnick] = _new;
        _new->SetFd(FD_MAGIC_NUMBER);
-       strlcpy(_new->nick, tempnick,NICKMAX-1);
-       strlcpy(_new->host, params[2].c_str(),64);
-       strlcpy(_new->dhost, params[3].c_str(),64);
+       strlcpy(_new->nick, tempnick, NICKMAX - 1);
+       strlcpy(_new->host, params[3].c_str(),64);
+       strlcpy(_new->dhost, params[4].c_str(),64);
        _new->server = this->Instance->FindServerNamePtr(source.c_str());
-       strlcpy(_new->ident, params[4].c_str(),IDENTMAX);
-       strlcpy(_new->fullname, params[7].c_str(),MAXGECOS);
+       strlcpy(_new->ident, params[5].c_str(),IDENTMAX);
+       strlcpy(_new->fullname, params[8].c_str(),MAXGECOS);
        _new->registered = REG_ALL;
        _new->signon = age;
 
        /* we need to remove the + from the modestring, so we can do our stuff */
-       std::string::size_type pos_after_plus = params[5].find_first_not_of('+');
+       std::string::size_type pos_after_plus = params[6].find_first_not_of('+');
        if (pos_after_plus != std::string::npos)
-       params[5] = params[5].substr(pos_after_plus);
+       params[6] = params[6].substr(pos_after_plus);
 
-       for (std::string::iterator v = params[5].begin(); v != params[5].end(); v++)
+       for (std::string::iterator v = params[6].begin(); v != params[6].end(); v++)
        {
-               _new->modes[(*v)-65] = 1;
                /* For each mode thats set, increase counter */
                ModeHandler* mh = Instance->Modes->FindMode(*v, MODETYPE_USER);
+
                if (mh)
+               {
+                       mh->OnModeChange(_new, _new, NULL, empty, true);
+                       _new->SetMode(*v, true);
                        mh->ChangeCount(1);
+               }
        }
 
        /* now we've done with modes processing, put the + back for remote servers */
-       params[5] = "+" + params[5];
+       params[6] = "+" + params[6];
 
 #ifdef SUPPORT_IP6LINKS
-       if (params[6].find_first_of(":") != std::string::npos)
-               _new->SetSockAddr(AF_INET6, params[6].c_str(), 0);
+       if (params[7].find_first_of(":") != std::string::npos)
+               _new->SetSockAddr(AF_INET6, params[7].c_str(), 0);
        else
 #endif
-               _new->SetSockAddr(AF_INET, params[6].c_str(), 0);
+               _new->SetSockAddr(AF_INET, params[7].c_str(), 0);
 
        Instance->AddGlobalClone(_new);
 
@@ -976,8 +1127,8 @@ bool TreeSocket::IntroduceClient(const std::string &source, std::deque<std::stri
        if (dosend)
                this->Instance->SNO->WriteToSnoMask('C',"Client connecting at %s: %s!%s@%s [%s] [%s]",_new->server,_new->nick,_new->ident,_new->host, _new->GetIPString(), _new->fullname);
 
-       params[7] = ":" + params[7];
-       Utils->DoOneToAllButSender(source,"NICK", params, source);
+       params[8] = ":" + params[8];
+       Utils->DoOneToAllButSender(source, "UID", params, source);
 
        // Increment the Source Servers User Count..
        TreeServer* SourceServer = Utils->FindServer(source);
@@ -1013,7 +1164,7 @@ void TreeSocket::SendFJoins(TreeServer* Current, chanrec* c)
        for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
                // The first parameter gets a : before it
-               size_t ptrlen = snprintf(ptr, MAXBUF, " %s%s,%s", !numusers ? ":" : "", c->GetAllPrefixChars(i->first), i->first->nick);
+               size_t ptrlen = snprintf(ptr, MAXBUF, " %s%s,%s", !numusers ? ":" : "", c->GetAllPrefixChars(i->first), i->first->uuid);
 
                curlen += ptrlen;
                ptr += ptrlen;
@@ -1152,20 +1303,21 @@ void TreeSocket::SendUsers(TreeServer* Current)
        {
                if (u->second->registered == REG_ALL)
                {
-                       snprintf(data,MAXBUF,":%s NICK %lu %s %s %s %s +%s %s :%s",u->second->server,(unsigned long)u->second->age,u->second->nick,u->second->host,u->second->dhost,u->second->ident,u->second->FormatModes(),u->second->GetIPString(),u->second->fullname);
+                       snprintf(data,MAXBUF,":%s UID %s %lu %s %s %s %s +%s %s :%s", u->second->server, u->second->uuid, (unsigned long)u->second->age,u->second->nick,u->second->host,u->second->dhost,u->second->ident,u->second->FormatModes(),u->second->GetIPString(),u->second->fullname);
                        this->WriteLine(data);
                        if (*u->second->oper)
                        {
-                               snprintf(data,MAXBUF,":%s OPERTYPE %s", u->second->nick, u->second->oper);
+                               snprintf(data,MAXBUF,":%s OPERTYPE %s", u->second->uuid, u->second->oper);
                                this->WriteLine(data);
                        }
                        if (*u->second->awaymsg)
                        {
-                               snprintf(data,MAXBUF,":%s AWAY :%s", u->second->nick, u->second->awaymsg);
+                               snprintf(data,MAXBUF,":%s AWAY :%s", u->second->uuid, u->second->awaymsg);
                                this->WriteLine(data);
                        }
                }
        }
+
        for (user_hash::iterator u = this->Instance->clientlist->begin(); u != this->Instance->clientlist->end(); u++)
        {
                FOREACH_MOD_I(this->Instance,I_OnSyncUser,OnSyncUser(u->second,(Module*)Utils->Creator,(void*)this));