]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/treesocket1.cpp
Fix error message on OPTCOMMON mismatch
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / treesocket1.cpp
index 432ee2a098d7a8a57c6b5dc43fb06e5c9e685dbd..ea87c615fb9a989bd32f743269d662d06b8db6fc 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2010 InspIRCd Development Team
  * See: http://wiki.inspircd.org/Credits
  *
  * This program is free but copyrighted software; see
@@ -35,31 +35,20 @@ TreeSocket::TreeSocket(SpanningTreeUtilities* Util, const std::string& shost, in
 {
        age = ServerInstance->Time();
        myhost = ServerName;
-       capab_phase = 0;
+       capab = new CapabData;
+       capab->capab_phase = 0;
        proto_version = 0;
        LinkState = CONNECTING;
        if (!hook.empty())
        {
-               modulelist* ml = ServerInstance->Modules->FindInterface("BufferedSocketHook");
-               if (ml)
+               ServiceProvider* prov = ServerInstance->Modules->FindService(SERVICE_IOHOOK, hook);
+               if (!prov)
                {
-                       for(modulelist::iterator i = ml->begin(); i != ml->end(); ++i)
-                       {
-                               std::string name = (**i).ModuleSourceFile;
-                               int a = name.rfind('_');
-                               int b = name.rfind('.');
-                               name = name.substr(a, b-a-1);
-                               if (name == hook)
-                               {
-                                       AddIOHook(*i);
-                                       goto found;
-                               }
-                       }
+                       SetError("Could not find hook '" + hook + "' for connection to " + ServerName);
+                       return;
                }
-               SetError("Could not find hook '" + hook + "' for connection to " + ServerName);
-               return;
+               AddIOHook(prov->creator);
        }
-found:
        DoConnect(shost, iport, maxtime, bindto);
        Utils->timeoutlist[this] = std::pair<std::string, int>(ServerName, maxtime);
        SendCapabilities(1);
@@ -69,23 +58,23 @@ found:
  * we must associate it with a socket without creating a new
  * connection. This constructor is used for this purpose.
  */
-TreeSocket::TreeSocket(SpanningTreeUtilities* Util, int newfd, ListenSocketBase* via, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
+TreeSocket::TreeSocket(SpanningTreeUtilities* Util, int newfd, ListenSocket* via, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
        : BufferedSocket(newfd), Utils(Util)
 {
-       int dummy;
-       irc::sockets::satoap(client, IP, dummy);
+       capab = new CapabData;
+       IP = client->addr();
        age = ServerInstance->Time();
        LinkState = WAIT_AUTH_1;
-       capab_phase = 0;
+       capab->capab_phase = 0;
        proto_version = 0;
+       myhost = "inbound from " + IP;
 
        FOREACH_MOD(I_OnHookIO, OnHookIO(this, via));
        if (GetIOHook())
                GetIOHook()->OnStreamSocketAccept(this, client, server);
        SendCapabilities(1);
 
-       /* Fix by Brain - inbound sockets need a timeout, too. 30 secs should be pleanty */
-       Utils->timeoutlist[this] = std::pair<std::string, int>("<from " + IP + ">", 30);
+       Utils->timeoutlist[this] = std::pair<std::string, int>(myhost, 30);
 }
 
 ServerState TreeSocket::GetLinkState()
@@ -95,22 +84,22 @@ ServerState TreeSocket::GetLinkState()
 
 void TreeSocket::CleanNegotiationInfo()
 {
-       ModuleList.clear();
-       OptModuleList.clear();
-       CapKeys.clear();
-       ourchallenge.clear();
-       theirchallenge.clear();
-       OutboundPass.clear();
+       delete capab;
+       capab = NULL;
 }
 
-bool TreeSocket::cull()
+CullResult TreeSocket::cull()
 {
        Utils->timeoutlist.erase(this);
+       if (myautoconnect)
+               Utils->Creator->ConnectServer(myautoconnect, false);
        return this->BufferedSocket::cull();
 }
 
 TreeSocket::~TreeSocket()
 {
+       if (capab)
+               delete capab;
 }
 
 /** When an outbound connection finishes connecting, we receive
@@ -129,8 +118,8 @@ void TreeSocket::OnConnected()
                        Link* x = *i;
                        if (x->Name == this->myhost)
                        {
-                               ServerInstance->SNO->WriteToSnoMask('l', "Connection to \2%s\2[%s] started.", myhost.c_str(), (x->HiddenFromStats ? "<hidden>" : this->IP.c_str()));
-                               this->OutboundPass = x->SendPass;
+                               ServerInstance->SNO->WriteGlobalSno('l', "Connection to \2%s\2[%s] started.", myhost.c_str(), (x->HiddenFromStats ? "<hidden>" : this->IP.c_str()));
+                               capab->OutboundPass = x->SendPass;
                                this->SendCapabilities(1);
                                return;
                        }
@@ -141,41 +130,21 @@ void TreeSocket::OnConnected()
         * If that happens the connection hangs here until it's closed. Unlikely
         * and rather harmless.
         */
-       ServerInstance->SNO->WriteToSnoMask('l', "Connection to \2%s\2 lost link tag(!)", myhost.c_str());
+       ServerInstance->SNO->WriteGlobalSno('l', "Connection to \2%s\2 lost link tag(!)", myhost.c_str());
 }
 
 void TreeSocket::OnError(BufferedSocketError e)
 {
-       switch (e)
-       {
-               case I_ERR_CONNECT:
-                       ServerInstance->SNO->WriteToSnoMask('l', "Connection failed: Connection to \002%s\002 refused", myhost.c_str());
-                       Utils->Creator->ConnectServer(myautoconnect);
-               break;
-               case I_ERR_SOCKET:
-                       ServerInstance->SNO->WriteToSnoMask('l', "Connection failed: Could not create socket (%s)", strerror(errno));
-               break;
-               case I_ERR_BIND:
-                       ServerInstance->SNO->WriteToSnoMask('l', "Connection failed: Error binding socket to address or port (%s)", strerror(errno));
-               break;
-               case I_ERR_WRITE:
-                       ServerInstance->SNO->WriteToSnoMask('l', "Connection failed: I/O error on connection (%s)", errno ? strerror(errno) : "Connection closed unexpectedly");
-               break;
-               case I_ERR_NOMOREFDS:
-                       ServerInstance->SNO->WriteToSnoMask('l', "Connection failed: Operating system is out of file descriptors!");
-               break;
-               default:
-                       if ((errno) && (errno != EINPROGRESS) && (errno != EAGAIN))
-                               ServerInstance->SNO->WriteToSnoMask('l', "Connection to \002%s\002 failed with OS error: %s", myhost.c_str(), strerror(errno));
-               break;
-       }
+       ServerInstance->SNO->WriteGlobalSno('l', "Connection to \002%s\002 failed with error: %s",
+               myhost.c_str(), getError().c_str());
+       ServerInstance->GlobalCulls.AddItem(this);
 }
 
 void TreeSocket::SendError(const std::string &errormessage)
 {
-       /* Display the error locally as well as sending it remotely */
-       ServerInstance->SNO->WriteToSnoMask('l', "Sent \2ERROR\2 to %s: %s", (this->InboundServerName.empty() ? this->IP.c_str() : this->InboundServerName.c_str()), errormessage.c_str());
        WriteLine("ERROR :"+errormessage);
+       DoWrite();
+       LinkState = DYING;
        SetError(errormessage);
 }
 
@@ -221,12 +190,12 @@ void TreeSocket::Squit(TreeServer* Current, const std::string &reason)
                Utils->DoOneToAllButSender(Current->GetParent()->GetName(),"SQUIT",params,Current->GetName());
                if (Current->GetParent() == Utils->TreeRoot)
                {
-                       ServerInstance->SNO->WriteToSnoMask('l', "Server \002"+Current->GetName()+"\002 split: "+reason);
+                       ServerInstance->SNO->WriteGlobalSno('l', "Server \002"+Current->GetName()+"\002 split: "+reason);
                        LocalSquit = true;
                }
                else
                {
-                       ServerInstance->SNO->WriteToSnoMask('L', "Server \002"+Current->GetName()+"\002 split from server \002"+Current->GetParent()->GetName()+"\002 with reason: "+reason);
+                       ServerInstance->SNO->WriteGlobalSno('L', "Server \002"+Current->GetName()+"\002 split from server \002"+Current->GetParent()->GetName()+"\002 with reason: "+reason);
                }
                num_lost_servers = 0;
                num_lost_users = 0;
@@ -234,11 +203,12 @@ void TreeSocket::Squit(TreeServer* Current, const std::string &reason)
                SquitServer(from, Current);
                Current->Tidy();
                Current->GetParent()->DelChild(Current);
+               Current->cull();
                delete Current;
                if (LocalSquit)
-                       ServerInstance->SNO->WriteToSnoMask('l', "Netsplit complete, lost \002%d\002 users on \002%d\002 servers.", num_lost_users, num_lost_servers);
+                       ServerInstance->SNO->WriteToSnoMask('l', "Netsplit complete, lost \002%d\002 user%s on \002%d\002 server%s.", num_lost_users, num_lost_users != 1 ? "s" : "", num_lost_servers, num_lost_servers != 1 ? "s" : "");
                else
-                       ServerInstance->SNO->WriteToSnoMask('L', "Netsplit complete, lost \002%d\002 users on \002%d\002 servers.", num_lost_users, num_lost_servers);
+                       ServerInstance->SNO->WriteToSnoMask('L', "Netsplit complete, lost \002%d\002 user%s on \002%d\002 server%s.", num_lost_users, num_lost_users != 1 ? "s" : "", num_lost_servers, num_lost_servers != 1 ? "s" : "");
        }
        else
                ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"Squit from unknown server");
@@ -250,20 +220,22 @@ void TreeSocket::Squit(TreeServer* Current, const std::string &reason)
 void TreeSocket::OnDataReady()
 {
        Utils->Creator->loopCall = true;
-       /* While there is at least one new line in the buffer,
-        * do something useful (we hope!) with it.
-        */
-       while (recvq.find("\n") != std::string::npos)
+       std::string line;
+       while (GetNextLine(line))
        {
-               std::string ret = recvq.substr(0,recvq.find("\n")-1);
-               recvq = recvq.substr(recvq.find("\n")+1,recvq.length()-recvq.find("\n"));
-               /* Use rfind here not find, as theres more
-                * chance of the \r being near the end of the
-                * string, not the start.
-                */
-               if (ret.find("\r") != std::string::npos)
-                       ret = recvq.substr(0,recvq.find("\r")-1);
-               ProcessLine(ret);
+               std::string::size_type rline = line.find('\r');
+               if (rline != std::string::npos)
+                       line = line.substr(0,rline);
+               if (line.find('\0') != std::string::npos)
+               {
+                       SendError("Read null character from socket");
+                       break;
+               }
+               ProcessLine(line);
+               if (!getError().empty())
+                       break;
        }
+       if (LinkState != CONNECTED && recvq.length() > 4096)
+               SendError("RecvQ overrun (line too long)");
        Utils->Creator->loopCall = false;
 }