]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/utils.cpp
Merge pull request #488 from SaberUK/master+loglevel-rename
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / utils.cpp
index 9ae6d4d14bcd398b81f5124e91ad9f91246e2d46..1517ac1b97735bc3c6cf0334244123fa5bd773bc 100644 (file)
@@ -1,67 +1,56 @@
-/*       +------------------------------------+
- *       | Inspire Internet Relay Chat Daemon |
- *       +------------------------------------+
+/*
+ * InspIRCd -- Internet Relay Chat Daemon
  *
- *  InspIRCd: (C) 2002-2009 InspIRCd Development Team
- * See: http://wiki.inspircd.org/Credits
+ *   Copyright (C) 2009 Daniel De Graaf <danieldg@inspircd.org>
+ *   Copyright (C) 2007-2009 Craig Edwards <craigedwards@brainbox.cc>
+ *   Copyright (C) 2008 Robin Burchell <robin+git@viroteck.net>
+ *   Copyright (C) 2007 Dennis Friis <peavey@inspircd.org>
  *
- * This program is free but copyrighted software; see
- *            the file COPYING for details.
+ * This file is part of InspIRCd.  InspIRCd is free software: you can
+ * redistribute it and/or modify it under the terms of the GNU General Public
+ * License as published by the Free Software Foundation, version 2.
  *
- * ---------------------------------------------------
+ * This program is distributed in the hope that it will be useful, but WITHOUT
+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
+ * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
+ * details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
+
 #include "inspircd.h"
-#include "commands/cmd_whois.h"
-#include "commands/cmd_stats.h"
 #include "socket.h"
 #include "xline.h"
-#include "transport.h"
 #include "socketengine.h"
 
-#include "m_spanningtree/main.h"
-#include "m_spanningtree/utils.h"
-#include "m_spanningtree/treeserver.h"
-#include "m_spanningtree/link.h"
-#include "m_spanningtree/treesocket.h"
-#include "m_spanningtree/resolvers.h"
-
-/* $ModDep: m_spanningtree/resolvers.h m_spanningtree/main.h m_spanningtree/utils.h m_spanningtree/treeserver.h m_spanningtree/link.h m_spanningtree/treesocket.h */
+#include "main.h"
+#include "utils.h"
+#include "treeserver.h"
+#include "link.h"
+#include "treesocket.h"
+#include "resolvers.h"
 
 /* Create server sockets off a listener. */
-void ServerSocketListener::OnAcceptReady(const std::string &ipconnectedto, int newsock, const std::string &incomingip)
+ModResult ModuleSpanningTree::OnAcceptConnection(int newsock, ListenSocket* from, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
 {
-       bool found = false;
-       char *ip = (char *)incomingip.c_str(); // XXX ugly cast
+       if (from->bind_tag->getString("type") != "servers")
+               return MOD_RES_PASSTHRU;
 
-       found = (std::find(Utils->ValidIPs.begin(), Utils->ValidIPs.end(), ip) != Utils->ValidIPs.end());
-       if (!found)
-       {
-               for (std::vector<std::string>::iterator i = Utils->ValidIPs.begin(); i != Utils->ValidIPs.end(); i++)
-               {
-                       if (*i == "*" || irc::sockets::MatchCIDR(ip, *i))
-                       {
-                               found = true;
-                               break;
-                       }
-               }
+       std::string incomingip = client->addr();
 
-               if (!found)
+       for (std::vector<std::string>::iterator i = Utils->ValidIPs.begin(); i != Utils->ValidIPs.end(); i++)
+       {
+               if (*i == "*" || *i == incomingip || irc::sockets::cidr_mask(*i).match(*client))
                {
-                       this->ServerInstance->SNO->WriteToSnoMask('l', "Server connection from %s denied (no link blocks with that IP address)", ip);
-                       ServerInstance->SE->Close(newsock);
-                       return;
+                       /* we don't need to do anything with the pointer, creating it stores it in the necessary places */
+                       new TreeSocket(Utils, newsock, from, client, server);
+                       return MOD_RES_ALLOW;
                }
        }
-
-       if (this->GetIOHook())
-       {
-               this->GetIOHook()->OnRawSocketAccept(newsock, incomingip.c_str(), this->bind_port);
-       }
-
-       /* we don't need a pointer to this, creating it stores it in the necessary places */
-       new TreeSocket(this->Utils, this->ServerInstance, newsock, ip, this->GetIOHook());
-       return;
+       ServerInstance->SNO->WriteToSnoMask('l', "Server connection from %s denied (no link blocks with that IP address)", incomingip.c_str());
+       return MOD_RES_DENY;
 }
 
 /** Yay for fast searches!
@@ -72,7 +61,7 @@ void ServerSocketListener::OnAcceptReady(const std::string &ipconnectedto, int n
  */
 TreeServer* SpanningTreeUtilities::FindServer(const std::string &ServerName)
 {
-       if (this->ServerInstance->IsSID(ServerName))
+       if (InspIRCd::IsSID(ServerName))
                return this->FindServerID(ServerName);
 
        server_hash::iterator iter = serverlist.find(ServerName.c_str());
@@ -141,45 +130,39 @@ TreeServer* SpanningTreeUtilities::FindServerID(const std::string &id)
                return NULL;
 }
 
-/* A convenient wrapper that returns true if a server exists */
-bool SpanningTreeUtilities::IsServer(const std::string &ServerName)
-{
-       return (FindServer(ServerName) != NULL);
-}
-
-SpanningTreeUtilities::SpanningTreeUtilities(InspIRCd* Instance, ModuleSpanningTree* C) : ServerInstance(Instance), Creator(C)
+SpanningTreeUtilities::SpanningTreeUtilities(ModuleSpanningTree* C) : Creator(C)
 {
-       Bindings.clear();
+       ServerInstance->Logs->Log("m_spanningtree",LOG_DEBUG,"***** Using SID for hash: %s *****", ServerInstance->Config->GetSID().c_str());
 
-       ServerInstance->Logs->Log("m_spanningtree",DEBUG,"***** Using SID for hash: %s *****", ServerInstance->Config->GetSID().c_str());
-
-       this->TreeRoot = new TreeServer(this, ServerInstance, ServerInstance->Config->ServerName, ServerInstance->Config->ServerDesc, ServerInstance->Config->GetSID());
-       this->ServerUser = new FakeUser(ServerInstance, TreeRoot->GetID());
-
-       this->ReadConfiguration(true);
+       this->TreeRoot = new TreeServer(this, ServerInstance->Config->ServerName, ServerInstance->Config->ServerDesc, ServerInstance->Config->GetSID());
+       this->ReadConfiguration();
 }
 
-SpanningTreeUtilities::~SpanningTreeUtilities()
+CullResult SpanningTreeUtilities::cull()
 {
-       for (unsigned int i = 0; i < Bindings.size(); i++)
-       {
-               delete Bindings[i];
-       }
-
        while (TreeRoot->ChildCount())
        {
                TreeServer* child_server = TreeRoot->GetChild(0);
                if (child_server)
                {
                        TreeSocket* sock = child_server->GetSocket();
-                       ServerInstance->SE->DelFd(sock);
                        sock->Close();
                }
        }
+
+       for(std::map<TreeSocket*, std::pair<std::string, int> >::iterator i = timeoutlist.begin(); i != timeoutlist.end(); ++i)
+       {
+               TreeSocket* s = i->first;
+               s->Close();
+       }
+       TreeRoot->cull();
+
+       return classbase::cull();
+}
+
+SpanningTreeUtilities::~SpanningTreeUtilities()
+{
        delete TreeRoot;
-       ServerUser->uuid = TreeRoot->GetID();
-       delete ServerUser;
-       ServerInstance->BufferedSocketCull();
 }
 
 void SpanningTreeUtilities::AddThisServer(TreeServer* server, TreeServerList &list)
@@ -191,14 +174,22 @@ void SpanningTreeUtilities::AddThisServer(TreeServer* server, TreeServerList &li
 /* returns a list of DIRECT servernames for a specific channel */
 void SpanningTreeUtilities::GetListOfServersForChannel(Channel* c, TreeServerList &list, char status, const CUList &exempt_list)
 {
-       CUList *ulist = c->GetUsers();
+       unsigned int minrank = 0;
+       if (status)
+       {
+               ModeHandler* mh = ServerInstance->Modes->FindPrefix(status);
+               if (mh)
+                       minrank = mh->GetPrefixRank();
+       }
 
-       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+       const UserMembList *ulist = c->GetUsers();
+
+       for (UserMembCIter i = ulist->begin(); i != ulist->end(); i++)
        {
                if (IS_LOCAL(i->first))
                        continue;
 
-               if (status && !strchr(c->GetAllPrefixChars(i->first), status))
+               if (minrank && i->second->getRank() < minrank)
                        continue;
 
                if (exempt_list.find(i->first) == exempt_list.end())
@@ -211,80 +202,7 @@ void SpanningTreeUtilities::GetListOfServersForChannel(Channel* c, TreeServerLis
        return;
 }
 
-bool SpanningTreeUtilities::DoOneToAllButSenderRaw(const std::string &data, const std::string &omit, const std::string &prefix, const irc::string &command, std::deque<std::string> &params)
-{
-       char pfx = 0;
-       TreeServer* omitroute = this->BestRouteTo(omit);
-       if ((command == "NOTICE") || (command == "PRIVMSG"))
-       {
-               if (params.size() >= 2)
-               {
-                       /* Prefixes */
-                       if (ServerInstance->Modes->FindPrefix(params[0][0]))
-                       {
-                               pfx = params[0][0];
-                               params[0] = params[0].substr(1, params[0].length()-1);
-                       }
-                       if ((*(params[0].c_str()) != '#') && (*(params[0].c_str()) != '$'))
-                       {
-                               // special routing for private messages/notices
-                               User* d = ServerInstance->FindNick(params[0]);
-                               if (d)
-                               {
-                                       std::deque<std::string> par;
-                                       par.push_back(params[0]);
-                                       par.push_back(":"+params[1]);
-                                       this->DoOneToOne(prefix,command.c_str(),par,d->server);
-                                       return true;
-                               }
-                       }
-                       else if (*(params[0].c_str()) == '$')
-                       {
-                               std::deque<std::string> par;
-                               par.push_back(params[0]);
-                               par.push_back(":"+params[1]);
-                               this->DoOneToAllButSender(prefix,command.c_str(),par,omitroute->GetName());
-                               return true;
-                       }
-                       else
-                       {
-                               Channel* c = ServerInstance->FindChan(params[0]);
-                               User* u = ServerInstance->FindNick(prefix);
-                               if (c)
-                               {
-                                       CUList elist;
-                                       TreeServerList list;
-                                       FOREACH_MOD(I_OnBuildExemptList, OnBuildExemptList((command == "PRIVMSG" ? MSG_PRIVMSG : MSG_NOTICE), c, u, pfx, elist, params[1]));
-                                       GetListOfServersForChannel(c,list,pfx,elist);
-
-                                       for (TreeServerList::iterator i = list.begin(); i != list.end(); i++)
-                                       {
-                                               TreeSocket* Sock = i->second->GetSocket();
-                                               if ((Sock) && (i->second->GetName() != omit) && (omitroute != i->second))
-                                               {
-                                                       Sock->WriteLine(data);
-                                               }
-                                       }
-                                       return true;
-                               }
-                       }
-               }
-       }
-       unsigned int items =this->TreeRoot->ChildCount();
-       for (unsigned int x = 0; x < items; x++)
-       {
-               TreeServer* Route = this->TreeRoot->GetChild(x);
-               if ((Route) && (Route->GetSocket()) && (Route->GetName() != omit) && (omitroute != Route))
-               {
-                       TreeSocket* Sock = Route->GetSocket();
-                       if (Sock)
-                               Sock->WriteLine(data);
-               }
-       }
-       return true;
-}
-
-bool SpanningTreeUtilities::DoOneToAllButSender(const std::string &prefix, const std::string &command, std::deque<std::string> &params, std::string omit)
+bool SpanningTreeUtilities::DoOneToAllButSender(const std::string &prefix, const std::string &command, const parameterlist &params, std::string omit)
 {
        TreeServer* omitroute = this->BestRouteTo(omit);
        std::string FullLine = ":" + prefix + " " + command;
@@ -311,7 +229,7 @@ bool SpanningTreeUtilities::DoOneToAllButSender(const std::string &prefix, const
        return true;
 }
 
-bool SpanningTreeUtilities::DoOneToMany(const std::string &prefix, const std::string &command, std::deque<std::string> &params)
+bool SpanningTreeUtilities::DoOneToMany(const std::string &prefix, const std::string &command, const parameterlist &params)
 {
        std::string FullLine = ":" + prefix + " " + command;
        unsigned int words = params.size();
@@ -333,21 +251,21 @@ bool SpanningTreeUtilities::DoOneToMany(const std::string &prefix, const std::st
        return true;
 }
 
-bool SpanningTreeUtilities::DoOneToMany(const char* prefix, const char* command, std::deque<std::string> &params)
+bool SpanningTreeUtilities::DoOneToMany(const char* prefix, const char* command, const parameterlist &params)
 {
        std::string spfx = prefix;
        std::string scmd = command;
        return this->DoOneToMany(spfx, scmd, params);
 }
 
-bool SpanningTreeUtilities::DoOneToAllButSender(const char* prefix, const char* command, std::deque<std::string> &params, std::string omit)
+bool SpanningTreeUtilities::DoOneToAllButSender(const char* prefix, const char* command, const parameterlist &params, std::string omit)
 {
        std::string spfx = prefix;
        std::string scmd = command;
        return this->DoOneToAllButSender(spfx, scmd, params, omit);
 }
 
-bool SpanningTreeUtilities::DoOneToOne(const std::string &prefix, const std::string &command, std::deque<std::string> &params, std::string target)
+bool SpanningTreeUtilities::DoOneToOne(const std::string &prefix, const std::string &command, const parameterlist &params, std::string target)
 {
        TreeServer* Route = this->BestRouteTo(target);
        if (Route)
@@ -375,53 +293,29 @@ bool SpanningTreeUtilities::DoOneToOne(const std::string &prefix, const std::str
 void SpanningTreeUtilities::RefreshIPCache()
 {
        ValidIPs.clear();
-       for (std::vector<Link>::iterator L = LinkBlocks.begin(); L != LinkBlocks.end(); L++)
+       for (std::vector<reference<Link> >::iterator i = LinkBlocks.begin(); i != LinkBlocks.end(); ++i)
        {
-               if (L->IPAddr.empty() || L->RecvPass.empty() || L->SendPass.empty() || L->Name.empty() || !L->Port)
+               Link* L = *i;
+               if (!L->Port)
                {
-                       if (L->Name.empty())
-                       {
-                               ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"m_spanningtree: Ignoring a malformed link block (all link blocks require a name!)");
-                       }
-                       else
-                       {
-                               ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"m_spanningtree: Ignoring a link block missing recvpass, sendpass, port or ipaddr.");
-                       }
-
+                       ServerInstance->Logs->Log("m_spanningtree",LOG_DEFAULT,"m_spanningtree: Ignoring a link block without a port.");
                        /* Invalid link block */
                        continue;
                }
 
-               ValidIPs.push_back(L->IPAddr);
-
                if (L->AllowMask.length())
                        ValidIPs.push_back(L->AllowMask);
 
-               /* Needs resolving */
-               bool ipvalid = true;
-               QueryType start_type = DNS_QUERY_A;
-#ifdef IPV6
-               start_type = DNS_QUERY_AAAA;
-               if (strchr(L->IPAddr.c_str(),':'))
-               {
-                       in6_addr n;
-                       if (inet_pton(AF_INET6, L->IPAddr.c_str(), &n) < 1)
-                               ipvalid = false;
-               }
+               irc::sockets::sockaddrs dummy;
+               bool ipvalid = irc::sockets::aptosa(L->IPAddr, L->Port, dummy);
+               if ((L->IPAddr == "*") || (ipvalid))
+                       ValidIPs.push_back(L->IPAddr);
                else
-#endif
-               {
-                       in_addr n;
-                       if (inet_aton(L->IPAddr.c_str(),&n) < 1)
-                               ipvalid = false;
-               }
-
-               if (!ipvalid)
                {
                        try
                        {
-                               bool cached;
-                               SecurityIPResolver* sr = new SecurityIPResolver((Module*)this->Creator, this, ServerInstance, L->IPAddr, *L, cached, start_type);
+                               bool cached = false;
+                               SecurityIPResolver* sr = new SecurityIPResolver(Creator, this, L->IPAddr, L, cached, DNS_QUERY_AAAA);
                                ServerInstance->AddResolver(sr, cached);
                        }
                        catch (...)
@@ -431,86 +325,18 @@ void SpanningTreeUtilities::RefreshIPCache()
        }
 }
 
-void SpanningTreeUtilities::ReadConfiguration(bool rebind)
+void SpanningTreeUtilities::ReadConfiguration()
 {
-       ConfigReader* Conf = new ConfigReader(ServerInstance);
-
-       /* We don't need to worry about these being *unloaded* on the fly, only loaded,
-        * because we 'use' the interface locking the module in memory.
-        */
-       hooks.clear();
-       hooknames.clear();
-       modulelist* ml = ServerInstance->Modules->FindInterface("BufferedSocketHook");
-
-       /* Did we find any modules? */
-       if (ml)
-       {
-               /* Yes, enumerate them all to find out the hook name */
-               for (modulelist::iterator m = ml->begin(); m != ml->end(); m++)
-               {
-                       /* Make a request to it for its name, its implementing
-                        * BufferedSocketHook so we know its safe to do this
-                        */
-                       std::string name = BufferedSocketNameRequest((Module*)Creator, *m).Send();
-                       /* Build a map of them */
-                       hooks[name.c_str()] = *m;
-                       hooknames.push_back(name);
-               }
-       }
-
-       if (rebind)
-       {
-               for (unsigned int i = 0; i < Bindings.size(); i++)
-               {
-                       delete Bindings[i];
-               }
-               ServerInstance->BufferedSocketCull();
-               Bindings.clear();
-
-               for (int j = 0; j < Conf->Enumerate("bind"); j++)
-               {
-                       std::string Type = Conf->ReadValue("bind","type",j);
-                       std::string IP = Conf->ReadValue("bind","address",j);
-                       std::string Port = Conf->ReadValue("bind","port",j);
-                       std::string transport = Conf->ReadValue("bind","transport",j);
-                       if (Type == "servers")
-                       {
-                               irc::portparser portrange(Port, false);
-                               int portno = -1;
-
-                               if (IP == "*")
-                                       IP.clear();
-
-                               while ((portno = portrange.GetToken()))
-                               {
-                                       if ((!transport.empty()) && (hooks.find(transport.c_str()) ==  hooks.end()))
-                                       {
-                                               throw CoreException("Can't find transport type '"+transport+"' for port "+IP+":"+Port+" - maybe you forgot to load it BEFORE m_spanningtree in your config file?");
-                                               break;
-                                       }
-
-                                       ServerSocketListener *listener = new ServerSocketListener(ServerInstance, this, portno, (char *)IP.c_str());
-                                       if (listener->GetFd() == -1)
-                                       {
-                                               delete listener;
-                                               continue;
-                                       }
-
-                                       if (!transport.empty())
-                                               listener->AddIOHook(hooks[transport.c_str()]);
-
-                                       Bindings.push_back(listener);
-                               }
-                       }
-               }
-       }
-       FlatLinks = Conf->ReadFlag("security","flatlinks",0);
-       HideULines = Conf->ReadFlag("security","hideulines",0);
-       AnnounceTSChange = Conf->ReadFlag("options","announcets",0);
-       ChallengeResponse = !Conf->ReadFlag("security", "disablehmac", 0);
-       quiet_bursts = Conf->ReadFlag("performance", "quietbursts", 0);
-       PingWarnTime = Conf->ReadInteger("options", "pingwarning", 0, true);
-       PingFreq = Conf->ReadInteger("options", "serverpingfreq", 0, true);
+       ConfigTag* security = ServerInstance->Config->ConfValue("security");
+       ConfigTag* options = ServerInstance->Config->ConfValue("options");
+       FlatLinks = security->getBool("flatlinks");
+       HideULines = security->getBool("hideulines");
+       AnnounceTSChange = options->getBool("announcets");
+       AllowOptCommon = options->getBool("allowmismatch");
+       ChallengeResponse = !security->getBool("disablehmac");
+       quiet_bursts = ServerInstance->Config->ConfValue("performance")->getBool("quietbursts");
+       PingWarnTime = options->getInt("pingwarning");
+       PingFreq = options->getInt("serverpingfreq");
 
        if (PingFreq == 0)
                PingFreq = 60;
@@ -518,159 +344,100 @@ void SpanningTreeUtilities::ReadConfiguration(bool rebind)
        if (PingWarnTime < 0 || PingWarnTime > PingFreq - 1)
                PingWarnTime = 0;
 
+       AutoconnectBlocks.clear();
        LinkBlocks.clear();
-       ValidIPs.clear();
-       for (int j = 0; j < Conf->Enumerate("link"); j++)
+       ConfigTagList tags = ServerInstance->Config->ConfTags("link");
+       for(ConfigIter i = tags.first; i != tags.second; ++i)
        {
-               Link L;
-               std::string Allow = Conf->ReadValue("link", "allowmask", j);
-               L.Name = (Conf->ReadValue("link", "name", j)).c_str();
-               L.AllowMask = Allow;
-               L.IPAddr = Conf->ReadValue("link", "ipaddr", j);
-               L.FailOver = Conf->ReadValue("link", "failover", j).c_str();
-               L.Port = Conf->ReadInteger("link", "port", j, true);
-               L.SendPass = Conf->ReadValue("link", "sendpass", j);
-               L.RecvPass = Conf->ReadValue("link", "recvpass", j);
-               L.Fingerprint = Conf->ReadValue("link", "fingerprint", j);
-               L.AutoConnect = Conf->ReadInteger("link", "autoconnect", j, true);
-               L.HiddenFromStats = Conf->ReadFlag("link", "statshidden", j);
-               L.Timeout = Conf->ReadInteger("link", "timeout", j, true);
-               L.Hook = Conf->ReadValue("link", "transport", j);
-               L.Bind = Conf->ReadValue("link", "bind", j);
-               L.Hidden = Conf->ReadFlag("link", "hidden", j);
-
-               if ((!L.Hook.empty()) && (hooks.find(L.Hook.c_str()) ==  hooks.end()))
-               {
-                       throw CoreException("Can't find transport type '"+L.Hook+"' for link '"+assign(L.Name)+"' - maybe you forgot to load it BEFORE m_spanningtree in your config file? Skipping <link> tag completely.");
-                       continue;
-
-               }
-
-               // Fix: Only trip autoconnects if this wouldn't delay autoconnect..
-               if (L.NextConnectTime > ((time_t)(ServerInstance->Time() + L.AutoConnect)))
-                       L.NextConnectTime = ServerInstance->Time() + L.AutoConnect;
-
-               if (L.Name.find('.') == std::string::npos)
-                       throw CoreException("The link name '"+assign(L.Name)+"' is invalid and must contain at least one '.' character");
-
-               if (L.Name.length() > 64)
-                       throw CoreException("The link name '"+assign(L.Name)+"' is longer than 64 characters!");
-
-               if ((!L.IPAddr.empty()) && (!L.RecvPass.empty()) && (!L.SendPass.empty()) && (!L.Name.empty()) && (L.Port))
+               ConfigTag* tag = i->second;
+               reference<Link> L = new Link(tag);
+               std::string linkname = tag->getString("name");
+               L->Name = linkname.c_str();
+               L->AllowMask = tag->getString("allowmask");
+               L->IPAddr = tag->getString("ipaddr");
+               L->Port = tag->getInt("port");
+               L->SendPass = tag->getString("sendpass", tag->getString("password"));
+               L->RecvPass = tag->getString("recvpass", tag->getString("password"));
+               L->Fingerprint = tag->getString("fingerprint");
+               L->HiddenFromStats = tag->getBool("statshidden");
+               L->Timeout = tag->getInt("timeout", 30);
+               L->Hook = tag->getString("ssl");
+               L->Bind = tag->getString("bind");
+               L->Hidden = tag->getBool("hidden");
+
+               if (L->Name.empty())
+                       throw ModuleException("Invalid configuration, found a link tag without a name!" + (!L->IPAddr.empty() ? " IP address: "+L->IPAddr : ""));
+
+               if (L->Name.find('.') == std::string::npos)
+                       throw ModuleException("The link name '"+assign(L->Name)+"' is invalid as it must contain at least one '.' character");
+
+               if (L->Name.length() > 64)
+                       throw ModuleException("The link name '"+assign(L->Name)+"' is invalid as it is longer than 64 characters");
+
+               if (L->RecvPass.empty())
+                       throw ModuleException("Invalid configuration for server '"+assign(L->Name)+"', recvpass not defined");
+
+               if (L->SendPass.empty())
+                       throw ModuleException("Invalid configuration for server '"+assign(L->Name)+"', sendpass not defined");
+
+               if ((L->SendPass.find(' ') != std::string::npos) || (L->RecvPass.find(' ') != std::string::npos))
+                       throw ModuleException("Link block '" + assign(L->Name) + "' has a password set that contains a space character which is invalid");
+
+               if ((L->SendPass[0] == ':') || (L->RecvPass[0] == ':'))
+                       throw ModuleException("Link block '" + assign(L->Name) + "' has a password set that begins with a colon (:) which is invalid");
+
+               if (L->IPAddr.empty())
                {
-                       if (Allow.length())
-                               ValidIPs.push_back(Allow);
-
-                       ValidIPs.push_back(L.IPAddr);
-
-                       /* Needs resolving */
-                       bool ipvalid = true;
-                       QueryType start_type = DNS_QUERY_A;
-#ifdef IPV6
-                       start_type = DNS_QUERY_AAAA;
-                       if (strchr(L.IPAddr.c_str(),':'))
-                       {
-                               in6_addr n;
-                               if (inet_pton(AF_INET6, L.IPAddr.c_str(), &n) < 1)
-                                       ipvalid = false;
-                       }
-                       else
-                       {
-                               in_addr n;
-                               if (inet_aton(L.IPAddr.c_str(),&n) < 1)
-                                       ipvalid = false;
-                       }
-#else
-                       in_addr n;
-                       if (inet_aton(L.IPAddr.c_str(),&n) < 1)
-                               ipvalid = false;
-#endif
-
-                       if (!ipvalid)
-                       {
-                               try
-                               {
-                                       bool cached;
-                                       SecurityIPResolver* sr = new SecurityIPResolver((Module*)this->Creator, this, ServerInstance, L.IPAddr, L, cached, start_type);
-                                       ServerInstance->AddResolver(sr, cached);
-                               }
-                               catch (...)
-                               {
-                               }
-                       }
+                       L->IPAddr = "*";
+                       ServerInstance->Logs->Log("m_spanningtree",LOG_DEFAULT,"Configuration warning: Link block '" + assign(L->Name) + "' has no IP defined! This will allow any IP to connect as this server, and MAY not be what you want.");
                }
-               else
-               {
-                       if (L.IPAddr.empty())
-                       {
-                               L.IPAddr = "*";
-                               ValidIPs.push_back("*");
-                               ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"Configuration warning: Link block " + assign(L.Name) + " has no IP defined! This will allow any IP to connect as this server, and MAY not be what you want.");
-                       }
-
-                       if (L.RecvPass.empty())
-                       {
-                               throw CoreException("Invalid configuration for server '"+assign(L.Name)+"', recvpass not defined!");
-                       }
 
-                       if (L.SendPass.empty())
-                       {
-                               throw CoreException("Invalid configuration for server '"+assign(L.Name)+"', sendpass not defined!");
-                       }
-
-                       if (L.Name.empty())
-                       {
-                               throw CoreException("Invalid configuration, link tag without a name! IP address: "+L.IPAddr);
-                       }
-
-                       if (!L.Port)
-                       {
-                               ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"Configuration warning: Link block " + assign(L.Name) + " has no port defined, you will not be able to /connect it.");
-                       }
-               }
+               if (!L->Port)
+                       ServerInstance->Logs->Log("m_spanningtree",LOG_DEFAULT,"Configuration warning: Link block '" + assign(L->Name) + "' has no port defined, you will not be able to /connect it.");
 
+               L->Fingerprint.erase(std::remove(L->Fingerprint.begin(), L->Fingerprint.end(), ':'), L->Fingerprint.end());
                LinkBlocks.push_back(L);
        }
-       delete Conf;
-}
 
-void SpanningTreeUtilities::DoFailOver(Link* x)
-{
-       if (x->FailOver.length())
+       tags = ServerInstance->Config->ConfTags("autoconnect");
+       for(ConfigIter i = tags.first; i != tags.second; ++i)
        {
-               if (x->FailOver == x->Name)
+               ConfigTag* tag = i->second;
+               reference<Autoconnect> A = new Autoconnect(tag);
+               A->Period = tag->getInt("period");
+               A->NextConnectTime = ServerInstance->Time() + A->Period;
+               A->position = -1;
+               irc::spacesepstream ss(tag->getString("server"));
+               std::string server;
+               while (ss.GetToken(server))
                {
-                       this->ServerInstance->SNO->WriteToSnoMask('l', "FAILOVER: Some muppet configured the failover for server \002%s\002 to point at itself. Not following it!", x->Name.c_str());
-                       return;
+                       A->servers.push_back(server);
                }
-               Link* TryThisOne = this->FindLink(x->FailOver.c_str());
-               if (TryThisOne)
+
+               if (A->Period <= 0)
                {
-                       TreeServer* CheckDupe = this->FindServer(x->FailOver.c_str());
-                       if (CheckDupe)
-                       {
-                               ServerInstance->Logs->Log("m_spanningtree",DEBUG,"Skipping existing failover: %s", x->FailOver.c_str());
-                       }
-                       else
-                       {
-                               this->ServerInstance->SNO->WriteToSnoMask('l', "FAILOVER: Trying failover link for \002%s\002: \002%s\002...", x->Name.c_str(), TryThisOne->Name.c_str());
-                               Creator->ConnectServer(TryThisOne);
-                       }
+                       throw ModuleException("Invalid configuration for autoconnect, period not a positive integer!");
                }
-               else
+
+               if (A->servers.empty())
                {
-                       this->ServerInstance->SNO->WriteToSnoMask('l', "FAILOVER: Invalid failover server specified for server \002%s\002, will not follow!", x->Name.c_str());
+                       throw ModuleException("Invalid configuration for autoconnect, server cannot be empty!");
                }
+
+               AutoconnectBlocks.push_back(A);
        }
+
+       RefreshIPCache();
 }
 
 Link* SpanningTreeUtilities::FindLink(const std::string& name)
 {
-       for (std::vector<Link>::iterator x = LinkBlocks.begin(); x != LinkBlocks.end(); x++)
+       for (std::vector<reference<Link> >::iterator i = LinkBlocks.begin(); i != LinkBlocks.end(); ++i)
        {
+               Link* x = *i;
                if (InspIRCd::Match(x->Name.c_str(), name.c_str()))
                {
-                       return &(*x);
+                       return x;
                }
        }
        return NULL;