]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/utils.cpp
NEVER use the two-param assign unless you want your string padding to len bytes with \0!
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / utils.cpp
index abc251ab09844ebb65242c9aa0150713565d68e2..cfbb9add0b8e308a1d404f3964ee2f4b459c0f5d 100644 (file)
@@ -2,7 +2,7 @@
  *       | Inspire Internet Relay Chat Daemon |
  *       +------------------------------------+
  *
- *  InspIRCd: (C) 2002-2007 InspIRCd Development Team
+ *  InspIRCd: (C) 2002-2008 InspIRCd Development Team
  * See: http://www.inspircd.org/wiki/index.php/Credits
  *
  * This program is free but copyrighted software; see
 
 /* $ModDep: m_spanningtree/timesynctimer.h m_spanningtree/resolvers.h m_spanningtree/main.h m_spanningtree/utils.h m_spanningtree/treeserver.h m_spanningtree/link.h m_spanningtree/treesocket.h */
 
-bool SpanningTreeUtilities::IsSID(const std::string &str)
-{
-       /* Returns true if the string given is exactly 3 characters long,
-        * starts with a digit, and the other two characters are A-Z or digits
-        */
-       return ((str.length() == 3) && isdigit(str[0]) &&
-                       ((str[1] >= 'A' && str[1] <= 'Z') || isdigit(str[1])) &&
-                        ((str[2] >= 'A' && str[2] <= 'Z') || isdigit(str[2])));
-}
-
 /** Yay for fast searches!
  * This is hundreds of times faster than recursion
  * or even scanning a linked list, especially when
@@ -47,7 +37,7 @@ bool SpanningTreeUtilities::IsSID(const std::string &str)
  */
 TreeServer* SpanningTreeUtilities::FindServer(const std::string &ServerName)
 {
-       if (IsSID(ServerName))
+       if (this->ServerInstance->IsSID(ServerName))
                return this->FindServerID(ServerName);
 
        server_hash::iterator iter = serverlist.find(ServerName.c_str());
@@ -61,66 +51,6 @@ TreeServer* SpanningTreeUtilities::FindServer(const std::string &ServerName)
        }
 }
 
-TreeServer* SpanningTreeUtilities::FindRemoteBurstServer(TreeServer* Server)
-{
-       server_hash::iterator iter = RemoteServersBursting.find(Server->GetName().c_str());
-       if (iter != RemoteServersBursting.end())
-               return iter->second;
-       else
-               return NULL;
-}
-
-TreeSocket* SpanningTreeUtilities::FindBurstingServer(const std::string &ServerName)
-{
-       std::map<irc::string,TreeSocket*>::iterator iter;
-       iter = burstingserverlist.find(ServerName.c_str());
-       if (iter != burstingserverlist.end())
-       {
-               return iter->second;
-       }
-       else
-       {
-               return NULL;
-       }
-}
-
-void SpanningTreeUtilities::SetRemoteBursting(TreeServer* Server, bool bursting)
-{
-       server_hash::iterator iter = RemoteServersBursting.find(Server->GetName().c_str());
-       if (bursting)
-       {
-               if (iter == RemoteServersBursting.end())
-                       RemoteServersBursting.insert(make_pair(Server->GetName(), Server));
-               else return;
-       }
-       else
-       {
-               if (iter != RemoteServersBursting.end())
-                       RemoteServersBursting.erase(iter);
-               else return;
-       }
-       ServerInstance->Log(DEBUG,"Server %s is %sbursting nicknames", Server->GetName().c_str(), bursting ? "" : "no longer ");
-}
-
-void SpanningTreeUtilities::AddBurstingServer(const std::string &ServerName, TreeSocket* s)
-{
-       std::map<irc::string,TreeSocket*>::iterator iter = burstingserverlist.find(ServerName.c_str());
-       if (iter == burstingserverlist.end())
-               burstingserverlist[ServerName.c_str()] = s;
-}
-
-void SpanningTreeUtilities::DelBurstingServer(TreeSocket* s)
-{
-        for (std::map<irc::string,TreeSocket*>::iterator iter = burstingserverlist.begin(); iter != burstingserverlist.end(); iter++)
-        {
-                if (iter->second == s)
-                {
-                        burstingserverlist.erase(iter);
-                        return;
-                }
-        }
-}
-
 /** Returns the locally connected server we must route a
  * message through to reach server 'ServerName'. This
  * only applies to one-to-one and not one-to-many routing.
@@ -152,7 +82,7 @@ TreeServer* SpanningTreeUtilities::FindServerMask(const std::string &ServerName)
 {
        for (server_hash::iterator i = serverlist.begin(); i != serverlist.end(); i++)
        {
-               if (match(i->first.c_str(),ServerName.c_str()))
+               if (match(i->first,ServerName))
                        return i->second;
        }
        return NULL;
@@ -177,11 +107,11 @@ SpanningTreeUtilities::SpanningTreeUtilities(InspIRCd* Instance, ModuleSpanningT
 {
        Bindings.clear();
 
-       lines_to_apply = 0;
+       ServerInstance->Logs->Log("m_spanningtree",DEBUG,"***** Using SID for hash: %s *****", ServerInstance->Config->GetSID().c_str());
 
        this->TreeRoot = new TreeServer(this, ServerInstance, ServerInstance->Config->ServerName, ServerInstance->Config->ServerDesc, ServerInstance->Config->GetSID());
 
-       modulelist* ml = ServerInstance->Modules->FindInterface("InspSocketHook");
+       modulelist* ml = ServerInstance->Modules->FindInterface("BufferedSocketHook");
 
        /* Did we find any modules? */
        if (ml)
@@ -190,9 +120,9 @@ SpanningTreeUtilities::SpanningTreeUtilities(InspIRCd* Instance, ModuleSpanningT
                for (modulelist::iterator m = ml->begin(); m != ml->end(); m++)
                {
                        /* Make a request to it for its name, its implementing
-                        * InspSocketHook so we know its safe to do this
+                        * BufferedSocketHook so we know its safe to do this
                         */
-                       std::string name = InspSocketNameRequest((Module*)Creator, *m).Send();
+                       std::string name = BufferedSocketNameRequest((Module*)Creator, *m).Send();
                        /* Build a map of them */
                        hooks[name.c_str()] = *m;
                        hooknames.push_back(name);
@@ -220,7 +150,7 @@ SpanningTreeUtilities::~SpanningTreeUtilities()
                }
        }
        delete TreeRoot;
-       ServerInstance->InspSocketCull();
+       ServerInstance->BufferedSocketCull();
 }
 
 void SpanningTreeUtilities::AddThisServer(TreeServer* server, TreeServerList &list)
@@ -230,27 +160,19 @@ void SpanningTreeUtilities::AddThisServer(TreeServer* server, TreeServerList &li
 }
 
 /* returns a list of DIRECT servernames for a specific channel */
-void SpanningTreeUtilities::GetListOfServersForChannel(chanrec* c, TreeServerList &list, char status, const CUList &exempt_list)
+void SpanningTreeUtilities::GetListOfServersForChannel(Channel* c, TreeServerList &list, char status, const CUList &exempt_list)
 {
-       CUList *ulist;
-       switch (status)
-       {
-               case '@':
-                       ulist = c->GetOppedUsers();
-               break;
-               case '%':
-                       ulist = c->GetHalfoppedUsers();
-               break;
-               case '+':
-                       ulist = c->GetVoicedUsers();
-               break;
-               default:
-                       ulist = c->GetUsers();
-               break;
-       }
+       CUList *ulist = c->GetUsers();
+
        for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               if ((i->first->GetFd() < 0) && (exempt_list.find(i->first) == exempt_list.end()))
+               if (IS_LOCAL(i->first))
+                       continue;
+
+               if (status && !strchr(c->GetAllPrefixChars(i->first), status))
+                       continue;
+
+               if (exempt_list.find(i->first) == exempt_list.end())
                {
                        TreeServer* best = this->BestRouteTo(i->first->server);
                        if (best)
@@ -269,7 +191,7 @@ bool SpanningTreeUtilities::DoOneToAllButSenderRaw(const std::string &data, cons
                if (params.size() >= 2)
                {
                        /* Prefixes */
-                       if ((*(params[0].c_str()) == '@') || (*(params[0].c_str()) == '%') || (*(params[0].c_str()) == '+'))
+                       if (ServerInstance->Modes->FindPrefix(params[0][0]))
                        {
                                pfx = params[0][0];
                                params[0] = params[0].substr(1, params[0].length()-1);
@@ -277,7 +199,7 @@ bool SpanningTreeUtilities::DoOneToAllButSenderRaw(const std::string &data, cons
                        if ((*(params[0].c_str()) != '#') && (*(params[0].c_str()) != '$'))
                        {
                                // special routing for private messages/notices
-                               userrec* d = ServerInstance->FindNick(params[0]);
+                               User* d = ServerInstance->FindNick(params[0]);
                                if (d)
                                {
                                        std::deque<std::string> par;
@@ -297,9 +219,9 @@ bool SpanningTreeUtilities::DoOneToAllButSenderRaw(const std::string &data, cons
                        }
                        else
                        {
-                               chanrec* c = ServerInstance->FindChan(params[0]);
-                               userrec* u = ServerInstance->FindNick(prefix);
-                               if (c && u)
+                               Channel* c = ServerInstance->FindChan(params[0]);
+                               User* u = ServerInstance->FindNick(prefix);
+                               if (c)
                                {
                                        CUList elist;
                                        TreeServerList list;
@@ -426,42 +348,55 @@ void SpanningTreeUtilities::RefreshIPCache()
        ValidIPs.clear();
        for (std::vector<Link>::iterator L = LinkBlocks.begin(); L != LinkBlocks.end(); L++)
        {
-               if ((!L->IPAddr.empty()) && (!L->RecvPass.empty()) && (!L->SendPass.empty()) && (!L->Name.empty()) && (L->Port))
+               if (L->IPAddr.empty() || L->RecvPass.empty() || L->SendPass.empty() || L->Name.empty() || L->Port)
                {
-                       ValidIPs.push_back(L->IPAddr);
-
-                       if (L->AllowMask.length())
-                               ValidIPs.push_back(L->AllowMask);
-
-                       /* Needs resolving */
-                       bool ipvalid = true;
-                       QueryType start_type = DNS_QUERY_A;
-#ifdef IPV6
-                       start_type = DNS_QUERY_AAAA;
-                       if (strchr(L->IPAddr.c_str(),':'))
+                       if (L->Name.empty())
                        {
-                               in6_addr n;
-                               if (inet_pton(AF_INET6, L->IPAddr.c_str(), &n) < 1)
-                                       ipvalid = false;
+                               ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"m_spanningtree: Ignoring a malformed link block (all link blocks require a name!)");
                        }
                        else
+                       {
+                               ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"m_spanningtree: Ignoring a link block missing recvpass, sendpass, port or ipaddr.");
+                       }
+
+                       /* Invalid link block */
+                       continue;
+               }
+
+               ValidIPs.push_back(L->IPAddr);
+
+               if (L->AllowMask.length())
+                       ValidIPs.push_back(L->AllowMask);
+
+               /* Needs resolving */
+               bool ipvalid = true;
+               QueryType start_type = DNS_QUERY_A;
+#ifdef IPV6
+               start_type = DNS_QUERY_AAAA;
+               if (strchr(L->IPAddr.c_str(),':'))
+               {
+                       in6_addr n;
+                       if (inet_pton(AF_INET6, L->IPAddr.c_str(), &n) < 1)
+                               ipvalid = false;
+               }
+               else
 #endif
+               {
+                       in_addr n;
+                       if (inet_aton(L->IPAddr.c_str(),&n) < 1)
+                               ipvalid = false;
+               }
+
+               if (!ipvalid)
+               {
+                       try
                        {
-                               in_addr n;
-                               if (inet_aton(L->IPAddr.c_str(),&n) < 1)
-                                       ipvalid = false;
+                               bool cached;
+                               SecurityIPResolver* sr = new SecurityIPResolver((Module*)this->Creator, this, ServerInstance, L->IPAddr, *L, cached, start_type);
+                               ServerInstance->AddResolver(sr, cached);
                        }
-                       if (!ipvalid)
+                       catch (...)
                        {
-                               try
-                               {
-                                       bool cached;
-                                       SecurityIPResolver* sr = new SecurityIPResolver((Module*)this->Creator, this, ServerInstance, L->IPAddr, *L, cached, start_type);
-                                       ServerInstance->AddResolver(sr, cached);
-                               }
-                               catch (...)
-                               {
-                               }
                        }
                }
        }
@@ -472,6 +407,14 @@ void SpanningTreeUtilities::ReadConfiguration(bool rebind)
        ConfigReader* Conf = new ConfigReader(ServerInstance);
        if (rebind)
        {
+               for (unsigned int i = 0; i < Bindings.size(); i++)
+               {
+                       ServerInstance->SE->DelFd(Bindings[i]);
+                       Bindings[i]->Close();
+               }
+               ServerInstance->BufferedSocketCull();
+               Bindings.clear();
+
                for (int j = 0; j < Conf->Enumerate("bind"); j++)
                {
                        std::string Type = Conf->ReadValue("bind","type",j);
@@ -482,39 +425,38 @@ void SpanningTreeUtilities::ReadConfiguration(bool rebind)
                        {
                                irc::portparser portrange(Port, false);
                                int portno = -1;
+
+                               if (IP == "*")
+                                       IP.clear();
+
                                while ((portno = portrange.GetToken()))
                                {
-                                       if (IP == "*")
-                                               IP.clear();
-
                                        if ((!transport.empty()) && (hooks.find(transport.c_str()) ==  hooks.end()))
                                        {
-                                               ServerInstance->Log(DEFAULT,"m_spanningtree: WARNING: Can't find transport type '%s' for port %s:%s - maybe you forgot to load it BEFORE m_spanningtree in your config file? - Skipping this port binding", transport.c_str(), IP.c_str(), Port.c_str());
+                                               throw CoreException("Can't find transport type '"+transport+"' for port "+IP+":"+Port+" - maybe you forgot to load it BEFORE m_spanningtree in your config file?");
                                                break;
                                        }
 
                                        TreeSocket* listener = new TreeSocket(this, ServerInstance, IP.c_str(), portno, true, 10, transport.empty() ? NULL : hooks[transport.c_str()]);
                                        if (listener->GetState() == I_LISTENING)
                                        {
-                                               ServerInstance->Log(DEFAULT,"m_spanningtree: Binding server port %s:%d successful!", IP.c_str(), portno);
+                                               ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"m_spanningtree: Binding server port %s:%d successful!", IP.c_str(), portno);
                                                Bindings.push_back(listener);
                                        }
                                        else
                                        {
-                                               ServerInstance->Log(DEFAULT,"m_spanningtree: Warning: Failed to bind server port: %s:%d: %s",IP.c_str(), portno, strerror(errno));
+                                               ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"m_spanningtree: Warning: Failed to bind server port: %s:%d: %s",IP.c_str(), portno, strerror(errno));
                                                listener->Close();
                                        }
                                }
                        }
                }
        }
-       FlatLinks = Conf->ReadFlag("options","flatlinks",0);
-       HideULines = Conf->ReadFlag("options","hideulines",0);
+       FlatLinks = Conf->ReadFlag("security","flatlinks",0);
+       HideULines = Conf->ReadFlag("security","hideulines",0);
        AnnounceTSChange = Conf->ReadFlag("options","announcets",0);
-       EnableTimeSync = Conf->ReadFlag("timesync","enable",0);
-       MasterTime = Conf->ReadFlag("timesync", "master", 0);
-       ChallengeResponse = !Conf->ReadFlag("options", "disablehmac", 0);
-       quiet_bursts = Conf->ReadFlag("options", "quietbursts", 0);
+       ChallengeResponse = !Conf->ReadFlag("security", "disablehmac", 0);
+       quiet_bursts = Conf->ReadFlag("performance", "quietbursts", 0);
        PingWarnTime = Conf->ReadInteger("options", "pingwarning", 0, true);
        PingFreq = Conf->ReadInteger("options", "serverpingfreq", 0, true);
 
@@ -546,8 +488,7 @@ void SpanningTreeUtilities::ReadConfiguration(bool rebind)
 
                if ((!L.Hook.empty()) && (hooks.find(L.Hook.c_str()) ==  hooks.end()))
                {
-                       ServerInstance->Log(DEFAULT,"m_spanningtree: WARNING: Can't find transport type '%s' for link '%s' - maybe you forgot to load it BEFORE m_spanningtree in your config file? Skipping <link> tag completely.",
-                       L.Hook.c_str(), L.Name.c_str());
+                       throw CoreException("Can't find transport type '"+L.Hook+"' for link '"+assign(L.Name)+"' - maybe you forgot to load it BEFORE m_spanningtree in your config file? Skipping <link> tag completely.");
                        continue;
 
                }
@@ -556,13 +497,19 @@ void SpanningTreeUtilities::ReadConfiguration(bool rebind)
                /* Bugfix by brain, do not allow people to enter bad configurations */
                if (L.Name != ServerInstance->Config->ServerName)
                {
+                       if (L.Name.find('.') == std::string::npos)
+                               throw CoreException("The link name '"+assign(L.Name)+"' is invalid and must contain at least one '.' character");
+
+                       if (L.Name.length() > 64)
+                               throw CoreException("The link name '"+assign(L.Name)+"' is longer than 64 characters!");
+
                        if ((!L.IPAddr.empty()) && (!L.RecvPass.empty()) && (!L.SendPass.empty()) && (!L.Name.empty()) && (L.Port))
                        {
-                               ValidIPs.push_back(L.IPAddr);
-
                                if (Allow.length())
                                        ValidIPs.push_back(Allow);
 
+                               ValidIPs.push_back(L.IPAddr);
+
                                /* Needs resolving */
                                bool ipvalid = true;
                                QueryType start_type = DNS_QUERY_A;
@@ -598,39 +545,46 @@ void SpanningTreeUtilities::ReadConfiguration(bool rebind)
                                        {
                                        }
                                }
-
-                               LinkBlocks.push_back(L);
                        }
                        else
                        {
                                if (L.IPAddr.empty())
                                {
-                                       ServerInstance->Log(DEFAULT,"Invalid configuration for server '%s', IP address not defined!",L.Name.c_str());
+                                       L.IPAddr = "*";
+                                       ValidIPs.push_back("*");
+                                       ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"Configuration warning: Link block " + assign(L.Name) + " has no IP defined! This will allow any IP to connect as this server, and MAY not be what you want.");
                                }
-                               else if (L.RecvPass.empty())
+
+                               if (L.RecvPass.empty())
                                {
-                                       ServerInstance->Log(DEFAULT,"Invalid configuration for server '%s', recvpass not defined!",L.Name.c_str());
+                                       throw CoreException("Invalid configuration for server '"+assign(L.Name)+"', recvpass not defined!");
                                }
-                               else if (L.SendPass.empty())
+
+                               if (L.SendPass.empty())
                                {
-                                       ServerInstance->Log(DEFAULT,"Invalid configuration for server '%s', sendpass not defined!",L.Name.c_str());
+                                       throw CoreException("Invalid configuration for server '"+assign(L.Name)+"', sendpass not defined!");
                                }
-                               else if (L.Name.empty())
+
+                               if (L.Name.empty())
                                {
-                                       ServerInstance->Log(DEFAULT,"Invalid configuration, link tag without a name!");
+                                       throw CoreException("Invalid configuration, link tag without a name! IP address: "+L.IPAddr);
                                }
-                               else if (!L.Port)
+
+                               if (!L.Port)
                                {
-                                       ServerInstance->Log(DEFAULT,"Invalid configuration for server '%s', no port specified!",L.Name.c_str());
+                                       ServerInstance->Logs->Log("m_spanningtree",DEFAULT,"Configuration warning: Link block " + assign(L.Name) + " has no port defined, you will not be able to /connect it.");
                                }
                        }
+
+
+                       LinkBlocks.push_back(L);
                }
                else
                {
-                       ServerInstance->Log(DEFAULT,"Invalid configuration for server '%s', link tag has the same server name as the local server!",L.Name.c_str());
+                       throw CoreException("Invalid configuration for server '"+assign(L.Name)+"', link tag has the same server name as the local server!");
                }
        }
-       DELETE(Conf);
+       delete Conf;
 }
 
 void SpanningTreeUtilities::DoFailOver(Link* x)
@@ -648,7 +602,7 @@ void SpanningTreeUtilities::DoFailOver(Link* x)
                        TreeServer* CheckDupe = this->FindServer(x->FailOver.c_str());
                        if (CheckDupe)
                        {
-                               ServerInstance->Log(DEBUG,"Skipping existing failover: %s", x->FailOver.c_str());
+                               ServerInstance->Logs->Log("m_spanningtree",DEBUG,"Skipping existing failover: %s", x->FailOver.c_str());
                        }
                        else
                        {