]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree/utils.cpp
Clean up duplicated link snomask messages on errors
[user/henk/code/inspircd.git] / src / modules / m_spanningtree / utils.cpp
index 7b6ea1565abda61914d2fccecc4bf5a91bc9e99f..da3417de9735d60a8c5a85d047e507a20b8c1869 100644 (file)
@@ -14,7 +14,6 @@
 #include "inspircd.h"
 #include "socket.h"
 #include "xline.h"
-#include "../transport.h"
 #include "socketengine.h"
 
 #include "main.h"
 #include "treesocket.h"
 #include "resolvers.h"
 
-/* $ModDep: m_spanningtree/resolvers.h m_spanningtree/main.h m_spanningtree/utils.h m_spanningtree/treeserver.h m_spanningtree/link.h m_spanningtree/treesocket.h */
-
 /* Create server sockets off a listener. */
-void ServerSocketListener::OnAcceptReady(int newsock)
+ModResult ModuleSpanningTree::OnAcceptConnection(int newsock, ListenSocket* from, irc::sockets::sockaddrs* client, irc::sockets::sockaddrs* server)
 {
-       bool found = false;
-       int port;
-       std::string incomingip;
-       irc::sockets::satoap(&client, incomingip, port);
-       char *ip = const_cast<char*>(incomingip.c_str());
-
-       found = (std::find(Utils->ValidIPs.begin(), Utils->ValidIPs.end(), ip) != Utils->ValidIPs.end());
-       if (!found)
-       {
-               for (std::vector<std::string>::iterator i = Utils->ValidIPs.begin(); i != Utils->ValidIPs.end(); i++)
-               {
-                       if (*i == "*" || irc::sockets::MatchCIDR(ip, *i))
-                       {
-                               found = true;
-                               break;
-                       }
-               }
+       if (from->bind_tag->getString("type") != "servers")
+               return MOD_RES_PASSTHRU;
 
-               if (!found)
+       std::string incomingip = client->addr();
+
+       for (std::vector<std::string>::iterator i = Utils->ValidIPs.begin(); i != Utils->ValidIPs.end(); i++)
+       {
+               if (*i == "*" || *i == incomingip || irc::sockets::cidr_mask(*i).match(*client))
                {
-                       ServerInstance->SNO->WriteToSnoMask('l', "Server connection from %s denied (no link blocks with that IP address)", ip);
-                       ServerInstance->SE->Close(newsock);
-                       return;
+                       /* we don't need to do anything with the pointer, creating it stores it in the necessary places */
+                       new TreeSocket(Utils, newsock, from, client, server);
+                       return MOD_RES_ALLOW;
                }
        }
-
-       /* we don't need to do anything with the pointer, creating it stores it in the necessary places */
-       TreeSocket* ts = new TreeSocket(Utils, newsock, ip, NULL, Hook);
-
-       if (Hook)
-               Hook->OnStreamSocketAccept(ts, &client, &server);
-
-       return;
+       ServerInstance->SNO->WriteToSnoMask('l', "Server connection from %s denied (no link blocks with that IP address)", incomingip.c_str());
+       return MOD_RES_DENY;
 }
 
 /** Yay for fast searches!
@@ -152,18 +132,11 @@ SpanningTreeUtilities::SpanningTreeUtilities(ModuleSpanningTree* C) : Creator(C)
        ServerInstance->Logs->Log("m_spanningtree",DEBUG,"***** Using SID for hash: %s *****", ServerInstance->Config->GetSID().c_str());
 
        this->TreeRoot = new TreeServer(this, ServerInstance->Config->ServerName, ServerInstance->Config->ServerDesc, ServerInstance->Config->GetSID());
-       ServerUser = new FakeUser(TreeRoot->GetID());
-
-       this->ReadConfiguration(true);
+       this->ReadConfiguration();
 }
 
-bool SpanningTreeUtilities::cull()
+CullResult SpanningTreeUtilities::cull()
 {
-       for (unsigned int i = 0; i < Bindings.size(); i++)
-       {
-               Bindings[i]->cull();
-       }
-
        while (TreeRoot->ChildCount())
        {
                TreeServer* child_server = TreeRoot->GetChild(0);
@@ -171,22 +144,22 @@ bool SpanningTreeUtilities::cull()
                {
                        TreeSocket* sock = child_server->GetSocket();
                        sock->Close();
+                       ServerInstance->GlobalCulls.AddItem(sock);
                }
        }
 
-       ServerUser->uuid = TreeRoot->GetID();
-       if (ServerUser->cull())
-               delete ServerUser;
-       return true;
+       for(std::map<TreeSocket*, std::pair<std::string, int> >::iterator i = timeoutlist.begin(); i != timeoutlist.end(); ++i)
+       {
+               TreeSocket* s = i->first;
+               ServerInstance->GlobalCulls.AddItem(s);
+       }
+       TreeRoot->cull();
+
+       return classbase::cull();
 }
 
 SpanningTreeUtilities::~SpanningTreeUtilities()
 {
-       for (unsigned int i = 0; i < Bindings.size(); i++)
-       {
-               delete Bindings[i];
-       }
-
        delete TreeRoot;
 }
 
@@ -345,34 +318,19 @@ void SpanningTreeUtilities::RefreshIPCache()
                        continue;
                }
 
-               ValidIPs.push_back(L->IPAddr);
-
                if (L->AllowMask.length())
                        ValidIPs.push_back(L->AllowMask);
 
-               /* Needs resolving */
-               bool ipvalid = true;
-               QueryType start_type = DNS_QUERY_A;
-               start_type = DNS_QUERY_AAAA;
-               if (strchr(L->IPAddr.c_str(),':'))
-               {
-                       in6_addr n;
-                       if (inet_pton(AF_INET6, L->IPAddr.c_str(), &n) < 1)
-                               ipvalid = false;
-               }
+               irc::sockets::sockaddrs dummy;
+               bool ipvalid = irc::sockets::aptosa(L->IPAddr, L->Port, dummy);
+               if (ipvalid)
+                       ValidIPs.push_back(L->IPAddr);
                else
-               {
-                       in_addr n;
-                       if (inet_aton(L->IPAddr.c_str(),&n) < 1)
-                               ipvalid = false;
-               }
-
-               if (!ipvalid)
                {
                        try
                        {
                                bool cached;
-                               SecurityIPResolver* sr = new SecurityIPResolver(Creator, this, L->IPAddr, L, cached, start_type);
+                               SecurityIPResolver* sr = new SecurityIPResolver(Creator, this, L->IPAddr, L, cached, DNS_QUERY_AAAA);
                                ServerInstance->AddResolver(sr, cached);
                        }
                        catch (...)
@@ -382,86 +340,18 @@ void SpanningTreeUtilities::RefreshIPCache()
        }
 }
 
-void SpanningTreeUtilities::ReadConfiguration(bool rebind)
+void SpanningTreeUtilities::ReadConfiguration()
 {
-       ConfigReader* Conf = new ConfigReader;
+       ConfigReader Conf;
 
-       /* We don't need to worry about these being *unloaded* on the fly, only loaded,
-        * because we 'use' the interface locking the module in memory.
-        */
-       hooks.clear();
-       hooknames.clear();
-       modulelist* ml = ServerInstance->Modules->FindInterface("BufferedSocketHook");
-
-       /* Did we find any modules? */
-       if (ml)
-       {
-               /* Yes, enumerate them all to find out the hook name */
-               for (modulelist::iterator m = ml->begin(); m != ml->end(); m++)
-               {
-                       /* Make a request to it for its name, its implementing
-                        * BufferedSocketHook so we know its safe to do this
-                        */
-                       std::string name = BufferedSocketNameRequest((Module*)Creator, *m).Send();
-                       /* Build a map of them */
-                       hooks[name.c_str()] = *m;
-                       hooknames.push_back(name);
-               }
-       }
-
-       if (rebind)
-       {
-               for (unsigned int i = 0; i < Bindings.size(); i++)
-               {
-                       delete Bindings[i];
-               }
-               Bindings.clear();
-
-               for (int j = 0; j < Conf->Enumerate("bind"); j++)
-               {
-                       std::string Type = Conf->ReadValue("bind","type",j);
-                       std::string IP = Conf->ReadValue("bind","address",j);
-                       std::string Port = Conf->ReadValue("bind","port",j);
-                       std::string transport = Conf->ReadValue("bind","transport",j);
-                       if (Type == "servers")
-                       {
-                               irc::portparser portrange(Port, false);
-                               int portno = -1;
-
-                               if (IP == "*")
-                                       IP.clear();
-
-                               while ((portno = portrange.GetToken()))
-                               {
-                                       if ((!transport.empty()) && (hooks.find(transport.c_str()) ==  hooks.end()))
-                                       {
-                                               throw CoreException("Can't find transport type '"+transport+"' for port "+IP+":"+Port+" - maybe you forgot to load it BEFORE m_spanningtree in your config file?");
-                                               break;
-                                       }
-
-                                       ServerSocketListener *listener = new ServerSocketListener(this, portno, (char *)IP.c_str());
-                                       if (listener->GetFd() == -1)
-                                       {
-                                               delete listener;
-                                               continue;
-                                       }
-
-                                       if (!transport.empty())
-                                               listener->Hook = hooks[transport.c_str()];
-
-                                       Bindings.push_back(listener);
-                               }
-                       }
-               }
-       }
-       FlatLinks = Conf->ReadFlag("security","flatlinks",0);
-       HideULines = Conf->ReadFlag("security","hideulines",0);
-       AnnounceTSChange = Conf->ReadFlag("options","announcets",0);
-       AllowOptCommon = Conf->ReadFlag("options", "allowmismatch", 0);
-       ChallengeResponse = !Conf->ReadFlag("security", "disablehmac", 0);
-       quiet_bursts = Conf->ReadFlag("performance", "quietbursts", 0);
-       PingWarnTime = Conf->ReadInteger("options", "pingwarning", 0, true);
-       PingFreq = Conf->ReadInteger("options", "serverpingfreq", 0, true);
+       FlatLinks = Conf.ReadFlag("security","flatlinks",0);
+       HideULines = Conf.ReadFlag("security","hideulines",0);
+       AnnounceTSChange = Conf.ReadFlag("options","announcets",0);
+       AllowOptCommon = Conf.ReadFlag("options", "allowmismatch", 0);
+       ChallengeResponse = !Conf.ReadFlag("security", "disablehmac", 0);
+       quiet_bursts = Conf.ReadFlag("performance", "quietbursts", 0);
+       PingWarnTime = Conf.ReadInteger("options", "pingwarning", 0, true);
+       PingFreq = Conf.ReadInteger("options", "serverpingfreq", 0, true);
 
        if (PingFreq == 0)
                PingFreq = 60;
@@ -472,29 +362,23 @@ void SpanningTreeUtilities::ReadConfiguration(bool rebind)
        AutoconnectBlocks.clear();
        LinkBlocks.clear();
        ValidIPs.clear();
-       for (int j = 0; j < Conf->Enumerate("link"); ++j)
+       ConfigTagList tags = ServerInstance->Config->ConfTags("link");
+       for(ConfigIter i = tags.first; i != tags.second; ++i)
        {
-               reference<Link> L = new Link;
-               std::string Allow = Conf->ReadValue("link", "allowmask", j);
-               L->Name = (Conf->ReadValue("link", "name", j)).c_str();
-               L->AllowMask = Allow;
-               L->IPAddr = Conf->ReadValue("link", "ipaddr", j);
-               L->Port = Conf->ReadInteger("link", "port", j, true);
-               L->SendPass = Conf->ReadValue("link", "sendpass", j);
-               L->RecvPass = Conf->ReadValue("link", "recvpass", j);
-               L->Fingerprint = Conf->ReadValue("link", "fingerprint", j);
-               L->HiddenFromStats = Conf->ReadFlag("link", "statshidden", j);
-               L->Timeout = Conf->ReadInteger("link", "timeout", j, true);
-               L->Hook = Conf->ReadValue("link", "transport", j);
-               L->Bind = Conf->ReadValue("link", "bind", j);
-               L->Hidden = Conf->ReadFlag("link", "hidden", j);
-
-               if ((!L->Hook.empty()) && (hooks.find(L->Hook.c_str()) ==  hooks.end()))
-               {
-                       throw CoreException("Can't find transport type '"+L->Hook+"' for link '"+assign(L->Name)+"' - maybe you forgot to load it BEFORE m_spanningtree in your config file? Skipping <link> tag completely.");
-                       continue;
-
-               }
+               ConfigTag* tag = i->second;
+               reference<Link> L = new Link(tag);
+               L->Name = tag->getString("name").c_str();
+               L->AllowMask = tag->getString("allowmask");
+               L->IPAddr = tag->getString("ipaddr");
+               L->Port = tag->getInt("port");
+               L->SendPass = tag->getString("sendpass");
+               L->RecvPass = tag->getString("recvpass");
+               L->Fingerprint = tag->getString("fingerprint");
+               L->HiddenFromStats = tag->getBool("statshidden");
+               L->Timeout = tag->getInt("timeout");
+               L->Hook = tag->getString("ssl");
+               L->Bind = tag->getString("bind");
+               L->Hidden = tag->getBool("hidden");
 
                if (L->Name.find('.') == std::string::npos)
                        throw CoreException("The link name '"+assign(L->Name)+"' is invalid and must contain at least one '.' character");
@@ -504,40 +388,7 @@ void SpanningTreeUtilities::ReadConfiguration(bool rebind)
 
                if ((!L->IPAddr.empty()) && (!L->RecvPass.empty()) && (!L->SendPass.empty()) && (!L->Name.empty()) && (L->Port))
                {
-                       if (Allow.length())
-                               ValidIPs.push_back(Allow);
-
                        ValidIPs.push_back(L->IPAddr);
-
-                       /* Needs resolving */
-                       bool ipvalid = true;
-                       QueryType start_type = DNS_QUERY_A;
-                       start_type = DNS_QUERY_AAAA;
-                       if (strchr(L->IPAddr.c_str(),':'))
-                       {
-                               in6_addr n;
-                               if (inet_pton(AF_INET6, L->IPAddr.c_str(), &n) < 1)
-                                       ipvalid = false;
-                       }
-                       else
-                       {
-                               in_addr n;
-                               if (inet_aton(L->IPAddr.c_str(),&n) < 1)
-                                       ipvalid = false;
-                       }
-
-                       if (!ipvalid)
-                       {
-                               try
-                               {
-                                       bool cached;
-                                       SecurityIPResolver* sr = new SecurityIPResolver(Creator, this, L->IPAddr, L, cached, start_type);
-                                       ServerInstance->AddResolver(sr, cached);
-                               }
-                               catch (...)
-                               {
-                               }
-                       }
                }
                else
                {
@@ -572,14 +423,15 @@ void SpanningTreeUtilities::ReadConfiguration(bool rebind)
                LinkBlocks.push_back(L);
        }
 
-       for (int j = 0; j < Conf->Enumerate("autoconnect"); ++j)
+       tags = ServerInstance->Config->ConfTags("autoconnect");
+       for(ConfigIter i = tags.first; i != tags.second; ++i)
        {
-               reference<Autoconnect> A = new Autoconnect;
-               A->Period = Conf->ReadInteger("autoconnect", "period", j, true);
+               ConfigTag* tag = i->second;
+               reference<Autoconnect> A = new Autoconnect(tag);
+               A->Period = tag->getInt("period");
                A->NextConnectTime = ServerInstance->Time() + A->Period;
                A->position = -1;
-               std::string servers = Conf->ReadValue("autoconnect", "server", j);
-               irc::spacesepstream ss(servers);
+               irc::spacesepstream ss(tag->getString("server"));
                std::string server;
                while (ss.GetToken(server))
                {
@@ -599,7 +451,7 @@ void SpanningTreeUtilities::ReadConfiguration(bool rebind)
                AutoconnectBlocks.push_back(A);
        }
 
-       delete Conf;
+       RefreshIPCache();
 }
 
 Link* SpanningTreeUtilities::FindLink(const std::string& name)