]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree.cpp
Allowed capab unencrypted in an encrypted connection
[user/henk/code/inspircd.git] / src / modules / m_spanningtree.cpp
index 2561da651e5c62065eff6e6c57a7d1d267cfe9d2..57872b65d63e7a209678addd6aa35550ec357963 100644 (file)
@@ -31,6 +31,7 @@ using namespace std;
 #include "users.h"
 #include "channels.h"
 #include "modules.h"
+#include "commands.h"
 #include "socket.h"
 #include "helperfuncs.h"
 #include "inspircd.h"
@@ -38,6 +39,9 @@ using namespace std;
 #include "hashcomp.h"
 #include "message.h"
 #include "xline.h"
+#include "typedefs.h"
+#include "cull_list.h"
+#include "aes.h"
 
 #ifdef GCC3
 #define nspace __gnu_cxx
@@ -91,8 +95,6 @@ extern int MODCOUNT;
 enum ServerState { LISTENER, CONNECTING, WAIT_AUTH_1, WAIT_AUTH_2, CONNECTED };
 
 /* We need to import these from the core for use in netbursts */
-typedef nspace::hash_map<std::string, userrec*, nspace::hash<string>, irc::StrHashComp> user_hash;
-typedef nspace::hash_map<std::string, chanrec*, nspace::hash<string>, irc::StrHashComp> chan_hash;
 extern user_hash clientlist;
 extern chan_hash chanlist;
 
@@ -105,6 +107,8 @@ class TreeSocket;
  */
 TreeServer *TreeRoot;
 
+Server* Srv;
+
 /* This hash_map holds the hash equivalent of the server
  * tree, used for rapid linear lookups.
  */
@@ -124,7 +128,11 @@ extern std::vector<GLine> glines;
 extern std::vector<ZLine> zlines;
 extern std::vector<QLine> qlines;
 extern std::vector<ELine> elines;
-
+extern std::vector<KLine> pklines;
+extern std::vector<GLine> pglines;
+extern std::vector<ZLine> pzlines;
+extern std::vector<QLine> pqlines;
+extern std::vector<ELine> pelines;
 
 /* Each server in the tree is represented by one class of
  * type TreeServer. A locally connected TreeServer can
@@ -167,7 +175,7 @@ class TreeServer
                ServerDesc = "";
                VersionString = "";
                UserCount = OperCount = 0;
-               VersionString = GetVersionString();
+               VersionString = Srv->GetVersion();
        }
 
        /* We use this constructor only to create the 'root' item, TreeRoot, which
@@ -179,8 +187,9 @@ class TreeServer
                Parent = NULL;
                VersionString = "";
                UserCount = OperCount = 0;
-               VersionString = GetVersionString();
+               VersionString = Srv->GetVersion();
                Route = NULL;
+               Socket = NULL; /* Fix by brain */
                AddHashEntry();
        }
 
@@ -284,17 +293,17 @@ class TreeServer
 
        std::string GetName()
        {
-               return this->ServerName;
+               return ServerName;
        }
 
        std::string GetDesc()
        {
-               return this->ServerDesc;
+               return ServerDesc;
        }
 
        std::string GetVersion()
        {
-               return this->VersionString;
+               return VersionString;
        }
 
        void SetNextPingTime(time_t t)
@@ -305,7 +314,7 @@ class TreeServer
 
        time_t NextPingTime()
        {
-               return this->NextPing;
+               return NextPing;
        }
 
        bool AnsweredLastPing()
@@ -320,22 +329,22 @@ class TreeServer
 
        int GetUserCount()
        {
-               return this->UserCount;
+               return UserCount;
        }
 
        int GetOperCount()
        {
-               return this->OperCount;
+               return OperCount;
        }
 
        TreeSocket* GetSocket()
        {
-               return this->Socket;
+               return Socket;
        }
 
        TreeServer* GetParent()
        {
-               return this->Parent;
+               return Parent;
        }
 
        void SetVersion(std::string Version)
@@ -430,6 +439,7 @@ class Link
         std::string RecvPass;
         unsigned long AutoConnect;
         time_t NextConnectTime;
+        std::string EncryptionKey;
 };
 
 /* The usual stuff for inspircd modules,
@@ -437,7 +447,6 @@ class Link
  * use to store the <link> tags from the config
  * file.
  */
-Server *Srv;
 ConfigReader *Conf;
 std::vector<Link> LinkBlocks;
 
@@ -527,6 +536,9 @@ class TreeSocket : public InspSocket
        int num_lost_servers;
        time_t NextPing;
        bool LastPingWasGood;
+       bool bursting;
+       AES* ctx;
+       unsigned int keylength;
        
  public:
 
@@ -557,6 +569,29 @@ class TreeSocket : public InspSocket
                : InspSocket(newfd, ip)
        {
                this->LinkState = WAIT_AUTH_1;
+               this->SendCapabilities();
+       }
+
+       void InitAES(std::string key,std::string SName)
+       {
+               if (key == "")
+                       return;
+
+               ctx = new AES();
+               log(DEBUG,"Initialized AES key %s",key.c_str());
+               // key must be 16, 24, 32 etc bytes (multiple of 8)
+               keylength = key.length();
+               if (!(keylength == 16 || keylength == 24 || keylength == 32))
+               {
+                       WriteOpers("*** \2ERROR\2: Key length for encryptionkey is not 16, 24 or 32 bytes in length!");
+                       log(DEBUG,"Key length not 16, 24 or 32 characters!");
+               }
+               else
+               {
+                       WriteOpers("*** \2AES\2: Initialized %d bit encryption to server %s",keylength*8,SName.c_str());
+                       ctx->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
+                               \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
+               }
        }
        
        /* When an outbound connection finishes connecting, we receive
@@ -575,6 +610,19 @@ class TreeSocket : public InspSocket
                        {
                                if (x->Name == this->myhost)
                                {
+                                       this->SendCapabilities();
+                                       if (x->EncryptionKey != "")
+                                       {
+                                               if (!(x->EncryptionKey.length() == 16 || x->EncryptionKey.length() == 24 || x->EncryptionKey.length() == 32))
+                                               {
+                                                       WriteOpers("\2WARNING\2: Your encryption key is NOT 16, 24 or 32 characters in length, encryption will \2NOT\2 be enabled.");
+                                               }
+                                               else
+                                               {
+                                                       this->WriteLine("AES "+Srv->GetServerName());
+                                                       this->InitAES(x->EncryptionKey,x->Name);
+                                               }
+                                       }
                                        /* found who we're supposed to be connecting to, send the neccessary gubbins. */
                                        this->WriteLine("SERVER "+Srv->GetServerName()+" "+x->SendPass+" 0 :"+Srv->GetServerDescription());
                                        return true;
@@ -631,13 +679,63 @@ class TreeSocket : public InspSocket
                }
        }
 
+       std::string MyCapabilities()
+       {
+               ServerConfig* Config = Srv->GetConfig();
+               std::vector<std::string> modlist;
+               std::string capabilities = "";
+
+                for (int i = 0; i <= MODCOUNT; i++)
+                {
+                       if ((modules[i]->GetVersion().Flags & VF_STATIC) || (modules[i]->GetVersion().Flags & VF_COMMON))
+                               modlist.push_back(Config->module_names[i]);
+                }
+               sort(modlist.begin(),modlist.end());
+               for (unsigned int i = 0; i < modlist.size(); i++)
+               {
+                       if (i)
+                               capabilities = capabilities + ",";
+                       capabilities = capabilities + modlist[i];
+               }
+               return capabilities;
+       }
+       
+       void SendCapabilities()
+       {
+               this->WriteLine("CAPAB "+MyCapabilities());
+       }
+
+       bool Capab(std::deque<std::string> params)
+       {
+               if (params.size() != 1)
+               {
+                       this->WriteLine("ERROR :Invalid number of parameters for CAPAB");
+                       return false;
+               }
+               if (params[0] != this->MyCapabilities())
+               {
+                       std::string quitserver = this->myhost;
+                       if (this->InboundServerName != "")
+                       {
+                               quitserver = this->InboundServerName;
+                       }
+                       WriteOpers("*** \2ERROR\2: Server '%s' does not have the same set of modules loaded, cannot link!",quitserver.c_str());
+                       WriteOpers("*** Our networked module set is: '%s'",this->MyCapabilities().c_str());
+                       WriteOpers("*** Other server's networked module set is: '%s'",params[0].c_str());
+                       WriteOpers("*** These lists must match exactly on both servers. Please correct these errors, and try again.");
+                       this->WriteLine("ERROR :CAPAB mismatch; My capabilities: '"+this->MyCapabilities()+"'");
+                       return false;
+               }
+               return true;
+       }
+
        /* This function forces this server to quit, removing this server
         * and any users on it (and servers and users below that, etc etc).
         * It's very slow and pretty clunky, but luckily unless your network
         * is having a REAL bad hair day, this function shouldnt be called
         * too many times a month ;-)
         */
-       void SquitServer(TreeServer* Current)
+       void SquitServer(TreeServer* Current, CullList* Goners)
        {
                /* recursively squit the servers attached to 'Current'.
                 * We're going backwards so we don't remove users
@@ -646,29 +744,17 @@ class TreeSocket : public InspSocket
                for (unsigned int q = 0; q < Current->ChildCount(); q++)
                {
                        TreeServer* recursive_server = Current->GetChild(q);
-                       this->SquitServer(recursive_server);
+                       this->SquitServer(recursive_server,Goners);
                }
                /* Now we've whacked the kids, whack self */
                num_lost_servers++;
-               bool quittingpeople = true;
-               while (quittingpeople)
-               {
-                       /* Yup i know, "ew". We cant continue to loop through the
-                        * iterator if we modify it, so whenever we modify it with a
-                        * QUIT we have to start alllll over again. If anyone knows
-                        * a better faster way of *safely* doing this, please let me
-                        * know!
-                        */
-                       quittingpeople = false;
-                       for (user_hash::iterator u = clientlist.begin(); u != clientlist.end(); u++)
+               for (user_hash::iterator u = clientlist.begin(); u != clientlist.end(); u++)
+               {
+                       if (!strcasecmp(u->second->server,Current->GetName().c_str()))
                        {
-                               if (!strcasecmp(u->second->server,Current->GetName().c_str()))
-                               {
-                                       Srv->QuitUser(u->second,Current->GetName()+" "+std::string(Srv->GetServerName()));
-                                       num_lost_users++;
-                                       quittingpeople = true;
-                                       break;
-                               }
+                               std::string qreason = Current->GetName()+" "+std::string(Srv->GetServerName());
+                               Goners->AddItem(u->second,qreason);
+                               num_lost_users++;
                        }
                }
        }
@@ -679,7 +765,7 @@ class TreeSocket : public InspSocket
         */
        void Squit(TreeServer* Current,std::string reason)
        {
-               if (Current)
+               if ((Current) && (Current != TreeRoot))
                {
                        std::deque<std::string> params;
                        params.push_back(Current->GetName());
@@ -695,10 +781,13 @@ class TreeSocket : public InspSocket
                        }
                        num_lost_servers = 0;
                        num_lost_users = 0;
-                       SquitServer(Current);
+                       CullList* Goners = new CullList();
+                       SquitServer(Current, Goners);
+                       Goners->Apply();
                        Current->Tidy();
                        Current->GetParent()->DelChild(Current);
                        delete Current;
+                       delete Goners;
                        WriteOpers("Netsplit complete, lost \002%d\002 users on \002%d\002 servers.", num_lost_users, num_lost_servers);
                }
                else
@@ -836,8 +925,9 @@ class TreeSocket : public InspSocket
                                        /* theres a mode for this user. push them onto the mode queue, and flush it
                                         * if there are more than MAXMODES to go.
                                         */
-                                       if (ourTS >= TS)
+                                       if ((ourTS >= TS) || (Srv->IsUlined(who->server)))
                                        {
+                                               /* We also always let u-lined clients win, no matter what the TS value */
                                                log(DEBUG,"Our our channel newer than theirs, accepting their modes");
                                                Srv->SendMode(mode_users,modectr,who);
                                        }
@@ -931,12 +1021,17 @@ class TreeSocket : public InspSocket
                clientlist[tempnick]->signon = age;
                strlcpy(clientlist[tempnick]->modes, modes.c_str(),53);
                strlcpy(clientlist[tempnick]->ip,ip.c_str(),16);
+
+               ucrec a;
+               a.channel = NULL;
+               a.uc_modes = 0;
                for (int i = 0; i < MAXCHANS; i++)
+                       clientlist[tempnick]->chans.push_back(a);
+
+               if (!this->bursting)
                {
-                       clientlist[tempnick]->chans[i].channel = NULL;
-                       clientlist[tempnick]->chans[i].uc_modes = 0;
+                       WriteOpers("*** Client connecting at %s: %s!%s@%s [%s]",clientlist[tempnick]->server,clientlist[tempnick]->nick,clientlist[tempnick]->ident,clientlist[tempnick]->host,clientlist[tempnick]->ip);
                }
-               WriteOpers("*** Client connecting at %s: %s!%s@%s [%s]",clientlist[tempnick]->server,clientlist[tempnick]->nick,clientlist[tempnick]->ident,clientlist[tempnick]->host,clientlist[itempnick]->ip);
                params[7] = ":" + params[7];
                DoOneToAllButSender(source,"NICK",params,source);
                return true;
@@ -948,6 +1043,7 @@ class TreeSocket : public InspSocket
         */
        void SendFJoins(TreeServer* Current, chanrec* c)
        {
+               log(DEBUG,"Sending FJOINs to other server for %s",c->name);
                char list[MAXBUF];
                snprintf(list,MAXBUF,":%s FJOIN %s %lu",Srv->GetServerName().c_str(),c->name,(unsigned long)c->age);
                std::vector<char*> *ulist = c->GetUsers();
@@ -960,12 +1056,14 @@ class TreeSocket : public InspSocket
                        strlcat(list,otheruser->nick,MAXBUF);
                        if (strlen(list)>(480-NICKMAX))
                        {
+                               log(DEBUG,"FJOIN line wrapped");
                                this->WriteLine(list);
                                snprintf(list,MAXBUF,":%s FJOIN %s %lu",Srv->GetServerName().c_str(),c->name,(unsigned long)c->age);
                        }
                }
                if (list[strlen(list)-1] != ':')
                {
+                       log(DEBUG,"Final FJOIN line");
                        this->WriteLine(list);
                }
        }
@@ -995,12 +1093,33 @@ class TreeSocket : public InspSocket
                        snprintf(data,MAXBUF,":%s ADDLINE E %s %s %lu %lu :%s",Srv->GetServerName().c_str(),i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
                        this->WriteLine(data);
                }
+               for (std::vector<ZLine>::iterator i = pzlines.begin(); i != pzlines.end(); i++)
+               {
+                       snprintf(data,MAXBUF,":%s ADDLINE Z %s %s %lu %lu :%s",Srv->GetServerName().c_str(),i->ipaddr,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       this->WriteLine(data);
+               }
+               for (std::vector<QLine>::iterator i = pqlines.begin(); i != pqlines.end(); i++)
+               {
+                       snprintf(data,MAXBUF,":%s ADDLINE Q %s %s %lu %lu :%s",Srv->GetServerName().c_str(),i->nick,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       this->WriteLine(data);
+               }
+               for (std::vector<GLine>::iterator i = pglines.begin(); i != pglines.end(); i++)
+               {
+                       snprintf(data,MAXBUF,":%s ADDLINE G %s %s %lu %lu :%s",Srv->GetServerName().c_str(),i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       this->WriteLine(data);
+               }
+               for (std::vector<ELine>::iterator i = pelines.begin(); i != pelines.end(); i++)
+               {
+                       snprintf(data,MAXBUF,":%s ADDLINE E %s %s %lu %lu :%s",Srv->GetServerName().c_str(),i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       this->WriteLine(data);
+               }
        }
 
        /* Send channel modes and topics */
        void SendChannelModes(TreeServer* Current)
        {
                char data[MAXBUF];
+               std::deque<std::string> list;
                for (chan_hash::iterator c = chanlist.begin(); c != chanlist.end(); c++)
                {
                        SendFJoins(Current, c->second);
@@ -1017,6 +1136,12 @@ class TreeSocket : public InspSocket
                                this->WriteLine(data);
                        }
                        FOREACH_MOD OnSyncChannel(c->second,(Module*)TreeProtocolModule,(void*)this);
+                       list.clear();
+                       c->second->GetExtList(list);
+                       for (unsigned int j = 0; j < list.size(); j++)
+                       {
+                               FOREACH_MOD OnSyncChannelMetaData(c->second,(Module*)TreeProtocolModule,(void*)this,list[j]);
+                       }
                }
        }
 
@@ -1024,6 +1149,7 @@ class TreeSocket : public InspSocket
        void SendUsers(TreeServer* Current)
        {
                char data[MAXBUF];
+               std::deque<std::string> list;
                for (user_hash::iterator u = clientlist.begin(); u != clientlist.end(); u++)
                {
                        if (u->second->registered == 7)
@@ -1034,12 +1160,13 @@ class TreeSocket : public InspSocket
                                {
                                        this->WriteLine(":"+std::string(u->second->nick)+" OPERTYPE "+std::string(u->second->oper));
                                }
-                               //char* chl = chlist(u->second,u->second);
-                               //if (*chl)
-                               //{
-                               //      this->WriteLine(":"+std::string(u->second->nick)+" FJOIN "+std::string(chl));
-                               //}
                                FOREACH_MOD OnSyncUser(u->second,(Module*)TreeProtocolModule,(void*)this);
+                               list.clear();
+                               u->second->GetExtList(list);
+                               for (unsigned int j = 0; j < list.size(); j++)
+                               {
+                                       FOREACH_MOD OnSyncUserMetaData(u->second,(Module*)TreeProtocolModule,(void*)this,list[j]);
+                               }
                        }
                }
        }
@@ -1054,7 +1181,7 @@ class TreeSocket : public InspSocket
                Srv->SendOpers("*** Bursting to \2"+s->GetName()+"\2.");
                this->WriteLine("BURST");
                /* send our version string */
-               this->WriteLine(":"+Srv->GetServerName()+" VERSION :"+GetVersionString());
+               this->WriteLine(":"+Srv->GetServerName()+" VERSION :"+Srv->GetVersion());
                /* Send server tree */
                this->SendServers(TreeRoot,s,1);
                /* Send users and their oper status */
@@ -1098,6 +1225,22 @@ class TreeSocket : public InspSocket
                                /* Process this one, abort if it
                                 * didnt return true.
                                 */
+                               if (this->ctx)
+                               {
+                                       char out[1024];
+                                       char result[1024];
+                                       log(DEBUG,"Original string '%s'",ret.c_str());
+                                       /* ERROR + CAPAB is still allowed unencryped */
+                                       if ((ret.substr(0,7) != "ERROR :") && (ret.substr(0,6) != "CAPAB "))
+                                       {
+                                               int nbytes = from64tobits(out, ret.c_str(), 1024);
+                                               log(DEBUG,"m_spanningtree: decrypt %d bytes",nbytes);
+                                               ctx->Decrypt(out, result, nbytes, 0);
+                                               for (int t = 0; t < nbytes; t++)
+                                                       if (result[t] == '\7') result[t] = 0;
+                                               ret = result;
+                                       }
+                               }
                                if (!this->ProcessLine(ret))
                                {
                                        return false;
@@ -1109,6 +1252,31 @@ class TreeSocket : public InspSocket
 
        int WriteLine(std::string line)
        {
+               log(DEBUG,"OUT: %s",line.c_str());
+               if (this->ctx)
+               {
+                       log(DEBUG,"AES context");
+                       char result[10240];
+                       char result64[10240];
+                       if (this->keylength)
+                       {
+                               while (line.length() % this->keylength != 0)
+                               {
+                                       // pad it to be a multiple of the key length
+                                       line = line + "\7";
+                               }
+                       }
+                       unsigned int ll = line.length();
+                       log(DEBUG,"Plaintext line with padding = %d chars",ll);
+                       ctx->Encrypt(line.c_str(), result, ll, 0);
+                       log(DEBUG,"Encrypted.");
+                       to64frombits((unsigned char*)result64,
+                                       (unsigned char*)result,
+                                       ll);
+                       line = result64;
+                       log(DEBUG,"Encrypted: %s",line.c_str());
+                       //int from64tobits(char *out, const char *in, int maxlen);
+               }
                return this->Write(line + "\r\n");
        }
 
@@ -1233,6 +1401,35 @@ class TreeSocket : public InspSocket
                }
                return true;
        }
+       
+       bool MetaData(std::string prefix, std::deque<std::string> &params)
+       {
+               if (params.size() < 3)
+                       return true;
+               TreeServer* ServerSource = FindServer(prefix);
+               if (ServerSource)
+               {
+                       if (*(params[0].c_str()) == '#')
+                       {
+                               chanrec* c = Srv->FindChannel(params[0]);
+                               if (c)
+                               {
+                                       FOREACH_MOD OnDecodeMetaData(TYPE_CHANNEL,c,params[1],params[2]);
+                               }
+                       }
+                       else
+                       {
+                               userrec* u = Srv->FindNick(params[0]);
+                               if (u)
+                               {
+                                       FOREACH_MOD OnDecodeMetaData(TYPE_USER,u,params[1],params[2]);
+                               }
+                       }
+               }
+               params[2] = ":" + params[2];
+               DoOneToAllButSender(prefix,"METADATA",params,prefix);
+               return true;
+       }
 
        bool ServerVersion(std::string prefix, std::deque<std::string> &params)
        {
@@ -1276,15 +1473,19 @@ class TreeSocket : public InspSocket
                {
                        case 'Z':
                                add_zline(atoi(duration.c_str()), source.c_str(), reason.c_str(), mask.c_str());
+                               zline_set_creation_time((char*)mask.c_str(), atoi(settime.c_str()));
                        break;
                        case 'Q':
                                add_qline(atoi(duration.c_str()), source.c_str(), reason.c_str(), mask.c_str());
+                               qline_set_creation_time((char*)mask.c_str(), atoi(settime.c_str()));
                        break;
                        case 'E':
                                add_eline(atoi(duration.c_str()), source.c_str(), reason.c_str(), mask.c_str());
+                               eline_set_creation_time((char*)mask.c_str(), atoi(settime.c_str()));
                        break;
                        case 'G':
                                add_gline(atoi(duration.c_str()), source.c_str(), reason.c_str(), mask.c_str());
+                               gline_set_creation_time((char*)mask.c_str(), atoi(settime.c_str()));
                        break;
                        case 'K':
                                add_kline(atoi(duration.c_str()), source.c_str(), reason.c_str(), mask.c_str());
@@ -1313,6 +1514,65 @@ class TreeSocket : public InspSocket
                }
                return true;
        }
+
+       bool Whois(std::string prefix, std::deque<std::string> &params)
+       {
+               if (params.size() < 1)
+                       return true;
+               log(DEBUG,"In IDLE command");
+               userrec* u = Srv->FindNick(prefix);
+               if (u)
+               {
+                       log(DEBUG,"USER EXISTS: %s",u->nick);
+                       // an incoming request
+                       if (params.size() == 1)
+                       {
+                               userrec* x = Srv->FindNick(params[0]);
+                               if (x->fd > -1)
+                               {
+                                       userrec* x = Srv->FindNick(params[0]);
+                                       log(DEBUG,"Got IDLE");
+                                       char signon[MAXBUF];
+                                       char idle[MAXBUF];
+                                       log(DEBUG,"Sending back IDLE 3");
+                                       snprintf(signon,MAXBUF,"%lu",(unsigned long)x->signon);
+                                       snprintf(idle,MAXBUF,"%lu",(unsigned long)abs((x->idle_lastmsg)-time(NULL)));
+                                       std::deque<std::string> par;
+                                       par.push_back(prefix);
+                                       par.push_back(signon);
+                                       par.push_back(idle);
+                                       // ours, we're done, pass it BACK
+                                       DoOneToOne(params[0],"IDLE",par,u->server);
+                               }
+                               else
+                               {
+                                       // not ours pass it on
+                                       DoOneToOne(prefix,"IDLE",params,x->server);
+                               }
+                       }
+                       else if (params.size() == 3)
+                       {
+                               std::string who_did_the_whois = params[0];
+                               userrec* who_to_send_to = Srv->FindNick(who_did_the_whois);
+                               if (who_to_send_to->fd > -1)
+                               {
+                                       log(DEBUG,"Got final IDLE");
+                                       // an incoming reply to a whois we sent out
+                                       std::string nick_whoised = prefix;
+                                       unsigned long signon = atoi(params[1].c_str());
+                                       unsigned long idle = atoi(params[2].c_str());
+                                       if ((who_to_send_to) && (who_to_send_to->fd > -1))
+                                               do_whois(who_to_send_to,u,signon,idle,(char*)nick_whoised.c_str());
+                               }
+                               else
+                               {
+                                       // not ours, pass it on
+                                       DoOneToOne(prefix,"IDLE",params,who_to_send_to->server);
+                               }
+                       }
+               }
+               return true;
+       }
        
        bool LocalPing(std::string prefix, std::deque<std::string> &params)
        {
@@ -1341,6 +1601,7 @@ class TreeSocket : public InspSocket
                if (CheckDupe)
                {
                        this->WriteLine("ERROR :Server "+servername+" already exists on server "+CheckDupe->GetParent()->GetName()+"!");
+                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, already exists on server "+CheckDupe->GetParent()->GetName());
                        return false;
                }
                TreeServer* Node = new TreeServer(servername,description,ParentOfThis,NULL);
@@ -1361,6 +1622,7 @@ class TreeSocket : public InspSocket
                if (hops)
                {
                        this->WriteLine("ERROR :Server too far away for authentication");
+                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, server is too far away for authentication");
                        return false;
                }
                std::string description = params[3];
@@ -1372,6 +1634,7 @@ class TreeSocket : public InspSocket
                                if (CheckDupe)
                                {
                                        this->WriteLine("ERROR :Server "+servername+" already exists on server "+CheckDupe->GetParent()->GetName()+"!");
+                                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, already exists on server "+CheckDupe->GetParent()->GetName());
                                        return false;
                                }
                                // Begin the sync here. this kickstarts the
@@ -1386,11 +1649,13 @@ class TreeSocket : public InspSocket
                                TreeRoot->AddChild(Node);
                                params[3] = ":" + params[3];
                                DoOneToAllButSender(TreeRoot->GetName(),"SERVER",params,servername);
+                               this->bursting = true;
                                this->DoBurst(Node);
                                return true;
                        }
                }
                this->WriteLine("ERROR :Invalid credentials");
+               Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, invalid link credentials");
                return false;
        }
 
@@ -1404,6 +1669,7 @@ class TreeSocket : public InspSocket
                if (hops)
                {
                        this->WriteLine("ERROR :Server too far away for authentication");
+                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, server is too far away for authentication");
                        return false;
                }
                std::string description = params[3];
@@ -1415,6 +1681,17 @@ class TreeSocket : public InspSocket
                                if (CheckDupe)
                                {
                                        this->WriteLine("ERROR :Server "+servername+" already exists on server "+CheckDupe->GetParent()->GetName()+"!");
+                                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, already exists on server "+CheckDupe->GetParent()->GetName());
+                                       return false;
+                               }
+                               /* If the config says this link is encrypted, but the remote side
+                                * hasnt bothered to send the AES command before SERVER, then we
+                                * boot them off as we MUST have this connection encrypted.
+                                */
+                               if ((x->EncryptionKey != "") && (!this->ctx))
+                               {
+                                       this->WriteLine("ERROR :This link requires AES encryption to be enabled. Plaintext connection refused.");
+                                       Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, remote server did not enable AES.");
                                        return false;
                                }
                                Srv->SendOpers("*** Verified incoming server connection from \002"+servername+"\002["+this->GetIP()+"] ("+description+")");
@@ -1429,6 +1706,7 @@ class TreeSocket : public InspSocket
                        }
                }
                this->WriteLine("ERROR :Invalid credentials");
+               Srv->SendOpers("*** Server connection from \2"+servername+"\2 denied, invalid link credentials");
                return false;
        }
 
@@ -1490,7 +1768,7 @@ class TreeSocket : public InspSocket
                line = l;
                if (line == "")
                        return true;
-               Srv->Log(DEBUG,"IN: '"+line+"'");
+               Srv->Log(DEBUG,"IN: "+line);
                std::deque<std::string> params;
                this->Split(line,true,params);
                std::string command = "";
@@ -1510,7 +1788,24 @@ class TreeSocket : public InspSocket
                        command = params[0];
                        params.pop_front();
                }
-               
+
+               if ((!this->ctx) && (command == "AES"))
+               {
+                        std::string sserv = params[0];
+                        for (std::vector<Link>::iterator x = LinkBlocks.begin(); x < LinkBlocks.end(); x++)
+                        {
+                                if ((x->EncryptionKey != "") && (x->Name == sserv))
+                                {
+                                        this->InitAES(x->EncryptionKey,sserv);
+                                }
+                        }
+                        return true;
+               }
+               else if ((this->ctx) && (command == "AES"))
+               {
+                       WriteOpers("*** \2AES\2: Encryption already enabled on this connection yet %s is trying to enable it twice!",params[0].c_str());
+               }
+
                switch (this->LinkState)
                {
                        TreeServer* Node;
@@ -1521,7 +1816,11 @@ class TreeSocket : public InspSocket
                                // replies with theirs if its happy, then if the initiator is happy,
                                // it starts to send its net sync, which starts the merge, otherwise
                                // it sends an ERROR.
-                               if (command == "SERVER")
+                               if (command == "PASS")
+                               {
+                                       /* Silently ignored */
+                               }
+                               else if (command == "SERVER")
                                {
                                        return this->Inbound_Server(params);
                                }
@@ -1529,6 +1828,20 @@ class TreeSocket : public InspSocket
                                {
                                        return this->Error(params);
                                }
+                               else if (command == "USER")
+                               {
+                                       this->WriteLine("ERROR :Client connections to this port are prohibited.");
+                                       return false;
+                               }
+                               else if (command == "CAPAB")
+                               {
+                                       return this->Capab(params);
+                               }
+                               else
+                               {
+                                       this->WriteLine("ERROR :Invalid command in negotiation phase.");
+                                       return false;
+                               }
                        break;
                        case WAIT_AUTH_2:
                                // Waiting for start of other side's netmerge to say they liked our
@@ -1550,12 +1863,17 @@ class TreeSocket : public InspSocket
                                        params.push_back("1");
                                        params.push_back(":"+InboundDescription);
                                        DoOneToAllButSender(TreeRoot->GetName(),"SERVER",params,InboundServerName);
+                                       this->bursting = true;
                                        this->DoBurst(Node);
                                }
                                else if (command == "ERROR")
                                {
                                        return this->Error(params);
                                }
+                               else if (command == "CAPAB")
+                               {
+                                       return this->Capab(params);
+                               }
                                
                        break;
                        case LISTENER:
@@ -1581,6 +1899,31 @@ class TreeSocket : public InspSocket
                                // This is the 'authenticated' state, when all passwords
                                // have been exchanged and anything past this point is taken
                                // as gospel.
+                               
+                               if (prefix != "")
+                               {
+                                       std::string direction = prefix;
+                                       userrec* t = Srv->FindNick(prefix);
+                                       if (t)
+                                       {
+                                               direction = t->server;
+                                       }
+                                       TreeServer* route_back_again = BestRouteTo(direction);
+                                       if ((!route_back_again) || (route_back_again->GetSocket() != this))
+                                       {
+                                               if (route_back_again)
+                                               {
+                                                       WriteOpers("*** Protocol violation: Fake direction in command '%s' from connection '%s'",line.c_str(),this->GetName().c_str());
+                                               }
+                                               else
+                                               {
+                                                       WriteOpers("*** Protocol violation: Invalid source '%s' in command '%s' from connection '%s'",direction.c_str(),line.c_str(),this->GetName().c_str());
+                                               }
+                                               
+                                               return true;
+                                       }
+                               }
+                               
                                if (command == "SVSMODE")
                                {
                                        /* Services expects us to implement
@@ -1629,6 +1972,10 @@ class TreeSocket : public InspSocket
                                {
                                        return this->RemoteRehash(prefix,params);
                                }
+                               else if (command == "METADATA")
+                               {
+                                       return this->MetaData(prefix,params);
+                               }
                                else if (command == "PING")
                                {
                                        return this->LocalPing(prefix,params);
@@ -1661,6 +2008,10 @@ class TreeSocket : public InspSocket
                                        }
                                        return this->ForceNick(prefix,params);
                                }
+                               else if (command == "IDLE")
+                               {
+                                       return this->Whois(prefix,params);
+                               }
                                else if (command == "SVSJOIN")
                                {
                                        if (prefix == "")
@@ -1677,6 +2028,11 @@ class TreeSocket : public InspSocket
                                        }
                                        return true;
                                }
+                               else if (command == "ENDBURST")
+                               {
+                                       this->bursting = false;
+                                       return true;
+                               }
                                else
                                {
                                        // not a special inter-server command.
@@ -1754,6 +2110,7 @@ class TreeSocket : public InspSocket
                {
                        Squit(s,"Remote host closed the connection");
                }
+               WriteOpers("Server '\2%s\2[%s]' closed the connection.",quitserver.c_str(),this->GetIP().c_str());
        }
 
        virtual int OnIncomingConnection(int newsock, char* ip)
@@ -1785,7 +2142,7 @@ void GetListOfServersForChannel(chanrec* c, std::deque<TreeServer*> &list)
        {
                char* o = (*ulist)[i];
                userrec* otheruser = (userrec*)o;
-               if (std::string(otheruser->server) != Srv->GetServerName())
+               if (otheruser->fd < 0)
                {
                        TreeServer* best = BestRouteTo(otheruser->server);
                        if (best)
@@ -1966,9 +2323,18 @@ void ReadConfiguration(bool rebind)
                L.SendPass = Conf->ReadValue("link","sendpass",j);
                L.RecvPass = Conf->ReadValue("link","recvpass",j);
                L.AutoConnect = Conf->ReadInteger("link","autoconnect",j,true);
+               L.EncryptionKey =  Conf->ReadValue("link","encryptionkey",j);
                L.NextConnectTime = time(NULL) + L.AutoConnect;
-               LinkBlocks.push_back(L);
-               log(DEBUG,"m_spanningtree: Read server %s with host %s:%d",L.Name.c_str(),L.IPAddr.c_str(),L.Port);
+               /* Bugfix by brain, do not allow people to enter bad configurations */
+               if ((L.RecvPass != "") && (L.SendPass != "") && (L.Name != "") && (L.Port))
+               {
+                       LinkBlocks.push_back(L);
+                       log(DEBUG,"m_spanningtree: Read server %s with host %s:%d",L.Name.c_str(),L.IPAddr.c_str(),L.Port);
+               }
+               else
+               {
+                       log(DEFAULT,"m_spanningtree: Invalid configuration for server '%s', ignored!",L.Name.c_str());
+               }
        }
        delete Conf;
 }
@@ -1982,9 +2348,10 @@ class ModuleSpanningTree : public Module
 
  public:
 
-       ModuleSpanningTree()
+       ModuleSpanningTree(Server* Me)
+               : Module::Module(Me)
        {
-               Srv = new Server;
+               Srv = Me;
                Bindings.clear();
 
                // Create the root of the tree
@@ -2119,9 +2486,15 @@ class ModuleSpanningTree : public Module
                TreeServer* s = FindServerMask(parameters[0]);
                if (s)
                {
+                       if (s == TreeRoot)
+                       {
+                                WriteServ(user->fd,"NOTICE %s :*** SQUIT: Foolish mortal, you cannot make a server SQUIT itself! (%s matches local server name)",user->nick,parameters[0]);
+                               return 1;
+                       }
                        TreeSocket* sock = s->GetSocket();
                        if (sock)
                        {
+                               log(DEBUG,"Splitting server %s",s->GetName().c_str());
                                WriteOpers("*** SQUIT: Server \002%s\002 removed from network by %s",parameters[0],user->nick);
                                sock->Squit(s,"Server quit by "+std::string(user->nick)+"!"+std::string(user->ident)+"@"+std::string(user->host));
                                sock->Close();
@@ -2138,6 +2511,28 @@ class ModuleSpanningTree : public Module
                return 1;
        }
 
+       int HandleRemoteWhois(char** parameters, int pcnt, userrec* user)
+       {
+               if ((user->fd > -1) && (pcnt > 1))
+               {
+                       userrec* remote = Srv->FindNick(parameters[1]);
+                       if ((remote) && (remote->fd < 0))
+                       {
+                               std::deque<std::string> params;
+                               params.push_back(parameters[1]);
+                               DoOneToOne(user->nick,"IDLE",params,remote->server);
+                               return 1;
+                       }
+                       else if (!remote)
+                       {
+                               WriteServ(user->fd,"401 %s %s :No such nick/channel",user->nick, parameters[1]);
+                               WriteServ(user->fd,"318 %s %s :End of /WHOIS list.",user->nick, parameters[1]);
+                               return 1;
+                       }
+               }
+               return 0;
+       }
+
        void DoPingChecks(time_t curtime)
        {
                for (unsigned int j = 0; j < TreeRoot->ChildCount(); j++)
@@ -2233,7 +2628,7 @@ class ModuleSpanningTree : public Module
                {
                        for (unsigned int i = 0; i < LinkBlocks.size(); i++)
                        {
-                               WriteServ(user->fd,"213 %s C *@%s * %s %d 0 M",user->nick,LinkBlocks[i].IPAddr.c_str(),LinkBlocks[i].Name.c_str(),LinkBlocks[i].Port);
+                               WriteServ(user->fd,"213 %s C *@%s * %s %d 0 %s",user->nick,LinkBlocks[i].IPAddr.c_str(),LinkBlocks[i].Name.c_str(),LinkBlocks[i].Port,(LinkBlocks[i].EncryptionKey != "" ? "es" : " s"));
                                WriteServ(user->fd,"244 %s H * * %s",user->nick,LinkBlocks[i].Name.c_str());
                        }
                        WriteServ(user->fd,"219 %s %s :End of /STATS report",user->nick,parameters[0]);
@@ -2243,8 +2638,12 @@ class ModuleSpanningTree : public Module
                return false;
        }
 
-       virtual int OnPreCommand(std::string command, char **parameters, int pcnt, userrec *user)
+       virtual int OnPreCommand(std::string command, char **parameters, int pcnt, userrec *user, bool validated)
        {
+               /* If the command doesnt appear to be valid, we dont want to mess with it. */
+               if (!validated)
+                       return 0;
+
                if (command == "CONNECT")
                {
                        return this->HandleConnect(parameters,pcnt,user);
@@ -2272,6 +2671,14 @@ class ModuleSpanningTree : public Module
                        this->HandleLinks(parameters,pcnt,user);
                        return 1;
                }
+               else if (command == "WHOIS")
+               {
+                       if (pcnt > 1)
+                       {
+                               // remote whois
+                               return this->HandleRemoteWhois(parameters,pcnt,user);
+                       }
+               }
                else if ((command == "VERSION") && (pcnt > 0))
                {
                        this->HandleVersion(parameters,pcnt,user);
@@ -2313,7 +2720,7 @@ class ModuleSpanningTree : public Module
 
        virtual void OnUserInvite(userrec* source,userrec* dest,chanrec* channel)
        {
-               if (std::string(source->server) == Srv->GetServerName())
+               if (source->fd > -1)
                {
                        std::deque<std::string> params;
                        params.push_back(dest->nick);
@@ -2332,7 +2739,7 @@ class ModuleSpanningTree : public Module
 
        virtual void OnWallops(userrec* user, std::string text)
        {
-               if (std::string(user->server) == Srv->GetServerName())
+               if (user->fd > -1)
                {
                        std::deque<std::string> params;
                        params.push_back(":"+text);
@@ -2345,7 +2752,7 @@ class ModuleSpanningTree : public Module
                if (target_type == TYPE_USER)
                {
                        userrec* d = (userrec*)dest;
-                       if ((std::string(d->server) != Srv->GetServerName()) && (std::string(user->server) == Srv->GetServerName()))
+                       if ((d->fd < 0) && (user->fd > -1))
                        {
                                std::deque<std::string> params;
                                params.clear();
@@ -2356,7 +2763,7 @@ class ModuleSpanningTree : public Module
                }
                else
                {
-                       if (std::string(user->server) == Srv->GetServerName())
+                       if (user->fd > -1)
                        {
                                chanrec *c = (chanrec*)dest;
                                std::deque<TreeServer*> list;
@@ -2379,7 +2786,7 @@ class ModuleSpanningTree : public Module
                        // route private messages which are targetted at clients only to the server
                        // which needs to receive them
                        userrec* d = (userrec*)dest;
-                       if ((std::string(d->server) != Srv->GetServerName()) && (std::string(user->server) == Srv->GetServerName()))
+                       if ((d->fd < 0) && (user->fd > -1))
                        {
                                std::deque<std::string> params;
                                params.clear();
@@ -2390,7 +2797,7 @@ class ModuleSpanningTree : public Module
                }
                else
                {
-                       if (std::string(user->server) == Srv->GetServerName())
+                       if (user->fd > -1)
                        {
                                chanrec *c = (chanrec*)dest;
                                std::deque<TreeServer*> list;
@@ -2415,7 +2822,7 @@ class ModuleSpanningTree : public Module
        virtual void OnUserJoin(userrec* user, chanrec* channel)
        {
                // Only do this for local users
-               if (std::string(user->server) == Srv->GetServerName())
+               if (user->fd > -1)
                {
                        std::deque<std::string> params;
                        params.clear();
@@ -2448,6 +2855,8 @@ class ModuleSpanningTree : public Module
        virtual void OnChangeHost(userrec* user, std::string newhost)
        {
                // only occurs for local clients
+               if (user->registered != 7)
+                       return;
                std::deque<std::string> params;
                params.push_back(newhost);
                DoOneToMany(user->nick,"FHOST",params);
@@ -2456,6 +2865,8 @@ class ModuleSpanningTree : public Module
        virtual void OnChangeName(userrec* user, std::string gecos)
        {
                // only occurs for local clients
+               if (user->registered != 7)
+                       return;
                std::deque<std::string> params;
                params.push_back(gecos);
                DoOneToMany(user->nick,"FNAME",params);
@@ -2463,7 +2874,7 @@ class ModuleSpanningTree : public Module
 
        virtual void OnUserPart(userrec* user, chanrec* channel)
        {
-               if (std::string(user->server) == Srv->GetServerName())
+               if (user->fd > -1)
                {
                        std::deque<std::string> params;
                        params.push_back(channel->name);
@@ -2474,7 +2885,7 @@ class ModuleSpanningTree : public Module
        virtual void OnUserConnect(userrec* user)
        {
                char agestr[MAXBUF];
-               if (std::string(user->server) == Srv->GetServerName())
+               if (user->fd > -1)
                {
                        std::deque<std::string> params;
                        snprintf(agestr,MAXBUF,"%lu",(unsigned long)user->age);
@@ -2492,7 +2903,7 @@ class ModuleSpanningTree : public Module
 
        virtual void OnUserQuit(userrec* user, std::string reason)
        {
-               if (std::string(user->server) == Srv->GetServerName())
+               if ((user->fd > -1) && (user->registered == 7))
                {
                        std::deque<std::string> params;
                        params.push_back(":"+reason);
@@ -2502,7 +2913,7 @@ class ModuleSpanningTree : public Module
 
        virtual void OnUserPostNick(userrec* user, std::string oldnick)
        {
-               if (std::string(user->server) == Srv->GetServerName())
+               if (user->fd > -1)
                {
                        std::deque<std::string> params;
                        params.push_back(user->nick);
@@ -2512,7 +2923,7 @@ class ModuleSpanningTree : public Module
 
        virtual void OnUserKick(userrec* source, userrec* user, chanrec* chan, std::string reason)
        {
-               if (std::string(source->server) == Srv->GetServerName())
+               if (source->fd > -1)
                {
                        std::deque<std::string> params;
                        params.push_back(chan->name);
@@ -2552,7 +2963,7 @@ class ModuleSpanningTree : public Module
        // locally.
        virtual void OnOper(userrec* user, std::string opertype)
        {
-               if (std::string(user->server) == Srv->GetServerName())
+               if (user->fd > -1)
                {
                        std::deque<std::string> params;
                        params.push_back(opertype);
@@ -2562,7 +2973,7 @@ class ModuleSpanningTree : public Module
 
        void OnLine(userrec* source, std::string host, bool adding, char linetype, long duration, std::string reason)
        {
-               if (std::string(source->server) == Srv->GetServerName())
+               if (source->fd > -1)
                {
                        char type[8];
                        snprintf(type,8,"%cLINE",linetype);
@@ -2628,7 +3039,7 @@ class ModuleSpanningTree : public Module
 
        virtual void OnMode(userrec* user, void* dest, int target_type, std::string text)
        {
-               if (std::string(user->server) == Srv->GetServerName())
+               if ((user->fd > -1) && (user->registered == 7))
                {
                        if (target_type == TYPE_USER)
                        {
@@ -2667,9 +3078,26 @@ class ModuleSpanningTree : public Module
                }
        }
 
+       virtual void ProtoSendMetaData(void* opaque, int target_type, void* target, std::string extname, std::string extdata)
+       {
+               TreeSocket* s = (TreeSocket*)opaque;
+               if (target)
+               {
+                       if (target_type == TYPE_USER)
+                       {
+                               userrec* u = (userrec*)target;
+                               s->WriteLine(":"+Srv->GetServerName()+" METADATA "+u->nick+" "+extname+" :"+extdata);
+                       }
+                       else
+                       {
+                               chanrec* c = (chanrec*)target;
+                               s->WriteLine(":"+Srv->GetServerName()+" METADATA "+c->name+" "+extname+" :"+extdata);
+                       }
+               }
+       }
+
        virtual ~ModuleSpanningTree()
        {
-               delete Srv;
        }
 
        virtual Version GetVersion()
@@ -2690,9 +3118,9 @@ class ModuleSpanningTreeFactory : public ModuleFactory
        {
        }
        
-       virtual Module * CreateModule()
+       virtual Module * CreateModule(Server* Me)
        {
-               TreeProtocolModule = new ModuleSpanningTree;
+               TreeProtocolModule = new ModuleSpanningTree(Me);
                return TreeProtocolModule;
        }