]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree.cpp
Remove some annoying debug
[user/henk/code/inspircd.git] / src / modules / m_spanningtree.cpp
index 679dc00dfc52825d012bc3b6b5c85523783b6811..654c524420f219f7fa877b926c398aa05ac41414 100644 (file)
@@ -37,7 +37,7 @@ using namespace std;
 /** If you make a change which breaks the protocol, increment this.
  * If you  completely change the protocol, completely change the number.
  */
-const long ProtocolVersion = 1100;
+const long ProtocolVersion = 1101;
 
 /*
  * The server list in InspIRCd is maintained as two structures
@@ -66,7 +66,7 @@ class ModuleSpanningTree;
 static ModuleSpanningTree* TreeProtocolModule;
 static InspIRCd* ServerInstance;
 
-/* Any socket can have one of five states at any one time.
+/** Any socket can have one of five states at any one time.
  * The LISTENER state indicates a socket which is listening
  * for connections. It cannot receive data itself, only incoming
  * sockets.
@@ -114,6 +114,8 @@ void ReadConfiguration(bool rebind);
 bool FlatLinks;
 /* Hide U-Lined servers in /MAP and /LINKS */
 bool HideULines;
+/* Announce TS changes to channels on merge */
+bool AnnounceTSChange;
 
 std::vector<std::string> ValidIPs;
 
@@ -165,7 +167,7 @@ class UserManager : public classbase
 };
 
 
-/* Each server in the tree is represented by one class of
+/** Each server in the tree is represented by one class of
  * type TreeServer. A locally connected TreeServer can
  * have a class of type TreeSocket associated with it, for
  * remote servers, the TreeSocket entry will be NULL.
@@ -179,7 +181,6 @@ class UserManager : public classbase
  * TreeServer items, deleting and inserting them as they
  * are created and destroyed.
  */
-
 class TreeServer : public classbase
 {
        InspIRCd* ServerInstance;               /* Creator */
@@ -197,7 +198,7 @@ class TreeServer : public classbase
        
  public:
 
-       /* We don't use this constructor. Its a dummy, and won't cause any insertion
+       /** We don't use this constructor. Its a dummy, and won't cause any insertion
         * of the TreeServer into the hash_map. See below for the two we DO use.
         */
        TreeServer(InspIRCd* Instance) : ServerInstance(Instance)
@@ -210,7 +211,7 @@ class TreeServer : public classbase
                VersionString = ServerInstance->GetVersionString();
        }
 
-       /* We use this constructor only to create the 'root' item, TreeRoot, which
+       /** We use this constructor only to create the 'root' item, TreeRoot, which
         * represents our own server. Therefore, it has no route, no parent, and
         * no socket associated with it. Its version string is our own local version.
         */
@@ -225,7 +226,7 @@ class TreeServer : public classbase
                AddHashEntry();
        }
 
-       /* When we create a new server, we call this constructor to initialize it.
+       /** When we create a new server, we call this constructor to initialize it.
         * This constructor initializes the server's Route and Parent, and sets up
         * its ping counters so that it will be pinged one minute from now.
         */
@@ -313,7 +314,7 @@ class TreeServer : public classbase
                return time_to_die.size();
        }
 
-       /* This method is used to add the structure to the
+       /** This method is used to add the structure to the
         * hash_map for linear searches. It is only called
         * by the constructors.
         */
@@ -325,7 +326,7 @@ class TreeServer : public classbase
                        serverlist[this->ServerName.c_str()] = this;
        }
 
-       /* This method removes the reference to this object
+       /** This method removes the reference to this object
         * from the hash_map which is used for linear searches.
         * It is only called by the default destructor.
         */
@@ -337,10 +338,9 @@ class TreeServer : public classbase
                        serverlist.erase(iter);
        }
 
-       /* These accessors etc should be pretty self-
+       /** These accessors etc should be pretty self-
         * explanitory.
         */
-
        TreeServer* GetRoute()
        {
                return Route;
@@ -457,7 +457,7 @@ class TreeServer : public classbase
                return false;
        }
 
-       /* Removes child nodes of this node, and of that node, etc etc.
+       /** Removes child nodes of this node, and of that node, etc etc.
         * This is used during netsplits to automatically tidy up the
         * server tree. It is slow, we don't use it for much else.
         */
@@ -487,13 +487,12 @@ class TreeServer : public classbase
        }
 };
 
-/* The Link class might as well be a struct,
+/** The Link class might as well be a struct,
  * but this is C++ and we don't believe in structs (!).
  * It holds the entire information of one <link>
  * tag from the main config file. We maintain a list
  * of them, and populate the list on rehash/load.
  */
-
 class Link : public classbase
 {
  public:
@@ -520,7 +519,7 @@ Link* FindLink(const std::string& name);
 ConfigReader *Conf;
 std::vector<Link> LinkBlocks;
 
-/* Yay for fast searches!
+/** Yay for fast searches!
  * This is hundreds of times faster than recursion
  * or even scanning a linked list, especially when
  * there are more than a few servers to deal with.
@@ -540,7 +539,7 @@ TreeServer* FindServer(std::string ServerName)
        }
 }
 
-/* Returns the locally connected server we must route a
+/** Returns the locally connected server we must route a
  * message through to reach server 'ServerName'. This
  * only applies to one-to-one and not one-to-many routing.
  * See the comments for the constructor of TreeServer
@@ -561,7 +560,7 @@ TreeServer* BestRouteTo(std::string ServerName)
        }
 }
 
-/* Find the first server matching a given glob mask.
+/** Find the first server matching a given glob mask.
  * Theres no find-using-glob method of hash_map [awwww :-(]
  * so instead, we iterate over the list using an iterator
  * and match each one until we get a hit. Yes its slow,
@@ -594,7 +593,7 @@ class cmd_rconnect : public command_t
                syntax = "<remote-server-mask> <servermask>";
        }
 
-       void Handle (const char** parameters, int pcnt, userrec *user)
+       CmdResult Handle (const char** parameters, int pcnt, userrec *user)
        {
                user->WriteServ("NOTICE %s :*** RCONNECT: Sending remote connect to \002%s\002 to connect server \002%s\002.",user->nick,parameters[0],parameters[1]);
                /* Is this aimed at our server? */
@@ -604,14 +603,19 @@ class cmd_rconnect : public command_t
                        ServerInstance->SNO->WriteToSnoMask('l',"Remote CONNECT from %s matching \002%s\002, connecting server \002%s\002",user->nick,parameters[0],parameters[1]);
                        const char* para[1];
                        para[0] = parameters[1];
-                       Creator->OnPreCommand("CONNECT", para, 1, user, true);
+                       std::string original_command = std::string("CONNECT ") + parameters[1];
+                       Creator->OnPreCommand("CONNECT", para, 1, user, true, original_command);
+
+                       return CMD_SUCCESS;
                }
+
+               return CMD_FAILURE;
        }
 };
  
 
 
-/* Every SERVER connection inbound or outbound is represented by
+/** Every SERVER connection inbound or outbound is represented by
  * an object of type TreeSocket.
  * TreeSockets, being inherited from InspSocket, can be tied into
  * the core socket engine, and we cn therefore receive activity events
@@ -622,7 +626,6 @@ class cmd_rconnect : public command_t
  * maintain a list of servers, some of which are directly connected,
  * some of which are not.
  */
-
 class TreeSocket : public InspSocket
 {
        std::string myhost;
@@ -643,7 +646,7 @@ class TreeSocket : public InspSocket
 
  public:
 
-       /* Because most of the I/O gubbins are encapsulated within
+       /** Because most of the I/O gubbins are encapsulated within
         * InspSocket, we just call the superclass constructor for
         * most of the action, and append a few of our own values
         * to it.
@@ -666,7 +669,7 @@ class TreeSocket : public InspSocket
                this->ctx_out = NULL;
        }
 
-       /* When a listening socket gives us a new file descriptor,
+       /** When a listening socket gives us a new file descriptor,
         * we must associate it with a socket without creating a new
         * connection. This constructor is used for this purpose.
         */
@@ -694,25 +697,28 @@ class TreeSocket : public InspSocket
 
                ctx_in = new AES();
                ctx_out = new AES();
-               ServerInstance->Log(DEBUG,"Initialized AES key %s",key.c_str());
+               Instance->Log(DEBUG,"Initialized AES key %s",key.c_str());
                // key must be 16, 24, 32 etc bytes (multiple of 8)
                keylength = key.length();
                if (!(keylength == 16 || keylength == 24 || keylength == 32))
                {
                        this->Instance->SNO->WriteToSnoMask('l',"\2ERROR\2: Key length for encryptionkey is not 16, 24 or 32 bytes in length!");
-                       ServerInstance->Log(DEBUG,"Key length not 16, 24 or 32 characters!");
+                       Instance->Log(DEBUG,"Key length not 16, 24 or 32 characters!");
                }
                else
                {
-                       this->Instance->SNO->WriteToSnoMask('l',"\2AES\2: Initialized %d bit encryption to server %s",keylength*8,SName.c_str());
-                       ctx_in->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
-                               \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
-                       ctx_out->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
-                               \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
+                       if (this->GetState() != I_ERROR)
+                       {
+                               this->Instance->SNO->WriteToSnoMask('l',"\2AES\2: Initialized %d bit encryption to server %s",keylength*8,SName.c_str());
+                               ctx_in->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
+                                       \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
+                               ctx_out->MakeKey(key.c_str(), "\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\
+                                       \0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0\0", keylength, keylength);
+                       }
                }
        }
        
-       /* When an outbound connection finishes connecting, we receive
+       /** When an outbound connection finishes connecting, we receive
         * this event, and must send our SERVER string to the other
         * side. If the other side is happy, as outlined in the server
         * to server docs on the inspircd.org site, the other side
@@ -727,7 +733,7 @@ class TreeSocket : public InspSocket
                        {
                                if (x->Name == this->myhost)
                                {
-                                       this->Instance->SNO->WriteToSnoMask('l',"Connection to \2"+myhost+"\2["+(x->HiddenFromStats ? "<hidden>" : this->GetIP())+"] established.");
+                                       this->Instance->SNO->WriteToSnoMask('l',"Connection to \2"+myhost+"\2["+(x->HiddenFromStats ? "<hidden>" : this->GetIP())+"] started.");
                                        this->SendCapabilities();
                                        if (x->EncryptionKey != "")
                                        {
@@ -779,7 +785,7 @@ class TreeSocket : public InspSocket
                return true;
        }
 
-       /* Recursively send the server tree with distances as hops.
+       /** Recursively send the server tree with distances as hops.
         * This is used during network burst to inform the other server
         * (and any of ITS servers too) of what servers we know about.
         * If at any point any of these servers already exist on the other
@@ -1022,7 +1028,7 @@ class TreeSocket : public InspSocket
                return true;
        }
 
-       /* This function forces this server to quit, removing this server
+       /** This function forces this server to quit, removing this server
         * and any users on it (and servers and users below that, etc etc).
         * It's very slow and pretty clunky, but luckily unless your network
         * is having a REAL bad hair day, this function shouldnt be called
@@ -1044,7 +1050,7 @@ class TreeSocket : public InspSocket
                num_lost_users += Current->QuitUsers(from);
        }
 
-       /* This is a wrapper function for SquitServer above, which
+       /** This is a wrapper function for SquitServer above, which
         * does some validation first and passes on the SQUIT to all
         * other remaining servers.
         */
@@ -1075,11 +1081,11 @@ class TreeSocket : public InspSocket
                }
                else
                {
-                       ServerInstance->Log(DEFAULT,"Squit from unknown server");
+                       Instance->Log(DEFAULT,"Squit from unknown server");
                }
        }
 
-       /* FMODE command - server mode with timestamp checks */
+       /** FMODE command - server mode with timestamp checks */
        bool ForceMode(std::string source, std::deque<std::string> &params)
        {
                /* Chances are this is a 1.0 FMODE without TS */
@@ -1143,6 +1149,9 @@ class TreeSocket : public InspSocket
                        {
                                ourTS = chan->age;
                        }
+                       else
+                               /* Oops, channel doesnt exist! */
+                               return true;
                }
 
                /* TS is equal: Merge the mode changes, use voooodoooooo on modes
@@ -1150,7 +1159,7 @@ class TreeSocket : public InspSocket
                 */
                if (TS == ourTS)
                {
-                       ServerInstance->Log(DEBUG,"Entering TS equality check");
+                       Instance->Log(DEBUG,"Entering TS equality check");
                        ModeHandler* mh = NULL;
                        unsigned long paramptr = 3;
                        std::string to_bounce = "";
@@ -1260,7 +1269,7 @@ class TreeSocket : public InspSocket
        
                                                                        if ((mh->GetNumParams(adding) > 0) && (paramptr < params.size()))
                                                                        {
-                                                                               ServerInstance->Log(DEBUG,"Mode removal %d %d",adding, mh->GetNumParams(adding));
+                                                                               Instance->Log(DEBUG,"Mode removal %d %d",adding, mh->GetNumParams(adding));
                                                                                params_to_keep.push_back(params[paramptr++]);
                                                                        }
                                                                }
@@ -1294,6 +1303,7 @@ class TreeSocket : public InspSocket
                                newparams.push_back(params[0]);
                                newparams.push_back(ConvToStr(ourTS));
                                newparams.push_back(to_bounce+params_to_bounce);
+                               Instance->Log(DEBUG,"BOUNCE BACK: %s",(to_bounce+params_to_bounce).c_str());
                                DoOneToOne(this->Instance->Config->ServerName,"FMODE",newparams,sourceserv);
                        }
 
@@ -1304,24 +1314,24 @@ class TreeSocket : public InspSocket
                                modelist[0] = params[0].c_str();
                                modelist[1] = to_keep.c_str();
 
-                               if (params_to_keep.size() > 2)
+                               if (params_to_keep.size() > 0)
                                {
-                                       for (q = 2; (q < params_to_keep.size()) && (q < 64); q++)
+                                       for (q = 0; (q < params_to_keep.size()) && (q < 64); q++)
                                        {
-                                               ServerInstance->Log(DEBUG,"Item %d of %d", q, params_to_keep.size());
+                                               Instance->Log(DEBUG,"KEEP Item %d of %d: %s", q, params_to_keep.size(), params_to_keep[q].c_str());
                                                modelist[n++] = params_to_keep[q].c_str();
                                        }
                                }
 
                                if (smode)
                                {
-                                       ServerInstance->Log(DEBUG,"Send mode");
-                                       this->Instance->SendMode(modelist, n+2, who);
+                                       Instance->Log(DEBUG,"Send mode");
+                                       this->Instance->SendMode(modelist, n, who);
                                }
                                else
                                {
-                                       ServerInstance->Log(DEBUG,"Send mode client");
-                                       this->Instance->CallCommandHandler("MODE", modelist, n+2, who);
+                                       Instance->Log(DEBUG,"Send mode client");
+                                       this->Instance->CallCommandHandler("MODE", modelist, n, who);
                                }
 
                                /* HOT POTATO! PASS IT ON! */
@@ -1435,11 +1445,11 @@ class TreeSocket : public InspSocket
                        newparams[2] = modebounce;
                        /* Only send it back the way it came, no need to send it anywhere else */
                        DoOneToOne(this->Instance->Config->ServerName,"FMODE",newparams,sourceserv);
-                       ServerInstance->Log(DEBUG,"FMODE bounced intelligently, our TS less than theirs and the other server is NOT a uline.");
+                       Instance->Log(DEBUG,"FMODE bounced intelligently, our TS less than theirs and the other server is NOT a uline.");
                }
                else
                {
-                       ServerInstance->Log(DEBUG,"Allow modes, TS lower for sender");
+                       Instance->Log(DEBUG,"Allow modes, TS lower for sender");
                        /* The server was ulined, but something iffy is up with the TS.
                         * Sound the alarm bells!
                         */
@@ -1463,7 +1473,7 @@ class TreeSocket : public InspSocket
                return true;
        }
 
-       /* FTOPIC command */
+       /** FTOPIC command */
        bool ForceTopic(std::string source, std::deque<std::string> &params)
        {
                if (params.size() != 4)
@@ -1507,45 +1517,109 @@ class TreeSocket : public InspSocket
                return true;
        }
 
-       /* FJOIN, similar to unreal SJOIN */
+       /** FJOIN, similar to TS6 SJOIN, but not quite. */
        bool ForceJoin(std::string source, std::deque<std::string> &params)
        {
+               /* 1.1 FJOIN works as follows:
+                *
+                * Each FJOIN is sent along with a timestamp, and the side with the lowest
+                * timestamp 'wins'. From this point on we will refer to this side as the
+                * winner. The side with the higher timestamp loses, from this point on we
+                * will call this side the loser or losing side. This should be familiar to
+                * anyone who's dealt with dreamforge or TS6 before.
+                *
+                * When two sides of a split heal and this occurs, the following things
+                * will happen:
+                *
+                * If the timestamps are exactly equal, both sides merge their privilages
+                * and users, as in InspIRCd 1.0 and ircd2.8. The channels have not been
+                * re-created during a split, this is safe to do.
+                *
+                *
+                * If the timestamps are NOT equal, the losing side removes all privilage
+                * modes from all of its users that currently exist in the channel, before
+                * introducing new users into the channel which are listed in the FJOIN
+                * command's parameters. This means, all modes +ohv, and privilages added
+                * by modules, such as +qa. The losing side then LOWERS its timestamp value
+                * of the channel to match that of the winning side, and the modes of the
+                * users of the winning side are merged in with the losing side. The loser
+                * then sends out a set of FMODE commands which 'confirm' that it just
+                * removed all privilage modes from its existing users, which allows for
+                * services packages to still work correctly without needing to know the
+                * timestamping rules which InspIRCd follows. In TS6 servers this is always
+                * a problem, and services packages must contain code which explicitly
+                * behaves as TS6 does, removing ops from the losing side of a split where
+                * neccessary within its internal records, as this state information is
+                * not explicitly echoed out in that protocol.
+                *
+                * The winning side on the other hand will ignore all user modes from the
+                * losing side, so only its own modes get applied. Life is simple for those
+                * who succeed at internets. :-)
+                *
+                * NOTE: Unlike TS6 and dreamforge and other protocols which have SJOIN,
+                * FJOIN does not contain the simple-modes such as +iklmnsp. Why not,
+                * you ask? Well, quite simply because we don't need to. They'll be sent
+                * after the FJOIN by FMODE, and FMODE is timestamped, so in the event
+                * the losing side sends any modes for the channel which shouldnt win,
+                * they wont as their timestamp will be too high :-)
+                */
+
                if (params.size() < 3)
                        return true;
 
-               char first[MAXBUF];
-               char modestring[MAXBUF];
-               char* mode_users[127];
-               memset(&mode_users,0,sizeof(mode_users));
-               mode_users[0] = first;
-               mode_users[1] = modestring;
-               strcpy(modestring,"+");
-               unsigned int modectr = 2;
+               char first[MAXBUF];             /* The first parameter of the mode command */
+               char modestring[MAXBUF];        /* The mode sequence (2nd parameter) of the mode command */
+               char* mode_users[127];          /* The values used by the mode command */
+               memset(&mode_users,0,sizeof(mode_users));       /* Initialize mode parameters */
+               mode_users[0] = first;          /* Set this up to be our on-stack value */
+               mode_users[1] = modestring;     /* Same here as above */
+               strcpy(modestring,"+");         /* Initialize the mode sequence to just '+' */
+               unsigned int modectr = 2;       /* Pointer to the third mode parameter (e.g. the one after the +-sequence) */
                
-               userrec* who = NULL;
-               std::string channel = params[0];
-               time_t TS = atoi(params[1].c_str());
-               char* key = "";
+               userrec* who = NULL;                    /* User we are currently checking */
+               std::string channel = params[0];        /* Channel name, as a string */
+               time_t TS = atoi(params[1].c_str());    /* Timestamp given to us for remote side */
                
+               /* Try and find the channel */
                chanrec* chan = this->Instance->FindChan(channel);
-               if (chan)
-               {
-                       key = chan->key;
-               }
+
+               /* Initialize channel name in the mode parameters */
                strlcpy(mode_users[0],channel.c_str(),MAXBUF);
 
-               /* default is a high value, which if we dont have this
+               /* default TS is a high value, which if we dont have this
                 * channel will let the other side apply their modes.
                 */
                time_t ourTS = time(NULL)+600;
-               chanrec* us = this->Instance->FindChan(channel);
-               if (us)
+
+               /* Does this channel exist? if it does, get its REAL timestamp */
+               if (chan)
+                       ourTS = chan->age;
+
+               /* In 1.1, if they have the newer channel, we immediately clear
+                * all status modes from our users. We then accept their modes.
+                * If WE have the newer channel its the other side's job to do this.
+                * Note that this causes the losing server to send out confirming
+                * FMODE lines.
+                */
+               if (ourTS > TS)
                {
-                       ourTS = us->age;
-               }
+                       std::deque<std::string> param_list;
+
+                       if (chan)
+                               chan->age = TS;
+
+                       /* Lower the TS here */
+                       if (AnnounceTSChange && chan)
+                               chan->WriteChannelWithServ(Instance->Config->ServerName,
+                               "TS for %s changed from %lu to %lu", chan->name, ourTS, TS);
+                       ourTS = TS;
 
-               ServerInstance->Log(DEBUG,"FJOIN detected, our TS=%lu, their TS=%lu",ourTS,TS);
+                       param_list.push_back(channel);
+                       /* Zap all the privilage modes on our side */
+                       this->RemoveStatus(Instance->Config->ServerName, param_list);
+               }
 
+               /* Put the final parameter of the FJOIN into a tokenstream ready to split it */
                irc::tokenstream users(params[2]);
                std::string item = "*";
 
@@ -1554,80 +1628,120 @@ class TreeSocket : public InspSocket
                 */
                params[2] = ":" + params[2];
                DoOneToAllButSender(source,"FJOIN",params,source);
+
+               /* Now, process every 'prefixes,nick' pair */
                while (item != "")
                {
+                       /* Find next user */
                        item = users.GetToken();
-                       /* process one user at a time, applying modes. */
-                       char* usr = (char*)item.c_str();
+
+                       const char* usr = item.c_str();
+
                        /* Safety check just to make sure someones not sent us an FJOIN full of spaces
                         * (is this even possible?) */
                        if (usr && *usr)
                        {
-                               char* permissions = usr;
+                               const char* permissions = usr;
                                int ntimes = 0;
-                               while ((*permissions) && (*permissions != ','))
+                               char* nm = new char[MAXBUF];
+                               char* tnm = nm;
+
+                               /* Iterate through all the prefix values, convert them from prefixes
+                                * to mode letters, and append them to the mode sequence
+                                */
+                               while ((*permissions) && (*permissions != ',') && (ntimes < MAXBUF))
                                {
-                                       ModeHandler* mh = ServerInstance->Modes->FindPrefix(*permissions);
+                                       ModeHandler* mh = Instance->Modes->FindPrefix(*permissions);
                                        if (mh)
                                        {
+                                               /* This is a valid prefix */
                                                ntimes++;
-                                               charlcat(modestring,mh->GetModeChar(),MAXBUF);
+                                               *tnm++ = mh->GetModeChar();
                                        }
                                        else
                                        {
-                                               this->Instance->WriteOpers("ERROR: We received a user with an unknown prefix '%c'. Closed connection to avoid a desync.",mh->GetPrefix());
-                                               this->WriteLine(std::string("ERROR :Invalid prefix '")+mh->GetModeChar()+"' in FJOIN");
+                                               /* Not a valid prefix...
+                                                * danger bill bobbertson! (that's will robinsons older brother ;-) ...)
+                                                */
+                                               this->Instance->WriteOpers("ERROR: We received a user with an unknown prefix '%c'. Closed connection to avoid a desync.",*permissions);
+                                               this->WriteLine(std::string("ERROR :Invalid prefix '")+(*permissions)+"' in FJOIN");
                                                return false;
                                        }
                                        usr++;
                                        permissions++;
                                }
-                               usr++;
 
-                               /* Did they get any modes? How many times? */
-                               for (int k = 0; k < ntimes; k++)
-                                       mode_users[modectr++] = strdup(usr); // XXX
+                               /* Null terminate modes */
+                               *tnm = 0;
+                               /* Advance past the comma, to the nick */
+                               usr++;
 
+                               /* Check the user actually exists */
                                who = this->Instance->FindNick(usr);
                                if (who)
                                {
-                                       chanrec::JoinUser(this->Instance, who, channel.c_str(), true, key);
+                                       /* Did they get any modes? How many times? */
+                                       strlcat(modestring, nm, MAXBUF);
+                                       for (int k = 0; k < ntimes; k++)
+                                               mode_users[modectr++] = strdup(usr);
+
+                                       /* Free temporary buffer used for mode sequence */
+                                       delete[] nm;
+
+                                       /* Check that the user's 'direction' is correct
+                                        * based on the server sending the FJOIN. We must
+                                        * check each nickname in turn, because the origin of
+                                        * the FJOIN may be different to the origin of the nicks
+                                        * in the command itself.
+                                        */
+                                       TreeServer* route_back_again = BestRouteTo(who->server);
+                                       if ((!route_back_again) || (route_back_again->GetSocket() != this))
+                                       {
+                                               /* Oh dear oh dear. */
+                                               Instance->Log(DEBUG,"Fake direction in FJOIN, user '%s'",who->nick);
+                                               continue;
+                                       }
+                                       /* Finally, we can actually place the user into the channel.
+                                        * We're sure its right. Final answer, phone a friend.
+                                        */
+                                       chanrec::JoinUser(this->Instance, who, channel.c_str(), true, "");
+
+                                       /* Have we already queued up MAXMODES modes with parameters
+                                        * (+qaohv) ready to be sent to the server?
+                                        */
                                        if (modectr >= (MAXMODES-1))
                                        {
-                                               /* theres a mode for this user. push them onto the mode queue, and flush it
-                                                * if there are more than MAXMODES to go.
+                                               /* Only actually give the users any status if we lost
+                                                * the FJOIN or drew (equal timestamps).
+                                                * It isn't actually possible for ourTS to be > TS here,
+                                                * only possible to actually have ourTS == TS, or
+                                                * ourTS < TS, because if we lost, we already lowered
+                                                * our TS above before we entered this loop. We only
+                                                * check >= as a safety measure, in case someone stuffed
+                                                * up. If someone DID stuff up, it was most likely me.
+                                                * Note: I do not like baseball bats in the face...
                                                 */
-                                               if ((ourTS >= TS) || (this->Instance->ULine(who->server)))
+                                               if (ourTS >= TS)
                                                {
-                                                       /* We also always let u-lined clients win, no matter what the TS value */
-                                                       ServerInstance->Log(DEBUG,"Our our channel newer than theirs, accepting their modes");
+                                                       Instance->Log(DEBUG,"Our our channel newer than theirs, accepting their modes");
                                                        this->Instance->SendMode((const char**)mode_users,modectr,who);
-                                                       if (ourTS != TS)
+
+                                                       /* Something stuffed up, and for some reason, the timestamp is
+                                                        * NOT lowered right now and should be. Lower it. Usually this
+                                                        * code won't be executed, doubtless someone will remove it some
+                                                        * day soon.
+                                                        */
+                                                       if (ourTS > TS)
                                                        {
-                                                               ServerInstance->Log(DEFAULT,"Channel TS for %s changed from %lu to %lu",us->name,ourTS,TS);
-                                                               us->age = TS;
+                                                               Instance->Log(DEFAULT,"Channel TS for %s changed from %lu to %lu",chan->name,ourTS,TS);
+                                                               chan->age = TS;
                                                                ourTS = TS;
                                                        }
                                                }
-                                               else
-                                               {
-                                                       ServerInstance->Log(DEBUG,"Their channel newer than ours, bouncing their modes");
-                                                       /* bouncy bouncy! */
-                                                       std::deque<std::string> params;
-                                                       /* modes are now being UNSET... */
-                                                       *mode_users[1] = '-';
-                                                       for (unsigned int x = 0; x < modectr; x++)
-                                                       {
-                                                               if (x == 1)
-                                                               {
-                                                                       params.push_back(ConvToStr(us->age));
-                                                               }
-                                                               params.push_back(mode_users[x]);
-                                                               
-                                                       }
-                                                       // tell everyone to bounce the modes. bad modes, bad!
-                                                       DoOneToMany(this->Instance->Config->ServerName,"FMODE",params);
-                                               }
+
+                                               /* Reset all this back to defaults, and
+                                                * free any ram we have left allocated.
+                                                */
                                                strcpy(mode_users[1],"+");
                                                for (unsigned int f = 2; f < modectr; f++)
                                                        free(mode_users[f]);
@@ -1636,73 +1750,52 @@ class TreeSocket : public InspSocket
                                }
                                else
                                {
-                                       for (unsigned int f = 2; f < modectr; f++)
-                                               free(mode_users[f]);
-
-                                       this->WriteLine("ERROR :Invalid user '"+std::string(usr)+"' in FJOIN to '"+channel+"'");
-                                       return false;
+                                       /* Remember to free this */
+                                       delete[] nm;
+                                       /* If we got here, there's a nick in FJOIN which doesnt exist on this server.
+                                        * We don't try to process the nickname here (that WOULD cause a segfault because
+                                        * we'd be playing with null pointers) however, we DO pass the nickname on, just
+                                        * in case somehow we're desynched, so that other users which might be able to see
+                                        * the nickname get their fair chance to process it.
+                                        */
+                                       Instance->Log(SPARSE,"Warning! Invalid user in FJOIN to channel %s IGNORED", channel.c_str());
+                                       continue;
                                }
                        }
                }
+
                /* there werent enough modes built up to flush it during FJOIN,
                 * or, there are a number left over. flush them out.
                 */
-               if ((modectr > 2) && (who) && (us))
+               if ((modectr > 2) && (who) && (chan))
                {
                        if (ourTS >= TS)
                        {
-                               ServerInstance->Log(DEBUG,"Our our channel newer than theirs, accepting their modes");
+                               /* Our channel is newer than theirs. Evil deeds must be afoot. */
                                this->Instance->SendMode((const char**)mode_users,modectr,who);
-                               if (ourTS != TS)
+                               /* Yet again, we can't actually get a true value here, if everything else
+                                * is working as it should.
+                                */
+                               if (ourTS > TS)
                                {
-                                       ServerInstance->Log(DEFAULT,"Channel TS for %s changed from %lu to %lu",us->name,ourTS,TS);
-                                       us->age = TS;
+                                       Instance->Log(DEFAULT,"Channel TS for %s changed from %lu to %lu",chan->name,ourTS,TS);
+                                       chan->age = TS;
                                        ourTS = TS;
                                }
                        }
-                       else
-                       {
-                               ServerInstance->Log(DEBUG,"Their channel newer than ours, bouncing their modes");
-                               std::deque<std::string> params;
-                               *mode_users[1] = '-';
-                               for (unsigned int x = 0; x < modectr; x++)
-                               {
-                                       if (x == 1)
-                                       {
-                                               params.push_back(ConvToStr(us->age));
-                                       }
-                                       params.push_back(mode_users[x]);
-                               }
-                               DoOneToMany(this->Instance->Config->ServerName,"FMODE",params);
-                       }
 
+                       /* Free anything we have left to free */
                        for (unsigned int f = 2; f < modectr; f++)
                                free(mode_users[f]);
                }
-               return true;
-       }
 
-       bool SyncChannelTS(std::string source, std::deque<std::string> &params)
-       {
-               if (params.size() >= 2)
-               {
-                       chanrec* c = this->Instance->FindChan(params[0]);
-                       if (c)
-                       {
-                               time_t theirTS = atoi(params[1].c_str());
-                               time_t ourTS = c->age;
-                               if (ourTS >= theirTS)
-                               {
-                                       ServerInstance->Log(DEBUG,"Updating timestamp for %s, our timestamp was %lu and theirs is %lu",c->name,ourTS,theirTS);
-                                       c->age = theirTS;
-                               }
-                       }
-               }
-               DoOneToAllButSender(this->Instance->Config->ServerName,"SYNCTS",params,source);
+               /* All done. That wasnt so bad was it, you can wipe
+                * the sweat from your forehead now. :-)
+                */
                return true;
        }
 
-       /* NICK command */
+       /** NICK command */
        bool IntroduceClient(std::string source, std::deque<std::string> &params)
        {
                if (params.size() < 8)
@@ -1724,15 +1817,16 @@ class TreeSocket : public InspSocket
                        params[5] = params[5].substr(pos_after_plus);
                
                const char* tempnick = params[1].c_str();
-               ServerInstance->Log(DEBUG,"Introduce client %s!%s@%s",tempnick,params[4].c_str(),params[2].c_str());
+               Instance->Log(DEBUG,"Introduce client %s!%s@%s",tempnick,params[4].c_str(),params[2].c_str());
                
                user_hash::iterator iter = this->Instance->clientlist.find(tempnick);
                
                if (iter != this->Instance->clientlist.end())
                {
                        // nick collision
-                       ServerInstance->Log(DEBUG,"Nick collision on %s!%s@%s: %lu %lu",tempnick,params[4].c_str(),params[2].c_str(),(unsigned long)age,(unsigned long)iter->second->age);
+                       Instance->Log(DEBUG,"Nick collision on %s!%s@%s: %lu %lu",tempnick,params[4].c_str(),params[2].c_str(),(unsigned long)age,(unsigned long)iter->second->age);
                        this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" KILL "+tempnick+" :Nickname collision");
+                       userrec::QuitUser(this->Instance, iter->second, "Nickname collision");
                        return true;
                }
 
@@ -1767,20 +1861,22 @@ class TreeSocket : public InspSocket
                TreeServer* SourceServer = FindServer(source);
                if (SourceServer)
                {
-                       ServerInstance->Log(DEBUG,"Found source server of %s",_new->nick);
+                       Instance->Log(DEBUG,"Found source server of %s",_new->nick);
                        SourceServer->AddUserCount();
                }
 
+               FOREACH_MOD(I_OnPostConnect,OnPostConnect(_new));
+
                return true;
        }
 
-       /* Send one or more FJOINs for a channel of users.
+       /** Send one or more FJOINs for a channel of users.
         * If the length of a single line is more than 480-NICKMAX
         * in length, it is split over multiple lines.
         */
        void SendFJoins(TreeServer* Current, chanrec* c)
        {
-               ServerInstance->Log(DEBUG,"Sending FJOINs to other server for %s",c->name);
+               Instance->Log(DEBUG,"Sending FJOINs to other server for %s",c->name);
                char list[MAXBUF];
                std::string individual_halfops = std::string(":")+this->Instance->Config->ServerName+" FMODE "+c->name+" "+ConvToStr(c->age);
                
@@ -1826,7 +1922,7 @@ class TreeSocket : public InspSocket
                this->WriteLine(std::string(":")+this->Instance->Config->ServerName+" FMODE "+c->name+" "+ConvToStr(c->age)+" +"+c->ChanModes(true)+modes+" "+params);
        }
 
-       /* Send G, Q, Z and E lines */
+       /** Send G, Q, Z and E lines */
        void SendXLines(TreeServer* Current)
        {
                char data[MAXBUF];
@@ -1834,49 +1930,49 @@ class TreeSocket : public InspSocket
                const char* sn = n.c_str();
                int iterations = 0;
                /* Yes, these arent too nice looking, but they get the job done */
-               for (std::vector<ZLine>::iterator i = Instance->XLines->zlines.begin(); i != Instance->XLines->zlines.end(); i++, iterations++)
+               for (std::vector<ZLine*>::iterator i = Instance->XLines->zlines.begin(); i != Instance->XLines->zlines.end(); i++, iterations++)
                {
-                       snprintf(data,MAXBUF,":%s ADDLINE Z %s %s %lu %lu :%s",sn,i->ipaddr,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       snprintf(data,MAXBUF,":%s ADDLINE Z %s %s %lu %lu :%s",sn,(*i)->ipaddr,(*i)->source,(unsigned long)(*i)->set_time,(unsigned long)(*i)->duration,(*i)->reason);
                        this->WriteLine(data);
                }
-               for (std::vector<QLine>::iterator i = Instance->XLines->qlines.begin(); i != Instance->XLines->qlines.end(); i++, iterations++)
+               for (std::vector<QLine*>::iterator i = Instance->XLines->qlines.begin(); i != Instance->XLines->qlines.end(); i++, iterations++)
                {
-                       snprintf(data,MAXBUF,":%s ADDLINE Q %s %s %lu %lu :%s",sn,i->nick,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       snprintf(data,MAXBUF,":%s ADDLINE Q %s %s %lu %lu :%s",sn,(*i)->nick,(*i)->source,(unsigned long)(*i)->set_time,(unsigned long)(*i)->duration,(*i)->reason);
                        this->WriteLine(data);
                }
-               for (std::vector<GLine>::iterator i = Instance->XLines->glines.begin(); i != Instance->XLines->glines.end(); i++, iterations++)
+               for (std::vector<GLine*>::iterator i = Instance->XLines->glines.begin(); i != Instance->XLines->glines.end(); i++, iterations++)
                {
-                       snprintf(data,MAXBUF,":%s ADDLINE G %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       snprintf(data,MAXBUF,":%s ADDLINE G %s %s %lu %lu :%s",sn,(*i)->hostmask,(*i)->source,(unsigned long)(*i)->set_time,(unsigned long)(*i)->duration,(*i)->reason);
                        this->WriteLine(data);
                }
-               for (std::vector<ELine>::iterator i = Instance->XLines->elines.begin(); i != Instance->XLines->elines.end(); i++, iterations++)
+               for (std::vector<ELine*>::iterator i = Instance->XLines->elines.begin(); i != Instance->XLines->elines.end(); i++, iterations++)
                {
-                       snprintf(data,MAXBUF,":%s ADDLINE E %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       snprintf(data,MAXBUF,":%s ADDLINE E %s %s %lu %lu :%s",sn,(*i)->hostmask,(*i)->source,(unsigned long)(*i)->set_time,(unsigned long)(*i)->duration,(*i)->reason);
                        this->WriteLine(data);
                }
-               for (std::vector<ZLine>::iterator i = Instance->XLines->pzlines.begin(); i != Instance->XLines->pzlines.end(); i++, iterations++)
+               for (std::vector<ZLine*>::iterator i = Instance->XLines->pzlines.begin(); i != Instance->XLines->pzlines.end(); i++, iterations++)
                {
-                       snprintf(data,MAXBUF,":%s ADDLINE Z %s %s %lu %lu :%s",sn,i->ipaddr,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       snprintf(data,MAXBUF,":%s ADDLINE Z %s %s %lu %lu :%s",sn,(*i)->ipaddr,(*i)->source,(unsigned long)(*i)->set_time,(unsigned long)(*i)->duration,(*i)->reason);
                        this->WriteLine(data);
                }
-               for (std::vector<QLine>::iterator i = Instance->XLines->pqlines.begin(); i != Instance->XLines->pqlines.end(); i++, iterations++)
+               for (std::vector<QLine*>::iterator i = Instance->XLines->pqlines.begin(); i != Instance->XLines->pqlines.end(); i++, iterations++)
                {
-                       snprintf(data,MAXBUF,":%s ADDLINE Q %s %s %lu %lu :%s",sn,i->nick,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       snprintf(data,MAXBUF,":%s ADDLINE Q %s %s %lu %lu :%s",sn,(*i)->nick,(*i)->source,(unsigned long)(*i)->set_time,(unsigned long)(*i)->duration,(*i)->reason);
                        this->WriteLine(data);
                }
-               for (std::vector<GLine>::iterator i = Instance->XLines->pglines.begin(); i != Instance->XLines->pglines.end(); i++, iterations++)
+               for (std::vector<GLine*>::iterator i = Instance->XLines->pglines.begin(); i != Instance->XLines->pglines.end(); i++, iterations++)
                {
-                       snprintf(data,MAXBUF,":%s ADDLINE G %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       snprintf(data,MAXBUF,":%s ADDLINE G %s %s %lu %lu :%s",sn,(*i)->hostmask,(*i)->source,(unsigned long)(*i)->set_time,(unsigned long)(*i)->duration,(*i)->reason);
                        this->WriteLine(data);
                }
-               for (std::vector<ELine>::iterator i = Instance->XLines->pelines.begin(); i != Instance->XLines->pelines.end(); i++, iterations++)
+               for (std::vector<ELine*>::iterator i = Instance->XLines->pelines.begin(); i != Instance->XLines->pelines.end(); i++, iterations++)
                {
-                       snprintf(data,MAXBUF,":%s ADDLINE E %s %s %lu %lu :%s",sn,i->hostmask,i->source,(unsigned long)i->set_time,(unsigned long)i->duration,i->reason);
+                       snprintf(data,MAXBUF,":%s ADDLINE E %s %s %lu %lu :%s",sn,(*i)->hostmask,(*i)->source,(unsigned long)(*i)->set_time,(unsigned long)(*i)->duration,(*i)->reason);
                        this->WriteLine(data);
                }
        }
 
-       /* Send channel modes and topics */
+       /** Send channel modes and topics */
        void SendChannelModes(TreeServer* Current)
        {
                char data[MAXBUF];
@@ -1902,7 +1998,7 @@ class TreeSocket : public InspSocket
                }
        }
 
-       /* send all users and their oper state/modes */
+       /** send all users and their oper state/modes */
        void SendUsers(TreeServer* Current)
        {
                char data[MAXBUF];
@@ -1933,7 +2029,7 @@ class TreeSocket : public InspSocket
                }
        }
 
-       /* This function is called when we want to send a netburst to a local
+       /** This function is called when we want to send a netburst to a local
         * server. There is a set order we must do this, because for example
         * users require their servers to exist, and channels require their
         * users to exist. You get the idea.
@@ -1960,7 +2056,7 @@ class TreeSocket : public InspSocket
                this->Instance->SNO->WriteToSnoMask('l',"Finished bursting to \2"+name+"\2.");
        }
 
-       /* This function is called when we receive data from a remote
+       /** This function is called when we receive data from a remote
         * server. We buffer the data in a std::string (it doesnt stay
         * there for long), reading using InspSocket::Read() which can
         * read up to 16 kilobytes in one operation.
@@ -1993,14 +2089,12 @@ class TreeSocket : public InspSocket
                                        char result[1024];
                                        memset(result,0,1024);
                                        memset(out,0,1024);
-                                       ServerInstance->Log(DEBUG,"Original string '%s'",ret.c_str());
                                        /* ERROR + CAPAB is still allowed unencryped */
                                        if ((ret.substr(0,7) != "ERROR :") && (ret.substr(0,6) != "CAPAB "))
                                        {
                                                int nbytes = from64tobits(out, ret.c_str(), 1024);
                                                if ((nbytes > 0) && (nbytes < 1024))
                                                {
-                                                       ServerInstance->Log(DEBUG,"m_spanningtree: decrypt %d bytes",nbytes);
                                                        ctx_in->Decrypt(out, result, nbytes, 0);
                                                        for (int t = 0; t < nbytes; t++)
                                                                if (result[t] == '\7') result[t] = 0;
@@ -2010,7 +2104,7 @@ class TreeSocket : public InspSocket
                                }
                                if (!this->ProcessLine(ret))
                                {
-                                       ServerInstance->Log(DEBUG,"ProcessLine says no!");
+                                       Instance->Log(DEBUG,"ProcessLine says no!");
                                        return false;
                                }
                        }
@@ -2024,7 +2118,7 @@ class TreeSocket : public InspSocket
 
        int WriteLine(std::string line)
        {
-               ServerInstance->Log(DEBUG,"OUT: %s",line.c_str());
+               Instance->Log(DEBUG,"OUT: %s",line.c_str());
                if (this->ctx_out)
                {
                        char result[10240];
@@ -2034,16 +2128,12 @@ class TreeSocket : public InspSocket
                                // pad it to the key length
                                int n = this->keylength - (line.length() % this->keylength);
                                if (n)
-                               {
-                                       ServerInstance->Log(DEBUG,"Append %d chars to line to make it %d long from %d, key length %d",n,n+line.length(),line.length(),this->keylength);
                                        line.append(n,'\7');
-                               }
                        }
                        unsigned int ll = line.length();
                        ctx_out->Encrypt(line.c_str(), result, ll, 0);
                        to64frombits((unsigned char*)result64,(unsigned char*)result,ll);
                        line = result64;
-                       //int from64tobits(char *out, const char *in, int maxlen);
                }
                return this->Write(line + "\r\n");
        }
@@ -2058,7 +2148,7 @@ class TreeSocket : public InspSocket
                return false;
        }
 
-       /* remote MOTD. leet, huh? */
+       /** remote MOTD. leet, huh? */
        bool Motd(std::string prefix, std::deque<std::string> &params)
        {
                if (params.size() > 0)
@@ -2075,23 +2165,23 @@ class TreeSocket : public InspSocket
                                        par.push_back(prefix);
                                        par.push_back("");
 
-                                       if (!ServerInstance->Config->MOTD.size())
+                                       if (!Instance->Config->MOTD.size())
                                        {
-                                               par[1] = std::string("::")+ServerInstance->Config->ServerName+" 422 "+source->nick+" :Message of the day file is missing.";
+                                               par[1] = std::string("::")+Instance->Config->ServerName+" 422 "+source->nick+" :Message of the day file is missing.";
                                                DoOneToOne(this->Instance->Config->ServerName, "PUSH",par, source->server);
                                                return true;
                                        }
    
-                                       par[1] = std::string("::")+ServerInstance->Config->ServerName+" 375 "+source->nick+" :"+ServerInstance->Config->ServerName+" message of the day";
+                                       par[1] = std::string("::")+Instance->Config->ServerName+" 375 "+source->nick+" :"+Instance->Config->ServerName+" message of the day";
                                        DoOneToOne(this->Instance->Config->ServerName, "PUSH",par, source->server);
    
-                                       for (unsigned int i = 0; i < ServerInstance->Config->MOTD.size(); i++)
+                                       for (unsigned int i = 0; i < Instance->Config->MOTD.size(); i++)
                                        {
-                                               par[1] = std::string("::")+ServerInstance->Config->ServerName+" 372 "+source->nick+" :- "+ServerInstance->Config->MOTD[i];
+                                               par[1] = std::string("::")+Instance->Config->ServerName+" 372 "+source->nick+" :- "+Instance->Config->MOTD[i];
                                                DoOneToOne(this->Instance->Config->ServerName, "PUSH",par, source->server);
                                        }
      
-                                       par[1] = std::string("::")+ServerInstance->Config->ServerName+" 376 "+source->nick+" End of message of the day.";
+                                       par[1] = std::string("::")+Instance->Config->ServerName+" 376 "+source->nick+" End of message of the day.";
                                        DoOneToOne(this->Instance->Config->ServerName, "PUSH",par, source->server);
                                }
                        }
@@ -2106,7 +2196,7 @@ class TreeSocket : public InspSocket
                return true;
        }
 
-       /* remote ADMIN. leet, huh? */
+       /** remote ADMIN. leet, huh? */
        bool Admin(std::string prefix, std::deque<std::string> &params)
        {
                if (params.size() > 0)
@@ -2123,16 +2213,16 @@ class TreeSocket : public InspSocket
                                        par.push_back(prefix);
                                        par.push_back("");
 
-                                       par[1] = std::string("::")+ServerInstance->Config->ServerName+" 256 "+source->nick+" :Administrative info for "+ServerInstance->Config->ServerName;
+                                       par[1] = std::string("::")+Instance->Config->ServerName+" 256 "+source->nick+" :Administrative info for "+Instance->Config->ServerName;
                                        DoOneToOne(this->Instance->Config->ServerName, "PUSH",par, source->server);
 
-                                       par[1] = std::string("::")+ServerInstance->Config->ServerName+" 257 "+source->nick+" :Name     - "+ServerInstance->Config->AdminName;
+                                       par[1] = std::string("::")+Instance->Config->ServerName+" 257 "+source->nick+" :Name     - "+Instance->Config->AdminName;
                                        DoOneToOne(this->Instance->Config->ServerName, "PUSH",par, source->server);
 
-                                       par[1] = std::string("::")+ServerInstance->Config->ServerName+" 258 "+source->nick+" :Nickname - "+ServerInstance->Config->AdminNick;
+                                       par[1] = std::string("::")+Instance->Config->ServerName+" 258 "+source->nick+" :Nickname - "+Instance->Config->AdminNick;
                                        DoOneToOne(this->Instance->Config->ServerName, "PUSH",par, source->server);
 
-                                       par[1] = std::string("::")+ServerInstance->Config->ServerName+" 258 "+source->nick+" :E-Mail   - "+ServerInstance->Config->AdminEmail;
+                                       par[1] = std::string("::")+Instance->Config->ServerName+" 258 "+source->nick+" :E-Mail   - "+Instance->Config->AdminEmail;
                                        DoOneToOne(this->Instance->Config->ServerName, "PUSH",par, source->server);
                                }
                        }
@@ -2184,14 +2274,14 @@ class TreeSocket : public InspSocket
        }
 
 
-       /* Because the core won't let users or even SERVERS set +o,
+       /** Because the core won't let users or even SERVERS set +o,
         * we use the OPERTYPE command to do this.
         */
        bool OperType(std::string prefix, std::deque<std::string> &params)
        {
                if (params.size() != 1)
                {
-                       ServerInstance->Log(DEBUG,"Received invalid oper type from %s",prefix.c_str());
+                       Instance->Log(DEBUG,"Received invalid oper type from %s",prefix.c_str());
                        return true;
                }
                std::string opertype = params[0];
@@ -2205,7 +2295,7 @@ class TreeSocket : public InspSocket
                return true;
        }
 
-       /* Because Andy insists that services-compatible servers must
+       /** Because Andy insists that services-compatible servers must
         * implement SVSNICK and SVSJOIN, that's exactly what we do :p
         */
        bool ForceNick(std::string prefix, std::deque<std::string> &params)
@@ -2263,6 +2353,7 @@ class TreeSocket : public InspSocket
                        this->Instance->SNO->WriteToSnoMask('l',"Remote rehash initiated from server \002"+prefix+"\002.");
                        this->Instance->RehashServer();
                        ReadConfiguration(false);
+                       InitializeDisabledCommands(ServerInstance->Config->DisabledCommands, ServerInstance);
                }
                DoOneToAllButSender(prefix,"REHASH",params,prefix);
                return true;
@@ -2416,23 +2507,23 @@ class TreeSocket : public InspSocket
                switch (*(params[0].c_str()))
                {
                        case 'Z':
-                               propogate = ServerInstance->XLines->add_zline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
-                               ServerInstance->XLines->zline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
+                               propogate = Instance->XLines->add_zline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
+                               Instance->XLines->zline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
                        break;
                        case 'Q':
-                               propogate = ServerInstance->XLines->add_qline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
-                               ServerInstance->XLines->qline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
+                               propogate = Instance->XLines->add_qline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
+                               Instance->XLines->qline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
                        break;
                        case 'E':
-                               propogate = ServerInstance->XLines->add_eline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
-                               ServerInstance->XLines->eline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
+                               propogate = Instance->XLines->add_eline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
+                               Instance->XLines->eline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
                        break;
                        case 'G':
-                               propogate = ServerInstance->XLines->add_gline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
-                               ServerInstance->XLines->gline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
+                               propogate = Instance->XLines->add_gline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
+                               Instance->XLines->gline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
                        break;
                        case 'K':
-                               propogate = ServerInstance->XLines->add_kline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
+                               propogate = Instance->XLines->add_kline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
                        break;
                        default:
                                /* Just in case... */
@@ -2457,8 +2548,8 @@ class TreeSocket : public InspSocket
                }
                if (!this->bursting)
                {
-                       ServerInstance->Log(DEBUG,"Applying lines...");
-                       ServerInstance->XLines->apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
+                       Instance->Log(DEBUG,"Applying lines...");
+                       Instance->XLines->apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
                }
                return true;
        }
@@ -2484,12 +2575,12 @@ class TreeSocket : public InspSocket
                if (params.size() < 1)
                        return true;
 
-               ServerInstance->Log(DEBUG,"In IDLE command");
+               Instance->Log(DEBUG,"In IDLE command");
                userrec* u = this->Instance->FindNick(prefix);
 
                if (u)
                {
-                       ServerInstance->Log(DEBUG,"USER EXISTS: %s",u->nick);
+                       Instance->Log(DEBUG,"USER EXISTS: %s",u->nick);
                        // an incoming request
                        if (params.size() == 1)
                        {
@@ -2497,10 +2588,9 @@ class TreeSocket : public InspSocket
                                if ((x) && (IS_LOCAL(x)))
                                {
                                        userrec* x = this->Instance->FindNick(params[0]);
-                                       ServerInstance->Log(DEBUG,"Got IDLE");
                                        char signon[MAXBUF];
                                        char idle[MAXBUF];
-                                       ServerInstance->Log(DEBUG,"Sending back IDLE 3");
+
                                        snprintf(signon,MAXBUF,"%lu",(unsigned long)x->signon);
                                        snprintf(idle,MAXBUF,"%lu",(unsigned long)abs((x->idle_lastmsg)-time(NULL)));
                                        std::deque<std::string> par;
@@ -2522,7 +2612,6 @@ class TreeSocket : public InspSocket
                                userrec* who_to_send_to = this->Instance->FindNick(who_did_the_whois);
                                if ((who_to_send_to) && (IS_LOCAL(who_to_send_to)))
                                {
-                                       ServerInstance->Log(DEBUG,"Got final IDLE");
                                        // an incoming reply to a whois we sent out
                                        std::string nick_whoised = prefix;
                                        unsigned long signon = atoi(params[1].c_str());
@@ -2643,6 +2732,64 @@ class TreeSocket : public InspSocket
                }
        }
 
+       bool RemoveStatus(std::string prefix, std::deque<std::string> &params)
+       {
+               if (params.size() < 1)
+                       return true;
+
+               chanrec* c = Instance->FindChan(params[0]);
+
+               if (c)
+               {
+                       irc::modestacker modestack(false);
+                       CUList *ulist = c->GetUsers();
+                       const char* y[127];
+                       std::deque<std::string> stackresult;
+                       std::string x;
+
+                       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
+                       {
+                               std::string modesequence = Instance->Modes->ModeString(i->second, c);
+                               if (modesequence.length())
+                               {
+                                       ServerInstance->Log(DEBUG,"Mode sequence = '%s'",modesequence.c_str());
+                                       irc::spacesepstream sep(modesequence);
+                                       std::string modeletters = sep.GetToken();
+                                       ServerInstance->Log(DEBUG,"Mode letters = '%s'",modeletters.c_str());
+                                       
+                                       while (!modeletters.empty())
+                                       {
+                                               char mletter = *(modeletters.begin());
+                                               modestack.Push(mletter,sep.GetToken());
+                                               ServerInstance->Log(DEBUG,"Push letter = '%c'",mletter);
+                                               modeletters.erase(modeletters.begin());
+                                               ServerInstance->Log(DEBUG,"Mode letters = '%s'",modeletters.c_str());
+                                       }
+                               }
+                       }
+
+                       while (modestack.GetStackedLine(stackresult))
+                       {
+                               ServerInstance->Log(DEBUG,"Stacked line size %d",stackresult.size());
+                               stackresult.push_front(ConvToStr(c->age));
+                               stackresult.push_front(c->name);
+                               DoOneToMany(Instance->Config->ServerName, "FMODE", stackresult);
+                               stackresult.erase(stackresult.begin() + 1);
+                               ServerInstance->Log(DEBUG,"Stacked items:");
+                               for (size_t z = 0; z < stackresult.size(); z++)
+                               {
+                                       y[z] = stackresult[z].c_str();
+                                       ServerInstance->Log(DEBUG,"\tstackresult[%d]='%s'",z,stackresult[z].c_str());
+                               }
+                               userrec* n = new userrec(Instance);
+                               n->SetFd(FD_MAGIC_NUMBER);
+                               Instance->SendMode(y, stackresult.size(), n);
+                               delete n;
+                       }
+               }
+               return true;
+       }
+
        bool RemoteServer(std::string prefix, std::deque<std::string> &params)
        {
                if (params.size() < 4)
@@ -2799,7 +2946,7 @@ class TreeSocket : public InspSocket
                
                line = line.substr(0, line.find_first_of("\r\n"));
                
-               ServerInstance->Log(DEBUG,"IN: %s", line.c_str());
+               Instance->Log(DEBUG,"IN: %s", line.c_str());
                
                this->Split(line.c_str(),params);
                        
@@ -2962,7 +3109,7 @@ class TreeSocket : public InspSocket
                                        if ((!route_back_again) || (route_back_again->GetSocket() != this))
                                        {
                                                if (route_back_again)
-                                                       ServerInstance->Log(DEBUG,"Protocol violation: Fake direction in command '%s' from connection '%s'",line.c_str(),this->GetName().c_str());
+                                                       Instance->Log(DEBUG,"Protocol violation: Fake direction in command '%s' from connection '%s'",line.c_str(),this->GetName().c_str());
                                                return true;
                                        }
 
@@ -3038,6 +3185,10 @@ class TreeSocket : public InspSocket
                                {
                                        return this->MetaData(prefix,params);
                                }
+                               else if (command == "REMSTATUS")
+                               {
+                                       return this->RemoveStatus(prefix,params);
+                               }
                                else if (command == "PING")
                                {
                                        /*
@@ -3048,7 +3199,7 @@ class TreeSocket : public InspSocket
                                        if (this->bursting)
                                        {
                                                this->bursting = false;
-                                               ServerInstance->XLines->apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
+                                               Instance->XLines->apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
                                        }
                                        if (prefix == "")
                                        {
@@ -3066,7 +3217,7 @@ class TreeSocket : public InspSocket
                                        if (this->bursting)
                                        {
                                                this->bursting = false;
-                                               ServerInstance->XLines->apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
+                                               Instance->XLines->apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
                                        }
                                        if (prefix == "")
                                        {
@@ -3149,7 +3300,7 @@ class TreeSocket : public InspSocket
                                else if (command == "ENDBURST")
                                {
                                        this->bursting = false;
-                                       ServerInstance->XLines->apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
+                                       Instance->XLines->apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
                                        std::string sourceserv = this->myhost;
                                        if (this->InboundServerName != "")
                                        {
@@ -3204,10 +3355,18 @@ class TreeSocket : public InspSocket
                                                {
                                                        strparams[q] = params[q].c_str();
                                                }
-                                               if (!this->Instance->CallCommandHandler(command.c_str(), strparams, params.size(), who))
+                                               switch (this->Instance->CallCommandHandler(command.c_str(), strparams, params.size(), who))
                                                {
-                                                       this->WriteLine("ERROR :Unrecognised command '"+std::string(command.c_str())+"' -- possibly loaded mismatched modules");
-                                                       return false;
+                                                       case CMD_INVALID:
+                                                               this->WriteLine("ERROR :Unrecognised command '"+std::string(command.c_str())+"' -- possibly loaded mismatched modules");
+                                                               return false;
+                                                       break;
+                                                       case CMD_FAILURE:
+                                                               return true;
+                                                       break;
+                                                       default:
+                                                               /* CMD_SUCCESS and CMD_USER_DELETED fall through here */
+                                                       break;
                                                }
                                        }
                                        else
@@ -3219,7 +3378,7 @@ class TreeSocket : public InspSocket
                                                }
                                                else
                                                {
-                                                       ServerInstance->Log(DEBUG,"Command with unknown origin '%s'",prefix.c_str());
+                                                       Instance->Log(DEBUG,"Command with unknown origin '%s'",prefix.c_str());
                                                        return true;
                                                }
                                        }
@@ -3384,7 +3543,7 @@ void AddThisServer(TreeServer* server, std::deque<TreeServer*> &list)
        list.push_back(server);
 }
 
-// returns a list of DIRECT servernames for a specific channel
+/** returns a list of DIRECT servernames for a specific channel */
 void GetListOfServersForChannel(chanrec* c, std::deque<TreeServer*> &list)
 {
        CUList *ulist = c->GetUsers();
@@ -3570,9 +3729,10 @@ void ReadConfiguration(bool rebind)
                {
                        std::string Type = Conf->ReadValue("bind","type",j);
                        std::string IP = Conf->ReadValue("bind","address",j);
-                       long Port = Conf->ReadInteger("bind","port",j,true);
+                       int Port = Conf->ReadInteger("bind","port",j,true);
                        if (Type == "servers")
                        {
+                               ServerInstance->Log(DEBUG,"m_spanningtree: Binding server port %s:%d", IP.c_str(), Port);
                                if (IP == "*")
                                {
                                        IP = "";
@@ -3580,6 +3740,7 @@ void ReadConfiguration(bool rebind)
                                TreeSocket* listener = new TreeSocket(ServerInstance, IP.c_str(),Port,true,10);
                                if (listener->GetState() == I_LISTENING)
                                {
+                                       ServerInstance->Log(DEFAULT,"m_spanningtree: Binding server port %s:%d successful!", IP.c_str(), Port);
                                        Bindings.push_back(listener);
                                }
                                else
@@ -3588,11 +3749,13 @@ void ReadConfiguration(bool rebind)
                                        listener->Close();
                                        DELETE(listener);
                                }
+                               ServerInstance->Log(DEBUG,"Done with this binding");
                        }
                }
        }
        FlatLinks = Conf->ReadFlag("options","flatlinks",0);
        HideULines = Conf->ReadFlag("options","hideulines",0);
+       AnnounceTSChange = Conf->ReadFlag("options","announcets",0);
        LinkBlocks.clear();
        ValidIPs.clear();
        for (int j =0; j < Conf->Enumerate("link"); j++)
@@ -3672,7 +3835,6 @@ void ReadConfiguration(bool rebind)
 
 class ModuleSpanningTree : public Module
 {
-       std::vector<TreeSocket*> Bindings;
        int line;
        int NumServers;
        unsigned int max_local;
@@ -4240,7 +4402,7 @@ class ModuleSpanningTree : public Module
                return 0;
        }
 
-       virtual int OnPreCommand(const std::string &command, const char** parameters, int pcnt, userrec *user, bool validated)
+       virtual int OnPreCommand(const std::string &command, const char** parameters, int pcnt, userrec *user, bool validated, const std::string &original_line)
        {
                /* If the command doesnt appear to be valid, we dont want to mess with it. */
                if (!validated)
@@ -4298,7 +4460,13 @@ class ModuleSpanningTree : public Module
                        this->HandleVersion(parameters,pcnt,user);
                        return 1;
                }
-               else if (ServerInstance->IsValidModuleCommand(command, pcnt, user))
+
+               return 0;
+       }
+
+       virtual void OnPostCommand(const std::string &command, const char** parameters, int pcnt, userrec *user, CmdResult result, const std::string &original_line)
+       {
+               if ((result == CMD_SUCCESS) && (ServerInstance->IsValidModuleCommand(command, pcnt, user)))
                {
                        // this bit of code cleverly routes all module commands
                        // to all remote severs *automatically* so that modules
@@ -4321,7 +4489,6 @@ class ModuleSpanningTree : public Module
                        ServerInstance->Log(DEBUG,"Globally route '%s'",command.c_str());
                        DoOneToMany(user->nick,command,params);
                }
-               return 0;
        }
 
        virtual void OnGetServerDescription(const std::string &servername,std::string &description)
@@ -4476,24 +4643,14 @@ class ModuleSpanningTree : public Module
                        std::deque<std::string> params;
                        params.clear();
                        params.push_back(channel->name);
-
-                       if (channel->GetUserCounter() > 1)
-                       {
-                               // not the first in the channel
-                               DoOneToMany(user->nick,"JOIN",params);
-                       }
-                       else
-                       {
-                               // first in the channel, set up their permissions
-                               // and the channel TS with FJOIN.
-                               char ts[24];
-                               snprintf(ts,24,"%lu",(unsigned long)channel->age);
-                               params.clear();
-                               params.push_back(channel->name);
-                               params.push_back(ts);
-                               params.push_back("@,"+std::string(user->nick));
-                               DoOneToMany(ServerInstance->Config->ServerName,"FJOIN",params);
-                       }
+                       // set up their permissions and the channel TS with FJOIN.
+                       // All users are FJOINed now, because a module may specify
+                       // new joining permissions for the user.
+                       params.clear();
+                       params.push_back(channel->name);
+                       params.push_back(ConvToStr(channel->age));
+                       params.push_back(std::string(channel->GetAllPrefixChars(user))+","+std::string(user->nick));
+                       DoOneToMany(ServerInstance->Config->ServerName,"FJOIN",params);
                }
        }
 
@@ -4792,17 +4949,26 @@ class ModuleSpanningTree : public Module
 
        virtual void OnEvent(Event* event)
        {
+               std::deque<std::string>* params = (std::deque<std::string>*)event->GetData();
+
                if (event->GetEventID() == "send_metadata")
                {
-                       std::deque<std::string>* params = (std::deque<std::string>*)event->GetData();
                        if (params->size() < 3)
                                return;
                        (*params)[2] = ":" + (*params)[2];
                        DoOneToMany(ServerInstance->Config->ServerName,"METADATA",*params);
                }
+               else if (event->GetEventID() == "send_topic")
+               {
+                       if (params->size() < 2)
+                               return;
+                       (*params)[1] = ":" + (*params)[1];
+                       params->insert(params->begin() + 1,ServerInstance->Config->ServerName);
+                       params->insert(params->begin() + 1,ConvToStr(ServerInstance->Time()));
+                       DoOneToMany(ServerInstance->Config->ServerName,"FTOPIC",*params);
+               }
                else if (event->GetEventID() == "send_mode")
                {
-                       std::deque<std::string>* params = (std::deque<std::string>*)event->GetData();
                        if (params->size() < 2)
                                return;
                        // Insert the TS value of the object, either userrec or chanrec
@@ -4827,11 +4993,33 @@ class ModuleSpanningTree : public Module
 
        virtual ~ModuleSpanningTree()
        {
+               ServerInstance->Log(DEBUG,"Performing unload of spanningtree!");
+               ServerInstance->Log(DEBUG,"Freeing %d bindings...",Bindings.size());
+               for (unsigned int i = 0; i < Bindings.size(); i++)
+               {
+                       ServerInstance->Log(DEBUG,"Freeing binding %d of %d",i, Bindings.size());
+                       ServerInstance->SE->DelFd(Bindings[i]);
+                       Bindings[i]->Close();
+                       DELETE(Bindings[i]);
+               }
+               ServerInstance->Log(DEBUG,"Freeing connected servers...");
+               while (TreeRoot->ChildCount())
+               {
+                       TreeServer* child_server = TreeRoot->GetChild(0);
+                       ServerInstance->Log(DEBUG,"Freeing connected server %s", child_server->GetName().c_str());
+                       if (child_server)
+                       {
+                               TreeSocket* sock = child_server->GetSocket();
+                               ServerInstance->SE->DelFd(sock);
+                               sock->Close();
+                               DELETE(sock);
+                       }
+               }              
        }
 
        virtual Version GetVersion()
        {
-               return Version(1,0,0,0,VF_STATIC|VF_VENDOR);
+               return Version(1,1,0,2,VF_VENDOR,API_VERSION);
        }
 
        void Implements(char* List)
@@ -4842,7 +5030,7 @@ class ModuleSpanningTree : public Module
                List[I_OnUserQuit] = List[I_OnUserPostNick] = List[I_OnUserKick] = List[I_OnRemoteKill] = List[I_OnRehash] = 1;
                List[I_OnOper] = List[I_OnAddGLine] = List[I_OnAddZLine] = List[I_OnAddQLine] = List[I_OnAddELine] = 1;
                List[I_OnDelGLine] = List[I_OnDelZLine] = List[I_OnDelQLine] = List[I_OnDelELine] = List[I_ProtoSendMode] = List[I_OnMode] = 1;
-               List[I_OnStats] = List[I_ProtoSendMetaData] = List[I_OnEvent] = List[I_OnSetAway] = List[I_OnCancelAway] = 1;
+               List[I_OnStats] = List[I_ProtoSendMetaData] = List[I_OnEvent] = List[I_OnSetAway] = List[I_OnCancelAway] = List[I_OnPostCommand] = 1;
        }
 
        /* It is IMPORTANT that m_spanningtree is the last module in the chain