]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree.cpp
Fixes :P
[user/henk/code/inspircd.git] / src / modules / m_spanningtree.cpp
index 94c610970eccf37a299768d8b752ecf65745eec5..78c37c5848f22354897eefe7427d0772afa4cea7 100644 (file)
@@ -169,6 +169,7 @@ class TreeServer
        TreeSocket* Socket;                     /* For directly connected servers this points at the socket object */
        time_t NextPing;                        /* After this time, the server should be PINGed*/
        bool LastPingWasGood;                   /* True if the server responded to the last PING with a PONG */
+       std::map<userrec*,userrec*> Users;      /* Users on this server */
        
  public:
 
@@ -265,6 +266,38 @@ class TreeServer
                this->AddHashEntry();
        }
 
+       void AddUser(userrec* user)
+       {
+               log(DEBUG,"Add user %s to server %s",user->nick,this->ServerName.c_str());
+               std::map<userrec*,userrec*>::iterator iter;
+               iter = Users.find(user);
+               if (iter == Users.end())
+                       Users[user] = user;
+       }
+
+       void DelUser(userrec* user)
+       {
+               log(DEBUG,"Remove user %s from server %s",user->nick,this->ServerName.c_str());
+               std::map<userrec*,userrec*>::iterator iter;
+               iter = Users.find(user);
+               if (iter != Users.end())
+                       Users.erase(iter);
+       }
+
+       int QuitUsers(const std::string &reason)
+       {
+               int x = Users.size();
+               log(DEBUG,"Removing all users from server %s",this->ServerName.c_str());
+               const char* reason_s = reason.c_str();
+               for (std::map<userrec*,userrec*>::iterator n = Users.begin(); n != Users.end(); n++)
+               {
+                       log(DEBUG,"Kill %s",n->second->nick);
+                       kill_link(n->second,reason_s);
+               }
+               Users.clear();
+               return x;
+       }
+
        /* This method is used to add the structure to the
         * hash_map for linear searches. It is only called
         * by the constructors.
@@ -802,7 +835,7 @@ class TreeSocket : public InspSocket
         * is having a REAL bad hair day, this function shouldnt be called
         * too many times a month ;-)
         */
-       void SquitServer(TreeServer* Current, CullList* Goners)
+       void SquitServer(std::string &from, TreeServer* Current)
        {
                /* recursively squit the servers attached to 'Current'.
                 * We're going backwards so we don't remove users
@@ -811,19 +844,19 @@ class TreeSocket : public InspSocket
                for (unsigned int q = 0; q < Current->ChildCount(); q++)
                {
                        TreeServer* recursive_server = Current->GetChild(q);
-                       this->SquitServer(recursive_server,Goners);
+                       this->SquitServer(from,recursive_server);
                }
                /* Now we've whacked the kids, whack self */
                num_lost_servers++;
-               for (user_hash::iterator u = clientlist.begin(); u != clientlist.end(); u++)
+               num_lost_users += Current->QuitUsers(from);
+               /*for (user_hash::iterator u = clientlist.begin(); u != clientlist.end(); u++)
                {
                        if (!strcasecmp(u->second->server,Current->GetName().c_str()))
                        {
-                               std::string qreason = Current->GetName()+" "+std::string(Srv->GetServerName());
-                               Goners->AddItem(u->second,qreason);
+                               Goners->AddItem(u->second,from);
                                num_lost_users++;
                        }
-               }
+               }*/
        }
 
        /* This is a wrapper function for SquitServer above, which
@@ -848,13 +881,11 @@ class TreeSocket : public InspSocket
                        }
                        num_lost_servers = 0;
                        num_lost_users = 0;
-                       CullList* Goners = new CullList();
-                       SquitServer(Current, Goners);
-                       Goners->Apply();
+                       std::string from = Current->GetParent()->GetName()+" "+Current->GetName();
+                       SquitServer(from, Current);
                        Current->Tidy();
                        Current->GetParent()->DelChild(Current);
                        delete Current;
-                       delete Goners;
                        WriteOpers("Netsplit complete, lost \002%d\002 users on \002%d\002 servers.", num_lost_users, num_lost_servers);
                }
                else
@@ -1094,26 +1125,35 @@ class TreeSocket : public InspSocket
                clientlist[tempnick] = new userrec();
                clientlist[tempnick]->fd = FD_MAGIC_NUMBER;
                strlcpy(clientlist[tempnick]->nick, tempnick,NICKMAX-1);
-               strlcpy(clientlist[tempnick]->host, params[2].c_str(),160);
-               strlcpy(clientlist[tempnick]->dhost, params[3].c_str(),160);
+               strlcpy(clientlist[tempnick]->host, params[2].c_str(),63);
+               strlcpy(clientlist[tempnick]->dhost, params[3].c_str(),63);
                clientlist[tempnick]->server = (char*)FindServerNamePtr(source.c_str());
                strlcpy(clientlist[tempnick]->ident, params[4].c_str(),IDENTMAX);
                strlcpy(clientlist[tempnick]->fullname, params[7].c_str(),MAXGECOS);
                clientlist[tempnick]->registered = 7;
                clientlist[tempnick]->signon = age;
                strlcpy(clientlist[tempnick]->modes, modes.c_str(),53);
+               for (char *v = clientlist[tempnick]->modes; *v; v++)
+               {
+                       switch (*v)
+                       {
+                               case 'i':
+                                       clientlist[tempnick]->modebits |= UM_INVISIBLE;
+                               break;
+                               case 'w':
+                                       clientlist[tempnick]->modebits |= UM_WALLOPS;
+                               break;
+                               case 's':
+                                       clientlist[tempnick]->modebits |= UM_SERVERNOTICE;
+                               break;
+                               default:
+                               break;
+                       }
+               }
                inet_aton(params[6].c_str(),&clientlist[tempnick]->ip4);
 
-               ucrec a;
-               a.channel = NULL;
-               a.uc_modes = 0;
-               for (int i = 0; i < MAXCHANS; i++)
-                       clientlist[tempnick]->chans.push_back(a);
+               WriteOpers("*** Client connecting at %s: %s!%s@%s [%s]",clientlist[tempnick]->server,clientlist[tempnick]->nick,clientlist[tempnick]->ident,clientlist[tempnick]->host,(char*)inet_ntoa(clientlist[tempnick]->ip4));
 
-               if (!this->bursting)
-               {
-                       WriteOpers("*** Client connecting at %s: %s!%s@%s [%s]",clientlist[tempnick]->server,clientlist[tempnick]->nick,clientlist[tempnick]->ident,clientlist[tempnick]->host,(char*)inet_ntoa(clientlist[tempnick]->ip4));
-               }
                params[7] = ":" + params[7];
                DoOneToAllButSender(source,"NICK",params,source);
 
@@ -1121,6 +1161,7 @@ class TreeSocket : public InspSocket
                TreeServer* SourceServer = FindServer(source);
                if (SourceServer)
                {
+                       SourceServer->AddUser(clientlist[tempnick]);
                        SourceServer->AddUserCount();
                }
 
@@ -1136,26 +1177,29 @@ class TreeSocket : public InspSocket
                log(DEBUG,"Sending FJOINs to other server for %s",c->name);
                char list[MAXBUF];
                std::string individual_halfops = ":"+Srv->GetServerName()+" FMODE "+c->name;
-               snprintf(list,MAXBUF,":%s FJOIN %s %lu",Srv->GetServerName().c_str(),c->name,(unsigned long)c->age);
-               std::map<char*,char*> *ulist = c->GetUsers();
+               
+               size_t dlen, curlen;
+               dlen = curlen = snprintf(list,MAXBUF,":%s FJOIN %s %lu",Srv->GetServerName().c_str(),c->name,(unsigned long)c->age);
+               int numusers = 0;
+               char* ptr = list + dlen;
+
+               CUList *ulist = c->GetUsers();
                std::vector<userrec*> specific_halfop;
                std::vector<userrec*> specific_voice;
-               for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+
+               for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
                {
-                       char* o = i->second;
-                       userrec* otheruser = (userrec*)o;
-                       strlcat(list," ",MAXBUF);
-                       int x = cflags(otheruser,c);
+                       int x = cflags(i->second,c);
                        if ((x & UCMODE_HOP) && (x & UCMODE_OP))
                        {
-                               specific_halfop.push_back(otheruser);
+                               specific_halfop.push_back(i->second);
                        }
                        if (((x & UCMODE_HOP) || (x & UCMODE_OP)) && (x & UCMODE_VOICE))
                        {
-                               specific_voice.push_back(otheruser);
+                               specific_voice.push_back(i->second);
                        }
 
-                       char* n = "";
+                       const char* n = "";
                        if (x & UCMODE_OP)
                        {
                                n = "@";
@@ -1169,13 +1213,20 @@ class TreeSocket : public InspSocket
                                n = "+";
                        }
 
-                       strlcat(list,n,MAXBUF);
-                       strlcat(list,otheruser->nick,MAXBUF);
-                       if (strlen(list)>(480-NICKMAX))
+                       size_t ptrlen = snprintf(ptr, MAXBUF, " %s%s", n, i->second->nick);
+
+                       curlen += ptrlen;
+                       ptr += ptrlen;
+
+                       numusers++;
+
+                       if (curlen > (480-NICKMAX))
                        {
-                               log(DEBUG,"FJOIN line wrapped");
                                this->WriteLine(list);
-                               snprintf(list,MAXBUF,":%s FJOIN %s %lu",Srv->GetServerName().c_str(),c->name,(unsigned long)c->age);
+                               dlen = curlen = snprintf(list,MAXBUF,":%s FJOIN %s %lu",Srv->GetServerName().c_str(),c->name,(unsigned long)c->age);
+                               ptr = list + dlen;
+                               ptrlen = 0;
+                               numusers = 0;
                                for (unsigned int y = 0; y < specific_voice.size(); y++)
                                {
                                        this->WriteLine(":"+Srv->GetServerName()+" FMODE "+c->name+" +v "+specific_voice[y]->nick);
@@ -1186,9 +1237,8 @@ class TreeSocket : public InspSocket
                                }
                        }
                }
-               if (list[strlen(list)-1] != ':')
+               if (numusers)
                {
-                       log(DEBUG,"Final FJOIN line");
                        this->WriteLine(list);
                        for (unsigned int y = 0; y < specific_voice.size(); y++)
                        {
@@ -1358,28 +1408,34 @@ class TreeSocket : public InspSocket
                 * back to the core so that a large burst is split into at least 6 sections
                 * (possibly more)
                 */
-               std::string burst = "BURST";
+               std::string burst = "BURST "+ConvToStr(time(NULL));
                std::string endburst = "ENDBURST";
-               Srv->SendOpers("*** Bursting to \2"+s->GetName()+"\2.");
+               // Because by the end of the netburst, it  could be gone!
+               std::string name = s->GetName();
+               Srv->SendOpers("*** Bursting to \2"+name+"\2.");
                this->WriteLine(burst);
                ServerInstance->DoOneIteration(false);
                /* send our version string */
                this->WriteLine(":"+Srv->GetServerName()+" VERSION :"+Srv->GetVersion());
                /* Send server tree */
-               this->SendServers(TreeRoot,s,1);
+               if (FindServer(name))
+                       this->SendServers(TreeRoot,s,1);
                ServerInstance->DoOneIteration(false);
                /* Send users and their oper status */
-               this->SendUsers(s);
+               if (FindServer(name))
+                       this->SendUsers(s);
                ServerInstance->DoOneIteration(false);
                /* Send everything else (channel modes, xlines etc) */
-               this->SendChannelModes(s);
+               if (FindServer(name))
+                       this->SendChannelModes(s);
                ServerInstance->DoOneIteration(false);
-               this->SendXLines(s);
+               if (FindServer(name))
+                       this->SendXLines(s);
                ServerInstance->DoOneIteration(false);
                FOREACH_MOD(I_OnSyncOtherMetaData,OnSyncOtherMetaData((Module*)TreeProtocolModule,(void*)this));
                ServerInstance->DoOneIteration(false);
                this->WriteLine(endburst);
-               Srv->SendOpers("*** Finished bursting to \2"+s->GetName()+"\2.");
+               Srv->SendOpers("*** Finished bursting to \2"+name+"\2.");
        }
 
        /* This function is called when we receive data from a remote
@@ -1742,11 +1798,20 @@ class TreeSocket : public InspSocket
                /* Send it on its way */
                if (propogate)
                {
+                       if (atoi(params[4].c_str()))
+                       {
+                               WriteOpers("*** %s Added %cLINE on %s to expire in %lu seconds (%s).",prefix.c_str(),*(params[0].c_str()),params[1].c_str(),atoi(params[4].c_str()),params[5].c_str());
+                       }
+                       else
+                       {
+                               WriteOpers("*** %s Added permenant %cLINE on %s (%s).",prefix.c_str(),*(params[0].c_str()),params[1].c_str(),params[5].c_str());
+                       }
                        params[5] = ":" + params[5];
                        DoOneToAllButSender(prefix,"ADDLINE",params,prefix);
                }
                if (!this->bursting)
                {
+                       log(DEBUG,"Applying lines...");
                        apply_lines(APPLY_ZLINES|APPLY_GLINES|APPLY_QLINES);
                }
                return true;
@@ -2098,10 +2163,7 @@ class TreeSocket : public InspSocket
                        {
                                *pptr = 0;
                                if (*param)
-                               {
-                                       log(DEBUG,"Pushback(1) '%s'",param);
                                        n.push_back(param);
-                               }
                                *param = count = 0;
                                pptr = param;
                                item++;
@@ -2116,8 +2178,7 @@ class TreeSocket : public InspSocket
                                if ((*param == ':') && (count == 1) && (item > 0))
                                {
                                        *param = count = 0;
-                                       *pptr = param;
-                                       log(DEBUG,"Final param");
+                                       pptr = param;
                                        while (!s.eof())
                                        {
                                                s.get(c);
@@ -2128,11 +2189,7 @@ class TreeSocket : public InspSocket
                                                }
                                        }
                                        *pptr = 0;
-                                       if (*param)
-                                       {
-                                               log(DEBUG,"Pushback(2) '%s'",param);
-                                               n.push_back(param);
-                                       }
+                                       n.push_back(param);
                                        *param = count = 0;
                                        pptr = param;
                                }
@@ -2141,7 +2198,6 @@ class TreeSocket : public InspSocket
                *pptr = 0;
                if (*param)
                {
-                       log(DEBUG,"Pushback(3) '%s'",param);
                        n.push_back(param);
                }
 
@@ -2151,15 +2207,18 @@ class TreeSocket : public InspSocket
        bool ProcessLine(std::string line)
        {
                char* l = (char*)line.c_str();
-               while ((strlen(l)) && (l[strlen(l)-1] == '\r') || (l[strlen(l)-1] == '\n'))
-                       l[strlen(l)-1] = '\0';
-               line = l;
-               if (line == "")
+               for (char* x = l; *x; x++)
+               {
+                       if ((*x == '\r') || (*x == '\n'))
+                               *x = 0;
+               }
+               if (!*l)
                        return true;
-               Srv->Log(DEBUG,"IN: "+line);
-               
+
+               log(DEBUG,"IN: %s",l);
+
                std::deque<std::string> params;
-               this->Split(line,true,params);
+               this->Split(l,true,params);
                irc::string command = "";
                std::string prefix = "";
                if (((params[0].c_str())[0] == ':') && (params.size() > 1))
@@ -2254,6 +2313,22 @@ class TreeSocket : public InspSocket
                                }
                                else if (command == "BURST")
                                {
+                                       if (params.size())
+                                       {
+                                               /* If a time stamp is provided, try and check syncronization */
+                                               time_t THEM = atoi(params[0].c_str());
+                                               long delta = THEM-time(NULL);
+                                               if ((delta < -600) || (delta > 600))
+                                               {
+                                                       WriteOpers("*** \2ERROR\2: Your clocks are out by %d seconds (this is more than ten minutes). Link aborted, \2PLEASE SYNC YOUR CLOCKS!\2",abs(delta));
+                                                       this->WriteLine("ERROR :Your clocks are out by "+ConvToStr(abs(delta))+" seconds (this is more than ten minutes). Link aborted, PLEASE SYNC YOUR CLOCKS!");
+                                                       return false;
+                                               }
+                                               else if ((delta < -60) || (delta > 60))
+                                               {
+                                                       WriteOpers("*** \2WARNING\2: Your clocks are out by %d seconds, please consider synching your clocks.",abs(delta));
+                                               }
+                                       }
                                        this->LinkState = CONNECTED;
                                        Node = new TreeServer(InboundServerName,InboundDescription,TreeRoot,this);
                                        TreeRoot->AddChild(Node);
@@ -2507,7 +2582,15 @@ class TreeSocket : public InspSocket
                                        }
                                        if (who)
                                        {
-                                               if ((command == "NICK") && (params.size() > 0))
+                                               if (command == "QUIT")
+                                               {
+                                                       TreeServer* s = FindServer(who->server);
+                                                       if (s)
+                                                       {
+                                                               s->DelUser(who);
+                                                       }
+                                               }
+                                               else if ((command == "NICK") && (params.size() > 0))
                                                {
                                                        /* On nick messages, check that the nick doesnt
                                                         * already exist here. If it does, kill their copy,
@@ -2542,7 +2625,7 @@ class TreeSocket : public InspSocket
                                                }
                                                if (!Srv->CallCommandHandler(command.c_str(), strparams, params.size(), who))
                                                {
-                                                       this->WriteLine("ERROR :Unrecognised command -- possibly loaded mismatched modules");
+                                                       this->WriteLine("ERROR :Unrecognised command '"+std::string(command.c_str())+"' -- possibly loaded mismatched modules");
                                                        return false;
                                                }
                                        }
@@ -2627,14 +2710,12 @@ void AddThisServer(TreeServer* server, std::deque<TreeServer*> &list)
 // returns a list of DIRECT servernames for a specific channel
 void GetListOfServersForChannel(chanrec* c, std::deque<TreeServer*> &list)
 {
-       std::map<char*,char*> *ulist = c->GetUsers();
-       for (std::map<char*,char*>::iterator i = ulist->begin(); i != ulist->end(); i++)
+       CUList *ulist = c->GetUsers();
+       for (CUList::iterator i = ulist->begin(); i != ulist->end(); i++)
        {
-               char* o = i->second;
-               userrec* otheruser = (userrec*)o;
-               if (otheruser->fd < 0)
+               if (i->second->fd < 0)
                {
-                       TreeServer* best = BestRouteTo(otheruser->server);
+                       TreeServer* best = BestRouteTo(i->second->server);
                        if (best)
                                AddThisServer(best,list);
                }
@@ -2929,19 +3010,21 @@ class ModuleSpanningTree : public Module
 
        void HandleLusers(char** parameters, int pcnt, userrec* user)
        {
+               unsigned int n_users = usercnt();
+
                /* Only update these when someone wants to see them, more efficient */
                if ((unsigned int)local_count() > max_local)
                        max_local = local_count();
-               if (clientlist.size() > max_global)
-                       max_global = clientlist.size();
+               if (n_users > max_global)
+                       max_global = n_users;
 
-               WriteServ(user->fd,"251 %s :There are %d users and %d invisible on %d servers",user->nick,usercnt()-usercount_invisible(),usercount_invisible(),this->CountServs());
+               WriteServ(user->fd,"251 %s :There are %d users and %d invisible on %d servers",user->nick,n_users-usercount_invisible(),usercount_invisible(),this->CountServs());
                WriteServ(user->fd,"252 %s %d :operator(s) online",user->nick,usercount_opers());
                WriteServ(user->fd,"253 %s %d :unknown connections",user->nick,usercount_unknown());
                WriteServ(user->fd,"254 %s %d :channels formed",user->nick,chancount());
                WriteServ(user->fd,"254 %s :I have %d clients and %d servers",user->nick,local_count(),this->CountLocalServs());
                WriteServ(user->fd,"265 %s :Current Local Users: %d  Max: %d",user->nick,local_count(),max_local);
-               WriteServ(user->fd,"266 %s :Current Global Users: %d  Max: %d",user->nick,clientlist.size(),max_global);
+               WriteServ(user->fd,"266 %s :Current Global Users: %d  Max: %d",user->nick,n_users,max_global);
                return;
        }
 
@@ -3284,7 +3367,7 @@ class ModuleSpanningTree : public Module
                return 0;
        }
 
-       virtual int OnPreCommand(std::string command, char **parameters, int pcnt, userrec *user, bool validated)
+       virtual int OnPreCommand(const std::string &command, char **parameters, int pcnt, userrec *user, bool validated)
        {
                /* If the command doesnt appear to be valid, we dont want to mess with it. */
                if (!validated)
@@ -3356,7 +3439,7 @@ class ModuleSpanningTree : public Module
                return 0;
        }
 
-       virtual void OnGetServerDescription(std::string servername,std::string &description)
+       virtual void OnGetServerDescription(const std::string &servername,std::string &description)
        {
                TreeServer* s = FindServer(servername);
                if (s)
@@ -3376,7 +3459,7 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       virtual void OnPostLocalTopicChange(userrec* user, chanrec* chan, std::string topic)
+       virtual void OnPostLocalTopicChange(userrec* user, chanrec* chan, const std::string &topic)
        {
                std::deque<std::string> params;
                params.push_back(chan->name);
@@ -3384,7 +3467,7 @@ class ModuleSpanningTree : public Module
                DoOneToMany(user->nick,"TOPIC",params);
        }
 
-       virtual void OnWallops(userrec* user, std::string text)
+       virtual void OnWallops(userrec* user, const std::string &text)
        {
                if (user->fd > -1)
                {
@@ -3394,7 +3477,7 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       virtual void OnUserNotice(userrec* user, void* dest, int target_type, std::string text, char status)
+       virtual void OnUserNotice(userrec* user, void* dest, int target_type, const std::string &text, char status)
        {
                if (target_type == TYPE_USER)
                {
@@ -3429,7 +3512,7 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       virtual void OnUserMessage(userrec* user, void* dest, int target_type, std::string text, char status)
+       virtual void OnUserMessage(userrec* user, void* dest, int target_type, const std::string &text, char status)
        {
                if (target_type == TYPE_USER)
                {
@@ -3505,7 +3588,7 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       virtual void OnChangeHost(userrec* user, std::string newhost)
+       virtual void OnChangeHost(userrec* user, const std::string &newhost)
        {
                // only occurs for local clients
                if (user->registered != 7)
@@ -3515,7 +3598,7 @@ class ModuleSpanningTree : public Module
                DoOneToMany(user->nick,"FHOST",params);
        }
 
-       virtual void OnChangeName(userrec* user, std::string gecos)
+       virtual void OnChangeName(userrec* user, const std::string &gecos)
        {
                // only occurs for local clients
                if (user->registered != 7)
@@ -3525,7 +3608,7 @@ class ModuleSpanningTree : public Module
                DoOneToMany(user->nick,"FNAME",params);
        }
 
-       virtual void OnUserPart(userrec* user, chanrec* channel, std::string partmessage)
+       virtual void OnUserPart(userrec* user, chanrec* channel, const std::string &partmessage)
        {
                if (user->fd > -1)
                {
@@ -3564,7 +3647,7 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       virtual void OnUserQuit(userrec* user, std::string reason)
+       virtual void OnUserQuit(userrec* user, const std::string &reason)
        {
                if ((user->fd > -1) && (user->registered == 7))
                {
@@ -3581,7 +3664,7 @@ class ModuleSpanningTree : public Module
 
        }
 
-       virtual void OnUserPostNick(userrec* user, std::string oldnick)
+       virtual void OnUserPostNick(userrec* user, const std::string &oldnick)
        {
                if (user->fd > -1)
                {
@@ -3591,7 +3674,7 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       virtual void OnUserKick(userrec* source, userrec* user, chanrec* chan, std::string reason)
+       virtual void OnUserKick(userrec* source, userrec* user, chanrec* chan, const std::string &reason)
        {
                if ((source) && (source->fd > -1))
                {
@@ -3611,7 +3694,7 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       virtual void OnRemoteKill(userrec* source, userrec* dest, std::string reason)
+       virtual void OnRemoteKill(userrec* source, userrec* dest, const std::string &reason)
        {
                std::deque<std::string> params;
                params.push_back(dest->nick);
@@ -3619,7 +3702,7 @@ class ModuleSpanningTree : public Module
                DoOneToMany(source->nick,"KILL",params);
        }
 
-       virtual void OnRehash(std::string parameter)
+       virtual void OnRehash(const std::string &parameter)
        {
                if (parameter != "")
                {
@@ -3639,7 +3722,7 @@ class ModuleSpanningTree : public Module
        // note: the protocol does not allow direct umode +o except
        // via NICK with 8 params. sending OPERTYPE infers +o modechange
        // locally.
-       virtual void OnOper(userrec* user, std::string opertype)
+       virtual void OnOper(userrec* user, const std::string &opertype)
        {
                if (user->fd > -1)
                {
@@ -3649,7 +3732,7 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       void OnLine(userrec* source, std::string host, bool adding, char linetype, long duration, std::string reason)
+       void OnLine(userrec* source, const std::string &host, bool adding, char linetype, long duration, const std::string &reason)
        {
                if (source->fd > -1)
                {
@@ -3675,47 +3758,47 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       virtual void OnAddGLine(long duration, userrec* source, std::string reason, std::string hostmask)
+       virtual void OnAddGLine(long duration, userrec* source, const std::string &reason, const std::string &hostmask)
        {
                OnLine(source,hostmask,true,'G',duration,reason);
        }
        
-       virtual void OnAddZLine(long duration, userrec* source, std::string reason, std::string ipmask)
+       virtual void OnAddZLine(long duration, userrec* source, const std::string &reason, const std::string &ipmask)
        {
                OnLine(source,ipmask,true,'Z',duration,reason);
        }
 
-       virtual void OnAddQLine(long duration, userrec* source, std::string reason, std::string nickmask)
+       virtual void OnAddQLine(long duration, userrec* source, const std::string &reason, const std::string &nickmask)
        {
                OnLine(source,nickmask,true,'Q',duration,reason);
        }
 
-       virtual void OnAddELine(long duration, userrec* source, std::string reason, std::string hostmask)
+       virtual void OnAddELine(long duration, userrec* source, const std::string &reason, const std::string &hostmask)
        {
                OnLine(source,hostmask,true,'E',duration,reason);
        }
 
-       virtual void OnDelGLine(userrec* source, std::string hostmask)
+       virtual void OnDelGLine(userrec* source, const std::string &hostmask)
        {
                OnLine(source,hostmask,false,'G',0,"");
        }
 
-       virtual void OnDelZLine(userrec* source, std::string ipmask)
+       virtual void OnDelZLine(userrec* source, const std::string &ipmask)
        {
                OnLine(source,ipmask,false,'Z',0,"");
        }
 
-       virtual void OnDelQLine(userrec* source, std::string nickmask)
+       virtual void OnDelQLine(userrec* source, const std::string &nickmask)
        {
                OnLine(source,nickmask,false,'Q',0,"");
        }
 
-       virtual void OnDelELine(userrec* source, std::string hostmask)
+       virtual void OnDelELine(userrec* source, const std::string &hostmask)
        {
                OnLine(source,hostmask,false,'E',0,"");
        }
 
-       virtual void OnMode(userrec* user, void* dest, int target_type, std::string text)
+       virtual void OnMode(userrec* user, void* dest, int target_type, const std::string &text)
        {
                if ((user->fd > -1) && (user->registered == 7))
                {
@@ -3758,7 +3841,7 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       virtual void ProtoSendMode(void* opaque, int target_type, void* target, std::string modeline)
+       virtual void ProtoSendMode(void* opaque, int target_type, void* target, const std::string &modeline)
        {
                TreeSocket* s = (TreeSocket*)opaque;
                if (target)
@@ -3776,7 +3859,7 @@ class ModuleSpanningTree : public Module
                }
        }
 
-       virtual void ProtoSendMetaData(void* opaque, int target_type, void* target, std::string extname, std::string extdata)
+       virtual void ProtoSendMetaData(void* opaque, int target_type, void* target, const std::string &extname, const std::string &extdata)
        {
                TreeSocket* s = (TreeSocket*)opaque;
                if (target)