]> git.netwichtig.de Git - user/henk/code/inspircd.git/blobdiff - src/modules/m_spanningtree.cpp
Mode +b stuff, probably wont work yet
[user/henk/code/inspircd.git] / src / modules / m_spanningtree.cpp
index e15ac11b7f15cc94669c33992cafe5f1add3f106..841206b8f4037023856304bc1bd75b3a20979bea 100644 (file)
@@ -965,7 +965,7 @@ class TreeSocket : public InspSocket
                                        userrec* user = Srv->FindNick(source);
                                        if (!user)
                                        {
-                                               WriteChannelWithServ((char*)source.c_str(), c, "TOPIC %s :%s", c->name, c->topic);
+                                               WriteChannelWithServ(source.c_str(), c, "TOPIC %s :%s", c->name, c->topic);
                                        }
                                        else
                                        {
@@ -1030,7 +1030,7 @@ class TreeSocket : public InspSocket
                for (unsigned int usernum = 2; usernum < params.size(); usernum++)
                {
                        /* process one channel at a time, applying modes. */
-                       char* usr = (char*)params[usernum].c_str();
+                       char* usr = const_cast<char*>(params[usernum].c_str());
                        /* Safety check just to make sure someones not sent us an FJOIN full of spaces
                         * (is this even possible?) */
                        if (usr && *usr)
@@ -1147,18 +1147,17 @@ class TreeSocket : public InspSocket
                // NICK age nick host dhost ident +modes ip :gecos
                //   0   123  4 56   7
                time_t age = atoi(params[0].c_str());
-               std::string modes = params[5];
-               while (*(modes.c_str()) == '+')
-               {
-                       char* m = (char*)modes.c_str();
-                       m++;
-                       modes = m;
-               }
-               char* tempnick = (char*)params[1].c_str();
+               
+               /* This used to have a pretty craq'y loop doing the same thing,
+                * now we just let the STL do the hard work (more efficiently)
+                */
+               params[5] = params[5].substr(params[5].find_first_not_of('+'));
+               
+               const char* tempnick = params[1].c_str();
                log(DEBUG,"Introduce client %s!%s@%s",tempnick,params[4].c_str(),params[2].c_str());
                
-               user_hash::iterator iter;
-               iter = clientlist.find(tempnick);
+               user_hash::iterator iter = clientlist.find(tempnick);
+               
                if (iter != clientlist.end())
                {
                        // nick collision
@@ -1172,12 +1171,13 @@ class TreeSocket : public InspSocket
                strlcpy(clientlist[tempnick]->nick, tempnick,NICKMAX-1);
                strlcpy(clientlist[tempnick]->host, params[2].c_str(),63);
                strlcpy(clientlist[tempnick]->dhost, params[3].c_str(),63);
-               clientlist[tempnick]->server = (char*)FindServerNamePtr(source.c_str());
+               clientlist[tempnick]->server = FindServerNamePtr(source.c_str());
                strlcpy(clientlist[tempnick]->ident, params[4].c_str(),IDENTMAX);
                strlcpy(clientlist[tempnick]->fullname, params[7].c_str(),MAXGECOS);
                clientlist[tempnick]->registered = 7;
                clientlist[tempnick]->signon = age;
-               strlcpy(clientlist[tempnick]->modes, modes.c_str(),53);
+               strlcpy(clientlist[tempnick]->modes, params[5].c_str(),53);
+               
                for (char *v = clientlist[tempnick]->modes; *v; v++)
                {
                        switch (*v)
@@ -1197,7 +1197,7 @@ class TreeSocket : public InspSocket
                }
                inet_aton(params[6].c_str(),&clientlist[tempnick]->ip4);
 
-               WriteOpers("*** Client connecting at %s: %s!%s@%s [%s]",clientlist[tempnick]->server,clientlist[tempnick]->nick,clientlist[tempnick]->ident,clientlist[tempnick]->host,(char*)inet_ntoa(clientlist[tempnick]->ip4));
+               WriteOpers("*** Client connecting at %s: %s!%s@%s [%s]",clientlist[tempnick]->server,clientlist[tempnick]->nick,clientlist[tempnick]->ident,clientlist[tempnick]->host, inet_ntoa(clientlist[tempnick]->ip4));
 
                params[7] = ":" + params[7];
                DoOneToAllButSender(source,"NICK",params,source);
@@ -1391,7 +1391,7 @@ class TreeSocket : public InspSocket
                {
                        if (u->second->registered == 7)
                        {
-                               snprintf(data,MAXBUF,":%s NICK %lu %s %s %s %s +%s %s :%s",u->second->server,(unsigned long)u->second->age,u->second->nick,u->second->host,u->second->dhost,u->second->ident,u->second->modes,(char*)inet_ntoa(u->second->ip4),u->second->fullname);
+                               snprintf(data,MAXBUF,":%s NICK %lu %s %s %s %s +%s %s :%s",u->second->server,(unsigned long)u->second->age,u->second->nick,u->second->host,u->second->dhost,u->second->ident,u->second->modes,inet_ntoa(u->second->ip4),u->second->fullname);
                                this->WriteLine(data);
                                if (*u->second->oper)
                                {
@@ -1773,19 +1773,19 @@ class TreeSocket : public InspSocket
                {
                        case 'Z':
                                propogate = add_zline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
-                               zline_set_creation_time((char*)params[1].c_str(), atoi(params[3].c_str()));
+                               zline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
                        break;
                        case 'Q':
                                propogate = add_qline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
-                               qline_set_creation_time((char*)params[1].c_str(), atoi(params[3].c_str()));
+                               qline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
                        break;
                        case 'E':
                                propogate = add_eline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
-                               eline_set_creation_time((char*)params[1].c_str(), atoi(params[3].c_str()));
+                               eline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
                        break;
                        case 'G':
                                propogate = add_gline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
-                               gline_set_creation_time((char*)params[1].c_str(), atoi(params[3].c_str()));
+                               gline_set_creation_time(params[1].c_str(), atoi(params[3].c_str()));
                        break;
                        case 'K':
                                propogate = add_kline(atoi(params[4].c_str()), params[2].c_str(), params[5].c_str(), params[1].c_str());
@@ -1884,7 +1884,7 @@ class TreeSocket : public InspSocket
                                        unsigned long signon = atoi(params[1].c_str());
                                        unsigned long idle = atoi(params[2].c_str());
                                        if ((who_to_send_to) && (who_to_send_to->fd > -1))
-                                               do_whois(who_to_send_to,u,signon,idle,(char*)nick_whoised.c_str());
+                                               do_whois(who_to_send_to,u,signon,idle,nick_whoised.c_str());
                                }
                                else
                                {
@@ -2213,37 +2213,28 @@ class TreeSocket : public InspSocket
 
        bool ProcessLine(std::string line)
        {
-               char* l = (char*)line.c_str();
-               for (char* x = l; *x; x++)
-               {
-                       if ((*x == '\r') || (*x == '\n'))
-                               *x = 0;
-               }
-               if (!*l)
-                       return true;
-
-               log(DEBUG,"IN: %s",l);
-
                std::deque<std::string> params;
-               this->Split(l,true,params);
-               irc::string command = "";
-               std::string prefix = "";
-               if (((params[0].c_str())[0] == ':') && (params.size() > 1))
-               {
-                       prefix = params[0];
-                       command = params[1].c_str();
-                       char* pref = (char*)prefix.c_str();
-                       prefix = ++pref;
-                       params.pop_front();
-                       params.pop_front();
-               }
-               else
+               irc::string command;
+               std::string prefix;
+               
+               if (line.empty())
+                       return true;
+               
+               line = line.substr(0, line.find_first_of("\r\n"));
+               
+               log(DEBUG,"IN: %s", line.c_str());
+               
+               this->Split(line.c_str(),true,params);
+                       
+               if ((params[0][0] == ':') && (params.size() > 1))
                {
-                       prefix = "";
-                       command = params[0].c_str();
+                       prefix = params[0].substr(1);
                        params.pop_front();
                }
 
+               command = params[0].c_str();
+               params.pop_front();
+
                if ((!this->ctx_in) && (command == "AES"))
                {
                        std::string sserv = params[0];
@@ -2622,6 +2613,11 @@ class TreeSocket : public InspSocket
                                                                userrec* y = Srv->FindNick(prefix);
                                                                if (y)
                                                                {
+                                                                       TreeServer* n = FindServer(y->server);
+                                                                       if (n)
+                                                                       {
+                                                                               n->DelUser(y);
+                                                                       }       
                                                                        Srv->QuitUser(y,"Nickname collision");
                                                                }
                                                                return DoOneToAllButSenderRaw(line,sourceserv,prefix,command,params);
@@ -2705,6 +2701,7 @@ class TreeSocket : public InspSocket
                 * IPs for which we don't have a link block.
                 */
                bool found = false;
+               char resolved_host[MAXBUF];
                vector<Link>::iterator i;
                for (i = LinkBlocks.begin(); i != LinkBlocks.end(); i++)
                {
@@ -2713,6 +2710,17 @@ class TreeSocket : public InspSocket
                                found = true;
                                break;
                        }
+                       /* XXX: Fixme: blocks for a very short amount of time,
+                        * we should cache these on rehash/startup
+                        */
+                       if (CleanAndResolve(resolved_host,i->IPAddr.c_str(),true))
+                       {
+                               if (std::string(resolved_host) == ip)
+                               {
+                                       found = true;
+                                       break;
+                               }
+                       }
                }
                if (!found)
                {
@@ -3728,6 +3736,17 @@ class ModuleSpanningTree : public Module
                params.push_back(dest->nick);
                params.push_back(":"+reason);
                DoOneToMany(source->nick,"KILL",params);
+               /* NOTE: We must remove the user from the servers list here.
+                * If we do not, there is a chance the user could hang around
+                * in the list if there is a desync for example (this would
+                * not be good).
+                * Part of the 'random crash on netsplit' tidying up. -Brain
+                */
+               TreeServer* n = FindServer(dest->server);
+               if (n)
+               {
+                       n->DelUser(dest);
+               }
        }
 
        virtual void OnRehash(const std::string &parameter)